258 changed files with 26080 additions and 1432 deletions

No files matched your search

+1
View File
@@ -14,3 +14,4 @@ CORS_ALLOWED_ORIGINS=
AUTH_RATE_LIMIT_MAX_ATTEMPTS=5
AUTH_RATE_LIMIT_WINDOW_SECONDS=60
TRUSTED_PROXIES=
UPDATE_FEED_URL=https://git.floriansylvain.fr
+5
View File
@@ -20,5 +20,10 @@ build-errors.log
uploadedImages/
*.exe
# AI fest
.claude/
CLAUDE.md
.codex/
.agents/
AGENTS.md
codex-workflow.md
+4
View File
@@ -15,6 +15,10 @@ cp .env.example .env # fill in PUBLIC_URL, JWT_SECRET and SMTP_*
Data is stored in `./data/` by default. For a real server (systemd, HTTPS, backups), see **[docs/deployment.md](docs/deployment.md)**.
### Updates from the browser
On Linux with systemd, install v2.6.0-beta or newer manually, then follow [the browser-update setup guide](docs/deployment.md#browser-updates). It covers finding the actual database directory, installing the helper, testing a restart and troubleshooting. Other platforms use manual upgrades.
### Develop
Requires Go 1.27+, Node.js 22, [Bun](https://bun.sh) and [Task](https://taskfile.dev).
+25 -2
View File
@@ -122,14 +122,37 @@ tasks:
- go build -trimpath -ldflags "{{.LDFLAGS}}" -o bin/{{.BINARY}}{{exeExt}} ./cmd/server
release:
desc: Cross-compile production binaries for all release targets → bin/
deps: [build:web]
desc: Cross-compile and sign production binaries for all release targets → bin/ (needs RELEASE_SIGNING_KEY)
cmds:
- task: release:check
- task: build:web
- for: { var: RELEASE_TARGETS }
task: build:target
vars:
GOOS: '{{index (splitList "/" .ITEM) 0}}'
GOARCH: '{{index (splitList "/" .ITEM) 1}}'
- go run ./cmd/releasesign checksums bin --match "{{.BINARY}}_{{.VERSION}}_*"
- go run ./cmd/releasesign sign bin/checksums.txt
- go run ./cmd/releasesign verify bin/checksums.txt
release:check:
internal: true
cmds:
- cmd: 'test -n "$RELEASE_SIGNING_KEY" || { echo "RELEASE_SIGNING_KEY is not set. Point it at the private release key file (see task release:keygen)." >&2; exit 1; }'
silent: true
- cmd: 'test -f "$RELEASE_SIGNING_KEY" || { echo "RELEASE_SIGNING_KEY points to a missing file: $RELEASE_SIGNING_KEY" >&2; exit 1; }'
silent: true
- mkdir -p tmp
- echo probe > tmp/release-probe.txt
- defer: rm -f tmp/release-probe.txt tmp/release-probe.txt.sig
- go run ./cmd/releasesign sign tmp/release-probe.txt
release:keygen:
desc: One-time release key pair. Usage, task release:keygen -- <private key path outside the repository>
cmds:
- cmd: 'test -n "{{.CLI_ARGS}}" || { echo "usage: task release:keygen -- <private key path outside the repository>" >&2; exit 1; }'
silent: true
- go run ./cmd/releasesign keygen {{.CLI_ARGS}}
build:target:
internal: true
+130 -15
View File
@@ -5,16 +5,23 @@ import (
domainImage "RenewCMS/internal/domain/image"
domainInvite "RenewCMS/internal/domain/invite"
domainMail "RenewCMS/internal/domain/mail"
domainUpdate "RenewCMS/internal/domain/update"
domainUser "RenewCMS/internal/domain/user"
"RenewCMS/internal/infrastructure/config"
"RenewCMS/internal/infrastructure/hashing"
"RenewCMS/internal/infrastructure/mailer"
"RenewCMS/internal/infrastructure/markdown"
"RenewCMS/internal/infrastructure/persistence/models"
persistence "RenewCMS/internal/infrastructure/persistence/repositories"
"RenewCMS/internal/infrastructure/update"
"RenewCMS/internal/infrastructure/useCases"
"crypto/ed25519"
"fmt"
"log"
"os"
"path/filepath"
"runtime"
"time"
"github.com/glebarez/sqlite"
"github.com/go-chi/jwtauth/v5"
@@ -51,17 +58,40 @@ type UseCases struct {
MergeMediaUseCase *useCases.MergeMediaUseCase
GetMediaUsageUseCase *useCases.GetMediaUsageUseCase
GetSettingsUseCase *useCases.GetSettingsUseCase
GetUpdateStatusUseCase *useCases.GetUpdateStatusUseCase
CheckForUpdateUseCase *useCases.CheckForUpdateUseCase
StartUpdateDownloadUseCase *useCases.StartUpdateDownloadUseCase
RequestRestartUseCase *useCases.RequestRestartUseCase
RecordRunningInfoUseCase *useCases.RecordRunningInfoUseCase
}
type Repositories struct {
ArticleRepo domainArticle.Repository
UserRepo domainUser.Repository
ImageRepo domainImage.Repository
InviteRepo domainInvite.Repository
MailRepo domainMail.Repository
ArticleRepo domainArticle.Repository
UserRepo domainUser.Repository
ImageRepo domainImage.Repository
InviteRepo domainInvite.Repository
MailRepo domainMail.Repository
ReleaseFeed domainUpdate.ReleaseFeed
UpdateStore domainUpdate.StatusStore
UpdateJobs domainUpdate.JobStore
UpdateHelper domainUpdate.HelperDetector
AssetFetcher domainUpdate.AssetFetcher
SignatureVerifier domainUpdate.SignatureVerifier
StagedRunner domainUpdate.StagedBinaryRunner
DatabaseBackup domainUpdate.DatabaseBackup
UpdateResults domainUpdate.ResultStore
RestartRequests domainUpdate.RestartRequestStore
RunningInfo domainUpdate.RunningInfoStore
}
const sqliteBusyTimeoutMs = 5000
const (
sqliteBusyTimeoutMs = 5000
updateStatusFileName = "update-status.json"
updateJobFileName = "update-job.json"
updateHelperFileName = "update-helper.json"
updatesDirName = "updates"
backupsDirName = "backups"
)
func SQLiteDSN(dbName string) string {
return fmt.Sprintf("%s?_pragma=busy_timeout(%d)", dbName, sqliteBusyTimeoutMs)
@@ -91,25 +121,46 @@ func getDb(dbName string, uploadDir string) *gorm.DB {
return db
}
func releasePublicKey() ed25519.PublicKey {
key, err := update.EmbeddedPublicKey()
if err != nil {
panic("Unable to read the embedded release key: " + err.Error())
}
return key
}
func getRepositories(db *gorm.DB, settings config.Settings) *Repositories {
dataDir := filepath.Dir(settings.DBFile)
return &Repositories{
ArticleRepo: persistence.NewArticleRepository(db),
UserRepo: persistence.NewUserRepository(db),
ImageRepo: persistence.NewImageRepository(db, settings.UploadDir),
InviteRepo: persistence.NewInviteRepository(db),
MailRepo: mailer.NewMailRepository(settings.Smtp),
ArticleRepo: persistence.NewArticleRepository(db),
UserRepo: persistence.NewUserRepository(db),
ImageRepo: persistence.NewImageRepository(db, settings.UploadDir),
InviteRepo: persistence.NewInviteRepository(db),
MailRepo: mailer.NewMailRepository(settings.Smtp),
ReleaseFeed: update.NewGiteaReleaseFeed(settings.UpdateFeedURL),
UpdateStore: update.NewJSONStatusStore(filepath.Join(dataDir, updateStatusFileName)),
UpdateJobs: update.NewJSONJobStore(filepath.Join(dataDir, updateJobFileName)),
UpdateHelper: update.NewFileHelperDetector(filepath.Join(dataDir, updateHelperFileName)),
AssetFetcher: update.NewHTTPAssetFetcher(settings.UpdateFeedURL),
SignatureVerifier: update.NewEd25519SignatureVerifier(releasePublicKey()),
StagedRunner: update.NewExecStagedBinaryRunner(),
DatabaseBackup: update.NewSQLiteDatabaseBackup(db, filepath.Join(dataDir, backupsDirName), time.Now),
UpdateResults: update.NewJSONResultStore(filepath.Join(dataDir, domainUpdate.ResultFileName)),
RestartRequests: update.NewJSONRestartRequestStore(filepath.Join(dataDir, domainUpdate.RestartRequestFileName)),
RunningInfo: update.NewJSONRunningInfoStore(filepath.Join(dataDir, domainUpdate.RunningInfoFileName)),
}
}
func getUseCases(repos *Repositories, settings config.Settings) *UseCases {
hasher := hashing.NewBcryptHasher()
renderer := markdown.NewConverter()
return &UseCases{
Token: jwtauth.New("HS256", []byte(settings.JWTSecret), nil),
CreateArticleUseCase: useCases.NewCreateArticleUseCase(repos.ArticleRepo),
GetArticleUseCase: useCases.NewGetArticleUseCase(repos.ArticleRepo),
ListArticlesUseCase: useCases.NewListArticlesUseCase(repos.ArticleRepo),
UpdateArticleUseCase: useCases.NewUpdateArticleUseCase(repos.ArticleRepo),
CreateArticleUseCase: useCases.NewCreateArticleUseCase(repos.ArticleRepo, renderer),
GetArticleUseCase: useCases.NewGetArticleUseCase(repos.ArticleRepo, renderer),
ListArticlesUseCase: useCases.NewListArticlesUseCase(repos.ArticleRepo, renderer),
UpdateArticleUseCase: useCases.NewUpdateArticleUseCase(repos.ArticleRepo, renderer),
DeleteArticleUseCase: useCases.NewDeleteArticleUseCase(repos.ArticleRepo),
GetUserUseCase: useCases.NewGetUserUseCase(repos.UserRepo),
CreateUserUseCase: useCases.NewCreateUserUseCase(repos.UserRepo, hasher, repos.MailRepo, settings.PublicURL),
@@ -134,9 +185,34 @@ func getUseCases(repos *Repositories, settings config.Settings) *UseCases {
MergeMediaUseCase: useCases.NewMergeMediaUseCase(repos.ImageRepo, repos.ArticleRepo),
GetMediaUsageUseCase: useCases.NewGetMediaUsageUseCase(repos.ImageRepo, repos.ArticleRepo),
GetSettingsUseCase: useCases.NewGetSettingsUseCase(settings.Version),
GetUpdateStatusUseCase: useCases.NewGetUpdateStatusUseCase(repos.UpdateStore, repos.UpdateJobs, repos.UpdateHelper, repos.UpdateResults, repos.RestartRequests, settings.Version, time.Now),
CheckForUpdateUseCase: useCases.NewCheckForUpdateUseCase(repos.ReleaseFeed, repos.UpdateStore, settings.Version, time.Now),
StartUpdateDownloadUseCase: startUpdateDownloadUseCase(repos, settings),
RequestRestartUseCase: useCases.NewRequestRestartUseCase(repos.UpdateStore, repos.UpdateJobs, repos.UpdateHelper, repos.UpdateResults, repos.RestartRequests, settings.Version, time.Now),
RecordRunningInfoUseCase: useCases.NewRecordRunningInfoUseCase(repos.RunningInfo, settings.Version, os.Getpid(), time.Now),
}
}
func startUpdateDownloadUseCase(repos *Repositories, settings config.Settings) *useCases.StartUpdateDownloadUseCase {
return useCases.NewStartUpdateDownloadUseCase(useCases.StartUpdateDownloadDependencies{
Store: repos.UpdateStore,
Jobs: repos.UpdateJobs,
Helper: repos.UpdateHelper,
Results: repos.UpdateResults,
Requests: repos.RestartRequests,
Fetcher: repos.AssetFetcher,
Verifier: repos.SignatureVerifier,
Runner: repos.StagedRunner,
Backup: repos.DatabaseBackup,
Staging: update.NewOSStagingArea(filepath.Join(filepath.Dir(settings.DBFile), updatesDirName)),
Logger: log.Default(),
CurrentVersion: settings.Version,
Platform: domainUpdate.Platform{OS: runtime.GOOS, Arch: runtime.GOARCH},
FeedURL: settings.UpdateFeedURL,
Now: time.Now,
})
}
func InitContainer(settings config.Settings) (*UseCases, func() error) {
db := getDb(settings.DBFile, settings.UploadDir)
repos := getRepositories(db, settings)
@@ -152,3 +228,42 @@ func closeDb(db *gorm.DB) func() error {
return sqlDb.Close()
}
}
type BrowserUpdateCommands struct {
Enable *useCases.EnableBrowserUpdatesUseCase
Disable *useCases.DisableBrowserUpdatesUseCase
}
func InitBrowserUpdateCommands() *BrowserUpdateCommands {
units := update.NewSystemdUnits()
dependencies := useCases.ManageBrowserUpdatesDependencies{
Probe: update.NewSystemMachineProbe(),
Locator: units,
Units: units,
Manager: update.NewSystemctlControl(domainUpdate.ServiceUnitName),
Status: update.NewJSONHelperStatusWriter(),
Now: time.Now,
}
return &BrowserUpdateCommands{
Enable: useCases.NewEnableBrowserUpdatesUseCase(dependencies),
Disable: useCases.NewDisableBrowserUpdatesUseCase(dependencies),
}
}
func InitApplyUpdateCommand(options domainUpdate.InstallOptions) *useCases.ApplyRestartRequestUseCase {
layout := domainUpdate.HelperLayout{DataDir: options.DataDir, BinaryPath: options.Binary}
files := update.NewNoFollowFilesystem()
return useCases.NewApplyRestartRequestUseCase(useCases.ApplyRestartRequestDependencies{
Requests: update.NewFSRestartRequestStore(files, layout.RestartRequestPath()),
Results: update.NewFSResultStore(files, layout.ResultPath()),
Running: update.NewJSONRunningInfoStore(filepath.Join(options.DataDir, domainUpdate.RunningInfoFileName)),
Files: files,
Service: update.NewSystemctlControl(options.Service),
Health: update.NewHTTPHealthChecker(options.Port),
Verifier: update.NewEd25519SignatureVerifier(releasePublicKey()),
Clock: update.NewSystemClock(),
Logger: log.Default(),
Layout: layout,
Platform: domainUpdate.Platform{OS: runtime.GOOS, Arch: runtime.GOARCH},
})
}
+102 -24
View File
@@ -12,6 +12,7 @@ import (
"log"
"net/http"
"strconv"
"time"
"github.com/go-chi/chi/v5"
)
@@ -41,6 +42,53 @@ func NewHandler(create *useCases.CreateArticleUseCase, get *useCases.GetArticleU
}
}
type articleResponse struct {
ID uint32 `json:"id"`
Title string `json:"title"`
Body json.RawMessage `json:"body"`
BodyFormat domain.BodyFormat `json:"body_format"`
IsOnline bool `json:"is_online"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
}
func toArticleResponse(article domain.Article, format domain.BodyFormat) (articleResponse, error) {
body := json.RawMessage(article.Body)
if format != domain.BodyFormatJSON {
encoded, err := json.Marshal(article.Body)
if err != nil {
return articleResponse{}, err
}
body = encoded
}
return articleResponse{
ID: article.ID,
Title: article.Title,
Body: body,
BodyFormat: format,
IsOnline: article.IsOnline,
CreatedAt: article.CreatedAt,
UpdatedAt: article.UpdatedAt,
}, nil
}
func encodeArticle(article domain.Article, format domain.BodyFormat) ([]byte, error) {
response, err := toArticleResponse(article, format)
if err != nil {
return nil, err
}
return json.Marshal(response)
}
func parseBodyFormat(w http.ResponseWriter, r *http.Request) (domain.BodyFormat, bool) {
format, err := domain.ParseBodyFormat(r.URL.Query().Get("format"))
if err != nil {
http.Error(w, apperr.ArticleBodyFormatErrorMessage, http.StatusBadRequest)
return "", false
}
return format, true
}
func parseArticleId(r *http.Request) (uint32, error) {
id, err := strconv.ParseUint(chi.URLParam(r, "id"), 10, 32)
return uint32(id), err
@@ -53,11 +101,16 @@ func (h *Handler) GetArticle(w http.ResponseWriter, r *http.Request) {
return
}
format, ok := parseBodyFormat(w, r)
if !ok {
return
}
var article domain.Article
if h.callerIsVerified(r) {
article, err = h.GetUseCase.GetArticle(id)
article, err = h.GetUseCase.GetArticle(id, format)
} else {
article, err = h.GetUseCase.GetOnlineArticle(id)
article, err = h.GetUseCase.GetOnlineArticle(id, format)
}
if err != nil {
if errors.Is(err, domain.ErrArticleNotFound) {
@@ -68,7 +121,7 @@ func (h *Handler) GetArticle(w http.ResponseWriter, r *http.Request) {
return
}
articleJson, err := json.Marshal(article)
articleJson, err := encodeArticle(article, format)
if err != nil {
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
return
@@ -80,6 +133,11 @@ func (h *Handler) GetArticle(w http.ResponseWriter, r *http.Request) {
}
func (h *Handler) PostArticle(w http.ResponseWriter, r *http.Request) {
format, ok := parseBodyFormat(w, r)
if !ok {
return
}
var localArticle PostArticle
if err := json.NewDecoder(r.Body).Decode(&localArticle); err != nil {
http.Error(w, apperr.BodyErrorMessage, http.StatusBadRequest)
@@ -92,8 +150,9 @@ func (h *Handler) PostArticle(w http.ResponseWriter, r *http.Request) {
}
createdArticle, err := h.CreateUseCase.CreateArticle(useCases.CreateArticleCommand{
Title: localArticle.Title,
Body: localArticle.Body,
Title: localArticle.Title,
Body: localArticle.Body,
Format: format,
})
if err != nil {
if errors.Is(err, domain.ErrInvalidTitle) {
@@ -104,16 +163,7 @@ func (h *Handler) PostArticle(w http.ResponseWriter, r *http.Request) {
return
}
articleJson, err := json.Marshal(createdArticle)
if err != nil {
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
return
}
w.WriteHeader(http.StatusCreated)
if _, err := w.Write(articleJson); err != nil {
log.Printf("Failed to write response: %v", err)
}
writeArticleJsonResponse(w, http.StatusCreated, createdArticle, format)
}
func writeArticleErrorResponse(w http.ResponseWriter, err error) {
@@ -124,13 +174,16 @@ func writeArticleErrorResponse(w http.ResponseWriter, err error) {
http.Error(w, "Internal server error", http.StatusInternalServerError)
}
func writeArticleJsonResponse(w http.ResponseWriter, article domain.Article) {
articleJson, err := json.Marshal(article)
func writeArticleJsonResponse(w http.ResponseWriter, status int, article domain.Article, format domain.BodyFormat) {
articleJson, err := encodeArticle(article, format)
if err != nil {
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
return
}
if status != http.StatusOK {
w.WriteHeader(status)
}
if _, err := w.Write(articleJson); err != nil {
log.Printf("Failed to write response: %v", err)
}
@@ -143,13 +196,18 @@ func (h *Handler) setIsOnline(w http.ResponseWriter, r *http.Request, isOnline b
return
}
updatedArticle, err := h.UpdateUseCase.UpdateIsOnline(id, isOnline)
format, ok := parseBodyFormat(w, r)
if !ok {
return
}
updatedArticle, err := h.UpdateUseCase.UpdateIsOnline(id, isOnline, format)
if err != nil {
writeArticleErrorResponse(w, err)
return
}
writeArticleJsonResponse(w, updatedArticle)
writeArticleJsonResponse(w, http.StatusOK, updatedArticle, format)
}
type UpdateArticleBody struct {
@@ -163,6 +221,11 @@ func (h *Handler) UpdateArticleBody(w http.ResponseWriter, r *http.Request) {
return
}
format, ok := parseBodyFormat(w, r)
if !ok {
return
}
var localArticle UpdateArticleBody
if err := json.NewDecoder(r.Body).Decode(&localArticle); err != nil {
http.Error(w, apperr.BodyErrorMessage, http.StatusBadRequest)
@@ -174,13 +237,13 @@ func (h *Handler) UpdateArticleBody(w http.ResponseWriter, r *http.Request) {
return
}
updatedArticle, err := h.UpdateUseCase.UpdateBody(id, localArticle.Body)
updatedArticle, err := h.UpdateUseCase.UpdateBody(id, localArticle.Body, format)
if err != nil {
writeArticleErrorResponse(w, err)
return
}
writeArticleJsonResponse(w, updatedArticle)
writeArticleJsonResponse(w, http.StatusOK, updatedArticle, format)
}
func (h *Handler) PublishArticle(w http.ResponseWriter, r *http.Request) {
@@ -206,19 +269,34 @@ func (h *Handler) callerIsVerified(r *http.Request) bool {
}
func (h *Handler) ListArticles(w http.ResponseWriter, r *http.Request) {
format, ok := parseBodyFormat(w, r)
if !ok {
return
}
var articles []domain.Article
var err error
if h.callerIsVerified(r) {
articles, err = h.ListUseCase.ListAllArticles()
articles, err = h.ListUseCase.ListAllArticles(format)
} else {
articles, err = h.ListUseCase.ListOnlineArticles()
articles, err = h.ListUseCase.ListOnlineArticles(format)
}
if err != nil {
http.Error(w, "Failed to retrieve articles", http.StatusInternalServerError)
return
}
articlesJson, err := json.Marshal(articles)
responses := make([]articleResponse, 0, len(articles))
for _, article := range articles {
response, err := toArticleResponse(article, format)
if err != nil {
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
return
}
responses = append(responses, response)
}
articlesJson, err := json.Marshal(responses)
if err != nil {
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
return
+162
View File
@@ -0,0 +1,162 @@
package update
import (
"RenewCMS/api/pkg/apperr"
"RenewCMS/api/pkg/claims"
validator "RenewCMS/api/pkg/validator"
domain "RenewCMS/internal/domain/update"
"RenewCMS/internal/domain/user"
"RenewCMS/internal/infrastructure/useCases"
"encoding/json"
"errors"
"io"
"net/http"
"strings"
)
const restartBodyLimitBytes = 1024
type Handler struct {
GetUpdateStatusUseCase *useCases.GetUpdateStatusUseCase
CheckForUpdateUseCase *useCases.CheckForUpdateUseCase
StartUpdateDownloadUseCase *useCases.StartUpdateDownloadUseCase
RequestRestartUseCase *useCases.RequestRestartUseCase
GetUserUseCase *useCases.GetUserUseCase
}
type restartRequest struct {
Kind *string `json:"kind" validate:"omitempty,oneof=update restart"`
}
func NewHandler(getStatus *useCases.GetUpdateStatusUseCase, checkForUpdate *useCases.CheckForUpdateUseCase, startDownload *useCases.StartUpdateDownloadUseCase, requestRestart *useCases.RequestRestartUseCase, getUser *useCases.GetUserUseCase) *Handler {
return &Handler{
GetUpdateStatusUseCase: getStatus,
CheckForUpdateUseCase: checkForUpdate,
StartUpdateDownloadUseCase: startDownload,
RequestRestartUseCase: requestRestart,
GetUserUseCase: getUser,
}
}
func (h *Handler) GetStatus(w http.ResponseWriter, r *http.Request) {
isOwner, ok := h.isOwner(w, r)
if !ok {
return
}
writeStatus(w, http.StatusOK, h.GetUpdateStatusUseCase.GetStatus(isOwner))
}
func (h *Handler) Check(w http.ResponseWriter, r *http.Request) {
if _, err := h.CheckForUpdateUseCase.Check(); err != nil {
http.Error(w, "Internal server error", http.StatusInternalServerError)
return
}
isOwner, ok := h.isOwner(w, r)
if !ok {
return
}
writeStatus(w, http.StatusOK, h.GetUpdateStatusUseCase.GetStatus(isOwner))
}
func (h *Handler) Download(w http.ResponseWriter, _ *http.Request) {
status, err := h.StartUpdateDownloadUseCase.Start()
if err != nil {
writeDownloadError(w, err)
return
}
writeStatus(w, http.StatusAccepted, status)
}
func (h *Handler) Restart(w http.ResponseWriter, r *http.Request) {
kind, ok := decodeRestartKind(w, r)
if !ok {
return
}
userId, ok := claims.UserId(r)
if !ok {
http.Error(w, apperr.UnauthorizedErrorMessage, http.StatusUnauthorized)
return
}
status, err := h.RequestRestartUseCase.Request(userId, kind)
if err != nil {
writeRestartError(w, err)
return
}
writeStatus(w, http.StatusAccepted, status)
}
func decodeRestartKind(w http.ResponseWriter, r *http.Request) (string, bool) {
body, err := io.ReadAll(http.MaxBytesReader(w, r.Body, restartBodyLimitBytes))
if err != nil {
http.Error(w, apperr.BodyErrorMessage, http.StatusBadRequest)
return "", false
}
if strings.TrimSpace(string(body)) == "" {
return "", true
}
var request restartRequest
if err := json.Unmarshal(body, &request); err != nil || validator.Validate.Struct(request) != nil {
http.Error(w, apperr.BodyErrorMessage, http.StatusBadRequest)
return "", false
}
if request.Kind == nil {
return "", true
}
return *request.Kind, true
}
func (h *Handler) isOwner(w http.ResponseWriter, r *http.Request) (bool, bool) {
userId, ok := claims.UserId(r)
if !ok {
http.Error(w, apperr.UnauthorizedErrorMessage, http.StatusUnauthorized)
return false, false
}
currentUser, err := h.GetUserUseCase.GetUser(userId)
if err != nil {
if errors.Is(err, user.ErrUserNotFound) {
http.Error(w, apperr.UnauthorizedErrorMessage, http.StatusUnauthorized)
return false, false
}
http.Error(w, "Internal server error", http.StatusInternalServerError)
return false, false
}
return currentUser.Role == user.RoleOwner, true
}
func writeDownloadError(w http.ResponseWriter, err error) {
switch {
case errors.Is(err, domain.ErrNotPrepared):
http.Error(w, apperr.UpdateNotPreparedErrorMessage, http.StatusConflict)
case errors.Is(err, domain.ErrJobInProgress), errors.Is(err, domain.ErrRestartPending):
http.Error(w, apperr.UpdateAlreadyRunningErrorMessage, http.StatusConflict)
case errors.Is(err, domain.ErrNothingToUpdate):
http.Error(w, apperr.NothingToUpdateErrorMessage, http.StatusBadRequest)
case errors.Is(err, domain.ErrPreflightRefused):
http.Error(w, apperr.UpdateRefusedErrorMessage, http.StatusUnprocessableEntity)
default:
http.Error(w, "Internal server error", http.StatusInternalServerError)
}
}
func writeRestartError(w http.ResponseWriter, err error) {
switch {
case errors.Is(err, domain.ErrNotPrepared):
http.Error(w, apperr.UpdateNotPreparedErrorMessage, http.StatusConflict)
case errors.Is(err, domain.ErrJobInProgress), errors.Is(err, domain.ErrRestartPending):
http.Error(w, apperr.UpdateAlreadyRunningErrorMessage, http.StatusConflict)
case errors.Is(err, domain.ErrRestartKindMismatch):
http.Error(w, apperr.UpdateRestartMismatchErrorMessage, http.StatusConflict)
default:
http.Error(w, "Internal server error", http.StatusInternalServerError)
}
}
func writeStatus(w http.ResponseWriter, code int, status domain.UpdateStatus) {
body, err := json.Marshal(status)
if err != nil {
http.Error(w, "Internal server error", http.StatusInternalServerError)
return
}
w.WriteHeader(code)
_, _ = w.Write(body)
}
+15 -1
View File
@@ -2,6 +2,7 @@ package middleware
import (
"RenewCMS/api/pkg/apperr"
"RenewCMS/api/pkg/claims"
"net/http"
"strconv"
"sync"
@@ -14,12 +15,25 @@ type rateLimitWindow struct {
}
func NewRateLimiter(maxAttempts int, window time.Duration) func(http.Handler) http.Handler {
return newKeyedRateLimiter(maxAttempts, window, func(r *http.Request) string { return r.RemoteAddr })
}
func NewUserRateLimiter(maxAttempts int, window time.Duration) func(http.Handler) http.Handler {
return newKeyedRateLimiter(maxAttempts, window, userRateLimitKey)
}
func userRateLimitKey(r *http.Request) string {
userId, _ := claims.UserId(r)
return strconv.FormatUint(uint64(userId), 10)
}
func newKeyedRateLimiter(maxAttempts int, window time.Duration, keyOf func(*http.Request) string) func(http.Handler) http.Handler {
var mu sync.Mutex
windows := make(map[string]*rateLimitWindow)
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
retryAfter, allowed := recordAttempt(&mu, windows, r.RemoteAddr, maxAttempts, window)
retryAfter, allowed := recordAttempt(&mu, windows, keyOf(r), maxAttempts, window)
if !allowed {
w.Header().Set("Retry-After", strconv.Itoa(retryAfter))
http.Error(w, apperr.TooManyRequestsErrorMessage, http.StatusTooManyRequests)
+6
View File
@@ -29,3 +29,9 @@ const MediaQueryErrorMessage = "The media query is invalid."
const MediaFilenameErrorMessage = "Enter a filename."
const MediaMergeConflictErrorMessage = "Some of the images to merge changed. Refresh and try again."
const MediaMergeRequestErrorMessage = "Choose an image to keep and at least one other image to merge into it."
const UpdateNotPreparedErrorMessage = "This server cannot update itself yet."
const UpdateAlreadyRunningErrorMessage = "An update is already running or waiting to be installed."
const NothingToUpdateErrorMessage = "There is nothing to update."
const UpdateRefusedErrorMessage = "This update cannot be downloaded."
const UpdateRestartMismatchErrorMessage = "The update state changed. Reload the page and try again."
const ArticleBodyFormatErrorMessage = "The format must be one of: markdown, html, json."
+37
View File
@@ -7,11 +7,13 @@ import (
"RenewCMS/api/handlers/media"
"RenewCMS/api/handlers/settings"
"RenewCMS/api/handlers/staticimages"
"RenewCMS/api/handlers/update"
"RenewCMS/api/handlers/user"
"RenewCMS/api/middleware"
"RenewCMS/internal/infrastructure/config"
"encoding/json"
"net/http"
"time"
"github.com/MadAppGang/httplog"
"github.com/go-chi/chi/v5"
@@ -129,6 +131,40 @@ func NewSettingsRouter(container *UseCases) http.Handler {
return r
}
const (
updateCheckMaxAttempts = 5
updateCheckWindow = time.Minute
updateDownloadMaxAttempts = 5
updateDownloadWindow = time.Minute
)
func NewSystemRouter(container *UseCases) http.Handler {
r := chi.NewRouter()
updateHandler := update.NewHandler(container.GetUpdateStatusUseCase, container.CheckForUpdateUseCase, container.StartUpdateDownloadUseCase, container.RequestRestartUseCase, container.GetUserUseCase)
r.Use(jwtauth.Verifier(container.Token))
r.Use(jwtauth.Authenticator(container.Token))
r.Use(middleware.RequireCurrentToken(container.GetUserUseCase))
r.Use(middleware.RequireVerifiedUser(container.GetUserUseCase))
r.Get("/update", updateHandler.GetStatus)
r.Group(func(r chi.Router) {
r.Use(middleware.RequireOwner(container.GetUserUseCase))
r.Use(middleware.NewUserRateLimiter(updateCheckMaxAttempts, updateCheckWindow))
r.Post("/update/check", updateHandler.Check)
})
r.Group(func(r chi.Router) {
r.Use(middleware.RequireOwner(container.GetUserUseCase))
r.Use(middleware.NewUserRateLimiter(updateDownloadMaxAttempts, updateDownloadWindow))
r.Post("/update/download", updateHandler.Download)
})
r.Group(func(r chi.Router) {
r.Use(middleware.RequireOwner(container.GetUserUseCase))
r.Post("/update/restart", updateHandler.Restart)
})
return r
}
func NewMediaRouter(container *UseCases) http.Handler {
r := chi.NewRouter()
@@ -162,6 +198,7 @@ func InitBackendRoutes(container *UseCases, settings config.Settings) *chi.Mux {
r.Mount("/user", NewUserRouter(container, settings.AuthRateLimit, settings.TrustedProxies))
r.Mount("/settings", NewSettingsRouter(container))
r.Mount("/media", NewMediaRouter(container))
r.Mount("/system", NewSystemRouter(container))
r.Mount("/auth", NewAuthRouter(container, settings.IsProduction(), settings.AuthRateLimit, settings.TrustedProxies))
return r
+10
View File
@@ -0,0 +1,10 @@
package main
import (
"RenewCMS/internal/infrastructure/update/releasesign"
"os"
)
func main() {
os.Exit(releasesign.Run(os.Args[1:], os.Stdout, os.Stderr))
}
+90
View File
@@ -0,0 +1,90 @@
package main
import (
"RenewCMS/api"
"RenewCMS/internal/domain/update"
"flag"
"fmt"
"io"
"log"
)
const (
enableCommand = "enable-browser-updates"
disableCommand = "disable-browser-updates"
applyCommand = "apply-update"
exitOK = 0
exitError = 1
exitUsage = 2
usageText = "usage: renewcms [--version]\n" +
" renewcms enable-browser-updates [--service NAME] [--binary PATH] [--data-dir DIR] [--port PORT]\n" +
" renewcms disable-browser-updates [--service NAME] [--data-dir DIR]\n" +
" renewcms apply-update --binary PATH --data-dir DIR [--service NAME] [--port PORT]"
applyNeedsFlagsMessage = "apply-update needs --binary and --data-dir."
)
func runCommand(args []string, stdout io.Writer, stderr io.Writer) int {
name, rest := args[0], args[1:]
switch name {
case enableCommand:
return withOptions(name, rest, stderr, func(options update.InstallOptions) int {
message, err := api.InitBrowserUpdateCommands().Enable.Enable(options)
return printOutcome(stdout, stderr, message, err)
})
case disableCommand:
return withOptions(name, rest, stderr, func(options update.InstallOptions) int {
message, err := api.InitBrowserUpdateCommands().Disable.Disable(options)
return printOutcome(stdout, stderr, message, err)
})
case applyCommand:
return withOptions(name, rest, stderr, func(options update.InstallOptions) int {
return apply(options, stderr)
})
}
fmt.Fprintln(stderr, usageText)
return exitUsage
}
func withOptions(name string, args []string, stderr io.Writer, run func(update.InstallOptions) int) int {
flags := flag.NewFlagSet(name, flag.ContinueOnError)
flags.SetOutput(stderr)
var options update.InstallOptions
flags.StringVar(&options.Service, "service", "", "systemd service name of RenewCMS")
flags.StringVar(&options.Binary, "binary", "", "path of the RenewCMS binary")
flags.StringVar(&options.DataDir, "data-dir", "", "directory that holds DB_FILE")
flags.StringVar(&options.Port, "port", "", "port RenewCMS listens on")
if err := flags.Parse(args); err != nil {
return exitUsage
}
return run(options)
}
func printOutcome(stdout io.Writer, stderr io.Writer, message string, err error) int {
if err != nil {
fmt.Fprintln(stderr, err)
return exitError
}
fmt.Fprintln(stdout, message)
return exitOK
}
func apply(options update.InstallOptions, stderr io.Writer) int {
if options.Binary == "" || options.DataDir == "" {
fmt.Fprintln(stderr, applyNeedsFlagsMessage)
return exitUsage
}
if options.Service == "" {
options.Service = update.DefaultService
}
if options.Port == "" {
options.Port = update.DefaultPort
}
if err := api.InitApplyUpdateCommand(options).Apply(); err != nil {
log.Printf("apply-update failed: %v", err)
return exitError
}
return exitOK
}
+24 -5
View File
@@ -8,6 +8,7 @@ import (
"errors"
"fmt"
"log"
"net"
"net/http"
"os"
"os/signal"
@@ -47,9 +48,19 @@ var envDefaults = map[string]string{
"AUTH_RATE_LIMIT_MAX_ATTEMPTS": "5",
"AUTH_RATE_LIMIT_WINDOW_SECONDS": "60",
"TRUSTED_PROXIES": "",
"UPDATE_FEED_URL": "https://git.floriansylvain.fr",
}
const versionFlag = "--version"
func main() {
if len(os.Args) == 2 && os.Args[1] == versionFlag {
fmt.Println(version)
return
}
if len(os.Args) > 1 {
os.Exit(runCommand(os.Args[1:], os.Stdout, os.Stderr))
}
if err := run(); err != nil {
log.Fatal(err)
}
@@ -69,7 +80,7 @@ func run() error {
validator.InitValidator()
server := newServer(api.InitRoutes(container, settings), settings)
return serveUntilStopped(server, settings)
return serveUntilStopped(server, settings, container.RecordRunningInfoUseCase.Record)
}
func initEnvVariables() {
@@ -120,12 +131,12 @@ func newServer(handler http.Handler, settings config.Settings) *http.Server {
}
}
func serveUntilStopped(server *http.Server, settings config.Settings) error {
func serveUntilStopped(server *http.Server, settings config.Settings, recordRunning func() error) error {
stopSignal, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
defer stop()
serverErr := make(chan error, 1)
go listen(server, serverErr, settings)
go listen(server, serverErr, settings, recordRunning)
select {
case err := <-serverErr:
@@ -135,9 +146,17 @@ func serveUntilStopped(server *http.Server, settings config.Settings) error {
}
}
func listen(server *http.Server, serverErr chan<- error, settings config.Settings) {
func listen(server *http.Server, serverErr chan<- error, settings config.Settings, recordRunning func() error) {
listener, err := net.Listen("tcp", server.Addr)
if err != nil {
serverErr <- err
return
}
if err := recordRunning(); err != nil {
log.Printf("WARNING: could not write the running-version file: %v", err)
}
log.Printf("RenewCMS %s (%s) listening on %s, public URL %s", version, settings.Environment, server.Addr, settings.PublicURL)
err := server.ListenAndServe()
err = server.Serve(listener)
if errors.Is(err, http.ErrServerClosed) {
err = nil
}
+97
View File
@@ -0,0 +1,97 @@
# Reading articles
Every route that returns an article accepts the optional `format` query parameter and returns the article body in that format. Articles are stored as HTML (Tiptap output). Storage and the request bodies of `POST /v1/article/` and `PATCH /v1/article/{id}` stay HTML.
## Routes that honour `format`
- `GET /v1/article/`
- `GET /v1/article/{id}`
- `POST /v1/article/`
- `PATCH /v1/article/{id}`
- `PATCH /v1/article/{id}/publish`
- `PATCH /v1/article/{id}/unpublish`
Visibility is unchanged: anonymous and unverified callers only see online articles, and an offline article answers `404 Article not found`.
## The `format` parameter
| Value | `body` | `body_format` |
| --- | --- | --- |
| empty or absent | markdown string | `markdown` |
| `markdown` | markdown string | `markdown` |
| `html` | the stored HTML string | `html` |
| `json` | JSON array of blocks | `json` |
Values are case-insensitive. When `format` is repeated, the first value is used. Any other value answers `400` with the plain-text message `The format must be one of: markdown, html, json.` before any article is read or written. An invalid id is reported first, ahead of the format.
Breaking change: the default used to be HTML. Clients that need HTML must send `?format=html`. The web interface does so.
## Article object
```json
{
"id": 1,
"title": "Backyard Renovation Update",
"body": "## Plan\n\nReplace the **old** deck.",
"body_format": "markdown",
"is_online": true,
"created_at": "2026-03-12T09:14:00Z",
"updated_at": "2026-09-10T07:00:00Z"
}
```
## Markdown output
Headings, bold, italic, links, bullet and ordered lists, blockquotes, fenced code blocks, rules, images and inline code are converted. Anything else is reduced to its text. `script` and `style` content is removed, and the source HTML is never passed through; the only HTML in the output is the alignment wrapper described below. List indentation attributes are dropped. Links with a scheme other than http, https, mailto or tel are reduced to their text. Characters that markdown would read as formatting (`*`, `_`, `` ` ``, `[`, `]`, `<`, `\`) and line starts that would read as a heading, list, quote or rule (`#`, `-`, `+`, `>`, `1.`) are backslash-escaped, so plain text stays plain text. A line break becomes a backslash followed by a newline.
### Text alignment
Markdown has no syntax for alignment, so centered, right-aligned and justified paragraphs and headings are wrapped in a `div` with an inline style. The blank lines around the content make CommonMark parse the inside as markdown:
```markdown
<div style="text-align: center">
A **centered** paragraph
</div>
```
Left alignment is the default and produces no wrapper. Your markdown renderer must allow raw HTML for the alignment to show (`html: true` in markdown-it); otherwise the wrapper tags appear as text, and a client that does not want them can request `?format=json` instead, where the alignment is a field.
## JSON block schema
`body` is a native JSON array. Every block has a `type`.
| Block | Fields |
| --- | --- |
| `heading` | `level` (1 to 6), `align` (only when `center`, `right` or `justify`), `children` (text nodes) |
| `paragraph` | `align` (only when `center`, `right` or `justify`), `children` (text nodes, empty array for an empty paragraph) |
| `list` | `ordered` (boolean), `items` (array of items, each an array of blocks) |
| `blockquote` | `children` (blocks) |
| `code` | `language` (empty string when unknown), `text` |
| `hr` | none |
| `image` | `src`, `alt` (empty string when missing) |
Text node: `{"type":"text","text":"...","marks":[...]}`. `marks` is always an array, listed outermost first. A mark is `{"type":"bold"}`, `{"type":"italic"}` or `{"type":"link","href":"..."}`. A line break becomes a `"\n"` inside the text. Adjacent text with identical marks is merged. Inline code, underline, strike-through and other formatting degrade to plain text. An image inside a paragraph becomes its own block and splits the paragraph. An empty body is `[]`.
Example for `<h2>Plan</h2><p>Replace the <strong>old</strong> deck.</p>`:
```json
[
{"type":"heading","level":2,"children":[{"type":"text","text":"Plan","marks":[]}]},
{"type":"paragraph","children":[
{"type":"text","text":"Replace the ","marks":[]},
{"type":"text","text":"old","marks":[{"type":"bold"}]},
{"type":"text","text":" deck.","marks":[]}
]}
]
```
## Errors
| Status | Body |
| --- | --- |
| `400` | `The server expects the ID to be in the format of an unsigned 32-bit integer (uint32).` for an invalid id |
| `400` | `The format must be one of: markdown, html, json.` for an unsupported format |
| `404` | `Article not found` |
| `500` | `Internal server error` when the body cannot be converted |
+3
View File
@@ -30,9 +30,12 @@ Copy [`.env.example`](../.env.example) to `.env` to get started. When a required
| `AUTH_RATE_LIMIT_MAX_ATTEMPTS` | `5` | Maximum number of requests a single client IP may send to `POST /v1/auth/login`, `POST /v1/auth/password-reset` or the invite-accept pair (`GET /v1/auth/invite` and `POST /v1/auth/invite/accept`, sharing one counter) within the window, tracked independently per route. |
| `AUTH_RATE_LIMIT_WINDOW_SECONDS` | `60` | Length, in seconds, of the fixed rate-limit window for the routes above. |
| `TRUSTED_PROXIES` | *(empty)* | Semicolon-separated list of exact IP addresses (no CIDR) of reverse proxies allowed to supply the client IP via `X-Real-IP` for the rate limiting of the routes above. When a request's connection address is not in this list, any `X-Real-IP` or `X-Forwarded-For` header it sends is ignored and the connection address is used instead. See [deployment.md](deployment.md). |
| `UPDATE_FEED_URL` | `https://git.floriansylvain.fr` | Base URL of the Gitea server that publishes RenewCMS releases. The Settings page asks `{UPDATE_FEED_URL}/api/v1/repos/fsylvain/RenewCMS/releases` when the owner checks for updates. The last result is kept in `update-status.json`, next to `DB_FILE`. |
Relative paths are resolved against the process's working directory. In production, use absolute paths (see [deployment.md](deployment.md)).
For example, `WorkingDirectory=/var/lib/renewcms` with `DB_FILE=./data/renewcms.db` puts the database in `/var/lib/renewcms/data`. Browser-update `--data-dir` must name that directory, because the app reads helper status and update records beside the database. It is not necessarily `WorkingDirectory` or `ReadWritePaths`. Do not change an existing `DB_FILE` merely to match the helper: that could open a different, empty database. See [browser-update setup](deployment.md#browser-updates).
## Adding a variable
1. Read it in the code where it is needed (infrastructure or `api/`, never `internal/domain`).
+139 -1
View File
@@ -8,7 +8,7 @@ RenewCMS ships as **one self-contained executable**. It serves:
| `/healthz` | Liveness check, returns `200 ok` |
| `/*` | The Vue SPA (embedded), with fallback to `index.html` for client-side routes |
Its only runtime state is the SQLite database (`DB_FILE`) and the uploads directory (`UPLOAD_DIR`). Nothing else needs to be installed on the server.
Runtime state includes the SQLite database (`DB_FILE`), uploads (`UPLOAD_DIR`), and update records, staged binaries and backups beside the database. Running a release binary needs no Go, Bun or Node installation. Browser updates additionally require Linux with systemd and the helper setup below.
## 1. Build
@@ -19,8 +19,146 @@ task build # this OS/arch → bin/renewcms[.exe]
task release # all targets → bin/renewcms_<version>_<os>_<arch>[.exe]
```
`task release` also signs the release: it writes `bin/checksums.txt` (SHA-256 of the six binaries) and signs it into `bin/checksums.txt.sig` with an Ed25519 key. It refuses to start, before building anything, unless `RELEASE_SIGNING_KEY` points to the private key file and that key matches the public key committed as `internal/infrastructure/update/release.pub`. The one-time setup is below.
The frontend is built once and embedded into every binary. The binaries are static (`CGO_ENABLED=0`), so a Linux build runs on any distribution. The version comes from `git describe`: tag a release (`git tag v1.2.0`) before building, and the binary logs its version at startup.
### Release signing key (maintainers, once)
1. Run `task release:keygen -- <path>` with a path outside the repository (for example `~/.renewcms/release.key`). The private key is written there and never leaves your machine; keygen refuses a path inside the work tree.
2. Commit the printed public key as `internal/infrastructure/update/release.pub`. A placeholder key (32 zero bytes) prevents signing. Official releases already embed the project's public key; this setup is for release maintainers, not site operators. Never copy the private signing key to a CMS server.
3. Export `RELEASE_SIGNING_KEY=<path to the private key>` before every `task release`.
To check a download by hand: `go run ./cmd/releasesign verify checksums.txt`, with `checksums.txt.sig` next to it, then compare the binary's hash with the matching line of `checksums.txt`.
### Update checks
The owner's Settings page asks the release feed for the newest release (see `UPDATE_FEED_URL` in [configuration.md](configuration.md)) and keeps the last result in `update-status.json`, next to `DB_FILE`. Back it up with the rest of the data directory if you like; it is rebuilt by the next check when missing. The Settings page reports a newer version. To install it from the browser, set up [Browser updates](#browser-updates) once on the server.
### Update downloads
Once the restart helper is installed (it writes `update-helper.json` next to `DB_FILE`), the owner's Update button downloads the new binary, `checksums.txt` and `checksums.txt.sig` from the release feed host over https only, checks the ed25519 signature and the SHA-256, runs the staged binary with `--version`, copies the database into `backups/` (the last 3 copies are kept) and stages everything under `updates/<tag>/`, all next to `DB_FILE`. The job record is `update-job.json`. Nothing running is replaced and the site is not restarted by the download: the owner's Restart button does that, as described in [Browser updates](#browser-updates). `renewcms --version` prints the build version and exits.
### Browser updates
The owner's Restart button installs a downloaded update, or just restarts the site, without touching the server by hand. The app itself stays unprivileged: the systemd unit below keeps `ProtectSystem=strict` and only the data directory (the directory that holds `DB_FILE`) is writable. The only privileged code is a small helper, the same binary started as `renewcms apply-update` by a systemd service that runs as root.
First install v2.6.0-beta or newer manually, back up the database, uploads and current binary, and confirm the app runs as an unprivileged service user. The binary and its parent directory should be controlled by root. Owners can start updates and restarts; admins have read-only update status.
#### Find the actual database directory
The helper's `--data-dir` must be the directory containing `DB_FILE`. Inspect the relevant settings without printing the configuration's secrets:
```sh
sudo systemctl show renewcms -p User -p WorkingDirectory
sudo grep '^DB_FILE=' /etc/renewcms/renewcms.env
```
| WorkingDirectory | DB_FILE | Correct --data-dir |
| --- | --- | --- |
| `/var/lib/renewcms` | `/var/lib/renewcms/renewcms.db` | `/var/lib/renewcms` |
| `/var/lib/renewcms` | `./data/renewcms.db` | `/var/lib/renewcms/data` |
Leave an existing `DB_FILE` unchanged: changing it can open a different, empty database. Configure the helper to match the existing database instead.
#### Enable the helper
For this guide's absolute database path and port 8080, run:
```sh
sudo /opt/renewcms/renewcms enable-browser-updates \
--service renewcms \
--binary /opt/renewcms/renewcms \
--data-dir /var/lib/renewcms \
--port 8080
```
Replace these flags with your actual paths and port. For the relative database example above and port 8788, use `--data-dir /var/lib/renewcms/data --port 8788`. The absolute executable path works even when `/opt/renewcms` is absent from sudo's PATH.
Without explicit flags, discovery reads `/etc/systemd/system/renewcms.service` and takes its first `ReadWritePaths` entry as the data directory. It does not resolve `DB_FILE`, so explicit flags are necessary when these directories differ or the unit lives elsewhere. The port comes from `--port`, else `PORT` in the unit's `EnvironmentFile`, else 8080. The helper polls `/healthz` on `127.0.0.1` at that port. It then:
- writes `renewcms-update.path` and `renewcms-update.service` next to your other units in `/etc/systemd/system` (no secret and no environment value goes into them);
- runs `systemctl daemon-reload` and enables and starts the path unit;
- writes `update-helper.json` in the data directory last, so the Settings page only offers Update and Restart once everything else worked.
Running it again rewrites the units and the status file to the current values. If a step fails, the units it wrote are removed again and `update-helper.json` is not written.
#### Verify setup and test a plain restart
For the layout above, run these checks, substituting your service user and database directory if different:
```sh
systemctl is-active renewcms-update.path
systemctl is-enabled renewcms-update.path
sudo systemctl cat renewcms-update.service
sudo -u renewcms cat /var/lib/renewcms/update-helper.json
```
Expect `active`, `enabled`, an `ExecStart` with the correct paths and port, and readable JSON. Reload Settings as owner. With no update waiting, Restart should appear. Press it, confirm the plain restart dialog, and expect the overlay followed by the site returning and a “Site restarted” message.
Then run:
```sh
systemctl is-active renewcms
sudo cat /var/lib/renewcms/update-result.json
sudo cat /var/lib/renewcms/update-running.json
sudo journalctl -u renewcms-update.service -n 30 --no-pager
curl --retry 5 --retry-connrefused --retry-delay 2 -fsS http://127.0.0.1:8080/healthz
```
Expect an active app service, result `kind: restart` with `outcome: succeeded`, the installed version and a new process in `update-running.json`, and health response `ok`. Check `/healthz` through your public HTTPS hostname too. A brief connection refusal during startup can be transient. The oneshot helper normally becomes inactive after success; the path unit stays active.
#### Install a future update
When a newer signed release exists, check for updates in Settings, read its notes and click Update. The site stays online while the files are downloaded, verified and backed up. Wait for Ready to install, then click Restart and confirm installation. Afterwards, check the version in Settings, public health, the helper journal and `update-result.json`: expect `kind: update` and `outcome: succeeded`.
On the latest release you can test only a plain restart. Test installation, forced rollback and hostile-file cases on an isolated Linux/systemd machine with its own data and service. The helper unit names are fixed, so setting up another instance on the same machine replaces that machine's existing helper configuration.
#### Troubleshooting
- **Restart is missing:** reload Settings, confirm you are owner, and inspect `GET /v1/system/update` in the browser's Network panel. For an idle owner, `can_apply: false` means the app did not detect the helper. Check that `update-helper.json` is beside the actual database and readable by the service user.
- **Wrong helper directory:** disable the helper with the old `--data-dir`, then enable it with the correct directory and port. Do not change `DB_FILE` to compensate.
- **Overlay does not clear:** inspect the helper journal, `update-result.json` and `update-running.json` in the actual database directory. Check localhost health on the configured port, then public health through the proxy. Do not cache `/healthz` at the proxy.
- **Old binary panics on `--version`:** older releases may interpret it as normal startup and require server environment variables. v2.6.0-beta and newer print their version without loading configuration. A separately launched process failing this way does not stop the systemd service.
- **Download or verification fails:** inspect the app journal. All assets and redirects must use HTTPS on the configured feed host. The release must include the six binaries, `checksums.txt` and `checksums.txt.sig`.
- **Update rolls back:** check the previous version and helper journal. Automatic rollback restores the binary, not the database; schema changes still require a recovery plan.
#### Disable the helper
Use the same database directory you supplied when enabling it:
```sh
sudo /opt/renewcms/renewcms disable-browser-updates \
--service renewcms \
--data-dir /var/lib/renewcms
```
This stops and disables the path unit, removes both unit files and `update-helper.json`, and runs `systemctl daemon-reload`. The restart request, result, staged files and backups stay. `can_apply` becomes false: Settings shows “Not prepared” when an update is available, or “You're up to date” without Restart otherwise.
How it works: pressing Restart makes the app write `update-restart-request.json` in the data directory. The path unit notices it and starts the helper, which deletes the request, checks the staged files again, installs the update, restarts the service and waits up to 60 seconds for the site to answer `/healthz` and for the new process to write `update-running.json`. The helper writes its outcome to `update-result.json`; the Settings page reads it. The technical reason of a failure goes to the journal only (`journalctl -u renewcms-update`).
Files in the data directory:
| File | Written by | What |
|------|------------|------|
| `update-restart-request.json` | the app | The request: `kind` (`update` or `restart`), `tag` (updates only), `requested_at`, `requested_by`. The helper deletes it first. |
| `update-result.json` | the helper | The outcome: `running`, `succeeded`, `rolled_back` or `failed`, with `kind`, `tag`, `from_version`, `started_at`, `finished_at`. It stays until the next download or restart. |
| `update-helper.json` | `enable-browser-updates` | Marks browser updates as set up (`version`, `service`, `binary`, `data_dir`, `installed_at`). |
| `update-running.json` | the server, at every start | `version`, `pid` and `started_at` of the running process. The helper uses it to tell a new process from an old one. |
What is supported and what is not:
- Linux with systemd only. Not Windows, macOS, Docker or other init systems: there the command refuses with a clear message and the Settings page keeps showing "Not prepared".
- Before the swap the helper copies the staged files into a private temp directory, checks the signature and the SHA-256 on that copy and installs the copy. It refuses symbolic links under `updates/` and on the request file.
- The previous binary is kept as `<name>.previous` next to the binary, and the update download keeps a database backup in `backups/`.
- If the new version does not come up within 60 seconds, the helper puts `<name>.previous` back, restarts the service and records `rolled_back`. If even that fails the result is `failed` and the journal says so loudly.
- A plain restart (no update waiting) restarts the service the same way and records `succeeded` or `failed`; no binary is replaced.
- Only the owner can press Restart. The site is unavailable for about 10 seconds.
#### Verification status
A real v2.6.0-beta plain browser restart was confirmed on Linux/systemd on 2026-10-02: the path unit triggered the helper, a new server process started, the result was `succeeded`, and public health returned `ok`. Real signed installation, forced rollback and adversarial filesystem checks remain unverified. The manual cases are listed in [the restart QA procedure](../features/updates_restart_helper.qa.md).
## 2. Lay out the server
The following is a suggested layout for Linux:
+2 -2
View File
@@ -25,7 +25,7 @@ The visual spec of record for the back-office SPA and the transactional emails,
| [Forgot password](screens/forgot-password.md) | `/register/reset/request` | 6 | `source/RenewCMS Screens Auth.dc.html` |
| [Reset password](screens/reset-password.md) | `/register/reset/validate?c=CODE&email=EMAIL` | 7 | `source/RenewCMS Screens Auth.dc.html` |
| [Boot](screens/boot.md) | `any route, first load` | 1 | `source/RenewCMS Screens Back-office.dc.html` |
| [Home](screens/home.md) | `/home` | 4 | `source/RenewCMS Screens Back-office.dc.html` |
| [Home](screens/home.md) | `/home` | 6 | `source/RenewCMS Screens Back-office.dc.html` |
| [Articles](screens/articles.md) | `/article` | 14 | `source/RenewCMS Screens Back-office.dc.html` |
| [New article](screens/new-article.md) | `modal from anywhere · /article/new` | 5 | `source/RenewCMS Screens Back-office.dc.html` |
| [Editor](screens/editor.md) | `/article/:id/edit` | 22 | `source/RenewCMS Screens Back-office.dc.html` |
@@ -33,7 +33,7 @@ The visual spec of record for the back-office SPA and the transactional emails,
| [Media picker](screens/media-picker.md) | `/article/:id/edit` (dialog) | 13 | `source/RenewCMS Screens Back-office.dc.html` |
| [Integration](screens/integration.md) | `/integration` | 2 | `source/RenewCMS Screens Back-office.dc.html` |
| [Users](screens/users.md) | `/users` | 17 | `source/RenewCMS Screens Back-office.dc.html` |
| [Settings](screens/settings.md) | `/settings` | 1 | `source/RenewCMS Screens Back-office.dc.html` |
| [Settings](screens/settings.md) | `/settings` | 25 | `source/RenewCMS Screens Back-office.dc.html` |
| [Profile](screens/profile.md) | `/profile` | 13 | `source/RenewCMS Screens Back-office.dc.html` |
| [Accept invite](screens/accept-invite.md) | `/invite/accept?c=CODE` | 9 | `source/RenewCMS Screens Auth.dc.html` |
| [Global](screens/global.md) | `any route` | 4 | `source/RenewCMS Screens Back-office.dc.html` |
+31 -6
View File
@@ -47,7 +47,7 @@ These are the RenewCMS components, built from the primitives on the first page .
### AuthShell
One centered card for every public screen. The logo sits above the title, and the form or ResultPanel goes in the slot. Footer links and the theme select sit outside the card, so the card itself stays about one task.
One centered card for every public screen. The logo sits above the title, and the form or ResultPanel goes in the slot. Footer links, the language chip and the theme select sit outside the card, so the card itself stays about one task.
Log in Welcome back. Log in to manage your articles.
@@ -55,7 +55,7 @@ default slot
Forgot password? System
Built from Custom layout component AuthShell.vue : a UPageCard variant="outline" inside a centered main , with AppLogo , and UColorModeSelect size="sm" in the footer. Forms inside it use UForm rather than UAuthForm , because every screen needs states (such as 403, 429 and an inline login during verification) that UAuthForm doesn't expose.
Built from Custom layout component AuthShell.vue : a UPageCard variant="outline" inside a centered main , with AppLogo , and UColorModeSelect size="sm" in the footer, next to the language chip (see LanguageSwitcher). Forms inside it use UForm rather than UAuthForm , because every screen needs states (such as 403, 429 and an inline login during verification) that UAuthForm doesn't expose.
Props, slots Props title: string , description?: string . Slots default , notice (an alert above the title, for session expired or password changed), footer (links). No emits.
@@ -383,12 +383,13 @@ The Product components board was not regenerated for these. They are written fro
### UserMenu (changed)
The chip at the foot of the sidebar no longer logs out on click. It opens the account menu, which lists Profile, the theme choice and Log out.
The chip at the foot of the sidebar no longer logs out on click. It opens the account menu, which lists Profile, the theme choice, the language choice and Log out.
- **Chip:** 40 px high, an initials avatar (26 px, sand `#d4c5b0` with ink text), the name, and a chevrons-up-down icon. `aria-haspopup="menu"`, `aria-expanded`, title "Account". While the menu is open, or while `/profile` is the current page, it takes `--rc-sand` with `#111111` text.
- **Name:** the display name when there is one, otherwise the username. Initials come from the first letters of the first two words of the display name, uppercased. Without a display name they come from the username.
- **Desktop menu:** a 224 px popover anchored above the chip on its left edge, with `--rc-shadow-pop`. Header: the name in semibold, the email below it in muted 12 px, a bottom border. Items are 32 px: Profile (circle-user), a separator, System, Light and Dark (14 px text, a check icon at the right edge on the current choice), a separator, Log out (log-out). The current page's item is highlighted with `--ui-bg-elevated`. The theme items are radio-style: choosing one applies at once and keeps the menu open. Nuxt UI: `type: 'checkbox'` items bound to `useColorMode().preference`.
- **Mobile:** the account row in the navigation drawer opens a bottom sheet over an `--rc-overlay` scrim, with a grab handle. Header: 36 px avatar, name in 15 px semibold, email in muted text. Items are 48 px at 15 px text; the theme items keep the same order and separators.
- **Desktop menu:** a 224 px popover anchored above the chip on its left edge, with `--rc-shadow-pop`. Header: the name in semibold, the email below it in muted 12 px, a bottom border. Items are 32 px: Profile (circle-user), a separator, a "Theme" section label, System, Light and Dark (14 px text, a check icon at the right edge on the current choice), a separator, a "Language" section label, English and Français (same row as the theme items, a check icon on the current one), a separator, Log out (log-out). Section labels are 11 px, weight 500, uppercase, letter-spacing .04em, `--ui-text-muted`, padded 6px 8px 2px. The current page's item is highlighted with `--ui-bg-elevated`. The theme items are radio-style: choosing one applies at once and keeps the menu open. Nuxt UI: `type: 'checkbox'` items bound to `useColorMode().preference`.
- **Mobile:** the account row in the navigation drawer opens a bottom sheet over an `--rc-overlay` scrim, with a grab handle. Header: 36 px avatar, name in 15 px semibold, email in muted text. Items are 48 px at 15 px text; the theme and language items keep the same order, section labels (padded 8px 16px 2px) and separators.
- **Language items:** a `menuitemradio` group named by the "Language" label. Each item is labelled with the language's own name (English, Français) and carries `lang="en"` / `lang="fr"`. Choosing one applies the language at once and keeps the menu open, like the theme items. See LanguageSwitcher.
- **Keyboard:** Escape or a click outside closes it. Arrow keys move between items.
- The board now draws the theme items, so the chip, menu and sheet need no visual exception. The board highlights Profile even on Home; the app highlights it only on `/profile`.
@@ -734,7 +735,16 @@ Three choices: System (the default), Light and Dark. The toggle at the top of th
Nuxt UI In the user menu: a UDropdownMenu group of three type: 'checkbox' items bound to useColorMode().preference . On auth screens: UColorModeSelect in the footer. Nuxt UI's UColorModeButton isn't used because it only toggles between light and dark and hides the system option. colorMode: true in the plugin handles storage and applying the .dark class before first paint.
ARIA Menu items use menuitemcheckbox , with aria-checked on the current choice. The segmented variant is a radiogroup named "Theme".
ARIA Menu items use menuitemradio , with aria-checked on the current choice. The segmented variant is a radiogroup named "Theme".
### LanguageSwitcher
Two choices: English and Français. Each is always written in its own language, whatever the interface language. It appears in two places and never as a form select.
- **Account menu (signed in):** a "Language" section between the theme items and Log out. See UserMenu (changed).
- **Auth footer (signed out):** a chip beside the System theme chip, in the footer outside the card. The chip is 28 px high on desktop and 44 px on mobile, 8 px side padding, 1 px `--ui-border-accented` border, `--ui-text-toned` text, a 14 px lucide `languages` icon, then the current language's own name. `aria-haspopup="menu"`, `aria-expanded`, `aria-label` "Language: English". While open it takes `--ui-bg-elevated`. The footer sits at the right with an 8 px gap between the two chips.
- **Auth popover:** opens above the chip (bottom 36 px, right-aligned, 168 px wide), `--ui-bg`, 1 px `--ui-border`, `--rc-shadow-pop`, 4 px padding, `role="menu"` named "Language". Rows are 32 px (44 px on mobile), 14 px text, `menuitemradio` with `lang`, a 16 px check icon at the right edge on the current one. Choosing a row applies the language and closes the popover; Escape or an outside click closes it without changing anything.
- The choice persists across reloads and applies to every screen at once.
## Added with roles, invite actions and Settings
@@ -784,3 +794,18 @@ Exact values live in `source/MediaFrame.dc.html`. Copy and states are in [media]
| MediaPicker | UTabs inside ImageUploader | articleId | picked(item, alt) | Editor |
ImageUploader (changed): it gains the Upload and Library tabs and the "Already in your library" card. The remove-image confirm becomes neutral and only detaches the image from the article.
## Added with Updates
Exact values live in `source/AppFrame.dc.html` (the Settings and Home states). Copy and states are in [settings](screens/settings.md) and [home](screens/home.md).
| Component | Nuxt UI base | Props | Emits | Used in |
|---|---|---|---|---|
| UpdatesCard | custom card, UProgress, UButton, UCollapsible | status: UpdateStatus, role | check, update, restart, copy-command | Settings |
| UpdateStatusBlock | custom (polite live region) | tone, icon, title, text, meta, pendingTag?, action? (in-block Restart, Ready only) | none | UpdatesCard |
| UpdateProgress | UProgress | label, text, value or indeterminate | none | UpdatesCard |
| ReleaseNotes | UCollapsible | version, date, items | none | UpdatesCard |
| ServerCommand | UButton, code block | line | copy | UpdatesCard (Not prepared) |
| RestartOverlay | custom full-page `role="status"` | title, text, startedAt, slow | reload | App shell |
| UpdateBanner | UAlert | state: 'available'\|'ready' | go-to-settings, dismiss | Home (owner) |
| UpdatePill | UBadge | none | none | DashboardShell Settings item (dot on mobile) |
+2 -2
View File
@@ -11,14 +11,14 @@ A global `router.beforeEach` guard reads `meta.auth`. On the first navigation it
| `/register/validate` | AuthShell | public | VerifyPage | POST /v1/auth/verify (+ POST /login inline on 401) |
| `/register/reset/request` | AuthShell | public | ResetRequestPage | POST /v1/auth/password-reset |
| `/register/reset/validate` | AuthShell | public | ResetConfirmPage | POST /v1/auth/password-reset/confirm |
| `/home` | DashboardShell | verified | HomePage | GET /v1/article/ |
| `/home` | DashboardShell | verified | HomePage | GET /v1/article/ · GET /v1/system/update (owner, for the banner) |
| `/article` | DashboardShell | verified | ArticlesPage | GET /v1/article/ · PATCH /{id}/publish\|unpublish · DELETE /{id} |
| `/article/new` | DashboardShell | verified | ArticlesPage + NewArticleModal | POST /v1/article/ |
| `/article/:id/edit` | DashboardShell | verified | EditorPage | GET /{id} · PATCH /{id} · PATCH /{id}/publish\|unpublish · GET /v1/media/ · POST /v1/media/ · DELETE /{id} |
| `/media` | DashboardShell | verified | MediaPage | GET /v1/media/ · POST /v1/media/ · PATCH /v1/media/{id} · DELETE /v1/media/{id} · POST /v1/media/merge · GET /v1/media/{id}/usage |
| `/integration` | DashboardShell | verified | IntegrationPage | none |
| `/users` | DashboardShell | verified | UsersPage + InviteUserModal | GET /v1/user/ · POST /v1/user/invite · DELETE /v1/user/invite/:id · POST /v1/user/invite/:id/renew |
| `/settings` | DashboardShell | verified | SettingsPage | GET /v1/settings |
| `/settings` | DashboardShell | verified | SettingsPage | GET /v1/settings · GET /v1/system/update · POST /v1/system/update/check · POST /v1/system/update/download · POST /v1/system/update/restart |
| `/profile` | DashboardShell | verified | ProfilePage | GET /v1/auth/me · PATCH /v1/user/me · POST /v1/auth/password-reset |
| `/invite/accept` | AuthShell | public | AcceptInvitePage | GET /v1/auth/invite?c=* · POST /v1/auth/invite/accept* |
| `/:pathMatch(.*)*` | either | any | NotFoundPage | none |
+14
View File
@@ -40,3 +40,17 @@ The greeting reads "Good morning, {name}", where the name is the display name wh
- Breadcrumbs: Home (mobile title "Home")
- Subtitle: "Here's where things stand on your site."
- Error state for the list request
### Update available (owner)
**Trigger:** The owner only. A quiet banner above the content, and an "Update" pill on the Settings sidebar item (a dot on the menu icon on mobile, read as "Update available"). Dismissing hides the banner until the next version; the pill stays. Admins see neither.
- Breadcrumbs: Home (mobile title "Home")
- Subtitle: "Here's where things stand on your site."
- Banner: `role="region"` labelled "Update available", info tone, `circle-arrow-up` icon, title "Version 2.3.0 is available", text "Update it from Settings. It takes about 2 minutes and the site stays online.", button "Go to Settings", and a dismiss button
### Update ready to install (owner)
**Trigger:** The download is checked. The same banner changes its copy, and a dismiss comes back on the next visit because the update is waiting.
- Banner: success tone, `circle-check` icon, title "Version 2.3.0 is ready to install", text "Restart from Settings to finish. The site is unavailable for about 10 seconds.", button "Go to Settings"
+5 -1
View File
@@ -48,8 +48,12 @@ Desktop: a 224 px popover above the chip, aligned to its left. Mobile: the accou
| Header | The name in semibold (display name, or the username), and the email in muted 12 px (14 px on mobile, with a 36 px initials avatar beside them) |
| Item | Profile (circle-user icon), highlighted while on `/profile` |
| Separator | |
| Label | "Theme": 11 px, weight 500, uppercase, letter-spacing .04em, muted |
| Items | System, Light, Dark: a radio-style group, the current choice carries a check icon at the right edge; choosing one applies the theme at once and keeps the menu open |
| Separator | |
| Label | "Language", styled like "Theme" |
| Items | English, Français (each in its own language, with `lang`): a radio-style group with a check on the current one; choosing one applies the language at once and keeps the menu open |
| Separator | |
| Item | Log out (log-out icon) |
Avatar initials come from the first letters of the first two words of the display name, uppercased ("Marta Alves" gives MA). Without a display name they come from the username.
@@ -64,7 +68,7 @@ The board's menu now carries System, Light and Dark, matching the shipped UserMe
- Breadcrumbs: Home (mobile title "Home")
- Page behind the menu: Home, default
- Menu open, as described above, with the System, Light and Dark group between Profile and Log out. The board shows Light checked
- Menu open, as described above, with the Theme group (System, Light, Dark) and the Language group (English, Français) between Profile and Log out. The board shows Light and English checked
### Loading
+113 -21
View File
@@ -1,35 +1,127 @@
# Settings
- **Route:** `/settings`
- **API:** GET /v1/settings (not drawn, see the notes)
- **Visual reference:** `source/RenewCMS Screens Back-office.dc.html`, group "Settings" (open it in a browser; each state is drawn at desktop and mobile, with a light/dark toggle).
- **API:** GET /v1/settings (version) · GET /v1/system/update · POST /v1/system/update/check · POST /v1/system/update/download · POST /v1/system/update/restart
- **Visual reference:** `source/RenewCMS Screens Back-office.dc.html`, group "Settings", drawn by `source/AppFrame.dc.html` (open it in a browser; each state is drawn at desktop and mobile, with a light/dark toggle).
Opened from the sidebar (Settings, settings icon, after Integration) and from the mobile drawer. Every verified user sees it, owner and admins alike. For now it holds a single section, Version. Nothing on it can be edited.
Opened from the sidebar (Settings, settings icon, after Integration) and from the mobile drawer. Every verified user sees it. It holds two sections: Version (everyone) and Updates (the owner has the buttons, admins read the status).
The Updates card lets a non-technical owner update the site without a terminal. **Update** downloads the new version and checks it, and changes nothing. **Restart** installs it and restarts the site (about 10 seconds). "Restart later" is simply closing the dialog or leaving the page; the update waits. A plain **Restart** appears only when no update is waiting. The state lives on the server, so any owner on any device sees the same card, and the buttons are disabled while any step runs.
Out of scope: choosing versions, downgrades, automatic updates, update history.
## The page
Title "Settings" and the subtitle "Workspace information.", 720 px wide at most. Page padding 32 px on desktop and `20px 16px 88px` on mobile, 20 px between the header and the card.
Title "Settings", subtitle "Workspace information.", 720 px at most, 20 px between sections. Page padding 32 px on desktop and `20px 16px 88px` on mobile.
One card (`--ui-bg`, 1 px `--ui-border`, 20 px padding on desktop and 16 px on mobile), a single row with the label on the left and the value on the right, 16 px apart:
**Version card** (unchanged): label "Version" and the running build's version in IBM Plex Mono 14 px, shown exactly as the server reports it (for example `v2.2.0-beta`).
**Updates card**, under it: `--ui-bg`, 1 px `--ui-border`, 20 px padding (16 px on mobile), 16 px gap. A region labelled by its heading "Updates" (`id="updates-h"`, `tabindex="-1"`, focus ring `2px solid var(--ui-primary)` with 4 px offset when focus is moved there). Inside:
| Part | Content |
|---|---|
| Label | "Version", 15 px semibold, `--ui-text-highlighted` |
| Value | The running build's version in IBM Plex Mono 14 px, `--ui-text-toned`. The board shows `v2.2.0-beta`. Shown exactly as the server reports it, so the SPA adds no `v` prefix. |
| Status block | A polite live region (`aria-live="polite"`): 14 px padding, 12 px gap, an 18 px icon, a semibold title, the text, and a muted `meta` line. Background and icon color follow the tone: neutral `--ui-bg-muted`, success, info, warning, error (`--rc-<tone>-soft` fill, `--ui-<tone>` icon). The title row is a flex row with an 8 px gap that wraps. In "Ready to install" it carries a **Pending tag** after the title and the block holds the **Restart** button (see below). |
| Pending tag | Only in "Ready to install", right after the title: 20 px high, 0 6 px padding, IBM Plex Mono 11 px medium, `--ui-bg` fill, `--ui-warning` text and 1 px `--ui-warning` border, square corners, text "Pending". |
| In-block button | Only in "Ready to install", "Restart: confirm" and "Restart: request failed": the primary Restart button sits inside the status block, under the `meta` line, after 8 px of extra top padding, left-aligned (content width, 14 px side padding, 32 px high, 44 px on mobile, not stretched). The buttons row under the block is not drawn in these states. The hint stays under the card. |
| Progress | A `progressbar` with a value (`aria-valuenow`) while downloading, labelled for example "Downloading version 2.3.0", with the text `42% · 11 of 26 MB`. Indeterminate while verifying (35 % wide moving bar), labelled "Checking the download", text "Almost there". Announced at 25 % steps and when the step changes, never on every tick. |
| Release notes | A button "What's new in 2.3.0" with `aria-expanded` and a chevron, collapsed by default. Open: "Released 24 Sep 2026" and a plain-text list. |
| Server command | Only in the "Not prepared" state: "For whoever manages the server", a one-line `code` block, a Copy button (reads "Copied" with a check for 2 s, announced), and the note "They run this once on the server. After that, Update and Restart appear here." The command shown is `renewcms enable-browser-updates` and is subject to the real one. |
| Buttons | 32 px high (44 px on mobile, stacked full width), 14 px side padding. One primary at most. Disabled buttons use 40 % opacity. |
| Hint | 12 px muted line under the buttons. |
| Link | Underlined, with an `arrow-up-right`: "How to update" or "Read the release notes". |
Buttons used: **Check for updates** (`refresh-cw`, secondary), **Update** (`download`, primary), **Restart** (`power`, primary and inside the status block when an update is ready, otherwise secondary in the buttons row), **Try again** (`rotate-cw`, primary), and the disabled "Checking…" and "Updating…" (`loader-circle`). Copy such as "Version 2.3.0" names the newer release. Decision for the spec: show the release tag without its leading `v` ("Version 2.3.0-beta" for tag `v2.3.0-beta`), while the Version card keeps the running build exactly as the server reports it.
## Copy
| Where | Copy |
|---|---|
| Up to date | `circle-check`, success: "You're up to date" / "You have the latest version of RenewCMS." / "Last checked today at 09:41"; buttons "Check for updates" and "Restart"; hint "Restart takes about 10 seconds. Your site is unavailable while it restarts." |
| Checking | `loader-circle`: "Checking for updates…" / "This usually takes a few seconds."; "Checking…" disabled |
| Check failed | `wifi-off`, warning: "Couldn't check for updates" / "RenewCMS couldn't reach the update server. Check your connection and try again. Your site isn't affected." / "Last checked yesterday at 18:12"; "Try again" (primary) and "Restart" |
| Available | `circle-arrow-up`, info: "Version 2.3.0 is available" / "You have v2.2.0-beta. Update downloads the new version and checks it. Nothing changes until you restart."; "Update"; hint "Takes about 2 minutes. Your site stays online." |
| Downloading | `download`, info: "Downloading version 2.3.0…" / "You can leave this page. The download continues and your site stays online."; "Updating…" disabled |
| Verifying | `shield-check`, info: "Checking the download…" / "Making sure the file is complete and safe to install. This takes a few seconds." |
| Ready | `clock`, warning, with the "Pending" tag after the title: "Version 2.3.0 is ready to install" / "The download is checked. Restart to install it. Your site will be unavailable for about 10 seconds." / "Nothing has changed yet."; "Restart" (primary, inside the block); hint "Not now? Leave this page. The update waits here, and the banner on Home reminds you." |
| Done | "You're on version 2.3.0" / "The update is installed and your site is running again." / "Updated today at 09:52"; link "Read the release notes"; toast `circle-check` "Update installed" / "RenewCMS is now on version 2.3.0." |
| Rolled back | `triangle-alert`, warning: "The update didn't install" / "RenewCMS put the previous version back, so your site is running as before. Nothing was lost." / "What to do next: try again in a few minutes. If it fails again, ask whoever manages your server to check the update."; "Try again"; toast (error, stays) `circle-x` "The update didn't install" / "Your site is back on v2.2.0-beta." |
| Download failed | `circle-x`, error: "The download didn't finish" / "The connection dropped before the file was complete. Nothing was changed and your site is running as before."; "Try again" |
| Not trusted | `triangle-alert`, warning: "We didn't use this update" / "The file didn't pass our safety check, so it was not installed. Nothing was changed. Try downloading it again. If this keeps happening, contact RenewCMS support." Technical detail goes to the server log. |
| Rate limited | `info`: "Too many tries" / "Wait a moment before trying again."; button "Try again in 0:42" counting down Retry-After |
| Not prepared | `info`: "Version 2.3.0 is available" / "This site can't update itself from the browser yet. Whoever manages your server can set it up once, or update RenewCMS for you." and a link "How to update". No buttons, not even Restart. |
| Admin | "Version 2.3.0 is available" / "You have v2.2.0-beta. Only the owner can update RenewCMS. Ask the owner of this site." No buttons. Up to date reads "You're up to date" and "Only the owner can update or restart the site." |
## Dialogs and overlays
Both dialogs use the ConfirmDialog behaviour: focus moves to the first button, Escape and the cancel button close it, and focus returns to the button that opened it. The confirm button is neutral, not red, because nothing is lost.
| Dialog | Title | Description | Cancel / Confirm |
|---|---|---|---|
| Install | "Restart to finish the update?" | "RenewCMS will install version 2.3.0 and restart. Your site will be unavailable for about 10 seconds. This page reloads on its own when the site is back. Save anything you're editing first." | "Restart later" / "Restart now" |
| Plain restart | "Restart the site?" | "Your site will be unavailable for about 10 seconds. This page reloads on its own when the site is back. Save anything you're editing first." | "Cancel" / "Restart site" |
Failure inside the install dialog: "Couldn't start the restart. Nothing was changed and your site is still running. Try again in a moment."
Restart overlay: a full-page `role="status"` live region (`--ui-bg-muted`, 440 px card) that survives the server going away, with a moving bar. Copy: "Installing version 2.3.0" / "Your site is restarting with the new version. This takes about 10 seconds. This page reloads on its own when the site is back." / "Started at 09:51". Announced once as "Installing version 2.3.0. Your site is restarting." After 60 seconds with no answer: "Still restarting" / "This is taking longer than usual. Keep this page open. It reloads on its own when the site is back, or you can reload it now." / "Started at 09:51 · 1 minute ago" and a "Reload page" button. Plain restart: "Restarting your site" / "This takes about 10 seconds. This page reloads on its own when the site is back." After the reload: focus lands on the "Updates" heading and a toast `circle-check` "Site restarted" / "Your site is running again."
## Elsewhere
For the owner only: an **Update** pill on the Settings sidebar item, and a dot on the menu icon on mobile (read as "Update available"). Admins see neither. The Home banner is described in [home](home.md).
## Status to copy
| Status | Where | Copy |
|---|---|---|
| 200 | Check, up to date | "You're up to date" and the last-checked line |
| 200 | Check, newer version | "Version 2.3.0 is available" and its text |
| 202 | Update, Restart | Accepted. The card switches to progress, announced as "Downloading version 2.3.0, 25 percent". |
| 200 | Update finished | "Version 2.3.0 is ready to install" |
| 200 | After restart | Toast "Update installed" or "Site restarted" |
| 400 | Update, nothing to install | Info toast "Nothing to update" / "You already have the latest version." The card refreshes. |
| 401 | any | Global: /login?redirect=/settings&reason=expired. No local copy. |
| 403 | any button, not the owner | Error toast "Only the owner can do this" / "Ask the owner of this site to update RenewCMS." The card reloads as the admin view. An unverified account is handled globally. |
| 409 | Update, Restart | Already running: info toast "An update is already running" / "Another owner started it. Progress shows here." Not prepared: the card shows the "Not prepared" state. |
| 422 | Update, file not trusted | The "Not trusted" card above |
| 429 | Check, Update | The rate-limited card above |
| 500 / network | Check | "Couldn't check for updates" with "Try again" |
| 500 / network | Update | "The download didn't finish" with "Try again" |
| 500 / network | Restart dialog | "Couldn't start the restart. Nothing was changed and your site is still running. Try again in a moment." |
| Site back, old version | after restart | The rolled-back card above |
| No answer, 60 s | restart overlay | "Still restarting" |
| Offline | whole page | Existing banner. Check, Update and Restart are disabled. During a restart the overlay keeps polling and ignores the offline state. |
## Behaviour notes
- The page asks for `GET /v1/system/update` on open and, when a step is running, polls it every second. The server holds the state (idle, downloading, verifying, ready, restarting, succeeded, failed), so another device or owner sees the same card.
- A check runs on the first open after 24 hours and when "Check for updates" is pressed.
- Update takes no confirmation because it changes nothing. Restart always asks.
## States
### Default
**Trigger:** Opened from the sidebar.
- Breadcrumbs: Settings (mobile title "Settings")
- Section: Version, `v2.2.0-beta`
The board draws no loading or error state. Decide them in the spec (see the notes).
## Notes for implementation
- The board's API line says "none (static)", but the version lives in the Go binary (`main.version`, set with `-ldflags -X`, `dev` when unset), so the SPA has to ask for it. The recommendation is `GET /v1/settings` returning `{ "version": "..." }` inside the verified group, so later settings have a home. It is read once at startup and never from the environment at request time.
- Not drawn: loading (the recommendation is a skeleton for the value only, after 150 ms, like the other pages), and a failed request (an inline error in the card with "Try again", using the global copy "Couldn't reach RenewCMS. Check your connection and try again.").
- Keep the page free of actions, toggles and links until a later slice adds a real setting.
| State | Trigger and behaviour |
|---|---|
| Up to date | Opened with no newer version. Restart is available but not emphasised. |
| Checking | Check for updates pressed, or the first open after 24 hours. Announced as "Checking for updates". Buttons are disabled. |
| Check failed | Offline, or the update server didn't answer (500, network). The last known result is kept. |
| Update available | A newer version exists. Release notes are collapsed. Update is the one primary button. |
| Update available, notes open | "What's new in 2.3.0" expanded. It is a button with aria-expanded, and the list is plain text. |
| Downloading | Update pressed (202). Progress polls every second. Announced as "Downloading, 25 percent" and so on, never every tick. |
| Verifying | The download finished. No percentage, so the bar is indeterminate. Announced as "Checking the download". |
| Ready to install | The file passed its checks. The card turns warning (orange) with a "Pending" tag and a `clock` icon, and Restart, the primary action, sits inside it. "Restart later" is closing the dialog or leaving the page. |
| Restart: confirm | Restart pressed. The card behind the dialog keeps the Ready look. Same dialog behaviour as the delete confirm: focus moves to the first button, Escape and "Restart later" close it, and focus returns to Restart. The confirm button is neutral, not red, because nothing is lost. |
| Restart: request failed | 500 or network failure before the restart began. The site is still running. The card behind the dialog keeps the Ready look. |
| Restarting to install | Full-page overlay, so it survives the server going away. The page polls until the site answers, then reloads. It is a live region announced once as "Installing version 2.3.0. Your site is restarting." |
| Restarting, taking longer | No answer after 60 seconds. The copy changes and a manual reload appears. The overlay stays until the site is back. |
| Update done | The page reloaded on the new version. Focus lands on the "Updates" heading (ring shown), the toast is announced, and the version updates. |
| Update failed, rolled back | The site came back on v2.2.0-beta. The error toast stays until dismissed and the card keeps the explanation. |
| Download failed | A 500, or the connection dropped. Focus moves to the card heading. Try again restarts the download. |
| Verification failed | The downloaded file isn't trusted. The tone is a warning, and the file is thrown away. Technical detail goes to the server log, not the screen. |
| Too many requests (429) | Retry-After counted down in the button. It re-enables at zero. |
| Not prepared | The server can't update from the browser. No buttons, not even Restart. The command is for the person who runs the server and is a single line. The placeholder command is subject to the real one. |
| Not prepared: command copied | Copy pressed. The button reads "Copied" for 2 s and it is announced. |
| Plain restart: confirm | Restart with no update waiting. Nothing is installed. |
| Plain restart: restarting | Same overlay as the update restart with shorter copy. |
| Plain restart: done | The page reloaded. Focus lands on the "Updates" heading. |
| Admin view | Admins see the version and the note, with no buttons. Up to date: "You're up to date" and "Only the owner can update or restart the site." No Home banner or Settings pill. |
| Role changed (403) | An owner was changed to admin while the page was open and pressed a button. The card reloads in the admin view. |
| Update already running (409) | Another owner started it. The card switches to that run's progress. |
+21 -9
View File
@@ -12,20 +12,20 @@
<div style="width:224px;flex-shrink:0;background:var(--ui-bg);border-right:1px solid var(--ui-border);display:flex;flex-direction:column;padding:12px;gap:2px">
<div style="display:flex;align-items:center;gap:10px;height:40px;padding:0 6px;margin-bottom:10px"><svg width="26" height="26" viewBox="0 0 16 16" shape-rendering="crispEdges"><rect width="16" height="16" fill="#111"></rect><path fill="#fff" fill-rule="evenodd" d="M4 3h6v1h1v1h1v3h-1v1h-1v1h1v1h1v2h-2v-2h-1v-1H6v3H4zm2 2v3h4V5z"></path></svg><span style="font-weight:600;font-size:14px;color:var(--ui-text-highlighted)">RenewCMS</span></div>
<sc-for list="{{ nav }}" as="n" hint-placeholder-count="3">
<div data-act="nav-{{ n.key }}" style="display:flex;align-items:center;gap:10px;height:32px;padding:0 10px;background:{{ n.bg }};color:{{ n.fg }};font-weight:{{ n.fw }}"><span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ n.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ n.icon }}.svg') center / contain no-repeat"></span>{{ n.t }}</div>
<div data-act="nav-{{ n.key }}" style="display:flex;align-items:center;gap:10px;height:32px;padding:0 10px;background:{{ n.bg }};color:{{ n.fg }};font-weight:{{ n.fw }}"><span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ n.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ n.icon }}.svg') center / contain no-repeat"></span>{{ n.t }}<sc-if value="{{ n.badge }}"><span style="margin-left:auto;height:18px;padding:0 6px;display:inline-flex;align-items:center;background:var(--ui-info);color:var(--ui-bg);font:500 11px 'IBM Plex Sans',sans-serif">Update</span></sc-if></div>
</sc-for>
<div style="flex:1"></div>
<sc-if value="{{ s.boot }}"><div style="display:flex;align-items:center;gap:10px;height:40px;padding:0 6px"><span style="width:26px;height:26px;background:var(--ui-bg-accented)"></span><span style="width:80px;height:12px;background:var(--ui-bg-accented)"></span></div></sc-if>
<sc-if value="{{ notBoot }}"><div data-act="usermenu" role="button" aria-haspopup="menu" aria-expanded="{{ menuOpen }}" title="Account" style="display:flex;align-items:center;gap:10px;height:40px;padding:0 6px;background:{{ chipBg }};color:{{ chipFg }}"><span style="width:26px;height:26px;flex-shrink:0;background:#d4c5b0;color:#111;display:flex;align-items:center;justify-content:center;font:600 11px 'IBM Plex Sans',sans-serif">{{ ini }}</span><span style="flex:1;min-width:0;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;font-weight:500">{{ who }}</span><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/chevrons-up-down.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/chevrons-up-down.svg') center / contain no-repeat"></span></div></sc-if>
</div>
<sc-if value="{{ deskMenu }}"><div role="menu" aria-label="Account" style="position:absolute;left:12px;bottom:56px;z-index:40;width:224px;background:var(--ui-bg);border:1px solid var(--ui-border);box-shadow:var(--rc-shadow-pop);padding:4px"><div style="padding:8px 8px 10px;display:flex;flex-direction:column;gap:2px;border-bottom:1px solid var(--ui-border);margin-bottom:4px"><span style="font-weight:600;color:var(--ui-text-highlighted);overflow:hidden;text-overflow:ellipsis;white-space:nowrap">{{ who }}</span><span style="font-size:12px;color:var(--ui-text-muted)">marta@renew.example</span></div><div data-act="nav-profile" role="menuitem" style="height:32px;padding:0 8px;display:flex;align-items:center;gap:10px;background:{{ pfItemBg }};color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat"></span>Profile</div><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><sc-for list="{{ themeSeg }}" as="m" hint-placeholder-count="3"><div data-act="{{ m.act }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:32px;padding:0 8px;display:flex;align-items:center;justify-content:space-between;font-size:14px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div data-act="logout" role="menuitem" style="height:32px;padding:0 8px;display:flex;align-items:center;gap:10px;color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat"></span>Log out</div></div></sc-if>
<sc-if value="{{ deskMenu }}"><div role="menu" aria-label="Account" style="position:absolute;left:12px;bottom:56px;z-index:40;width:224px;background:var(--ui-bg);border:1px solid var(--ui-border);box-shadow:var(--rc-shadow-pop);padding:4px"><div style="padding:8px 8px 10px;display:flex;flex-direction:column;gap:2px;border-bottom:1px solid var(--ui-border);margin-bottom:4px"><span style="font-weight:600;color:var(--ui-text-highlighted);overflow:hidden;text-overflow:ellipsis;white-space:nowrap">{{ who }}</span><span style="font-size:12px;color:var(--ui-text-muted)">marta@renew.example</span></div><div data-act="nav-profile" role="menuitem" style="height:32px;padding:0 8px;display:flex;align-items:center;gap:10px;background:{{ pfItemBg }};color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat"></span>Profile</div><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div style="padding:6px 8px 2px;font-size:11px;font-weight:500;letter-spacing:.04em;text-transform:uppercase;color:var(--ui-text-muted)">Theme</div><sc-for list="{{ themeSeg }}" as="m" hint-placeholder-count="3"><div data-act="{{ m.act }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:32px;padding:0 8px;display:flex;align-items:center;justify-content:space-between;font-size:14px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div style="padding:6px 8px 2px;font-size:11px;font-weight:500;letter-spacing:.04em;text-transform:uppercase;color:var(--ui-text-muted)">Language</div><sc-for list="{{ langSeg }}" as="m" hint-placeholder-count="2"><div data-act="{{ m.act }}" lang="{{ m.code }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:32px;padding:0 8px;display:flex;align-items:center;justify-content:space-between;font-size:14px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div data-act="logout" role="menuitem" style="height:32px;padding:0 8px;display:flex;align-items:center;gap:10px;color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat"></span>Log out</div></div></sc-if>
</sc-if>
<div style="flex:1;min-width:0;min-height:0;display:flex;flex-direction:column">
<sc-if value="{{ desk }}" hint-placeholder-val="{{ true }}">
<div style="height:48px;flex-shrink:0;border-bottom:1px solid var(--ui-border);background:var(--ui-bg);display:flex;align-items:center;padding:0 24px;gap:8px;color:var(--ui-text-muted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/panel-left-close.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/panel-left-close.svg') center / contain no-repeat"></span><span style="width:1px;height:16px;background:var(--ui-border);margin:0 6px"></span><sc-for list="{{ crumbs }}" as="c" hint-placeholder-count="1"><sc-if value="{{ c.sep }}"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/chevron-right.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/chevron-right.svg') center / contain no-repeat"></span></sc-if><span style="color:{{ c.fg }};font-weight:{{ c.fw }}">{{ c.t }}</span></sc-for></div>
</sc-if>
<sc-if value="{{ mob }}">
<div style="height:56px;flex-shrink:0;border-bottom:1px solid var(--ui-border);background:var(--ui-bg);display:flex;align-items:center;padding:0 6px;gap:4px;color:var(--ui-text-highlighted)"><span data-act="m-lead" style="width:44px;height:44px;display:flex;align-items:center;justify-content:center"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:20px;height:20px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ mLead }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ mLead }}.svg') center / contain no-repeat"></span></span><span style="flex:1;min-width:0;font-weight:600;font-size:16px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap">{{ s.mTitle }}</span><sc-if value="{{ s.mAction }}"><span data-act="m-action" style="width:44px;height:44px;display:flex;align-items:center;justify-content:center"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:20px;height:20px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ s.mAction }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.mAction }}.svg') center / contain no-repeat"></span></span></sc-if></div>
<div style="height:56px;flex-shrink:0;border-bottom:1px solid var(--ui-border);background:var(--ui-bg);display:flex;align-items:center;padding:0 6px;gap:4px;color:var(--ui-text-highlighted)"><span data-act="m-lead" style="position:relative;width:44px;height:44px;display:flex;align-items:center;justify-content:center"><sc-if value="{{ s.navBadge }}"><span aria-label="Update available" style="position:absolute;top:9px;right:9px;width:10px;height:10px;background:var(--ui-info);border:2px solid var(--ui-bg)"></span></sc-if><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:20px;height:20px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ mLead }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ mLead }}.svg') center / contain no-repeat"></span></span><span style="flex:1;min-width:0;font-weight:600;font-size:16px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap">{{ s.mTitle }}</span><sc-if value="{{ s.mAction }}"><span data-act="m-action" style="width:44px;height:44px;display:flex;align-items:center;justify-content:center"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:20px;height:20px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ s.mAction }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.mAction }}.svg') center / contain no-repeat"></span></span></sc-if></div>
</sc-if>
<sc-if value="{{ s.offline }}"><div role="status" style="flex-shrink:0;display:flex;align-items:center;gap:10px;padding:10px 16px;background:var(--ui-bg-inverted);color:var(--ui-text-inverted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/wifi-off.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/wifi-off.svg') center / contain no-repeat"></span><span style="flex:1">You're offline. You can keep writing, but saving and publishing will wait until you're back online.</span></div></sc-if>
@@ -43,6 +43,7 @@
<sc-if value="{{ isHome }}">
<div style="padding:{{ pad }};display:flex;flex-direction:column;gap:{{ gap }};max-width:1040px">
<div style="display:flex;align-items:flex-end;gap:16px;flex-wrap:wrap"><div style="flex:1;min-width:200px;display:flex;flex-direction:column;gap:4px"><span style="font:600 28px/36px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted)">Good morning, {{ who }}</span><span style="color:var(--ui-text-muted);font-size:14px">{{ s.home.sub }}</span></div><sc-if value="{{ desk }}"><span data-act="new" style="height:32px;padding:0 12px;display:flex;align-items:center;gap:6px;background:var(--ui-primary);color:var(--ui-bg);font-weight:500"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/plus.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/plus.svg') center / contain no-repeat"></span>New article</span></sc-if></div>
<sc-if value="{{ s.home.banner }}"><div role="region" aria-label="Update available" style="display:flex;flex-direction:{{ upBtnDir }};align-items:{{ upBannerAlign }};gap:12px;padding:12px 14px;background:{{ s.home.banner.bg }};border:1px solid var(--ui-border)"><div style="flex:1;display:flex;gap:10px;min-width:0"><span style="display:flex;padding-top:2px"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:{{ s.home.banner.fg }};-webkit-mask:url('https://api.iconify.design/lucide/{{ s.home.banner.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.home.banner.icon }}.svg') center / contain no-repeat"></span></span><div style="display:flex;flex-direction:column;gap:2px"><span style="font-weight:600;color:var(--ui-text-highlighted)">{{ s.home.banner.title }}</span><span style="color:var(--ui-text-toned);text-wrap:pretty">{{ s.home.banner.text }}</span></div></div><div style="display:flex;align-items:center;gap:8px"><span style="flex:1;height:{{ btnH }};padding:0 12px;display:flex;align-items:center;justify-content:center;border:1px solid var(--ui-border-accented);background:var(--ui-bg);color:var(--ui-text-highlighted);font-weight:500">{{ s.home.banner.btn }}</span><span role="button" aria-label="Dismiss" style="width:{{ btnH }};height:{{ btnH }};display:flex;align-items:center;justify-content:center;color:var(--ui-text-muted)"><span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/x.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/x.svg') center / contain no-repeat"></span></span></div></div></sc-if>
<sc-if value="{{ s.home.error }}"><div role="alert" style="display:flex;gap:10px;padding:12px 14px;background:var(--rc-error-soft);color:var(--ui-error)"><span style="display:flex;padding-top:2px"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/circle-x.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/circle-x.svg') center / contain no-repeat"></span></span><div style="flex:1;display:flex;flex-direction:column;gap:8px"><div style="display:flex;flex-direction:column;gap:2px"><span style="font-weight:600">Couldn't load your articles</span><span style="color:var(--ui-text-toned)">Check your connection and try again.</span></div><span style="align-self:flex-start;height:28px;padding:0 10px;display:flex;align-items:center;gap:6px;border:1px solid var(--ui-border-accented);background:var(--ui-bg);color:var(--ui-text-highlighted);font-weight:500;font-size:12px"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/rotate-cw.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/rotate-cw.svg') center / contain no-repeat"></span>Try again</span></div></div></sc-if>
<sc-if value="{{ s.home.stats }}">
<div style="display:grid;grid-template-columns:{{ cols3 }};gap:12px">
@@ -229,7 +230,16 @@
<sc-if value="{{ isSettings }}">
<div style="padding:{{ pad }};display:flex;flex-direction:column;gap:20px;max-width:720px;overflow:hidden">
<div style="display:flex;flex-direction:column;gap:2px"><span style="font:600 20px/28px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted)">Settings</span><span style="color:var(--ui-text-muted)">Workspace information.</span></div>
<div style="background:var(--ui-bg);border:1px solid var(--ui-border);padding:{{ cardPad }};display:flex;align-items:center;justify-content:space-between;gap:16px"><span style="font:600 15px/24px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted)">Version</span><span style="font:400 14px/22px 'IBM Plex Mono',monospace;color:var(--ui-text-toned)">v2.2.0-beta</span></div>
<div style="background:var(--ui-bg);border:1px solid var(--ui-border);padding:{{ cardPad }};display:flex;align-items:center;justify-content:space-between;gap:16px"><span style="font:600 15px/24px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted)">Version</span><span style="font:400 14px/22px 'IBM Plex Mono',monospace;color:var(--ui-text-toned)">{{ s.upd.v }}</span></div>
<div role="region" aria-labelledby="updates-h" style="background:var(--ui-bg);border:1px solid var(--ui-border);padding:{{ cardPad }};display:flex;flex-direction:column;gap:16px">
<span id="updates-h" tabindex="-1" style="align-self:flex-start;font:600 15px/24px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted);outline:{{ s.upd.focus }};outline-offset:4px">Updates</span>
<div aria-live="polite" style="display:flex;gap:12px;padding:14px;background:{{ s.upd.bg }}"><span style="display:flex;padding-top:2px"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:18px;height:18px;background-color:{{ s.upd.fg }};-webkit-mask:url('https://api.iconify.design/lucide/{{ s.upd.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.upd.icon }}.svg') center / contain no-repeat"></span></span><div style="flex:1;min-width:0;display:flex;flex-direction:column;gap:4px"><div style="display:flex;align-items:center;flex-wrap:wrap;gap:8px"><span style="font:600 14px/22px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted)">{{ s.upd.title }}</span><sc-if value="{{ s.upd.pendingTag }}"><span style="height:20px;padding:0 6px;display:inline-flex;align-items:center;background:var(--ui-bg);color:var(--ui-warning);border:1px solid var(--ui-warning);font:500 11px 'IBM Plex Mono',monospace">Pending</span></sc-if></div><span style="color:var(--ui-text-toned);text-wrap:pretty">{{ s.upd.text }}</span><sc-if value="{{ s.upd.bar }}"><div style="display:flex;flex-direction:column;gap:6px;padding-top:8px"><div role="progressbar" aria-label="{{ s.upd.barLabel }}" aria-valuemin="0" aria-valuemax="100" aria-valuenow="{{ s.upd.pct }}" style="height:6px;background:var(--ui-bg-accented)"><div style="height:6px;width:{{ s.upd.barW }};margin-left:{{ s.upd.barL }};background:var(--ui-primary)"></div></div><span style="font:400 12px/16px 'IBM Plex Mono',monospace;color:var(--ui-text-muted)">{{ s.upd.barText }}</span></div></sc-if><sc-if value="{{ s.upd.meta }}"><span style="font-size:12px;color:var(--ui-text-muted)">{{ s.upd.meta }}</span></sc-if><sc-if value="{{ s.upd.inBtn }}"><div style="display:flex;padding-top:8px"><span role="button" style="height:{{ btnH }};padding:0 14px;display:flex;align-items:center;justify-content:center;gap:6px;background:{{ s.upd.inBtn.bg }};color:{{ s.upd.inBtn.fg }};border:1px solid {{ s.upd.inBtn.bd }};font-weight:500"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ s.upd.inBtn.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.upd.inBtn.icon }}.svg') center / contain no-repeat"></span>{{ s.upd.inBtn.t }}</span></div></sc-if></div></div>
<sc-if value="{{ s.upd.notes }}"><div style="display:flex;flex-direction:column;gap:10px"><span role="button" aria-expanded="{{ s.upd.notes.open }}" style="align-self:flex-start;display:flex;align-items:center;gap:6px;min-height:{{ btnH }};font-weight:500;color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ s.upd.notes.chev }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.upd.notes.chev }}.svg') center / contain no-repeat"></span>What's new in {{ s.upd.notes.ver }}</span><sc-if value="{{ s.upd.notes.open }}"><div style="display:flex;flex-direction:column;gap:8px;padding:0 0 0 20px"><span style="font-size:12px;color:var(--ui-text-muted)">{{ s.upd.notes.date }}</span><sc-for list="{{ s.upd.notes.items }}" as="it" hint-placeholder-count="3"><div style="display:flex;gap:8px"><span aria-hidden="true" style="flex-shrink:0;width:4px;height:4px;margin-top:8px;background:var(--ui-text-muted)"></span><span style="color:var(--ui-text-toned);text-wrap:pretty">{{ it.t }}</span></div></sc-for><span style="align-self:flex-start;color:var(--ui-text-highlighted);text-decoration:underline;text-underline-offset:3px;font-weight:500">Read the full release notes</span></div></sc-if></div></sc-if>
<sc-if value="{{ s.upd.cmd }}"><div style="display:flex;flex-direction:column;gap:8px"><span style="font-weight:500;color:var(--ui-text-highlighted)">For whoever manages the server</span><div style="display:flex;flex-direction:{{ upCmdDir }};align-items:{{ upBtnAlign }};gap:8px"><code style="flex:1;min-width:0;padding:8px 12px;background:var(--ui-bg-elevated);color:var(--ui-text-highlighted);overflow:hidden;text-overflow:ellipsis;white-space:nowrap;line-height:22px">{{ s.upd.cmd.line }}</code><span role="button" style="height:{{ btnH }};padding:0 12px;display:flex;align-items:center;justify-content:center;gap:6px;border:1px solid var(--ui-border-accented);background:var(--ui-bg);color:{{ s.upd.cmd.fg }};font-weight:500"><span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ s.upd.cmd.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ s.upd.cmd.icon }}.svg') center / contain no-repeat"></span>{{ s.upd.cmd.t }}</span></div><span style="font-size:12px;color:var(--ui-text-muted)">{{ s.upd.cmd.note }}</span></div></sc-if>
<sc-if value="{{ s.upd.btns }}"><div style="display:flex;flex-direction:{{ upBtnDir }};align-items:{{ upBtnAlign }};gap:8px"><sc-for list="{{ s.upd.btns }}" as="b" hint-placeholder-count="1"><span role="button" style="height:{{ btnH }};padding:0 14px;display:flex;align-items:center;justify-content:center;gap:6px;background:{{ b.bg }};color:{{ b.fg }};border:1px solid {{ b.bd }};opacity:{{ b.op }};font-weight:500"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:16px;height:16px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/{{ b.icon }}.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/{{ b.icon }}.svg') center / contain no-repeat"></span>{{ b.t }}</span></sc-for></div></sc-if>
<sc-if value="{{ s.upd.hint }}"><span style="font-size:12px;color:var(--ui-text-muted);text-wrap:pretty">{{ s.upd.hint }}</span></sc-if>
<sc-if value="{{ s.upd.link }}"><span style="align-self:flex-start;display:flex;align-items:center;gap:6px;color:var(--ui-text-highlighted);text-decoration:underline;text-underline-offset:3px;font-weight:500">{{ s.upd.link }}<span aria-hidden="true" style="display:inline-block;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/external-link.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/external-link.svg') center / contain no-repeat"></span></span></sc-if>
</div>
</div>
</sc-if>
@@ -270,7 +280,9 @@
</div>
</div>
<sc-if value="{{ mobMenu }}"><div style="position:absolute;inset:0;z-index:50;background:var(--rc-overlay);display:flex;align-items:flex-end"><div role="menu" aria-label="Account" style="width:100%;background:var(--ui-bg);box-shadow:var(--rc-shadow-modal);padding:8px 0 24px"><div style="margin:0 auto 8px;width:36px;height:4px;background:var(--ui-bg-accented)"></div><div style="padding:8px 16px 14px;display:flex;align-items:center;gap:12px;border-bottom:1px solid var(--ui-border);margin-bottom:4px"><span style="width:36px;height:36px;flex-shrink:0;background:#d4c5b0;color:#111;display:flex;align-items:center;justify-content:center;font:600 13px 'IBM Plex Sans',sans-serif">{{ ini }}</span><div style="display:flex;flex-direction:column;min-width:0"><span style="font-weight:600;font-size:15px;color:var(--ui-text-highlighted)">{{ who }}</span><span style="color:var(--ui-text-muted)">marta@renew.example</span></div></div><div data-act="nav-profile" role="menuitem" style="height:48px;padding:0 16px;display:flex;align-items:center;gap:12px;font-size:15px;background:{{ pfItemBg }};color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:18px;height:18px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat"></span>Profile</div><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><sc-for list="{{ themeSeg }}" as="m" hint-placeholder-count="3"><div data-act="{{ m.act }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:48px;padding:0 16px;display:flex;align-items:center;justify-content:space-between;font-size:15px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:18px;height:18px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div data-act="logout" role="menuitem" style="height:48px;padding:0 16px;display:flex;align-items:center;gap:12px;font-size:15px;color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:18px;height:18px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat"></span>Log out</div></div></div></sc-if>
<sc-if value="{{ mobMenu }}"><div style="position:absolute;inset:0;z-index:50;background:var(--rc-overlay);display:flex;align-items:flex-end"><div role="menu" aria-label="Account" style="width:100%;background:var(--ui-bg);box-shadow:var(--rc-shadow-modal);padding:8px 0 24px"><div style="margin:0 auto 8px;width:36px;height:4px;background:var(--ui-bg-accented)"></div><div style="padding:8px 16px 14px;display:flex;align-items:center;gap:12px;border-bottom:1px solid var(--ui-border);margin-bottom:4px"><span style="width:36px;height:36px;flex-shrink:0;background:#d4c5b0;color:#111;display:flex;align-items:center;justify-content:center;font:600 13px 'IBM Plex Sans',sans-serif">{{ ini }}</span><div style="display:flex;flex-direction:column;min-width:0"><span style="font-weight:600;font-size:15px;color:var(--ui-text-highlighted)">{{ who }}</span><span style="color:var(--ui-text-muted)">marta@renew.example</span></div></div><div data-act="nav-profile" role="menuitem" style="height:48px;padding:0 16px;display:flex;align-items:center;gap:12px;font-size:15px;background:{{ pfItemBg }};color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:18px;height:18px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/circle-user.svg') center / contain no-repeat"></span>Profile</div><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div style="padding:8px 16px 2px;font-size:11px;font-weight:500;letter-spacing:.04em;text-transform:uppercase;color:var(--ui-text-muted)">Theme</div><sc-for list="{{ themeSeg }}" as="m" hint-placeholder-count="3"><div data-act="{{ m.act }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:48px;padding:0 16px;display:flex;align-items:center;justify-content:space-between;font-size:15px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:18px;height:18px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div style="padding:8px 16px 2px;font-size:11px;font-weight:500;letter-spacing:.04em;text-transform:uppercase;color:var(--ui-text-muted)">Language</div><sc-for list="{{ langSeg }}" as="m" hint-placeholder-count="2"><div data-act="{{ m.act }}" lang="{{ m.code }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:48px;padding:0 16px;display:flex;align-items:center;justify-content:space-between;font-size:15px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:18px;height:18px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for><div style="height:1px;background:var(--ui-border);margin:4px 0"></div><div data-act="logout" role="menuitem" style="height:48px;padding:0 16px;display:flex;align-items:center;gap:12px;font-size:15px;color:var(--ui-text-highlighted)"><span aria-hidden="true" style="display:inline-block;flex-shrink:0;width:18px;height:18px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/log-out.svg') center / contain no-repeat"></span>Log out</div></div></div></sc-if>
<sc-if value="{{ s.overlay }}"><div role="status" aria-live="polite" style="position:absolute;inset:0;z-index:70;background:var(--ui-bg-muted);display:flex;align-items:center;justify-content:center;padding:24px"><div style="width:100%;max-width:440px;display:flex;flex-direction:column;gap:16px;align-items:flex-start"><svg width="26" height="26" viewBox="0 0 16 16" shape-rendering="crispEdges" aria-hidden="true"><rect width="16" height="16" fill="#111"></rect><path fill="#fff" fill-rule="evenodd" d="M4 3h6v1h1v1h1v3h-1v1h-1v1h1v1h1v2h-2v-2h-1v-1H6v3H4zm2 2v3h4V5z"></path></svg><div style="display:flex;flex-direction:column;gap:6px"><span style="font:600 22px/30px 'IBM Plex Sans',sans-serif;color:var(--ui-text-highlighted)">{{ s.overlay.title }}</span><span style="font-size:14px;line-height:22px;color:var(--ui-text-toned);text-wrap:pretty">{{ s.overlay.text }}</span></div><div role="progressbar" aria-label="Restarting" style="width:100%;height:4px;background:var(--ui-bg-accented)"><div style="width:35%;height:4px;margin-left:{{ s.overlay.barL }};background:var(--ui-primary)"></div></div><span style="font-size:12px;color:var(--ui-text-muted)">{{ s.overlay.meta }}</span><sc-if value="{{ s.overlay.btn }}"><span role="button" style="height:{{ btnH }};padding:0 14px;display:flex;align-items:center;gap:6px;border:1px solid var(--ui-border-accented);background:var(--ui-bg);color:var(--ui-text-highlighted);font-weight:500">{{ s.overlay.btn }}</span></sc-if></div></div></sc-if>
<sc-if value="{{ s.modal }}">
<div style="position:absolute;inset:0;z-index:50;background:var(--rc-overlay);display:flex;align-items:{{ modalAlign }};justify-content:center;padding:{{ modalPad }}">
@@ -344,7 +356,7 @@ class Component extends DCLogic {
const m = !!this.props.mobile
const k = s.kind || 'home'
const navItems = [['home', 'house', 'Home'], ['articles', 'file-text', 'Articles'], ['media', 'images', 'Media'], ['users', 'users', 'Users'], ['integration', 'plug', 'Integration'], ['settings', 'settings', 'Settings']]
const nav = navItems.map(([key, icon, t]) => ({ key, icon, t, bg: s.nav === key ? 'var(--rc-sand)' : 'transparent', fg: s.nav === key ? '#111111' : 'var(--ui-text-toned)', fw: s.nav === key ? 500 : 400 }))
const nav = navItems.map(([key, icon, t]) => ({ key, icon, t, bg: s.nav === key ? 'var(--rc-sand)' : 'transparent', badge: key === 'settings' && !!s.navBadge, fg: s.nav === key ? '#111111' : 'var(--ui-text-toned)', fw: s.nav === key ? 500 : 400 }))
const crumbs = (s.crumbs || []).map((t, i, a) => ({ t, sep: i > 0, fg: i === a.length - 1 ? 'var(--ui-text-highlighted)' : 'var(--ui-text-muted)', fw: i === a.length - 1 ? 500 : 400 }))
const L = s.list || {}
const counts = L.counts || [6, 4, 2]
@@ -423,17 +435,17 @@ class Component extends DCLogic {
const edTitle = e.title || 'How we price a bathroom renovation'
return {
cr, s, nav, crumbs, who, ini, pf, dn, dnSave, rsNote, rsBtn,
themeSeg: [['system','monitor','System'],['light','sun','Light'],['dark','moon','Dark']].map(([k,icon,tt])=>{const on=(s.mode||'light')===k;return {act:'theme-'+k,icon,t:tt,on,op:on?1:0}}), menuOpen: !!s.userMenu, deskMenu: !m && !!s.userMenu, mobMenu: m && !!s.userMenu, pfItemBg: 'var(--ui-bg-elevated)',
langSeg: [['en','English'],['fr','Français']].map(([k,tt])=>{const on=(s.lang||'en')===k;return {act:'lang-'+k,code:k,t:tt,on,op:on?1:0}}), themeSeg: [['system','monitor','System'],['light','sun','Light'],['dark','moon','Dark']].map(([k,icon,tt])=>{const on=(s.mode||'light')===k;return {act:'theme-'+k,icon,t:tt,on,op:on?1:0}}), menuOpen: !!s.userMenu, deskMenu: !m && !!s.userMenu, mobMenu: m && !!s.userMenu, pfItemBg: 'var(--ui-bg-elevated)',
chipBg: s.userMenu || s.nav === 'profile' ? 'var(--rc-sand)' : 'transparent', chipFg: s.userMenu || s.nav === 'profile' ? '#111111' : 'var(--ui-text-highlighted)',
isSettings: k === 'settings', isProfile: k === 'profile', pfLoading: k === 'profile' && !!pf.loading, pfReady: k === 'profile' && !pf.loading,
cardPad: m ? '16px' : '20px', cardPadX: m ? '16px' : '20px', inH: m ? '44px' : '40px', pfCols: m ? 'minmax(0,1fr)' : 'minmax(0,1fr) minmax(0,1.4fr)', pwDir: m ? 'column' : 'row', pwAlign: m ? 'stretch' : 'flex-end', edTitle, edBody: e.body || '', sampleBody: !e.body, tabs, rows, save, counter, pub, mFields, up, toasts, endpoints, toolbar,
upBtnDir: m ? 'column' : 'row', upBtnAlign: m ? 'stretch' : 'flex-start', cardPad: m ? '16px' : '20px', cardPadX: m ? '16px' : '20px', inH: m ? '44px' : '40px', pfCols: m ? 'minmax(0,1fr)' : 'minmax(0,1fr) minmax(0,1.4fr)', pwDir: m ? 'column' : 'row', pwAlign: m ? 'stretch' : 'flex-end', edTitle, edBody: e.body || '', sampleBody: !e.body, tabs, rows, save, counter, pub, mFields, up, toasts, endpoints, toolbar,
desk: !m, mob: m, notBoot: !s.boot,
fw: m ? '390px' : '1440px', fh: m ? '844px' : '900px', dir: m ? 'column' : 'row',
mLead: s.mLead || 'menu',
isBoot: !!s.boot, isHome: k === 'home' && !s.boot, isList: k === 'articles', isEditor: k === 'editor', isInteg: k === 'integration', isError: k === 'error', isUsers: k === 'users',
usRows, usError: !!US.error, usOnly: !!US.only && !US.error, usTable: !m && !US.error, usCards: m && !US.error,
pad: m ? '20px 16px 88px' : '32px', gap: m ? '20px' : '28px', cols3: m ? 'repeat(3,minmax(0,1fr))' : 'repeat(3,minmax(0,1fr))',
btnH: m ? '44px' : '32px', rowH: m ? '52px' : '44px', inF: m ? '16px' : '14px',
upBannerAlign: m ? 'stretch' : 'center', upCmdDir: m ? 'column' : 'row', btnH: m ? '44px' : '32px', rowH: m ? '52px' : '44px', inF: m ? '16px' : '14px',
tbDir: m ? 'column' : 'row', tbGap: m ? '12px' : '16px', tbBorder: m ? '0' : '1px solid var(--ui-border)', tabBorder: m ? '1px solid var(--ui-border)' : '0', tabH: m ? '44px' : '36px', tabF: m ? '14px' : '13px',
qText: L.q ? L.q : 'Search by title', qFg: L.q ? 'var(--ui-text-highlighted)' : 'var(--ui-text-muted)',
showTable: !m && !L.empty, showCards: m && !L.empty, listFab: !s.modal,
+6 -3
View File
@@ -54,16 +54,17 @@
<sc-if value="{{ hasFooter }}">
<div style="width:{{ w }};max-width:100%;padding:{{ footPad }};display:flex;align-items:center;justify-content:space-between;gap:12px;flex-wrap:wrap;font-size:13px;color:var(--ui-text-muted)">
<span style="display:flex;gap:6px;flex-wrap:wrap;align-items:center"><sc-if value="{{ s.footer }}"><span>{{ s.footer.pre }}</span><span data-act="footer" style="color:var(--ui-text-highlighted);font-weight:500;text-decoration:underline;text-underline-offset:3px">{{ s.footer.link }}</span></sc-if><sc-if value="{{ s.pending }}"><span style="height:20px;padding:0 6px;display:inline-flex;align-items:center;border:1px dashed var(--ui-border-accented);color:var(--ui-text-toned);font:500 11px 'IBM Plex Mono',monospace">API pending</span></sc-if></span>
<span style="height:28px;padding:0 8px;display:flex;align-items:center;gap:6px;border:1px solid var(--ui-border-accented);color:var(--ui-text-toned)"><span aria-hidden="true" style="display:inline-block;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/monitor.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/monitor.svg') center / contain no-repeat"></span>System</span>
<span style="position:relative;display:flex;align-items:center;gap:8px"><sc-if value="{{ langOpen }}"><div role="menu" aria-label="Language" style="position:absolute;right:0;bottom:36px;z-index:10;width:168px;background:var(--ui-bg);border:1px solid var(--ui-border);box-shadow:var(--rc-shadow-pop);padding:4px"><sc-for list="{{ langSeg }}" as="m" hint-placeholder-count="2"><div data-act="{{ m.act }}" lang="{{ m.code }}" role="menuitemradio" aria-checked="{{ m.on }}" style="height:{{ optH }};padding:0 8px;display:flex;align-items:center;justify-content:space-between;font-size:14px;color:var(--ui-text-highlighted)">{{ m.t }}<span aria-hidden="true" style="display:inline-block;width:16px;height:16px;background-color:currentColor;opacity:{{ m.op }};-webkit-mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/check.svg') center / contain no-repeat"></span></div></sc-for></div></sc-if><span data-act="langmenu" role="button" aria-haspopup="menu" aria-expanded="{{ langOpen }}" aria-label="Language: {{ langName }}" style="height:{{ chipH }};padding:0 8px;display:flex;align-items:center;gap:6px;border:1px solid var(--ui-border-accented);color:var(--ui-text-toned);background:{{ langBg }}"><span aria-hidden="true" style="display:inline-block;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/languages.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/languages.svg') center / contain no-repeat"></span>{{ langName }}</span><span style="height:{{ chipH }};padding:0 8px;display:flex;align-items:center;gap:6px;border:1px solid var(--ui-border-accented);color:var(--ui-text-toned)"><span aria-hidden="true" style="display:inline-block;width:14px;height:14px;background-color:currentColor;-webkit-mask:url('https://api.iconify.design/lucide/monitor.svg') center / contain no-repeat;mask:url('https://api.iconify.design/lucide/monitor.svg') center / contain no-repeat"></span>System</span></span>
</div>
</sc-if>
</div>
</x-dc>
<script type="text/x-dc" data-dc-script data-props="{&quot;$preview&quot;:{&quot;width&quot;:480,&quot;height&quot;:620},&quot;s&quot;:{&quot;editor&quot;:null,&quot;tsType&quot;:&quot;object&quot;},&quot;mobile&quot;:{&quot;editor&quot;:&quot;boolean&quot;,&quot;default&quot;:false,&quot;tsType&quot;:&quot;boolean&quot;}}">
<script type="text/x-dc" data-dc-script data-props="{&quot;$preview&quot;:{&quot;width&quot;:480,&quot;height&quot;:620},&quot;s&quot;:{&quot;editor&quot;:null,&quot;tsType&quot;:&quot;object&quot;},&quot;lang&quot;:{&quot;editor&quot;:&quot;enum&quot;,&quot;options&quot;:[&quot;en&quot;,&quot;fr&quot;],&quot;default&quot;:&quot;en&quot;,&quot;tsType&quot;:&quot;string&quot;},&quot;langOpen&quot;:{&quot;editor&quot;:&quot;boolean&quot;,&quot;default&quot;:false,&quot;tsType&quot;:&quot;boolean&quot;},&quot;mobile&quot;:{&quot;editor&quot;:&quot;boolean&quot;,&quot;default&quot;:false,&quot;tsType&quot;:&quot;boolean&quot;}}">
class Component extends DCLogic {
renderVals() {
const s = this.props.s || {}
const m = !!this.props.mobile
const lang = this.props.lang || s.lang || 'en'
const tone = t => ({ bg: 'var(--rc-' + t + '-soft)', fg: 'var(--ui-' + t + ')' })
const notice = s.notice ? { ...s.notice, ...tone(s.notice.tone) } : null
const result = s.result ? { ...s.result, ...tone(s.result.tone), actions: (s.result.actions || []).map((a, i) => i === 0 && !a.secondary ? { act: 'result-' + i, t: a.t, bg: 'var(--ui-primary)', fg: 'var(--ui-bg)', bd: '1px solid var(--ui-primary)' } : { act: 'result-' + i, t: a.t, bg: 'var(--ui-bg)', fg: 'var(--ui-text-highlighted)', bd: '1px solid var(--ui-border-accented)' }) } : null
@@ -87,7 +88,9 @@ class Component extends DCLogic {
return {
s, notice, result, fields,
hasForm: fields.length > 0 && !!s.submit,
hasFooter: !!(s.footer || s.pending || !m),
hasFooter: true,
langOpen: !!(this.props.langOpen ?? s.langOpen), langName: lang === 'fr' ? 'Français' : 'English', langBg: this.props.langOpen ?? s.langOpen ? 'var(--ui-bg-elevated)' : 'transparent', chipH: m ? '44px' : '28px', optH: m ? '44px' : '32px',
langSeg: [['en','English'],['fr','Français']].map(([k,t]) => ({ act: 'lang-' + k, code: k, t, on: lang === k, op: lang === k ? 1 : 0 })),
submitOpacity: s.submit && s.submit.disabled && !s.submit.loading ? '0.4' : '1',
w: m ? '100%' : '400px',
border: m ? '0' : '1px solid var(--ui-border)',
@@ -46,7 +46,7 @@
<main ref="{{ stageRef }}" style="flex:1;min-width:0;height:100vh;overflow:auto;display:flex;align-items:center;justify-content:center;padding:24px">
<div style="flex-shrink:0;width:{{ boxW }};height:{{ boxH }};box-shadow:0 8px 40px rgb(0 0 0 / 0.15);overflow:hidden">
<div onClick="{{ onStage }}" class="{{ hsClass }}" style="width:{{ devW }};height:{{ devH }};zoom:{{ zoom }};position:relative;overflow:hidden;background:var(--ui-bg-muted)">
<sc-if value="{{ isAuth }}"><div style="width:100%;height:100%;overflow:hidden;background:{{ authBg }};padding-top:{{ authTop }};display:flex;flex-direction:column;align-items:center"><dc-import name="AuthCard" s="{{ authS }}" mobile="{{ mobile }}" hint-size="400px,520px"></dc-import></div></sc-if>
<sc-if value="{{ isAuth }}"><div style="width:100%;height:100%;overflow:hidden;background:{{ authBg }};padding-top:{{ authTop }};display:flex;flex-direction:column;align-items:center"><dc-import name="AuthCard" lang="{{ lang }}" lang-open="{{ langOpen }}" s="{{ authS }}" mobile="{{ mobile }}" hint-size="400px,520px"></dc-import></div></sc-if>
<sc-if value="{{ isApp }}"><dc-import name="AppFrame" s="{{ appS }}" mobile="{{ mobile }}" hint-size="100%,100%"></dc-import></sc-if>
<sc-if value="{{ isEmail }}"><div style="width:100%;height:100%;display:flex;flex-direction:column;background:var(--ui-bg)"><div style="flex-shrink:0;padding:14px 20px;border-bottom:1px solid var(--ui-border);display:flex;flex-direction:column;gap:2px"><span style="font-weight:600;font-size:15px;color:var(--ui-text-highlighted)">{{ emailSubject }}</span><span style="color:var(--ui-text-muted)">From RenewCMS · to marta@renew.example</span></div><iframe title="Email" srcDoc="{{ emailHtml }}" style="flex:1;width:100%;border:0"></iframe></div></sc-if>
<sc-if value="{{ mnav }}">
@@ -187,6 +187,9 @@ class Component extends DCLogic {
act(a) {
const s = this.state
if (a === 'usermenu') return this.setState({ userMenu: !s.userMenu })
if (a === 'langmenu') return this.setState({ langOpen: !s.langOpen })
if (a && a.startsWith('lang-')) return this.setState({ lang: a.slice(5), langOpen: false })
if (s.langOpen) this.setState({ langOpen: false })
if (a && a.startsWith('theme-')) return this.setState({ mode: a.slice(6) })
if (s.userMenu) this.setState({ userMenu: false })
if (a === 'pf-reset') return this.setState({ pfReset: 'sent' })
@@ -428,8 +431,8 @@ class Component extends DCLogic {
rootRef: this.rootRef, stageRef: this.stageRef,
devices: devs, modes, flows, hint, tools,
hs: s.hs, hsClass: s.hs ? 'hs' : '', hsJust: s.hs ? 'flex-end' : 'flex-start', hsBg: s.hs ? 'var(--ui-primary)' : 'var(--ui-bg-accented)', toggleHs: () => this.setState({ hs: !s.hs }),
mobile, isAuth, isApp, isEmail,
authS: isAuth ? this.authS() : {}, appS: isApp ? { ...this.appS(), userMenu: s.userMenu, mode: s.mode } : {},
mobile, isAuth, isApp, isEmail, lang: s.lang || 'en', langOpen: !!s.langOpen,
authS: isAuth ? this.authS() : {}, appS: isApp ? { ...this.appS(), userMenu: s.userMenu, mode: s.mode, lang: s.lang || 'en' } : {},
authBg: mobile ? 'var(--ui-bg)' : 'var(--ui-bg-muted)', authTop: mobile ? '40px' : '108px',
emailHtml: isEmail ? this.emailHtml() : '', emailSubject: s.email === 'reset' ? 'Reset your RenewCMS password' : 'Verify your RenewCMS account',
devW: dw + 'px', devH: dh + 'px', zoom: s.zoom, boxW: Math.round(dw * s.zoom) + 'px', boxH: Math.round(dh * s.zoom) + 'px',
@@ -118,6 +118,18 @@ class Component extends DCLogic {
const rowFail = { n: 'roof.png', sz: '1.4 MB', st: 'fail', im: 10 }
const gone = [1, 2, 3, 4, 5, 6, 7, 9, 10, 11, 12]
const pk = (o = {}, x = {}) => MS({ kind: 'picker', picker: true, pk: { tab: 'Library', ...o }, ...x })
const TB = { neutral: 'var(--ui-bg-muted)', success: 'var(--rc-success-soft)', info: 'var(--rc-info-soft)', warning: 'var(--rc-warning-soft)', error: 'var(--rc-error-soft)' }
const B = (t, kind, icon, dis) => ({ t, icon, bg: kind === 'primary' ? 'var(--ui-primary)' : 'var(--ui-bg)', fg: kind === 'primary' ? 'var(--ui-bg)' : 'var(--ui-text-highlighted)', bd: kind === 'primary' ? 'var(--ui-primary)' : 'var(--ui-border-accented)', op: dis ? '0.4' : '1' })
const UPD = (o) => { const rdy = o.title === 'Version 2.3.0 is ready to install' && o.btns && o.btns.length; if (rdy) o = { ...o, tone: 'warning', icon: 'clock', pendingTag: true, inBtn: o.btns[0], btns: undefined }; const tone = o.tone || 'neutral'; return { v: 'v2.2.0-beta', focus: 'none', ...o, fg: tone === 'neutral' ? 'var(--ui-text-toned)' : 'var(--ui-' + tone + ')', bg: TB[tone], bar: o.pct !== undefined || !!o.indet, barW: o.indet ? '35%' : (o.pct || 0) + '%', barL: o.indet ? '30%' : '0', pct: o.indet ? undefined : o.pct } }
const NOTES = (open) => ({ open, chev: open ? 'chevron-down' : 'chevron-right', ver: '2.3.0', date: 'Released 24 Sep 2026', items: [{ t: 'Images upload faster, and large images no longer stall.' }, { t: 'Fixed a problem where a draft could show an old title after saving.' }, { t: 'Small improvements to the Users page.' }] })
const SU = (o, extra) => withM({ kind: 'settings', nav: 'settings', crumbs: ['Settings'], mTitle: 'Settings', ...extra, upd: UPD(o) })
const LAST = 'Last checked today at 09:41'
const RESTART_FOOT = 'Restart takes about 10 seconds. Your site is unavailable while it restarts.'
const bn = (icon, title, text) => ({ icon, title, text, btn: 'Go to Settings', fg: 'var(--ui-info)', bg: 'var(--rc-info-soft)' })
const cmdLine = 'renewcms enable-browser-updates'
const notPrep = (copied) => ({ icon: 'info', tone: 'info', title: 'Version 2.3.0 is available', text: 'This site can\'t update itself from the browser yet. Whoever manages your server can set it up once, or update RenewCMS for you.', meta: LAST, cmd: { line: cmdLine, t: copied ? 'Copied' : 'Copy', icon: copied ? 'check' : 'copy', fg: copied ? 'var(--ui-success)' : 'var(--ui-text-highlighted)', note: 'They run this once on the server. After that, Update and Restart appear here.' }, link: 'How to update' })
const restartModal = (o) => ({ title: 'Restart the site?', desc: 'Your site will be unavailable for about 10 seconds. This page reloads on its own when the site is back. Save anything you\'re editing first.', cancel: 'Cancel', confirm: 'Restart site', ...o })
const installModal = (o) => ({ title: 'Restart to finish the update?', desc: 'RenewCMS will install version 2.3.0 and restart. Your site will be unavailable for about 10 seconds. This page reloads on its own when the site is back. Save anything you\'re editing first.', cancel: 'Restart later', confirm: 'Restart now', ...o })
return this.finish([
{ label: 'Boot', title: 'App boot', route: 'any route, first load', api: 'GET /v1/auth/me (pending)', note: 'While the session is checked, the shell renders with skeletons, never a spinner. The possible outcomes are: 200 with a verified user, which renders the route; 200 with an unverified user, which goes to /register/pending; and 401, which goes to /login?redirect=<path>. Public routes skip this check.', states: [
withM({ ...home, name: 'Checking session', trigger: 'The first paint on any back-office URL, and usually visible for well under a second.', boot: true })
@@ -126,7 +138,9 @@ class Component extends DCLogic {
withM({ ...home, name: 'Default', trigger: 'The articles loaded.', home: { sub: 'Here\'s where things stand on your site.', stats, recent } }),
withM({ ...home, name: 'Loading', trigger: 'The list request is in flight. Skeletons appear after 150 ms.', home: { sub: 'Here\'s where things stand on your site.', stats: stats.map(() => ({ skel: true })), recent: Array.from({ length: 5 }, () => ({ skel: true })) } }),
withM({ ...home, name: 'Empty, first run', trigger: 'Zero articles: a single call to action, and no stats.', home: { sub: 'Welcome to RenewCMS.', empty: true } }),
withM({ ...home, name: 'Error', trigger: 'A 500 or network failure on the list request.', home: { sub: 'Here\'s where things stand on your site.', error: true } })
withM({ ...home, name: 'Error', trigger: 'A 500 or network failure on the list request.', home: { sub: 'Here\'s where things stand on your site.', error: true } }),
withM({ ...home, navBadge: true, name: 'Update available (owner)', trigger: 'The owner only. A quiet banner above the content, and an "Update" pill on the Settings item (a dot on the menu icon on mobile, read as "Update available"). Dismissing hides the banner until the next version; the pill stays. Admins see neither.', home: { sub: 'Here\'s where things stand on your site.', stats, recent, banner: bn('circle-arrow-up', 'Version 2.3.0 is available', 'Update it from Settings. It takes about 2 minutes and the site stays online.') } }),
withM({ ...home, navBadge: true, name: 'Update ready to install (owner)', trigger: 'The download is checked. The same banner changes its copy, and a dismiss comes back on the next visit because the update is waiting.', home: { sub: 'Here\'s where things stand on your site.', stats, recent, banner: bn('circle-check', 'Version 2.3.0 is ready to install', 'Restart from Settings to finish. The site is unavailable for about 10 seconds.') } })
] },
{ label: 'Articles', title: 'Articles', route: '/article', api: 'GET /v1/article/ · PATCH …/publish · PATCH …/unpublish · DELETE /v1/article/{id}', note: 'Rows update when the server responds, not optimistically. Search, tab and sort are stored in the query string.', states: [
withM({ ...L(), name: 'Default', trigger: 'The list loaded, sorted by last updated.' }),
@@ -274,8 +288,50 @@ class Component extends DCLogic {
withM({ ...U({ toasts: [T('error', 'circle-x', 'Couldn\'t renew the invite', 'Try again in a moment.')] }), name: 'Renew invite: failed', trigger: '500 or network failure. The row stays Expired and the button can be pressed again.' }),
withM({ ...U({ users: { rows: [{ email: 'lea.martin@renew.example', role: 'admin', st: 'pending', c: 'Today', hl: true }, ...people] } , toasts: [T('success', 'circle-check', 'Invite sent', 'lea.martin@renew.example has 3 days to accept.')] }), name: 'Invite sent', trigger: '201: the dialog closes, the new invite appears at the top as Pending, and a toast confirms.' })
] },
{ label: 'Settings', title: 'Settings', route: '/settings', api: 'none (static)', note: 'Opened from the sidebar. For now it holds only the Version section.', states: [
withM({ kind: 'settings', nav: 'settings', crumbs: ['Settings'], mTitle: 'Settings', name: 'Default', trigger: 'Opened from the sidebar.' })
{ label: 'Settings', title: 'Settings: Updates', route: '/settings', api: 'GET /v1/system/update · POST …/check · POST …/download · POST …/restart (all pending)', note: 'New Updates card under Version, owner only. Update downloads and checks the new version and changes nothing. Restart installs it and restarts the site (about 10 seconds). "Restart later" is simply leaving the card or the dialog. A plain Restart shows only when no update is waiting. Admins see the version and a note. When the server isn\'t prepared, the card shows the notice and a "How to update" link with no buttons. Progress is a progressbar with a value, announced at 25% steps and when each step changes. The card is a polite live region. After the restart the page reloads, focus lands on the "Updates" heading, and a toast confirms. Buttons are disabled while any step runs, and any owner on any device sees the same state from the server. Cue elsewhere: see Home. Out of scope: choosing versions, downgrades, automatic updates, update history.', states: [
SU({ icon: 'circle-check', tone: 'success', title: 'You\'re up to date', text: 'You have the latest version of RenewCMS.', meta: LAST, btns: [B('Check for updates', 'sec', 'refresh-cw'), B('Restart', 'sec', 'power')], hint: RESTART_FOOT }, { name: 'Up to date', trigger: 'Opened with no newer version. Restart is available but not emphasised.' }),
SU({ icon: 'loader-circle', title: 'Checking for updates…', text: 'This usually takes a few seconds.', btns: [B('Checking…', 'sec', 'loader-circle', true)] }, { name: 'Checking', trigger: 'Check for updates pressed, or the first open after 24 hours. Announced as "Checking for updates". Buttons are disabled.' }),
SU({ icon: 'wifi-off', tone: 'warning', title: 'Couldn\'t check for updates', text: 'RenewCMS couldn\'t reach the update server. Check your connection and try again. Your site isn\'t affected.', meta: 'Last checked yesterday at 18:12', btns: [B('Try again', 'primary', 'rotate-cw'), B('Restart', 'sec', 'power')], hint: RESTART_FOOT }, { name: 'Check failed', trigger: 'Offline, or the update server didn\'t answer (500, network). The last known result is kept.' }),
SU({ icon: 'circle-arrow-up', tone: 'info', title: 'Version 2.3.0 is available', text: 'You have v2.2.0-beta. Update downloads the new version and checks it. Nothing changes until you restart.', meta: LAST, notes: NOTES(false), btns: [B('Update', 'primary', 'download')], hint: 'Takes about 2 minutes. Your site stays online.' }, { name: 'Update available', trigger: 'A newer version exists. Release notes are collapsed. Update is the one primary button.', navBadge: true }),
SU({ icon: 'circle-arrow-up', tone: 'info', title: 'Version 2.3.0 is available', text: 'You have v2.2.0-beta. Update downloads the new version and checks it. Nothing changes until you restart.', meta: LAST, notes: NOTES(true), btns: [B('Update', 'primary', 'download')], hint: 'Takes about 2 minutes. Your site stays online.' }, { name: 'Update available, notes open', trigger: '"What\'s new in 2.3.0" expanded. It is a button with aria-expanded, and the list is plain text.', navBadge: true }),
SU({ icon: 'download', tone: 'info', title: 'Downloading version 2.3.0…', text: 'You can leave this page. The download continues and your site stays online.', pct: 42, barLabel: 'Downloading version 2.3.0', barText: '42% · 11 of 26 MB', btns: [B('Updating…', 'sec', 'loader-circle', true)] }, { name: 'Downloading', trigger: 'Update pressed (202). Progress polls every second. Announced as "Downloading, 25 percent" and so on, never every tick.', navBadge: true }),
SU({ icon: 'shield-check', tone: 'info', title: 'Checking the download…', text: 'Making sure the file is complete and safe to install. This takes a few seconds.', indet: true, barLabel: 'Checking the download', barText: 'Almost there', btns: [B('Updating…', 'sec', 'loader-circle', true)] }, { name: 'Verifying', trigger: 'The download finished. No percentage, so the bar is indeterminate. Announced as "Checking the download".', navBadge: true }),
SU({ icon: 'circle-check', tone: 'success', title: 'Version 2.3.0 is ready to install', text: 'The download is checked. Restart to install it. Your site will be unavailable for about 10 seconds.', meta: 'Nothing has changed yet.', notes: NOTES(false), btns: [B('Restart', 'primary', 'power')], hint: 'Not now? Leave this page. The update waits here, and the banner on Home reminds you.' }, { name: 'Ready to install', trigger: 'The file passed its checks. Restart becomes the primary action. "Restart later" is closing the dialog or leaving the page.', navBadge: true }),
SU({ icon: 'circle-check', tone: 'success', title: 'Version 2.3.0 is ready to install', text: 'The download is checked. Restart to install it. Your site will be unavailable for about 10 seconds.', meta: 'Nothing has changed yet.', btns: [B('Restart', 'primary', 'power')] }, { name: 'Restart: confirm', trigger: 'Restart pressed. Same dialog behaviour as the delete confirm: focus moves to the first button, Escape and "Restart later" close it, and focus returns to Restart. The confirm button is neutral, not red, because nothing is lost.', navBadge: true, modal: installModal() }),
SU({ icon: 'circle-check', tone: 'success', title: 'Version 2.3.0 is ready to install', text: 'The download is checked. Restart to install it. Your site will be unavailable for about 10 seconds.', meta: 'Nothing has changed yet.', btns: [B('Restart', 'primary', 'power')] }, { name: 'Restart: request failed', trigger: '500 or network failure before the restart began. The site is still running.', navBadge: true, modal: installModal({ notice: 'Couldn\'t start the restart. Nothing was changed and your site is still running. Try again in a moment.' }) }),
SU({ icon: 'circle-check', tone: 'success', title: 'Version 2.3.0 is ready to install', text: '', btns: [] }, { name: 'Restarting to install', trigger: 'Full-page overlay, so it survives the server going away. The page polls until the site answers, then reloads. It is a live region announced once as "Installing version 2.3.0. Your site is restarting."', overlay: { title: 'Installing version 2.3.0', text: 'Your site is restarting with the new version. This takes about 10 seconds. This page reloads on its own when the site is back.', meta: 'Started at 09:51', barL: '30%' } }),
SU({ icon: 'circle-check', tone: 'success', title: '', text: '', btns: [] }, { name: 'Restarting, taking longer', trigger: 'No answer after 60 seconds. The copy changes and a manual reload appears. The overlay stays until the site is back.', overlay: { title: 'Still restarting', text: 'This is taking longer than usual. Keep this page open. It reloads on its own when the site is back, or you can reload it now.', meta: 'Started at 09:51 · 1 minute ago', btn: 'Reload page', barL: '65%' } }),
SU({ icon: 'circle-check', tone: 'success', title: 'You\'re on version 2.3.0', text: 'The update is installed and your site is running again.', meta: 'Updated today at 09:52', btns: [B('Check for updates', 'sec', 'refresh-cw'), B('Restart', 'sec', 'power')], hint: RESTART_FOOT, link: 'Read the release notes', v: 'v2.3.0', focus: '2px solid var(--ui-primary)', toasts: undefined }, { name: 'Update done', trigger: 'The page reloaded on the new version. Focus lands on the "Updates" heading (ring shown), the toast is announced, and the version updates.', toasts: [T('success', 'circle-check', 'Update installed', 'RenewCMS is now on version 2.3.0.')] }),
SU({ icon: 'triangle-alert', tone: 'warning', title: 'The update didn\'t install', text: 'RenewCMS put the previous version back, so your site is running as before. Nothing was lost.', meta: 'What to do next: try again in a few minutes. If it fails again, ask whoever manages your server to check the update.', btns: [B('Try again', 'primary', 'rotate-cw')] }, { name: 'Update failed, rolled back', trigger: 'The site came back on v2.2.0-beta. The error toast stays until dismissed and the card keeps the explanation.', toasts: [T('error', 'circle-x', 'The update didn\'t install', 'Your site is back on v2.2.0-beta.')] }),
SU({ icon: 'circle-x', tone: 'error', title: 'The download didn\'t finish', text: 'The connection dropped before the file was complete. Nothing was changed and your site is running as before.', btns: [B('Try again', 'primary', 'rotate-cw')] }, { name: 'Download failed', trigger: 'A 500, or the connection dropped. Focus moves to the card heading. Try again restarts the download.', navBadge: true }),
SU({ icon: 'triangle-alert', tone: 'warning', title: 'We didn\'t use this update', text: 'The file didn\'t pass our safety check, so it was not installed. Nothing was changed. Try downloading it again. If this keeps happening, contact RenewCMS support.', btns: [B('Try again', 'primary', 'rotate-cw')] }, { name: 'Verification failed', trigger: 'The downloaded file isn\'t trusted. The tone is a warning, and the file is thrown away. Technical detail goes to the server log, not the screen.', navBadge: true }),
SU({ icon: 'info', tone: 'info', title: 'Too many tries', text: 'Wait a moment before trying again.', btns: [B('Try again in 0:42', 'sec', 'clock', true)] }, { name: 'Too many requests (429)', trigger: 'Retry-After counted down in the button. It re-enables at zero.' }),
SU(notPrep(false), { name: 'Not prepared', trigger: 'The server can\'t update from the browser. No buttons, not even Restart. The command is for the person who runs the server and is a single line. The placeholder command is subject to the real one.', navBadge: true }),
SU(notPrep(true), { name: 'Not prepared: command copied', trigger: 'Copy pressed. The button reads "Copied" for 2 s and it is announced.', navBadge: true }),
SU({ icon: 'circle-check', tone: 'success', title: 'You\'re up to date', text: 'You have the latest version of RenewCMS.', meta: LAST, btns: [B('Check for updates', 'sec', 'refresh-cw'), B('Restart', 'sec', 'power')], hint: RESTART_FOOT }, { name: 'Plain restart: confirm', trigger: 'Restart with no update waiting. Nothing is installed.', modal: restartModal() }),
SU({ icon: 'circle-check', tone: 'success', title: '', text: '', btns: [] }, { name: 'Plain restart: restarting', trigger: 'Same overlay as the update restart with shorter copy.', overlay: { title: 'Restarting your site', text: 'This takes about 10 seconds. This page reloads on its own when the site is back.', meta: 'Started at 09:51', barL: '30%' } }),
SU({ icon: 'circle-check', tone: 'success', title: 'Your site is back', text: '', btns: [] }, { name: 'Plain restart: done', trigger: 'The page reloaded. Focus lands on the "Updates" heading.', toasts: [T('success', 'circle-check', 'Site restarted', 'Your site is running again.')] }),
SU({ icon: 'circle-arrow-up', tone: 'info', title: 'Version 2.3.0 is available', text: 'You have v2.2.0-beta. Only the owner can update RenewCMS. Ask the owner of this site.', meta: LAST }, { name: 'Admin view', trigger: 'Admins see the version and the note, with no buttons. Up to date: "You\'re up to date" and "Only the owner can update or restart the site." No Home banner or Settings pill.' }),
SU({ icon: 'circle-arrow-up', tone: 'info', title: 'Version 2.3.0 is available', text: 'You have v2.2.0-beta. Only the owner can update RenewCMS. Ask the owner of this site.', meta: LAST }, { name: 'Role changed (403)', trigger: 'An owner was changed to admin while the page was open and pressed a button. The card reloads in the admin view.', toasts: [T('error', 'circle-x', 'Only the owner can do this', 'Ask the owner of this site to update RenewCMS.')] }),
SU({ icon: 'circle-arrow-up', tone: 'info', title: 'Version 2.3.0 is available', text: 'You have v2.2.0-beta. Update downloads the new version and checks it. Nothing changes until you restart.', meta: LAST, btns: [B('Update', 'primary', 'download', true)] }, { name: 'Update already running (409)', trigger: 'Another owner started it. The card switches to that run\'s progress.', navBadge: true, toasts: [T('info', 'info', 'An update is already running', 'Another owner started it. Progress shows here.')] })
], tableTitle: 'Status to copy', table: [
{ a: '200', b: 'Check, up to date', c: '"You\'re up to date" / "You have the latest version of RenewCMS." / "Last checked today at 09:41"' },
{ a: '200', b: 'Check, newer version', c: '"Version 2.3.0 is available" / "You have v2.2.0-beta. Update downloads the new version and checks it. Nothing changes until you restart."' },
{ a: '202', b: 'Update, Restart', c: 'Accepted. The card switches to progress. Announced: "Downloading version 2.3.0, 25 percent".' },
{ a: '200', b: 'Update finished', c: '"Version 2.3.0 is ready to install" / "The download is checked. Restart to install it. Your site will be unavailable for about 10 seconds."' },
{ a: '200', b: 'After restart', c: 'Toast: "Update installed" / "RenewCMS is now on version 2.3.0." Plain restart: "Site restarted" / "Your site is running again."' },
{ a: '400', b: 'Update, nothing to install', c: 'Toast (info): "Nothing to update" / "You already have the latest version." The card refreshes.' },
{ a: '401', b: 'Any call', c: 'Handled globally: /login?redirect=/settings&reason=expired. No local copy.' },
{ a: '403', b: 'Any button, not the owner', c: 'Toast (error): "Only the owner can do this" / "Ask the owner of this site to update RenewCMS." The card reloads as the admin view. An unverified account is handled globally.' },
{ a: '409', b: 'Update, Restart', c: 'Already running: toast (info) "An update is already running" / "Another owner started it. Progress shows here." Not prepared: the card shows the "Not prepared" state and "How to update".' },
{ a: '422', b: 'Update, file not trusted', c: '"We didn\'t use this update" / "The file didn\'t pass our safety check, so it was not installed. Nothing was changed. Try downloading it again. If this keeps happening, contact RenewCMS support."' },
{ a: '429', b: 'Check, Update', c: 'Card alert (info): "Too many tries" / "Wait a moment before trying again." Button reads "Try again in 0:42" and counts down.' },
{ a: '500 / network', b: 'Check', c: '"Couldn\'t check for updates" / "RenewCMS couldn\'t reach the update server. Check your connection and try again. Your site isn\'t affected." with "Try again".' },
{ a: '500 / network', b: 'Update', c: '"The download didn\'t finish" / "The connection dropped before the file was complete. Nothing was changed and your site is running as before." with "Try again".' },
{ a: '500 / network', b: 'Restart dialog', c: '"Couldn\'t start the restart. Nothing was changed and your site is still running. Try again in a moment."' },
{ a: 'Site back, old version', b: 'After restart', c: '"The update didn\'t install" / "RenewCMS put the previous version back, so your site is running as before. Nothing was lost." Next step: "try again in a few minutes. If it fails again, ask whoever manages your server to check the update."' },
{ a: 'No answer, 60 s', b: 'Restart overlay', c: '"Still restarting" / "This is taking longer than usual. Keep this page open. It reloads on its own when the site is back, or you can reload it now."' },
{ a: 'Offline', b: 'Whole page', c: 'Existing banner. Check, Update and Restart are disabled. During a restart, the overlay keeps polling and ignores the offline state.' }
] },
{ label: 'Profile', title: 'Profile', route: '/profile', api: 'GET /v1/auth/me · PATCH /v1/user/me (pending) · POST /v1/auth/password-reset', note: 'Opened from the account menu at the bottom of the sidebar. Username, email and password are read-only. The display name is optional, trimmed, and up to 60 characters. Once saved it replaces the username everywhere a person is named: the sidebar, the account menu, the Home greeting, the Users list (with the username beside it) and the emails RenewCMS sends, such as "Marta Alves invited you to RenewCMS". Saving it empty goes back to the username. The reset link uses the same flow as "Forgot password" and ends on the auth board\'s "Choose a new password" screen.', states: [
withM({ ...home, home: { sub: 'Here\'s where things stand on your site.', stats, recent }, userMenu: true, name: 'Account menu', trigger: 'The account chip at the bottom of the sidebar. On mobile, the account row in the navigation drawer opens it as a sheet. Escape or a click outside closes it.' }),
+35 -1
View File
@@ -149,7 +149,33 @@ Every state is drawn at desktop and mobile on the screen boards, with final copy
| Users | `/users` | Renew invite: sending | "Renew invite" on an Expired row; POST in flight | [users](screens/users.md) |
| Users | `/users` | Renew invite: done | 200: row Pending on top, toast | [users](screens/users.md) |
| Users | `/users` | Renew invite: failed | 500 or network: toast, row stays Expired | [users](screens/users.md) |
| Settings | `/settings` | Default | Opened from the sidebar | [settings](screens/settings.md) |
| Settings | `/settings` | Up to date | Opened with no newer version | [settings](screens/settings.md) |
| Settings | `/settings` | Checking | Check for updates pressed, or the first open after 24 hours | [settings](screens/settings.md) |
| Settings | `/settings` | Check failed | Offline, or the update server didn't answer (500, network) | [settings](screens/settings.md) |
| Settings | `/settings` | Update available | A newer version exists | [settings](screens/settings.md) |
| Settings | `/settings` | Update available, notes open | "What's new in 2.3.0" expanded | [settings](screens/settings.md) |
| Settings | `/settings` | Downloading | Update pressed (202) | [settings](screens/settings.md) |
| Settings | `/settings` | Verifying | The download finished | [settings](screens/settings.md) |
| Settings | `/settings` | Ready to install | The file passed its checks | [settings](screens/settings.md) |
| Settings | `/settings` | Restart: confirm | Restart pressed | [settings](screens/settings.md) |
| Settings | `/settings` | Restart: request failed | 500 or network failure before the restart began | [settings](screens/settings.md) |
| Settings | `/settings` | Restarting to install | Full-page overlay, so it survives the server going away | [settings](screens/settings.md) |
| Settings | `/settings` | Restarting, taking longer | No answer after 60 seconds | [settings](screens/settings.md) |
| Settings | `/settings` | Update done | The page reloaded on the new version | [settings](screens/settings.md) |
| Settings | `/settings` | Update failed, rolled back | The site came back on v2.2.0-beta | [settings](screens/settings.md) |
| Settings | `/settings` | Download failed | A 500, or the connection dropped | [settings](screens/settings.md) |
| Settings | `/settings` | Verification failed | The downloaded file isn't trusted | [settings](screens/settings.md) |
| Settings | `/settings` | Too many requests (429) | Retry-After counted down in the button | [settings](screens/settings.md) |
| Settings | `/settings` | Not prepared | The server can't update from the browser | [settings](screens/settings.md) |
| Settings | `/settings` | Not prepared: command copied | Copy pressed | [settings](screens/settings.md) |
| Settings | `/settings` | Plain restart: confirm | Restart with no update waiting | [settings](screens/settings.md) |
| Settings | `/settings` | Plain restart: restarting | Same overlay as the update restart with shorter copy | [settings](screens/settings.md) |
| Settings | `/settings` | Plain restart: done | The page reloaded | [settings](screens/settings.md) |
| Settings | `/settings` | Admin view | Admins see the version and the note, with no buttons | [settings](screens/settings.md) |
| Settings | `/settings` | Role changed (403) | An owner was changed to admin while the page was open and pressed a button | [settings](screens/settings.md) |
| Settings | `/settings` | Update already running (409) | Another owner started it | [settings](screens/settings.md) |
| Home | `/home` | Update available (owner) | Owner only: quiet banner and Settings pill | [home](screens/home.md) |
| Home | `/home` | Update ready to install (owner) | Download checked: banner copy changes | [home](screens/home.md) |
| Profile | `/profile` | Account menu | Account chip clicked | [profile](screens/profile.md) |
| Profile | `/profile` | Loading | Opened by URL before /auth/me returns | [profile](screens/profile.md) |
| Profile | `/profile` | Default, no display name | First visit | [profile](screens/profile.md) |
@@ -220,6 +246,14 @@ Still not supported, so shown disabled or omitted:
Renaming a title (shown read-only, with an explanation in Details), resending the verification email (the pending page explains how to start over), changing the email or username, removing users, promoting or demoting anyone, and any role other than owner and admin. Changing the password while logged in works only through the emailed reset link on the Profile page.
Added by the Updates card, none of which exists yet (owner only unless noted, see [settings](screens/settings.md)):
- `GET /v1/system/update` (any verified user): `{ current, latest, available, notes: { version, released_at, items }, checked_at, can_apply, state, progress, error, started_at }`. `state` is `idle`, `downloading`, `verifying`, `ready`, `restarting`, `succeeded` or `failed`. `can_apply` is false when the server hasn't been prepared, or for admins.
- `POST /v1/system/update/check`: asks the release feed. 200, 429 with `Retry-After`, 500 when the feed can't be reached.
- `POST /v1/system/update/download`: 202 starts the download and verification, 400 when there is nothing to update, 403, 409 when one is already running or the server isn't prepared, 422 when the file fails verification, 429.
- `POST /v1/system/update/restart`: 202 starts the install and restart (or only a restart when no update is ready), 403, 409, 500.
- A restart must survive the server going away: the SPA polls `/healthz` and `GET /v1/system/update` until they answer.
Added by the Media screens, none of which exist yet:
- `GET /v1/media/?q=&filter=&sort=&limit=&cursor=&hash=`: the library, newest first by default. `hash` (SHA-256 hex) returns only the images with that content, which is how the browser checks for a duplicate before uploading. Each item carries `id`, `filename`, `url`, `size`, `content_type`, `width`, `height` (null for SVG), `uploaded_by`, `created_at`, `used_in` (count) and `duplicate` (bool). The response also carries the counts for the Unused and Duplicates tabs.
+4 -1
View File
@@ -17,7 +17,7 @@ Rules: bullets are full sentences ending with a period; user-facing wording, no
## Published releases
Each body lives in `docs/releases/<tag>.md`. Publish with `tea releases create --tag <tag> --title "<name>" --note-file docs/releases/<tag>.md --prerelease --asset <binary>` (one `--asset` per binary), after `task release`.
Each body lives in `docs/releases/<tag>.md`. Publish with `tea releases create --tag <tag> --title "<name>" --note-file docs/releases/<tag>.md --prerelease --asset <file>` after `task release`, with one `--asset` per file: the six binaries, `bin/checksums.txt` and `bin/checksums.txt.sig`. `task release` produces all eight and fails before building when the signing key is missing or wrong (see [deployment.md](deployment.md#release-signing-key-maintainers-once)). Never publish a release without the two checksum files.
| Tag | Name |
| --- | --- |
@@ -27,3 +27,6 @@ Each body lives in `docs/releases/<tag>.md`. Publish with `tea releases create -
| `v2.3.0-beta` | v2.3.0-beta - Multi-user invitations, display names & profile page |
| `v2.4.0-beta` | v2.4.0-beta - Owner role, invite management & Settings page |
| `v2.5.0-beta` | v2.5.0-beta - Media library & image picker |
| `v2.6.0-beta` | v2.6.0-beta - Signed updates and browser restart |
| `v2.6.2-beta` | v2.6.2-beta - English and French interface |
| `v2.7.0-beta` | v2.7.0-beta - Markdown and block article bodies |
+46
View File
@@ -0,0 +1,46 @@
RenewCMS can now check for releases, download a signed update and install it from Settings. On Linux with systemd, the owner can restart the site from the browser, with automatic binary rollback if the new version fails to start.
## New
**Updates in Settings**
- Owners can check for a newer release, read its release notes and download it while the site stays online.
- Downloads show progress, verify the release signature and binary checksum, check the staged version and back up the database before becoming ready to install.
- The Home page and Settings navigation show an owner-only update notification, and the Home banner can be dismissed for each version.
- Admins can read the update status without starting an update or restart.
**Browser restart and installation**
- Owners can confirm an update installation or a plain site restart from Settings.
- A restart overlay waits for the site to return and offers a reload action when the restart takes longer than expected.
- Linux installations with systemd can enable browser updates using `renewcms enable-browser-updates` and remove the helper using `renewcms disable-browser-updates`.
- The helper verifies the staged files again, keeps the previous binary and restores it if the new version does not start successfully.
## Improvements and fixes
- Update status and download progress survive navigation and are shared between owners.
- Update checks and download starts have separate per-user rate limits with retry countdowns.
- Restart confirmations identify whether the action installs an update or only restarts the site, and refuse a request when another owner's action has changed that state.
- Completion messages are shown in the browser tab that requested the restart.
## API
- `GET /v1/system/update` returns the current and latest versions, release notes, release URL, helper availability, progress, state, error kind and operation timestamps for verified users, without changing state.
- `POST /v1/system/update/check` checks the release feed for owners and returns 200, 403 for insufficient permissions, 429 with `Retry-After`, or 500 when the feed cannot be reached.
- `POST /v1/system/update/download` starts an owner-only background download with 202, or returns 400 when nothing is available, 403, 409 for an unavailable helper or conflicting job, 422 for a pre-flight refusal, or 429.
- `POST /v1/system/update/restart` accepts an optional `kind` of `update` or `restart` and returns 202, 400 for invalid input, 403, 409 for an unavailable helper or conflicting state, or 500 when the request cannot be saved.
## Under the hood
- Releases include signed `checksums.txt` and `checksums.txt.sig` files alongside the six platform binaries.
- The update helper runs separately from the unprivileged app, copies staged files into a private directory and verifies the bytes it installs rather than trusting a mutable staged path.
- Feature specifications, fake-backed Go tests and SPA tests cover release checks, downloads, restart requests and rollback decisions.
## Upgrading
- Back up your SQLite database and uploads, then replace the binary and restart manually for this first release with browser-update support.
- No database schema change is introduced by the update features.
- `UPDATE_FEED_URL` is optional and defaults to the project's release feed; existing configuration remains usable.
- On Linux with systemd, run `sudo renewcms enable-browser-updates` after the manual upgrade to enable future updates and restarts from Settings.
- Keep the update status files, staged files and backups beside the database in the data directory, with the permissions described in `docs/deployment.md`.
## Known limitations
- The privileged update helper has automated coverage through fakes, but its first real Linux/systemd update and rollback checks are still pending.
- Browser installation and restart require Linux with systemd; Windows, macOS and other init systems remain manual upgrades.
- Updating or restarting briefly takes the site offline, and a reverse proxy may return errors during that interval.
- Automatic rollback restores the previous binary; it does not restore the database, so schema-changing upgrades still require a backup and a recovery plan.
- Update assets and redirects must use HTTPS on the configured feed host.
+29
View File
@@ -0,0 +1,29 @@
This release adds English and French throughout the SPA, with an instant language switch and a preference remembered on this browser.
## New
**English and French interface**
- Choose English or Français from the Language control in the desktop or mobile profile submenu.
- Switch interface language immediately while keeping your current page and unsaved work.
- Keep your selected language after navigation, reload and logout, including on authentication screens.
- See translated forms, validation, notifications, dialogs and accessibility labels, with localized dates, numbers and counts.
## Improvements and fixes
- Keep partial bulk-delete failure notifications available after retrying, including when switching languages.
## Under the hood
- Add translation catalog parity, fallback, persistence and SPA interaction tests.
## Upgrading
- Install the signed update through Settings on a prepared Linux/systemd installation, or replace the binary and restart the service.
- No database migration or new environment variable is required.
- English remains the default until a language is selected; the preference is stored locally in the browser.
- User content, API data and transactional emails retain their existing language.
## Known limitations
- Visual parity checks for this feature were skipped under the accepted slice waiver.
+35
View File
@@ -0,0 +1,35 @@
This release lets your website read article bodies as markdown, HTML or structured blocks, and fixes text alignment in the editor.
## New
**Article body formats**
- Read an article body as markdown, HTML or a typed block array with the `format` query parameter, so a headless frontend can render it with markdown-it, comark or its own components.
- Keep text alignment in every format: markdown wraps centered, right-aligned and justified blocks in a `div` with an inline style, and the block array carries an `align` field.
- Keep plain text plain: text that merely looks like markdown, such as `# not a heading` or `- not a list`, is escaped in the markdown output.
- See the Integration page snippets and [the article API reference](../api/articles.md) for the full contract.
## Improvements and fixes
- Fix the text alignment buttons in the article editor, which were disabled and showed a blocked cursor. Paragraphs and headings can be aligned left, center, right or justified again, and unaligned text stays free of inline styles.
- The web interface requests HTML explicitly when it loads, saves, publishes, unpublishes or creates an article, so the editor and the image counts behave exactly as before.
## API
- Changed: `GET /v1/article/`, `GET /v1/article/{id}`, `POST /v1/article/`, `PATCH /v1/article/{id}`, `PATCH /v1/article/{id}/publish` and `PATCH /v1/article/{id}/unpublish` now return `body` as markdown by default. Pass `?format=html` to keep the previous HTML body.
- Every article object now includes `body_format` (`markdown`, `html` or `json`), which names the format of `body`.
- `?format=json` on the same routes returns `body` as a JSON array of typed blocks instead of a string.
- An unsupported `format` answers `400` before anything is read or written.
- Storage and the request bodies of `POST` and `PATCH` stay HTML.
## Under the hood
- Add the article body renderer port in the domain, with a markdown and JSON block adapter, and tests for every supported element.
- Update `golang.org/x/crypto` to v0.57.0 and add `golang.org/x/net` as a direct dependency for HTML parsing.
- Add `@tiptap/extension-text-align` to the web interface.
## Upgrading
- Replace the binary. No database migration or new environment variable is required.
- Clients that read an article `body` as HTML must add `?format=html` to their article requests, because the default is now markdown.
- A markdown renderer needs raw HTML enabled for text alignment to show, for example `html: true` in markdown-it.
+229
View File
@@ -0,0 +1,229 @@
Feature: Article body content negotiation on read
As a headless frontend developer
I want article routes to return the body as markdown (default), html or a typed json block array
So that my client can render it without handling editor HTML
Background:
Given article bodies are stored as Tiptap HTML
And storage, the POST /v1/article body and the PATCH /v1/article/{id} body stay HTML and are unchanged
And internal/domain/article defines BodyFormat with the values "markdown", "html" and "json"
And internal/domain/article defines the port BodyRenderer and the sentinel ErrUnsupportedBodyFormat
And ParseBodyFormat matches case-insensitively, treats an empty value as "markdown", and returns ErrUnsupportedBodyFormat otherwise
And the use cases receive the BodyRenderer through their constructors, the handler only reads the "format" query value, and only api/dependecyInjection.go builds the converter
And every article object in a response has the snake_case fields id, title, body, body_format, is_online, created_at, updated_at
And body_format is "markdown", "html" or "json" and always names the format of body
And for markdown and html, body is a JSON string; for json, body is a JSON array of blocks (not an escaped string)
And the covered routes are GET /v1/article/, GET /v1/article/{id}, POST /v1/article/, PATCH /v1/article/{id}, PATCH /v1/article/{id}/publish and PATCH /v1/article/{id}/unpublish
And visibility is unchanged: anonymous and unverified callers see only online articles, and an offline article reads as 404 "Article not found"
And an unsupported format answers 400 with apperr.ArticleBodyFormatErrorMessage as plain text, before any article lookup or write
And an invalid id answers apperr.IdUint32ErrorMessage first, ahead of the format check
And a repeated "format" parameter uses its first value
And a renderer failure answers 500 "Internal server error"
And article 1 is online, titled "Backyard Renovation Update", with body "<h2>Plan</h2><p>Replace the <strong>old</strong> deck.</p>"
Scenario Outline: Single read negotiates the body format
When an anonymous client sends GET /v1/article/1<query>
Then the response status is 200
And "body" is <body>
And "body_format" is "<body_format>"
Examples:
| query | body | body_format |
| | "## Plan\n\nReplace the **old** deck." | markdown |
| ?format= | "## Plan\n\nReplace the **old** deck." | markdown |
| ?format=markdown | "## Plan\n\nReplace the **old** deck." | markdown |
| ?format=MarkDown | "## Plan\n\nReplace the **old** deck." | markdown |
| ?format=html | "<h2>Plan</h2><p>Replace the <strong>old</strong> deck.</p>" | html |
| ?format=HTML | "<h2>Plan</h2><p>Replace the <strong>old</strong> deck.</p>" | html |
| ?format=json | [{"type":"heading","level":2,"children":[{"type":"text","text":"Plan","marks":[]}]},{"type":"paragraph","children":[{"type":"text","text":"Replace the ","marks":[]},{"type":"text","text":"old","marks":[{"type":"bold"}]},{"type":"text","text":" deck.","marks":[]}]}] | json |
| ?format=JSON | the same array as ?format=json | json |
Scenario: List read negotiates every element
Given the repository also holds online article 3 with body "<p>Second</p>"
When an anonymous client sends GET /v1/article/
Then every element has body_format "markdown" and article 3 has body "Second"
When an anonymous client sends GET /v1/article/?format=html
Then every element has body_format "html" and its stored HTML as body
When an anonymous client sends GET /v1/article/?format=json
Then every element has body_format "json" and article 3 has body [{"type":"paragraph","children":[{"type":"text","text":"Second","marks":[]}]}]
Scenario Outline: An unsupported format is rejected
When an anonymous client sends GET <path>
Then the response status is 400
And the response body is apperr.ArticleBodyFormatErrorMessage followed by a newline
And no use case reads or renders an article
Examples:
| path |
| /v1/article/1?format=pdf |
| /v1/article/?format=xml |
| /v1/article/9999?format=pdf |
| /v1/article/1?format=md |
Scenario: An invalid id is reported before an invalid format
When an anonymous client sends GET /v1/article/abc?format=pdf
Then the response status is 400
And the response body is apperr.IdUint32ErrorMessage followed by a newline
Scenario: The first repeated format parameter wins
When an anonymous client sends GET /v1/article/1?format=html&format=json
Then "body_format" is "html"
Scenario: Offline articles stay hidden whatever the format
Given article 2 is offline
When an anonymous client sends GET /v1/article/2?format=json
Then the response status is 404 and the body is "Article not found"
Scenario Outline: Authenticated routes negotiate the response body
Given a valid jwt cookie for a verified user with id 1
When the client sends <method> <path> with <request_body>
Then the response status is <status>
And "body_format" is "<body_format>"
And the stored body is the HTML that was sent, never markdown or json
Examples:
| method | path | request_body | status | body_format |
| POST | /v1/article/ | {"title":"Deck","body":"<p>A</p>"} | 201 | markdown |
| POST | /v1/article/?format=html | {"title":"Deck","body":"<p>A</p>"} | 201 | html |
| POST | /v1/article/?format=json | {"title":"Deck","body":"<p>A</p>"} | 201 | json |
| PATCH | /v1/article/1 | {"body":"<p>B</p>"} | 200 | markdown |
| PATCH | /v1/article/1?format=json | {"body":"<p>B</p>"} | 200 | json |
| PATCH | /v1/article/1/publish | | 200 | markdown |
| PATCH | /v1/article/1/unpublish?format=html | | 200 | html |
Scenario: An unsupported format on a write route changes nothing
Given a valid jwt cookie for a verified user with id 1
When the client sends PATCH /v1/article/1?format=pdf with {"body":"<p>B</p>"}
Then the response status is 400
And the stored body of article 1 is unchanged
When the client sends POST /v1/article/?format=pdf with {"title":"Deck","body":"<p>A</p>"}
Then the response status is 400 and no article is created
Scenario: The authenticated list includes offline articles in the negotiated format
Given a valid jwt cookie for a verified user and offline article 2
When the client sends GET /v1/article/?format=json
Then the array contains articles 1 and 2 with body_format "json"
Scenario: A converter failure answers 500
Given the BodyRenderer fails on its next call
When an anonymous client sends GET /v1/article/1
Then the response status is 500 and the body is "Internal server error"
Scenario Outline: Markdown fidelity for Tiptap output
Given the stored body is <html>
When converted with the format "markdown"
Then the body is <markdown>
Examples:
| html | markdown |
| <h1>T</h1><h3>S</h3> | # T\n\n### S |
| <p><strong>b</strong> <em>i</em></p> | **b** *i* |
| <p><a href="https://example.com/x">link</a></p> | [link](https://example.com/x) |
| <ul><li><p>a</p></li><li><p>b</p></li></ul> | - a\n- b |
| <ol><li><p>a</p></li><li><p>b</p></li></ol> | 1. a\n2. b |
| <ul><li data-indent="2"><p>a</p></li></ul> | - a |
| <blockquote><p>q</p></blockquote> | > q |
| <pre><code class="language-go">x := 1</code></pre> | ```go\nx := 1\n``` |
| <hr> | --- |
| <img src="/static/uploadedImages/a.png" alt="A"> | ![A](/static/uploadedImages/a.png) |
| <p>ok</p><script>alert(1)</script><style>p{}</style> | ok |
| <p>x<span style="color:red">y</span></p> | xy |
| <p>use <code>go test</code></p> | use `go test` |
Scenario Outline: Json block shapes, one row per block and mark type
Given the stored body is <html>
When converted with the format "json"
Then the body is <json>
Examples:
| html | json |
| <h1>T</h1> | [{"type":"heading","level":1,"children":[{"type":"text","text":"T","marks":[]}]}] |
| <h6>S</h6> | [{"type":"heading","level":6,"children":[{"type":"text","text":"S","marks":[]}]}] |
| <p>plain</p> | [{"type":"paragraph","children":[{"type":"text","text":"plain","marks":[]}]}] |
| <p></p> | [{"type":"paragraph","children":[]}] |
| <p><strong>b</strong></p> | [{"type":"paragraph","children":[{"type":"text","text":"b","marks":[{"type":"bold"}]}]}] |
| <p><em>i</em></p> | [{"type":"paragraph","children":[{"type":"text","text":"i","marks":[{"type":"italic"}]}]}] |
| <p><a href="https://example.com/x">l</a></p> | [{"type":"paragraph","children":[{"type":"text","text":"l","marks":[{"type":"link","href":"https://example.com/x"}]}]}] |
| <p><a href="/a"><strong><em>x</em></strong></a></p> | [{"type":"paragraph","children":[{"type":"text","text":"x","marks":[{"type":"link","href":"/a"},{"type":"bold"},{"type":"italic"}]}]}] |
| <p>a<br>b</p> | [{"type":"paragraph","children":[{"type":"text","text":"a\nb","marks":[]}]}] |
| <ul><li><p>a</p></li><li><p>b</p></li></ul> | [{"type":"list","ordered":false,"items":[[{"type":"paragraph","children":[{"type":"text","text":"a","marks":[]}]}],[{"type":"paragraph","children":[{"type":"text","text":"b","marks":[]}]}]]}] |
| <ol><li><p>a</p></li></ol> | [{"type":"list","ordered":true,"items":[[{"type":"paragraph","children":[{"type":"text","text":"a","marks":[]}]}]]}] |
| <ul><li>bare</li></ul> | [{"type":"list","ordered":false,"items":[[{"type":"paragraph","children":[{"type":"text","text":"bare","marks":[]}]}]]}] |
| <ul><li><p>a</p><ul><li><p>n</p></li></ul></li></ul> | a list item whose blocks are the paragraph "a" followed by a nested list block with ordered false and the item "n" |
| <ul><li data-indent="2"><p>a</p></li></ul> | the same output as without data-indent |
| <blockquote><p>q</p></blockquote> | [{"type":"blockquote","children":[{"type":"paragraph","children":[{"type":"text","text":"q","marks":[]}]}]}] |
| <pre><code class="language-go">x := 1</code></pre> | [{"type":"code","language":"go","text":"x := 1"}] |
| <pre><code>raw</code></pre> | [{"type":"code","language":"","text":"raw"}] |
| <hr> | [{"type":"hr"}] |
| <img src="/static/uploadedImages/a.png" alt="A"> | [{"type":"image","src":"/static/uploadedImages/a.png","alt":"A"}] |
| <img src="/static/uploadedImages/a.png"> | [{"type":"image","src":"/static/uploadedImages/a.png","alt":""}] |
| <p>x<img src="/i.png" alt="I">y</p> | [{"type":"paragraph","children":[{"type":"text","text":"x","marks":[]}]},{"type":"image","src":"/i.png","alt":"I"},{"type":"paragraph","children":[{"type":"text","text":"y","marks":[]}]}] |
| <p>x<span style="color:red">y</span></p> | [{"type":"paragraph","children":[{"type":"text","text":"xy","marks":[]}]}] |
| <p>use <code>go test</code></p> | [{"type":"paragraph","children":[{"type":"text","text":"use go test","marks":[]}]}] |
| <p>ok</p><script>alert(1)</script><style>p{}</style> | [{"type":"paragraph","children":[{"type":"text","text":"ok","marks":[]}]}] |
Scenario Outline: Text alignment survives the conversion
Given the stored body is <html>
When converted with the format "markdown"
Then the body is <markdown>
When converted with the format "json"
Then the body is <json>
Examples:
| html | markdown | json |
| <p style="text-align: center">a</p> | <div style="text-align: center">
a
</div> | [{"type":"paragraph","align":"center","children":[{"type":"text","text":"a","marks":[]}]}] |
| <h2 style="text-align:right">T</h2> | <div style="text-align: right">
## T
</div> | [{"type":"heading","level":2,"align":"right","children":[{"type":"text","text":"T","marks":[]}]}] |
| <p style="text-align: JUSTIFY">a</p> | <div style="text-align: justify">
a
</div> | [{"type":"paragraph","align":"justify","children":[{"type":"text","text":"a","marks":[]}]}] |
| <p style="text-align: left">a</p> | a | [{"type":"paragraph","children":[{"type":"text","text":"a","marks":[]}]}] |
| <p style="text-align: start">a</p> | a | the same output as the left row |
| <p style="text-align: center"></p> | an empty string | [{"type":"paragraph","align":"center","children":[]}] |
Scenario Outline: Plain text that looks like markdown stays plain text
Given the stored body is <html>
When converted with the format "markdown"
Then the body is <markdown>
Examples:
| html | markdown |
| <p># not a heading</p> | \# not a heading |
| <p>#tag</p> | #tag |
| <p>- not a list</p> | \- not a list |
| <p>+ not a list</p> | \+ not a list |
| <p>&gt; not a quote</p> | \> not a quote |
| <p>1. not a list</p> | 1\. not a list |
| <p>2) not a list</p> | 2\) not a list |
| <p>---</p> | \--- |
| <p>a - b</p> | a - b |
| <p>a * b _c_</p> | a \* b \_c\_ |
| <p>a<br>- b</p> | a\n\- b |
Scenario: The editor lets the author align text
Given the article editor registers the TextAlign extension for paragraphs and headings
Then the left, center, right and justify toolbar buttons are enabled
And clicking center writes style="text-align: center;" on the current paragraph or heading
And paragraphs and headings that were never aligned carry no style attribute
Scenario: The SPA asks for html explicitly
Given no visual change is expected, so docs/design is not consulted
When EditorView loads an article, or ArticleView or HomeView load the list
Then each request is /v1/article/{id}?format=html or /v1/article/?format=html
And the draft save PATCH, the publish and unpublish PATCH and the create POST also carry ?format=html, so a converter failure cannot fail a save
And the editor and the image counts receive HTML exactly as before
Scenario: The documentation reflects the contract
Then docs/api has an article read page covering format, the markdown default, body_format, the json block schema, the 400 message and the breaking default change
And web/src/views/IntegrationView.vue snippets show ?format
And docs/releases has a note stating the default flip and that the SPA sends format=html
+46
View File
@@ -0,0 +1,46 @@
# QA procedure: article_body_format
Package: `test` (black-box). New files: `test/article_body_format_test.go`, `test/markdown_converter_test.go`, `test/json_blocks_converter_test.go`. No live server, no real SQLite file, no real SMTP.
## Setup
1. Call `validator.InitValidator()` once.
2. Reuse `mockArticleRepo` and `mockUserRepo`. Add a fake `fakeBodyRenderer` with a unique type name. It records each call's format and the html it received. For markdown it returns "MD:"+html. For html it returns the html unchanged. For json it returns `[{"type":"paragraph","children":[{"type":"text","text":"FAKE","marks":[]}]}]`. It has a failure switch.
3. Wire the real use cases over the fakes, passing the renderer. Update every existing test that builds these use cases for the new constructor signatures. Build `article.NewHandler(...)`.
4. Mount a fresh `chi.NewRouter()` mirroring `api/router.go` for `/v1/article`: `jwtauth.Verifier` on the group, GET `/` and `/{id}` public, and `Authenticator` + `RequireCurrentToken` + `RequireVerifiedUser` for POST, DELETE and PATCH.
5. Mint a jwt cookie for user_id 1 with `token.Encode(map[string]any{"user_id": uint32(1)})`. Seed a verified user. Seed articles 1 (online) and 2 (offline).
## HTTP checks (fake renderer)
6. Single read matrix: for each of none, `?format=`, markdown, MarkDown, html, HTML, json, JSON, assert status 200, `body_format`, the renderer's recorded format and the stored HTML passed in. For json, decode `body` and assert it is a JSON array (not a string).
7. List with none, `?format=html` and `?format=json`: every element has the matching `body_format`.
8. `format=pdf`, `xml` and `md` on single, list and unknown-id paths return 400 with `apperr.ArticleBodyFormatErrorMessage + "\n"`. The renderer and the repo are not called.
9. `GET /v1/article/abc?format=pdf` returns 400 with `apperr.IdUint32ErrorMessage + "\n"`.
10. `?format=html&format=json` returns html.
11. `GET /v1/article/2?format=json` anonymous returns 404 `"Article not found\n"`.
12. Write-route matrix with a cookie (POST, PATCH, publish, unpublish, each with none, html and json where listed): assert status, `body_format`, and that the repo holds the HTML that was sent.
13. `PATCH /v1/article/1?format=pdf` and `POST /v1/article/?format=pdf` with a cookie return 400. The repo is unchanged and no article is created.
14. Authenticated `GET /v1/article/?format=json` includes articles 1 and 2.
15. Renderer failure switch, then `GET /v1/article/1` returns 500 `"Internal server error\n"`.
## Domain
16. `ParseBodyFormat`: "", markdown, MARKDOWN, html, Html, json, JSON are accepted (empty returns markdown). pdf, md and " html" return `errors.Is(err, ErrUnsupportedBodyFormat)`.
## Converter tests (real library, real Tiptap HTML samples)
17. `test/markdown_converter_test.go`: every row of the markdown fidelity table, plus a combined document (heading, paragraph with marks, list, image, code block, quote, hr). Assert exact output. For format html, assert the input comes back byte-identical.
17b. Alignment and escaping: every row of the alignment and plain-text tables, for markdown and json, in `test/markdown_converter_test.go` and `test/json_blocks_converter_test.go`. `test/body_converter_documents_test.go` covers the combined hostile document (no raw script, style, iframe or span leaks in markdown or json), its block types, and code block text extraction.
18. `test/json_blocks_converter_test.go`: every row of the json shapes table. Assert by unmarshalling both sides and comparing with deep equality. This also asserts `marks` is `[]` rather than null or absent, `ordered` is a bool, and code `language` is "" when absent. Also include a combined document with nested list, blockquote and an image inside a paragraph. Assert that script and style content never appears, and that no raw HTML survives in any output for any format except html.
19. `test/json_blocks_converter_test.go` also asserts that html "" produces `[]`, and that the output is a non-null JSON array.
## SPA (Vitest, `task test:web`)
20. Mock `/v1/article/12?format=html` and assert `EditorView` requests that URL and loads the HTML body into the draft.
21. Assert `useArticles.listArticles` requests `/v1/article/?format=html`.
22. Assert the `ArticleView` image count is computed from the HTML.
23. Assert `useArticleDraft.save` sends PATCH `/v1/article/{id}?format=html` with the JSON body.
24. Reported as NOT RUN if there is no runner. No visual check applies, because no visual change is expected.
## Docs
25. Check that a docs/api article read page, the IntegrationView snippets and a docs/releases note exist as described.
## Manual verification
- In the embedded SPA, edit and save an article against a real SQLite file and confirm the stored body is still HTML.
- `curl` the public list and a single article with no format, `?format=html` and `?format=json` against a built binary.
- No SMTP involvement.
@@ -0,0 +1,172 @@
Feature: Language switcher conforms to the official design
Background:
Given the design in docs/design is the visual spec of record for LanguageSwitcher and UserMenu
And the interface supports exactly two languages, English and Français
And each language is always written in its own name, whatever the interface language
And the language rules of features/spa_internationalization.feature still apply
And the language control no longer uses a form select anywhere
And no language preference is sent to the server
Scenario Outline: Account menu lists Profile, Theme, Language and Log out in design order
Given a signed-in user opens the account menu in the <surface>
Then the entries appear in this order
| Profile |
| separator |
| "Theme" section label |
| System, Light, Dark |
| separator |
| "Language" section label |
| English, Français |
| separator |
| Log out |
And the "Theme" and "Language" labels are 11 px, weight 500, uppercase, letter-spacing 0.04em and --ui-text-muted
And the label padding is <label_padding>
And the menu is <size>
And every item row is <row_height> high
Examples:
| surface | label_padding | size | row_height |
| desktop UserMenu popover | 6px 8px 2px | a 224 px popover above the chip | 32 px |
| mobile AccountMenuSheet | 8px 16px 2px | a bottom sheet with grab handle | 48 px |
Scenario Outline: Language rows are a radio group naming each language in its own name
Given the interface language is <locale>
When the account menu is open in the <surface>
Then the "Language" label names a group of two menuitemradio rows
And the rows read "English" with lang "en" and "Français" with lang "fr"
And the row for <locale_name> has aria-checked "true" and a check icon at the right edge
And the other row has aria-checked "false" and no check icon
And no Nuxt UI select, combobox or languages icon row is present in the menu
Examples:
| surface | locale | locale_name |
| desktop UserMenu popover | en | English |
| desktop UserMenu popover | fr | Français |
| mobile AccountMenuSheet | en | English |
| mobile AccountMenuSheet | fr | Français |
Scenario Outline: Theme rows are radio items that keep the menu open
Given the theme preference is <preference>
When the account menu is open in the <surface>
Then System, Light and Dark are menuitemradio rows in a group named "Theme"
And only the <preference> row has aria-checked "true" and a check icon
When the user chooses another theme row
Then the theme applies at once and the menu stays open
Examples:
| surface | preference |
| desktop UserMenu popover | light |
| mobile AccountMenuSheet | dark |
Scenario Outline: Choosing a language in the account menu applies it at once and keeps the menu open
Given the interface language is en and the user is on /profile with an unsaved display name "Alice B."
And the account menu is open in the <surface>
When the user chooses "Français"
Then all interface text, including the menu labels "Thème" and "Langue", is French
And the document lang is "fr" and localStorage "renewcms-language" is "fr"
And the Français row is checked and the menu stays open
And the route, session, theme and unsaved display name are unchanged
And no reload, navigation or /v1 request occurs
When the user chooses "English"
Then the interface is English, the document lang is "en" and the menu stays open
Examples:
| surface |
| desktop UserMenu popover |
| mobile AccountMenuSheet |
Scenario Outline: Account menu keyboard and dismissal
Given the account menu is open in the <surface>
When the user moves with ArrowDown and ArrowUp
Then focus visits Profile, the theme rows, the language rows and Log out in visual order and wraps at the ends
When the user presses Enter or Space on a language row
Then that language is applied and the menu stays open
When the user presses Escape or clicks outside
Then the menu closes without changing the language
Examples:
| surface |
| desktop UserMenu popover |
| mobile AccountMenuSheet |
Scenario Outline: Auth footer shows the language chip beside the theme chip
Given the user is signed out on <route>
And the interface language is en
Then the footer outside the card contains the language chip and the System theme chip aligned right with an 8 px gap
And any existing footer slot content stays to the left of the chips
And the chip shows the lucide languages icon at 14 px followed by "English"
And the chip has a 1 px --ui-border-accented border, --ui-text-toned text, aria-haspopup "menu", aria-expanded "false" and aria-label "Language: English"
And no language select is rendered in the card or the footer
Examples:
| route |
| /login |
| /register |
| /register/pending |
| /register/validate |
| /register/reset/request |
| /register/reset/validate |
| /invite/accept |
Scenario Outline: Auth footer is always rendered, on mobile too
Given the viewport is <viewport>
When an auth screen with no footer slot content renders
Then the footer with the language chip and the theme chip is visible
And the chip is <chip_height> high
Examples:
| viewport | chip_height |
| 1440 x 900 | 28 px |
| 390 x 844 | 44 px |
Scenario: Chip reflects the current language
Given the stored language is fr
When /login renders
Then the chip reads "Français" and its aria-label is "Langue : Français"
Scenario Outline: Auth language popover
Given the user is signed out on /login in <locale_name>
When the user activates the language chip
Then the chip has aria-expanded "true" and --ui-bg-elevated
And a popover with role "menu" named "Language" opens above the chip, right-aligned and 36 px above its bottom edge, 168 px wide, --ui-bg, 1 px --ui-border, --rc-shadow-pop and 4 px padding
And it holds menuitemradio rows "English" (lang "en") and "Français" (lang "fr") that are 32 px high on desktop and 44 px on mobile
And the current language row has aria-checked "true" and a 16 px check icon at the right edge
Examples:
| locale_name |
| English |
| Français |
Scenario: Choosing a language in the auth popover closes it
Given the auth language popover is open on /login with English current
When the user chooses "Français"
Then the whole screen is French at once, including the card, the footer and the document title
And the document lang is "fr" and localStorage "renewcms-language" is "fr"
And the popover closes and focus returns to the language chip
And the chip reads "Français"
And the form values already typed, the route and the theme are unchanged
And no /v1 request occurs
Scenario: Dismiss the auth popover without changing language
Given the auth language popover is open
When the user presses Escape or clicks outside it
Then it closes, aria-expanded is "false" and the language is unchanged
And focus returns to the chip on Escape
Scenario: Auth popover keyboard
Given the language chip has focus
When the user presses Enter, Space or ArrowDown
Then the popover opens with focus on the current language row
And ArrowUp and ArrowDown move between the two rows and Enter or Space chooses one
Scenario: Language persists across public and signed-in screens
Given the user chose Français on /login
When they sign in, open the account menu and log out
Then Français is checked in the account menu and the /login chip reads "Français" again
And a storage failure still lets the choice apply for the current session, as in spa_internationalization
Scenario: Catalog parity for the new strings
Then the en and fr catalogs contain "Theme" and "Language: {0}"
And "Language: {0}" keeps its {0} parameter in French
And the strings "English" and "Français" are not translated
@@ -0,0 +1,35 @@
# Language switcher conformance QA
Accepted by the user on 2026-10-04 together with the slice specification. Decisions folded in: spa_internationalization picker scenarios are amended; theme and language rows are menuitemradio and the account menu and sheet stay open after a choice; the auth popover is specified from docs/design/components.md because the boards draw only the chip.
## Automated (Vitest + Vue Test Utils, `task test:web`)
Mock `/v1` per case and assert that a language change makes no `/v1` request. Reset the stored `renewcms-language` between tests. Do not freeze the system date.
1. UserMenu (desktop) and AccountMenuSheet (mobile): open the menu and assert the entry order Profile, separator, "Theme" label, System/Light/Dark, separator, "Language" label, English/Français, separator, Log out. Assert the label classes. LanguagePicker and any combobox must be absent.
2. Roles and ARIA: theme rows and language rows are menuitemradio with aria-checked on the current one and a check icon. Language rows carry lang "en"/"fr" and native names. With locale fr the names stay "English"/"Français" while "Theme"/"Language" become "Thème"/"Langue".
3. Account menu selection: choosing Français in each surface switches the visible copy, sets document lang and storage, keeps the menu open, and leaves route, theme and an unsaved display-name draft on /profile unchanged. Choosing English restores it. Choosing a theme keeps the mobile sheet open.
4. Account menu keyboard: arrow order and wrap across all entries, Enter/Space applies and keeps open, Escape and outside click close with no language change.
5. AuthShell: the footer is rendered with the language chip next to UColorModeSelect when belowSm is true and false, with no footer slot content, and slot content stays to the left. Assert aria-haspopup, aria-expanded, aria-label "Language: English" / "Langue : Français", the icon, the native name and the absence of a select.
6. Auth popover: opens via click, Enter, Space and ArrowDown; role menu named "Language", two menuitemradio rows with lang and checked state; selection applies the language, closes it and returns focus to the chip; Escape and outside click dismiss with no change. Typed form values on /login survive the switch.
7. Each auth screen (login, register, pending, verify, forgot-password, reset-password, accept-invite) mounts with the chip present.
8. Persistence: stored fr gives chip "Français"; the choice survives log out and re-render of /login; a localStorage write failure still switches for the session.
9. Catalog parity: en/fr keys include "Theme" and "Language: {0}" with matching parameters.
10. Update web/src/i18n/spa.spec.ts, web/src/i18n/i18n.spec.ts and any AuthShell, UserMenu or AccountMenuSheet spec asserting menuitemcheckbox or the old picker. Remove LanguagePicker and its tests if the component is removed.
11. Run task test:web and the type check; inspect the diff for introduced comments.
## Visual (`task visual:check -- <screen>`, hard gate at 10 %)
Desktop and mobile, light and dark, reusing the boards' sample data.
- profile, state "Account menu": board `deskMenu` and `mobMenu` with the Theme and Language labels, Light and English checked.
- Every auth screen and state (log-in, register, pending, verify, forgot-password, reset-password, accept-invite): all captures change because of the language chip (`hasFooter: true`), including mobile where the footer is new. Clock-sensitive states stay `skip: 'clock-sensitive'`.
- The boards draw no open auth language popover, so it has no visual gate. It is covered by the automated and manual checks.
## Manual (screenshots cannot cover)
- Keyboard focus order and visible focus ring in the account menu, the chip and the popover; focus return to the chip.
- Hover, press and motion on the rows and the chip.
- Popover placement above the chip and containment at 390 px width, including the 36 px offset next to the 44 px mobile chip. Touch targets at 44 px on mobile.
- French readability of "Thème", "Langue" and "Langue : Français" in the labels, chip and popover.
- Language retained after reload and logout.
+75
View File
@@ -0,0 +1,75 @@
Feature: English and French throughout the SPA
Background:
Given all existing SPA interface text supports English and French
And English preserves existing copy and French provides equivalent meaning
And user content, API data and transactional emails remain unchanged
And the language control follows features/language_switcher_conformance.feature
Scenario Outline: Resolve the language before rendering
Given the browser-local stored language is <stored>
When the SPA starts
Then the interface language and document lang are <locale>
And browser language does not override the choice
Examples:
| stored | locale |
| absent | en |
| en | en |
| fr | fr |
| unsupported | en |
| unreadable | en |
Scenario Outline: Offer the language choice in the account menu
Given the user opens the <menu>
Then a localized Language section offers English and Français as radio items
And the selected language is visibly and accessibly identified
Examples:
| menu |
| desktop UserMenu |
| mobile AccountMenuSheet |
Scenario: Switch language without losing work
Given the user is editing an unsaved display name on /profile
When they select Français
Then all SPA interface text immediately uses French
And the document lang is fr
And the route, session, theme and unsaved work remain unchanged
And no reload, navigation or API request is caused by switching
When they select English
Then the interface immediately restores English with the same preserved state
Scenario: Remember language on this browser
Given the user selected Français
When they navigate, reload, log out or return on this browser
Then French remains selected including on public authentication screens
And no language preference is sent to the server
Scenario: Storage failure does not prevent switching
Given preference storage cannot be written
When the user selects Français
Then French is used for the current session without an error
And a fresh load without a readable preference defaults to English
Scenario: Translate the entire interface
Given French is selected
When an existing SPA screen or shared component renders
Then navigation, forms, validation, notifications, dialogs and accessibility labels use French
And counts, human-readable dates and numbers use the selected locale
And Nuxt UI controls use the selected locale
And English and French catalogs have matching keys and interpolation parameters
And an unavailable French message falls back to English
And user content, account details, filenames, URLs, API data and emails remain unchanged
Scenario Outline: Operate the language choice accessibly
Given the <menu> is open
When the user navigates the language items with the keyboard and confirms a choice
Then the language changes and the menu stays open
When they press Escape or click outside
Then the menu closes without changing language
Examples:
| menu |
| desktop UserMenu |
| mobile AccountMenuSheet |
+19
View File
@@ -0,0 +1,19 @@
# SPA internationalization QA
Accepted by the user on 2026-10-03 together with the slice specification.
## Automated
1. Verify absent, English, French, unsupported and unreadable stored preferences; English defaults independently of browser language and document lang follows selection.
2. Verify desktop UserMenu and mobile AccountMenuSheet offer a localized Language section with English and Français radio items, selected-state semantics, selection with the menu staying open, and dismissal. Preserve profile, theme and logout behavior. Details live in features/language_switcher_conformance.qa.md.
3. Switch both ways while editing an unsaved profile display name. Verify translated UI and unchanged draft, route, session and theme without additional API requests.
4. Verify browser-local persistence across reload initialization, navigation and logout/public authentication. Verify storage write failure allows switching for the current session.
5. Preserve existing English tests and add French checks for login, validation, profile save failure, integration copy feedback, not-found, representative dialogs and notifications.
6. Audit every existing view, shared component, composable and library producing interface text, including editor, media, users, invitations, settings and updates. Verify Nuxt UI controls use the active locale.
7. Assert catalog key/interpolation parity, nonempty translations, pluralization, English fallback and locale-sensitive formatting. Use fixed input dates without freezing system time. Verify displayed alerts and dialogs react to language changes.
8. Verify user content, account details, filenames, URLs, API fields, integration protocol examples, server release notes and transactional emails remain unchanged.
9. Run task test:web, frontend type checks, applicable lint and final build checks. Inspect introduced comments and ensure application changes are SPA-only.
## Visual and manual
The language control now has an official design. Its visual and manual checks live in features/language_switcher_conformance.qa.md. For the rest of this slice, confirm French text readability and language retention after reload and logout. Do not freeze dates or investigate clock-sensitive states.
+334
View File
@@ -0,0 +1,334 @@
Feature: Updates part 2: the Update button (download, verify, stage)
As the owner of a RenewCMS site
I want one button that downloads the new release, proves it is genuine, backs up the database and stages it
So that the later Restart (slice 3) installs a file that was already checked, while the site stays online
Background:
Given slices 1 to 3 of Updates ship in one release
And this slice changes nothing that is running: it never replaces the running binary and never restarts the site
And the domain package internal/domain/update (stdlib only) gains these interfaces, each faked in tests:
AssetFetcher (downloads one asset to a path, reporting bytes done and total),
SignatureVerifier (ed25519 check of checksums.txt against checksums.txt.sig with the embedded release.pub),
StagedBinaryRunner (runs <path> --version and returns its output),
DatabaseBackup (consistent copy of the SQLite file with VACUUM INTO, prune to the last 3),
HelperDetector (reports whether the slice 3 helper is installed),
JobStore (persists the update job record)
And update.Release gains Assets (name, download URL, size) read by the Gitea adapter, and the stored CheckResult keeps
them, so POST /v1/system/update/download never contacts the feed
And the use cases depend only on domain interfaces; handlers in api/handlers/update receive them through NewHandler;
only api/dependecyInjection.go builds the adapters
And the job runs in one background goroutine owned by the use case; the HTTP handler returns as soon as it is started
And POST /v1/system/update/download is mounted in NewSystemRouter behind jwtauth.Verifier, jwtauth.Authenticator,
RequireCurrentToken, RequireVerifiedUser, RequireOwner and its own limiter of 5 starts per minute per user_id
(constants, separate from the check limiter and the auth limiter) answering 429 with an integer Retry-After
And the checks on POST run in this order: no cookie or stale token (401), unverified (403), not owner (403),
limiter (429), can_apply false (409), a job running or already ready (409), available false (400),
pre-flight refusal (422), then 202
And errors are plain text from http.Error
And the data directory is the directory that holds DB_FILE; no new env var is added
And the job record is update-job.json in the data directory, shared by all owners and surviving a restart
And a job record found as "downloading" or "verifying" at startup (no goroutine owns it) reads as failed with
error "download"; a record "ready" whose staged binary is gone reads as idle
And the staged files live in <data dir>/updates/<tag>/: the binary, checksums.txt and checksums.txt.sig
And the asset to download is named renewcms_<tag>_<runtime.GOOS>_<runtime.GOARCH>, plus ".exe" on windows
And the job runs these steps in order: download checksums.txt, checksums.txt.sig and the binary; verify the
ed25519 signature of checksums.txt; verify the SHA-256 of the binary against its checksums.txt line; run the
staged binary with --version and require the output to equal the tag; back up the database; mark "ready"
And state is "downloading" during the downloads and "verifying" from the signature check until "ready"
(the version run and the backup happen in "verifying")
And the download policy, enforced in the production adapter: the URL must be https, its host (with port) must equal
the host of UPDATE_FEED_URL, and every redirect must satisfy the same rule; there is a size cap per file
(binary 200 MiB, checksums.txt 64 KiB, checksums.txt.sig 1 KiB) and an overall timeout of 10 minutes (named constants)
And in tests the policy is relaxed only through the adapter constructor, which takes the allowed host, an
"allow insecure scheme" option, a smaller cap and a shorter timeout; there is no env var or build flag that relaxes it
And GET /v1/system/update keeps its 12 keys; state is one of idle, downloading, verifying, ready, failed;
progress is {percent, downloaded_bytes, total_bytes} while downloading and null otherwise;
error is null, "download" or "verification" (a kind only, never technical text); started_at is the job start
And can_apply is true only for the owner when HelperDetector reports the helper installed; it is false for admins
And the real HelperDetector reads <data dir>/update-helper.json (the status file the slice 3 helper writes); nothing
writes it in this slice, so can_apply is false on real builds until slice 3
And disk errors and database backup failures end the job as failed with error "download"
And on any failure the staged files are deleted, the technical reason is logged server side, and no response carries it
And a failed record stays until the next job starts; ready stays until slice 3 consumes it
And the SPA shows the newer release without its leading "v" ("Version 2.3.0-beta") and the running version exactly as reported
And the Restart button in "Ready to install" is rendered but disabled in this slice: the board frame draws it as the
primary action, it has no handler, and slice 3 enables it; plain Restart (no update waiting) stays not rendered until slice 3
Scenario: Start the update, happy path
Given the owner, can_apply true, a stored result with latest "v2.3.0-beta" (running "v2.2.0-beta", available true)
and assets for the host platform, all served by the fake fetcher and signed with a throwaway key
When the owner sends POST /v1/system/update/download
Then the status is 202 and the body is the status JSON with state "downloading" and started_at set
And GET /v1/system/update then reports downloading with progress.total_bytes equal to the asset size
And when the job finishes GET reports state "ready", error null, progress null, latest "v2.3.0-beta"
And the staged binary, checksums.txt and checksums.txt.sig are in <data dir>/updates/v2.3.0-beta/
And a database backup exists in <data dir>/backups/ before state became "ready"
And the running binary and the database are unchanged
Scenario Outline: The asset name follows the platform
Given the runtime is <os>/<arch> and the release lists all six binaries
When the update starts
Then the fetcher is asked for "<asset>", "checksums.txt" and "checksums.txt.sig" only
Examples:
| os | arch | asset |
| linux | amd64 | renewcms_v2.3.0-beta_linux_amd64 |
| linux | arm64 | renewcms_v2.3.0-beta_linux_arm64 |
| darwin | arm64 | renewcms_v2.3.0-beta_darwin_arm64 |
| windows | amd64 | renewcms_v2.3.0-beta_windows_amd64.exe |
Scenario: Progress is reported in bytes
Given the fake fetcher has delivered 11 of 26 MiB
When any verified user sends GET /v1/system/update
Then state is "downloading" and progress is {percent: 42, downloaded_bytes: 11534336, total_bytes: 27262976}
And percent is the floor of done * 100 / total
Scenario: Every owner sees the same job
Given owner A started the job
When owner B and an admin send GET /v1/system/update
Then both read state "downloading" with the same progress and started_at
And the owner's can_apply is true and the admin's can_apply is false
Scenario: The job record survives a restart
Given the job is "ready" for "v2.3.0-beta" with its staged binary present
When a new status use case is built over the same data directory
Then GET reports state "ready"
And a record "downloading" at startup reads as state "failed", error "download"
And a record "ready" with the staged binary deleted reads as "idle"
And a missing or corrupt job file reads as "idle" and is not fatal
Scenario: Only the owner
When an admin sends POST /v1/system/update/download
Then the status is 403 and the body is apperr.OwnerRequiredErrorMessage
And no job starts and the fetcher is not called
Scenario Outline: POST is guarded like the other system routes
When <caller> sends POST /v1/system/update/download
Then the status is <status>
And no job starts
Examples:
| caller | status |
| no jwt cookie | 401 |
| a stale token version | 401 |
| an unverified owner | 403 |
Scenario: Nothing to update
Given a stored result with available false, or no stored result
When the owner sends POST /v1/system/update/download
Then the status is 400 and no job starts and the fetcher is not called
Scenario: The server is not prepared
Given HelperDetector reports no helper
When the owner sends POST /v1/system/update/download
Then the status is 409 and no job starts
And GET reports can_apply false
And this holds even when available is false (409 before 400)
Scenario Outline: A second start while a job exists
Given the job state is <state>
When the owner sends POST /v1/system/update/download
Then the status is 409 and the existing job is untouched
Examples:
| state |
| downloading |
| verifying |
| ready |
Scenario: Two starts at once run one job
When two owners send POST /v1/system/update/download concurrently
Then exactly one answers 202 and the other 409
And the fetcher downloads each asset once
Scenario: Try again after a failure
Given the job state is "failed"
When the owner sends POST /v1/system/update/download
Then the status is 202, error returns to null, started_at is new and the old staged files are replaced
Scenario: Start is rate limited per user
When the owner sends 6 starts within one minute
Then the first 5 are answered by the checks above and the 6th is 429 with apperr.TooManyRequestsErrorMessage
and an integer Retry-After of at least 1
And a different owner is not limited, and the check limiter and auth limiter counters are untouched
Scenario Outline: 422 is only a pre-flight refusal
Given a stored result where <condition>
When the owner sends POST /v1/system/update/download
Then the status is 422 and the body is plain text without technical detail
And no job starts, the fetcher is not called and the technical reason is logged
Examples:
| condition |
| no asset is named for the host platform |
| checksums.txt or checksums.txt.sig is missing from the assets |
| an asset URL is http, not https |
| an asset URL is on a host other than UPDATE_FEED_URL's host |
Scenario Outline: Verification failures end the job as failed, kind "verification"
Given a started job and <fault>
When the job reaches the check
Then GET reports state "failed", error "verification", progress null
And <data dir>/updates/<tag>/ is deleted
And the technical reason is logged and appears in no response body
Examples:
| fault |
| the binary was changed after signing (SHA-256 mismatch) |
| checksums.txt was changed after signing |
| the signature is from a different key |
| checksums.txt has no line for the asset |
| the staged binary prints "v2.2.9-beta" for --version |
| the staged binary cannot be run |
Scenario Outline: Download and disk failures end the job as failed, kind "download"
Given a started job and <fault>
Then GET reports state "failed", error "download"
And <data dir>/updates/<tag>/ is deleted and the technical reason is logged, not returned
Examples:
| fault |
| the connection drops after half the bytes (truncated download) |
| the bytes received differ from the size the release declares |
| a file exceeds its size cap |
| the download passes the overall timeout |
| the feed host answers 404 or 500 for an asset |
| the updates directory cannot be created or written (disk error) |
| the disk fills during the write |
| the database backup fails |
Scenario: The backup comes before ready, and the last 3 are kept
Given the backups directory holds 3 earlier backups
When a job completes
Then a new consistent copy exists (opened read-only it holds the same article rows as the live file)
And only the 3 newest backups remain, the oldest being deleted
And no job is "ready" until the new backup exists
And a failed backup leaves state "failed", error "download" and does not prune the earlier backups
Scenario: The production download policy
Given the production adapter with UPDATE_FEED_URL "https://git.example"
Then an http:// asset URL, an https URL on another host, and a redirect to another host or to http are refused
And an https URL on git.example is accepted
Scenario: A server --version flag
When the server binary is run with --version
Then it prints the build version and exits 0
And it does not read .env, open the database or start listening
And with no -ldflags version it prints "dev"
Scenario: Settings, owner, Update available with the helper detected (route /settings)
Given the owner and GET /v1/system/update resolves available true, can_apply true, state "idle", latest "v2.3.0-beta"
Then the block shows icon circle-arrow-up (info), "Version 2.3.0-beta is available" /
"You have v2.2.0-beta. Update downloads the new version and checks it. Nothing changes until you restart."
and the meta "Last checked ..."
And the notes button "What's new in 2.3.0-beta" is collapsed, and when open shows "Released 24 Sep 2026" and the list
And the one button is "Update" (download, primary) and the hint is "Takes about 2 minutes. Your site stays online."
And no server command, no "How to update" link, no Restart and no "Check for updates" is rendered
Scenario: Settings, owner, Downloading
When the owner presses "Update" and POST /v1/system/update/download answers 202
Then the block shows icon download (info), "Downloading version 2.3.0-beta…" /
"You can leave this page. The download continues and your site stays online."
And a progressbar labelled "Downloading version 2.3.0-beta" has aria-valuenow equal to progress.percent
and the text "42% · 11 of 26 MB"
And the button reads "Updating…" (loader-circle, secondary) and is disabled
And GET /v1/system/update is polled every second while state is downloading or verifying
Scenario: Settings, progress is announced at 25 percent steps only
Given the polled percent goes 3, 9, 24, 25, 26, 49, 50, 74, 75, 99, 100
Then the announcer text changes only at 25, 50, 75 and the step change, reading
"Downloading version 2.3.0-beta, 25 percent" and so on
And the visible text and aria-valuenow still update on every poll
And the live region does not announce the per-tick text
Scenario: Settings, owner, Verifying
Given the poll answers state "verifying"
Then the block shows icon shield-check (info), "Checking the download…" /
"Making sure the file is complete and safe to install. This takes a few seconds."
And the progressbar is indeterminate (no aria-valuenow, a 35% wide moving bar) labelled "Checking the download"
with the text "Almost there"
And the button reads "Updating…" and is disabled
And "Checking the download" is announced once, when the step changes
Scenario: Settings, owner, Ready to install
Given the poll answers state "ready"
Then polling stops
And the block shows icon clock (warning tone) with a "Pending" tag after the title, "Version 2.3.0-beta is ready to install" /
"The download is checked. Restart to install it. Your site will be unavailable for about 10 seconds." /
"Nothing has changed yet."
And the notes button is shown collapsed
And the Restart button (power, primary) is rendered with disabled set and 40% opacity, and activating it does nothing
And the hint is "Not now? Leave this page. The update waits here, and the banner on Home reminds you."
And no dialog, overlay or POST /v1/system/update/restart exists
Scenario: Settings, Download failed
Given the poll answers state "failed" with error "download", or POST download answers 500 or never reaches the server
Then focus moves to the "Updates" heading (id="updates-h")
And the block shows icon circle-x (error), "The download didn't finish" /
"The connection dropped before the file was complete. Nothing was changed and your site is running as before."
And the one button is "Try again" (rotate-cw, primary), which sends POST /v1/system/update/download
Scenario: Settings, Verification failed
Given the poll answers state "failed" with error "verification", or POST download answers 422
Then the block shows icon triangle-alert (warning), "We didn't use this update" /
"The file didn't pass our safety check, so it was not installed. Nothing was changed. Try downloading it again. If this keeps happening, contact RenewCMS support."
And the one button is "Try again" (rotate-cw, primary), as the board frame draws it
And focus does not move to the heading
And no technical detail is on screen
Scenario: Settings, 409 already running
Given POST /v1/system/update/download answers 409 and the reload answers state "downloading" or "verifying"
Then an info toast "An update is already running" / "Another owner started it. Progress shows here." shows
And the card switches to that run's progress and polls
When the reload instead answers can_apply false
Then the card shows the "Not prepared" state and no toast
When the reload instead answers state "ready"
Then the card shows "Ready to install" and no toast
Scenario: Settings, 400 nothing to update
Given POST /v1/system/update/download answers 400
Then an info toast "Nothing to update" / "You already have the latest version." shows
And the card reloads GET /v1/system/update
Scenario: Settings, 403 role changed on Update
Given POST /v1/system/update/download answers 403
Then an error toast "Only the owner can do this" / "Ask the owner of this site to update RenewCMS." shows
And the card reloads and renders the admin view
Scenario: Settings, 429 on Update
Given POST /v1/system/update/download answers 429 with Retry-After 42
Then the block shows icon info "Too many tries" / "Wait a moment before trying again."
And the button reads "Try again in 0:42" (clock, disabled) and counts down each second through useRetryAfter
And at zero it is re-enabled as "Try again" and pressing it sends POST /v1/system/update/download again
Scenario: Settings, reload keeps progress
Given a job is downloading and the owner leaves /settings
Then polling stops and the job continues on the server
When the owner opens /settings again, from this or another device
Then GET /v1/system/update is read on open and the card shows the job's current state and progress
And polling resumes while state is downloading or verifying
Scenario: Settings, a poll that fails keeps the card
Given a poll answers 500 or never reaches the server while downloading
Then the card keeps its last progress, no failure card shows, and polling continues each second
Scenario: Settings, admin view during a job
Given the session role is "admin" and state is "downloading"
Then the admin view of slice 1 shows ("Version 2.3.0-beta is available" / "You have v2.2.0-beta. Only the owner can update RenewCMS. Ask the owner of this site.")
And no button, progressbar or poll is rendered
Scenario: Home banner, ready to install (owner)
Given the owner is on /home and state is "ready"
Then a region labelled "Update available" shows above the content in info tone (as the board frame draws it)
with icon circle-check, title "Version 2.3.0-beta is ready to install",
text "Restart from Settings to finish. The site is unavailable for about 10 seconds.",
a "Go to Settings" button that navigates to /settings, and a Dismiss button
And it shows although the "available" banner for this version was dismissed earlier
When the owner dismisses it
Then it hides for this visit only and shows again on the next visit, and nothing is written to localStorage
And an admin sees no banner; with state "downloading" or "verifying" the "available" banner shows as before
Scenario: Pending states for slice 3
Then these remain pending in the visual gate, never passing: Restart confirm, Restart request failed, Restarting to install,
Restarting taking longer, Update done, Rolled back, Plain restart (confirm, restarting, done)
+113
View File
@@ -0,0 +1,113 @@
# QA: Updates part 2 (download, verify, stage)
## Automated Go (`task test`, package `test`, black-box, no live network, no real SMTP)
Files: `test/update_download_test.go` (domain, use case), `test/update_download_http_test.go` (HTTP),
`test/update_assets_test.go` (production download adapter against a local server). Fakes with unique names:
`fakeAssetFetcher` (serves bytes, can truncate, stall, fail, counts calls), `fakeHelperDetector`, `fakeJobStore`,
`fakeStagedRunner` (returns a configured --version output or error), `fakeDatabaseBackup`; reuse `fakeReleaseFeed`,
`fakeUpdateStore` and `mockUserRepo` from the slice 1 tests.
HTTP setup: `validator.InitValidator()`; `token := jwtauth.New("HS256", []byte("test-secret"), nil)`; a fresh `chi.NewRouter()` at
`/v1/system` mirroring `NewSystemRouter` (Verifier, Authenticator, RequireCurrentToken, RequireVerifiedUser; the download
route also RequireOwner and its limiter, 5 per minute); cookies as in `test/stale_token_invalidation_http_test.go`.
Job state, staged files and backups go in `t.TempDir()`. Wait for the job with a poll loop on GET (deadline 5 s), never a bare
`time.Sleep`. Use a throwaway ed25519 key generated in the test and sign `checksums.txt` with it; never read the committed
`release.pub`.
Local asset server: `httptest.NewServer` (plain HTTP) and `httptest.NewTLSServer` for the policy cases. The production adapter is
built through its constructor with the test's allowed host, allow-insecure true for the plain server, the TLS server's client for
the TLS cases, a small size cap and a short timeout. Never relax the policy by env var or build flag.
1. Happy path: owner POST gives 202 with state "downloading"; poll GET until "ready"; files in `updates/<tag>/`, one backup in
`backups/`; running binary unchanged; the fetcher was asked for exactly the three asset names.
2. Asset naming table over GOOS/GOARCH (including the `.exe` case). Inject the platform into the use case; never assert on the
test machine's own platform.
3. Progress: a fetcher paused at 11 of 26 MiB gives `{percent:42, downloaded_bytes, total_bytes}` on GET; `progress` is null in
verifying, ready and failed; `error` is null until a failure.
4. Shared state: GET as owner A, owner B and admin agree; admin `can_apply` false, owner true with the fake detector on.
5. Persistence: JSON job store round trip in a temp dir; "downloading" at startup reads failed/"download"; "ready" with the staged
binary deleted reads idle; a missing or corrupt file reads idle without error. The real helper detector reads
`<data dir>/update-helper.json`: absent file gives false, a present valid file gives true.
6. Guards: admin 403 with `apperr.OwnerRequiredErrorMessage+"\n"`; no cookie 401; stale token 401; unverified 403; none start a job.
7. Status codes: available false or nothing stored gives 400; detector off gives 409; state downloading, verifying, ready each give
409; after "failed" a new POST gives 202 with a new started_at. Order check: detector off and available false gives 409.
8. Concurrency: two simultaneous POSTs (goroutines) give one 202 and one 409; each asset fetched once (run with `-race`).
9. Rate limit: owner A sends 6 POSTs within a minute; the 6th is 429 with `apperr.TooManyRequestsErrorMessage+"\n"` and an integer
Retry-After >= 1; owner B is unaffected; the check limiter and a login limiter built in the test are untouched.
10. 422 pre-flight: each of the four conditions in the feature gives 422, the body is plain text with no URL, host or file name from
the fixture, no job record is created, fetcher count is 0, and the reason is captured from an injected logger.
11. Verification failures, one subtest per row, each ending with GET `state` "failed", `error` "verification", `updates/<tag>/`
removed, a body free of the fault text, and the fault text present in the injected logger: tampered binary, tampered
checksums.txt, signature from another key, no checksum line for the asset, wrong `--version` output, runner error.
12. Download failures, one subtest per row, each ending "failed", `error` "download", directory removed: truncated body, size
mismatch with the release, over the size cap, timeout (server stalls; adapter timeout shortened), 404/500, unwritable updates
directory (a file placed where the directory should be), disk full (a writer fake returning an error mid-write), backup failure
(earlier backups not pruned).
13. Backup: with the real SQLite backup adapter against a SQLite file created in `t.TempDir()` (pure-Go driver, `CGO_ENABLED=0`):
the copy opens and holds the same rows, four jobs leave only the 3 newest files, and a job is not "ready" before the copy exists.
14. Production policy: http URL, another host, redirect to another host and redirect to http are refused (no request reaches the
second server); the TLS server on the allowed host is accepted.
15. `--version`: build with `go build -tags nofrontend -ldflags "-X main.version=v9.9.9" ./cmd/server` into `t.TempDir()` and run
it with `--version` and an empty environment: stdout `v9.9.9`, exit 0, no `data/` created; without ldflags it prints `dev`.
16. Review items, not Go tests: `internal/domain/update` imports only the stdlib; use cases import no `net/http`, `os/exec`, `gorm`
or adapter; the handler imports no adapter; no secret value is in the repo; the helper detector reads only its status file.
## Automated SPA (Vitest + Vue Test Utils, `task test:web`)
Mock `useApi.request` for `GET /v1/system/update`, `POST /v1/system/update/check` and `POST /v1/system/update/download`. Fake timers
drive the 1 s poll and the countdown. No test freezes the system date and none asserts a relative date. Reuse the board's data:
running `v2.2.0-beta`, latest `v2.3.0-beta`, 26 MB total, 11 MB done (42 %), released 24 Sep 2026.
One test per state:
1. Update available, can_apply true: copy, notes collapsed, only "Update", hint; no command, no link, no Restart.
2. Update available, notes open (`aria-expanded`, "Released 24 Sep 2026").
3. Downloading: 202 then the card copy, progressbar label, `aria-valuenow` 42, "42% · 11 of 26 MB", "Updating…" disabled; GET called once per second.
4. Announcements: percents 3, 24, 25, 26, 49, 50, 75, 100; the announcer text changes only at 25, 50, 75 and the step change;
`aria-valuenow` changes on each tick.
5. Verifying: indeterminate bar (no `aria-valuenow`), "Almost there", announced once.
6. Ready: copy, meta, hint, Restart present with `disabled` and no request on click, notes button, polling stopped.
7. Download failed (state failed/download; a 500; a `NetworkError`): copy, focus on `#updates-h`, "Try again" posts download again.
8. Verification failed (state failed/verification; a 422): copy, "Try again", focus not moved, no technical text.
9. 409: reload downloading gives the info toast and progress; reload ready gives no toast and the Ready card; reload can_apply false
gives the Not prepared card.
10. 400: info toast "Nothing to update" and one GET.
11. 403: error toast and the admin view after reload.
12. 429: "Too many tries", "Try again in 0:42" counting down through `useRetryAfter`, re-enabled as "Try again" and it re-posts
download (not check).
13. Reload: unmount stops the poll; mount reads GET and resumes the poll for a running state; no poll for idle, ready or failed.
14. A failed poll keeps the last progress and keeps polling.
15. Admin with state downloading: admin copy, no button, no progressbar, no poll.
16. Home banner ready: info tone, copy, `role="region"` labelled "Update available", "Go to Settings" navigates, shows although the
available banner was dismissed, Dismiss hides until remount and writes nothing to localStorage; admin sees none.
17. Sidebar pill and mobile dot stay for ready, downloading and verifying (owner only, `available` true).
## Visual (`task visual:check -- settings` and `-- home`; desktop and mobile, light and dark; every capture within 10 %)
Add the setups to `web/visual/states.ts` with the board's sample data (v2.2.0-beta, v2.3.0-beta, 42 % / "11 of 26 MB"). Exact values
from `docs/design/source/AppFrame.dc.html` and the "Settings" and "Home" groups of the Screens board; layout as drawn.
- [ ] Settings: Update available, Update available (notes open), Downloading (42 %), Verifying, Ready to install,
Download failed, Verification failed. The frame draws an enabled Restart; the disabled one (40 % opacity) must still be
within budget. If it is not, stop and report; do not widen the budget or add an exception without the user's approval.
- [ ] Home: Update ready to install (owner), with the sidebar pill and the mobile dot as drawn.
- [ ] Settings: Update already running (409): the frame shows the card in progress; set up with the mocked 409 then the
downloading reload (the toast only if the frame draws it; check the markup).
- [ ] `skip: 'clock-sensitive'`: any state whose meta line is relative ("Last checked today at 09:41"), as in slice 1.
- [ ] Pending, never passing (slice 3): Restart confirm, Restart request failed, Restarting, Restarting taking longer,
Update done, Rolled back, Plain restart (confirm, restarting, done).
- [ ] Not covered by screenshots: keyboard and focus order, the focus ring on `#updates-h` after Download failed, the 25 %
announcements (screen reader), hover and motion of the indeterminate bar.
## Manual verification
- `can_apply` stays false on real builds until slice 3 writes `<data dir>/update-helper.json`: use the fake in tests, or place the
file by hand to see the Update button.
- Against a real signed release on the real feed host (needs `release.pub` replaced and `task release` signing): press Update, watch
progress, the Verifying step and the Ready card; check `<data dir>/updates/<tag>/` and one file in `<data dir>/backups/`.
- The real staged binary on the target OS runs `--version` and prints the tag.
- Flip one byte of a asset on a test mirror: the card shows "We didn't use this update" and the folder is gone.
- Kill the server mid-download and restart it: the card shows "The download didn't finish".
- Open the card in two browsers (two owners) and confirm the same progress; the second press shows the 409 toast.
- Embedded SPA build (no `-tags nofrontend`) serves /settings and /home with the new states.
- Confirm no secret or feed credential appears in logs, and that technical failure reasons are in the log only.
+292
View File
@@ -0,0 +1,292 @@
Feature: Updates part 1: signed releases, release feed and read-only update notification
As the owner of a RenewCMS site
I want to see when a newer signed release exists, and have admins see the same status read-only
So that I know when to update, while downloading and restarting arrive in later slices
Background:
Given slices 1 to 3 of Updates ship in one release, so no released build shows the command
"renewcms enable-browser-updates" before it exists (it is implemented in slice 3)
And every release is published as a Gitea prerelease with the six binaries, checksums.txt and checksums.txt.sig
And cmd/releasesign is a stdlib-only tool (crypto/ed25519, no new dependency) with the commands
keygen <private-key-path> [--pub-out <path>], sign <file> [--key <path>] [--pub <path>],
verify <file> [--pub <path>]
And keygen writes the private key to the path given and refuses a path inside the repository work tree
And sign and verify use the embedded public key unless --pub is given; tests always pass --pub with a throwaway key
And sign refuses to sign when the private key does not match the public key, naming the mismatch
And the public key is internal/infrastructure/update/release.pub, embedded with go:embed
And until the user runs task release:keygen and commits the real public key, release.pub holds the placeholder:
the base64 of 32 zero bytes (AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=); an all-zero key is recognised
as the placeholder, and sign and verify refuse it with a clear message
And the real private key is generated by the user outside the repo; the coder never generates or commits it
And task release writes checksums.txt (SHA-256 of every binary) next to the binaries and signs it into
checksums.txt.sig with the private key at the path in the env var RELEASE_SIGNING_KEY
And task release fails clearly, before building anything, when RELEASE_SIGNING_KEY is unset, the file is missing,
the embedded key is the placeholder, or the private key does not match the embedded public key
And task release:keygen creates the one-time key pair and prints where to commit the public key
And docs/release-notes.md gains the publish step (attach checksums.txt and checksums.txt.sig with the six binaries),
docs/deployment.md and docs/configuration.md are updated, and nothing is published
And the domain package internal/domain/update (stdlib only) holds Release, ReleaseNotes, version comparison,
UpdateStatus, the ReleaseFeed interface, the StatusStore interface and the Err sentinels
And the Gitea adapter lives under internal/infrastructure/update and implements update.ReleaseFeed with
var _ update.ReleaseFeed = &X{}; it requests GET {UPDATE_FEED_URL}/api/v1/repos/fsylvain/RenewCMS/releases
(the list, not "latest")
And UPDATE_FEED_URL is in requiredEnvVars/envDefaults, .env.example and docs/configuration.md, defaulting to the repo base URL
And a JSON file store implements update.StatusStore and keeps the last result and checked_at in update-status.json
beside DB_FILE, shared by all owners and surviving a restart; no new env var is added
And GetUpdateStatusUseCase and CheckForUpdateUseCase depend only on the domain interfaces; handlers in
api/handlers/update receive them through NewHandler; api/dependecyInjection.go builds the adapters
And NewSystemRouter is mounted at /v1/system behind jwtauth.Verifier, jwtauth.Authenticator, RequireCurrentToken
and RequireVerifiedUser; POST /update/check also sits behind RequireOwner and a limiter of 5 checks per minute
per user_id (constants, not env vars, separate from the auth limiter) that answers 429 with an integer Retry-After
And GET /v1/system/update returns 200 with JSON of exactly these snake_case keys: current, latest, available,
release_url, notes {version, released_at, items}, checked_at, can_apply, state, progress, error, started_at
And release_url is the release's html_url, null when never checked; in slice 3 the "How to update" link is
repointed at the "Browser updates" section of docs/deployment.md
And in this slice can_apply is always false and state is always "idle"; never-checked values are latest "",
available false, release_url null, notes null, checked_at null, progress null, error null, started_at null
And versions compare numerically per segment, a final release beats a beta of the same number, and the
running build "dev" never reports an update
And release notes are the release body converted to a plain-text list of items
And the API returns raw tags; the SPA shows the newer release without its leading "v" ("Version 2.3.0-beta")
and the running version exactly as reported
And the download and restart endpoints are not mounted; ReleaseFeed, StatusStore and UpdateStatus are shaped so
slices 2 and 3 only add use cases
And errors are plain text from http.Error
Scenario Outline: Version comparison
Given the running version is "<current>" and the newest feed release is "<latest>"
When the versions are compared
Then available is <available>
Examples:
| current | latest | available |
| v2.2.0-beta | v2.3.0-beta | true |
| v2.5.0-beta | v2.5.0 | true |
| v2.5.0 | v2.5.0-beta | false |
| v2.9.0 | v2.10.0 | true |
| v2.5.0-beta | v2.5.0-beta | false |
| v2.5.0 | v2.4.9 | false |
| dev | v9.9.9 | false |
Scenario: The newest release is chosen from the list regardless of feed order
Given the feed list holds v2.4.0-beta, v2.5.0-beta and v2.3.0-beta, all marked prerelease
When the feed is read
Then the latest release is v2.5.0-beta
Scenario: Drafts are ignored
Given the feed list holds a draft release v9.0.0 and a published v2.5.0-beta
When the feed is read
Then the latest release is v2.5.0-beta
Scenario: Release notes become a plain-text list
Given a release body "## What's new\n- **Media** library\n- Fixed [caching](http://x) bug\n\n* Faster start"
When the notes are built
Then notes.items is ["Media library","Fixed caching bug","Faster start"]
And notes.released_at is the release's published date
Scenario: GET returns the idle shape, never applicable
Given a verified user, running version "v2.2.0-beta", and a stored result with latest "v2.3.0-beta",
html_url "https://git.example/fsylvain/RenewCMS/releases/tag/v2.3.0-beta" and checked_at 2026-09-30T09:41:00Z
When the client sends GET /v1/system/update
Then the status is 200 and the body has exactly the 12 keys
And current is "v2.2.0-beta", latest is "v2.3.0-beta", available is true, can_apply is false, state is "idle"
And release_url is the stored html_url and checked_at is "2026-09-30T09:41:00Z"
And the feed is not contacted
Scenario: GET before any check
Given no stored result
When a verified user sends GET /v1/system/update
Then the status is 200, available is false, latest is "", release_url, notes and checked_at are null, state is "idle"
Scenario Outline: GET is open to any verified user
Given the caller is <role> with a valid jwt cookie
When the client sends GET /v1/system/update
Then the status is 200
Examples:
| role |
| owner |
| admin |
Scenario: GET without a cookie
When the client sends GET /v1/system/update with no jwt cookie
Then the status is 401
Scenario: GET with a stale token
Given the jwt cookie was minted with a token version older than the account's
When the client sends GET /v1/system/update
Then the status is 401 and the body is apperr.UnauthorizedErrorMessage
Scenario: GET by an unverified account
When an unverified user with a valid cookie sends GET /v1/system/update
Then the status is 403 and the body is apperr.VerificationRequiredErrorMessage
Scenario: The owner checks and the result is stored
Given the fake feed returns v2.3.0-beta and the running version is "v2.2.0-beta"
When the owner sends POST /v1/system/update/check
Then the status is 200 with the same body shape as GET and available true
And the fake store holds latest "v2.3.0-beta" and checked_at at the check time
And a later GET returns the same result without contacting the feed
Scenario: A check with nothing newer
Given the feed returns v2.2.0-beta and the running version is "v2.2.0-beta"
When the owner sends POST /v1/system/update/check
Then the status is 200 and available is false
Scenario: A dev build never reports an update
Given the running version is "dev" and the feed returns v9.9.9
When the owner sends POST /v1/system/update/check
Then the status is 200 and available is false
Scenario: An admin cannot check
Given the caller is an admin
When the client sends POST /v1/system/update/check
Then the status is 403 and the body is apperr.OwnerRequiredErrorMessage
And the feed is not contacted
Scenario: Feed failure keeps the last result
Given the store holds latest "v2.3.0-beta" checked at 2026-09-30T09:41:00Z and the feed returns an error
When the owner sends POST /v1/system/update/check
Then the status is 500
And the store still holds the previous result and checked_at
And no feed error detail appears in the body
Scenario: Check is rate limited per user
When the owner sends 6 checks within one minute
Then the first 5 answer 200 and the 6th answers 429 with apperr.TooManyRequestsErrorMessage and an integer Retry-After
And the feed is contacted 5 times
And a different owner is not limited by the first owner's checks
And the auth limiter's counters are untouched
Scenario: The stored result survives a restart
Given the JSON file store saved a result
When a new store is opened on the same file
Then the same latest, release_url and checked_at are returned
And a missing or corrupt file reads as "no result" and is not fatal
Scenario: Release signing round trip with a throwaway key
Given a key pair made by keygen at a path outside the repo
When sign is run on checksums.txt with that key and verify with its public key
Then verify exits 0
And after one byte of checksums.txt changes, verify exits non-zero with a clear message
And verify with a different public key exits non-zero
Scenario: keygen refuses a path inside the repository
When keygen is given a path inside the work tree
Then it exits non-zero, writes nothing and says why
Scenario: The placeholder public key is refused
Given release.pub holds the placeholder (32 zero bytes, base64)
When sign or verify uses the embedded key
Then it exits non-zero with a message that the placeholder key has not been replaced
Scenario: sign refuses a private key that does not match the public key
Given a private key whose public half differs from the public key in use
When sign is run
Then it exits non-zero naming the mismatch and writes no .sig file
Scenario Outline: task release refuses to sign
Given <condition>
When task release is run
Then it fails before building any binary with a message naming <what>
And nothing is published
Examples:
| condition | what |
| RELEASE_SIGNING_KEY is unset | RELEASE_SIGNING_KEY |
| RELEASE_SIGNING_KEY points to a missing file | the missing path |
| the embedded public key is the placeholder | the placeholder key |
| the private key does not match the public key | the key mismatch |
Scenario: Settings, owner, Up to date (route /settings)
Given the session role is "owner" and GET /v1/system/update resolves available false with checked_at set
When the owner opens /settings
Then the Updates card shows the status block with icon circle-check (success), title "You're up to date",
text "You have the latest version of RenewCMS." and a meta line "Last checked ..." built from checked_at
And the only button is "Check for updates" (refresh-cw, secondary)
And no Restart button, hint or progress is rendered
Scenario: Settings, owner, Checking
When the owner presses "Check for updates"
Then the block shows icon loader-circle, "Checking for updates…" / "This usually takes a few seconds."
in a polite live region
And the button reads "Checking…" and is disabled
And POST /v1/system/update/check is sent once
Scenario: Settings, owner, Check failed
Given POST /v1/system/update/check answers 500 or never reaches the server
Then the block shows icon wifi-off (warning), "Couldn't check for updates" /
"RenewCMS couldn't reach the update server. Check your connection and try again. Your site isn't affected."
and the meta "Last checked ..." from the kept result
And the only button is "Try again" (rotate-cw, primary)
Scenario: Settings, owner, newer version, not prepared
Given the session role is "owner" and GET /v1/system/update resolves available true, can_apply false, latest "v2.3.0-beta"
When the owner opens /settings
Then the block shows icon info, "Version 2.3.0-beta is available" /
"This site can't update itself from the browser yet. Whoever manages your server can set it up once, or update RenewCMS for you."
And "For whoever manages the server" shows the one-line code "renewcms enable-browser-updates" with a Copy button
And the note "They run this once on the server. After that, Update and Restart appear here." shows
And the link "How to update" (arrow-up-right) opens release_url in a new tab
And no button other than Copy is rendered: not Update, not Restart, not even Check for updates
Scenario: Settings, owner, newer version, notes open
Given the same state with notes.items and notes.released_at 2026-09-24
When the owner activates "What's new in 2.3.0-beta" (a button with aria-expanded false then true)
Then "Released 24 Sep 2026" and the plain-text list show, and activating it again collapses them
And the notes are collapsed by default
Scenario: Settings, command copied
When the owner presses Copy
Then the button reads "Copied" with a check for 2 s, is announced, then reads "Copy" again
Scenario: Settings, admin view
Given the session role is "admin"
When GET /v1/system/update resolves available true with latest "v2.3.0-beta"
Then the card shows "Version 2.3.0-beta is available" /
"You have v2.2.0-beta. Only the owner can update RenewCMS. Ask the owner of this site." and no button
When it resolves available false
Then the card shows "You're up to date" / "Only the owner can update or restart the site." and no button
Scenario: Settings, Role changed (403)
Given an owner is on /settings and POST /v1/system/update/check answers 403
Then an error toast "Only the owner can do this" / "Ask the owner of this site to update RenewCMS." shows
And the card reloads GET /v1/system/update and renders the admin view
Scenario: Settings, Too many requests (429)
Given POST /v1/system/update/check answers 429 with Retry-After 42
Then the block shows icon info "Too many tries" / "Wait a moment before trying again."
And the button reads "Try again in 0:42", counts down each second and is re-enabled at zero
Scenario: A check runs on the first open after 24 hours, for the owner only
Given the owner opens /settings and checked_at is null or older than 24 hours
Then POST /v1/system/update/check is sent once automatically and the Checking state shows
When checked_at is under 24 hours old
Then no automatic check is sent
And an admin never sends one
Scenario: Home banner for the owner, update available
Given the owner is on /home and available is true with latest "v2.3.0-beta"
Then a region labelled "Update available" shows above the content in info tone with icon circle-arrow-up,
title "Version 2.3.0-beta is available",
text "Update it from Settings. It takes about 2 minutes and the site stays online.",
a "Go to Settings" button and a dismiss button
When the owner dismisses it
Then the banner is hidden and localStorage remembers the dismissed version
And it shows again when latest changes to a newer version
Scenario: Settings sidebar pill and mobile dot
Given the owner and available is true
Then the Settings sidebar item shows an "Update" pill, and on mobile the menu icon shows a dot read as "Update available"
And the pill stays after the banner is dismissed
Scenario: Admins and an up-to-date owner see no banner, pill or dot
Then an admin, or an owner with available false, sees no banner, pill or dot
Scenario: Pending states of slices 2 and 3
Then these states are listed as pending in the visual gate, never passing: Update available with its Update button
(and its notes-open frame), Downloading, Verifying, Ready to install, Restart confirm, Restart request failed,
Restarting, Restarting taking longer, Update done, Rolled back, Download failed, Verification failed,
Plain restart confirm, restarting and done, Update already running (409), and the Home "ready to install" banner
And the Update, Restart and progress elements are not rendered in any state of this slice
+105
View File
@@ -0,0 +1,105 @@
# QA: Updates part 1 (signed releases, release feed, notification)
## Automated Go (`task test`, package `test`, black-box)
Files: `test/update_test.go` (domain, use cases), `test/update_http_test.go` (HTTP), `test/update_feed_test.go`
(Gitea adapter, JSON store), `test/releasesign_test.go` (signing tool). Fakes with unique names: `fakeReleaseFeed`
(returns a list or an error, counts calls), `fakeUpdateStore`; reuse `mockUserRepo` from `test/user_test.go`.
HTTP setup: `validator.InitValidator()`; `token := jwtauth.New("HS256", []byte("test-secret"), nil)`; mount a fresh
`chi.NewRouter()` at `/v1/system` mirroring `NewSystemRouter` (Verifier, Authenticator, RequireCurrentToken,
RequireVerifiedUser; the check route also RequireOwner and the per-user limiter, 5 per minute); cookies via
`token.Encode({"user_id","token_version"})` as in `test/stale_token_invalidation_http_test.go`. `httptest` only: no live
server, no SQLite, no SMTP.
1. Version comparison, table-driven over the Examples in the feature (domain; `errors.Is` for sentinels).
2. Feed adapter against `httptest.NewServer` serving a Gitea JSON list: path is
`/api/v1/repos/fsylvain/RenewCMS/releases`; newest by numeric order regardless of order; drafts skipped; final beats
beta; notes markdown converted to items; `html_url` carried; a 500 and invalid JSON return an error.
3. `GET /v1/system/update` as owner and as admin: 200, exactly the 12 keys, `can_apply` false, `state` "idle", values
from the stored result, `release_url` from the stored `html_url`; the fake feed call count is 0.
4. GET before any check: `latest` "", `available` false, `release_url`, `notes`, `checked_at`, `progress`, `error`,
`started_at` null.
5. GET: no cookie 401; stale token 401 with `apperr.UnauthorizedErrorMessage`; unverified 403 with
`apperr.VerificationRequiredErrorMessage`.
6. `POST /v1/system/update/check` as owner: 200, store updated with latest, `release_url` and `checked_at`, feed called
once, a later GET equals it. Nothing newer: `available` false. Running version "dev": `available` false.
7. POST check as admin: 403, body `apperr.OwnerRequiredErrorMessage+"\n"`, feed not called.
8. Feed error: 500, store unchanged (latest and `checked_at` as before), body contains no feed error text.
9. Rate limit: owner A sends 6 checks: first 5 are 200, the 6th is 429 with `apperr.TooManyRequestsErrorMessage+"\n"`
and an integer `Retry-After` of at least 1; feed called 5 times; owner B's first check still 200; a login-limiter
instance built in the same test is unaffected.
10. JSON file store in `t.TempDir()`: save, reopen, same values; missing file and corrupt file read as empty without error.
11. Signing tool, run through `go run ./cmd/releasesign` (or its exported package) with a throwaway key pair generated
in `t.TempDir()` at test time, always with `--pub`; never read the committed `release.pub` key except in case 13:
keygen creates the key; sign then verify passes; one flipped byte fails verify; a different public key fails verify;
keygen into a path inside the repo tree is refused and writes nothing; sign with a private key that does not match
`--pub` fails, naming the mismatch, and writes no `.sig`.
12. Placeholder: a `--pub` file holding base64 of 32 zero bytes makes sign and verify fail with the placeholder message.
13. The committed `internal/infrastructure/update/release.pub` is checked only for shape: a valid base64 string that
decodes to 32 bytes. Do not assert that it is or is not the placeholder, since the user replaces it later.
14. Review items, not Go tests: `internal/domain/update` imports only the stdlib; use cases import no `net/http`,
`gorm`, adapter or `config`; the handler imports no adapter; `UPDATE_FEED_URL` is in `requiredEnvVars`/`envDefaults`,
`.env.example` and `docs/configuration.md`; no private key or secret value is in the repo.
## Automated SPA (Vitest + Vue Test Utils, `task test:web`)
Mock `useApi.request` for `GET /v1/system/update` and `POST /v1/system/update/check`. Fake timers for the countdown and
the 2 s "Copied". No test freezes the system date and none asserts a relative date or "Last checked today". Reuse the
board's sample data: running `v2.2.0-beta`, latest `v2.3.0-beta`, released 24 Sep 2026, items from the frame's script.
One test per state:
1. Up to date (owner): "You're up to date", only "Check for updates" rendered.
2. Checking: text, polite live region, "Checking…" disabled, one POST.
3. Check failed (500, then `NetworkError`): copy, only "Try again", last result kept.
4. Not prepared (available, `can_apply` false): copy, command line, note, "How to update" link with `href` equal to
`release_url` and an external target; no button other than Copy.
5. Notes open: collapsed by default, `aria-expanded` toggles, "Released 24 Sep 2026" and the plain-text list.
6. Command copied: Copy writes the command to the clipboard mock, reads "Copied" for 2 s, then "Copy".
7. Admin view: both texts, no button; no auto check.
8. Role changed (403): toast "Only the owner can do this" / "Ask the owner of this site to update RenewCMS.", then a
reload of the GET and the admin view.
9. 429: "Too many tries", button "Try again in 0:42" counting down to enabled.
10. Auto check: sent once when `checked_at` is null or older than 24 h, not when fresh, never for admin.
11. Home banner: shown for the owner when available, copy and "Go to Settings" navigates to /settings, dismiss writes
the version to localStorage and hides it, same version stays hidden after remount, a newer `latest` shows it again,
absent for admin and when not available.
12. Sidebar pill and mobile dot: owner and available only, pill remains after the banner is dismissed; absent for admin.
13. No Update, Restart or progressbar element exists in any of the states above; the shown version drops the leading
"v" ("Version 2.3.0-beta") while the Version card keeps `v2.2.0-beta`.
## Visual (`task visual:check -- settings` and `-- home`; desktop and mobile, light and dark; every capture within 10 %)
Add the setups to `web/visual/states.ts` using the board's own sample data. Exact values from
`docs/design/source/AppFrame.dc.html` (Settings and Home blocks); layout as drawn, not from the prose.
- [ ] Settings: Checking (mock a never-resolving check after the click setup), Not prepared, Admin view (available),
Too many requests (429, Retry-After 42).
- [ ] Settings, `skip: 'clock-sensitive'` (the meta line is relative: "Last checked today at 09:41", "yesterday at 18:12"):
Up to date, Check failed, Admin view (up to date).
- [ ] Settings, Not prepared: command copied (the "Copied" state is time-bound; Vitest only), listed as not visual.
- [ ] Home: Update available (owner), with the sidebar pill and the mobile dot as drawn.
- [ ] Pending, never passing (slices 2 and 3): Update available with its Update button, Update available with notes
open (its frame draws the Update button), Downloading, Verifying, Ready to install, Restart confirm, Restart
request failed, Restarting, Restarting taking longer, Update done, Rolled back, Download failed, Verification
failed, Plain restart (confirm, restarting, done), Update already running (409), Home "ready to install" banner.
- [ ] Not covered by screenshots: keyboard and focus order, focus ring on the "Updates" heading (`id="updates-h"`),
hover and motion, the Copy announcement, the dismiss button focus.
## Manual verification
- Replace the placeholder key: run `task release:keygen`, store the private key outside the repo, set
`RELEASE_SIGNING_KEY` to its path, commit the printed public key as `internal/infrastructure/update/release.pub`, and
rebuild. Never commit or paste the private key. Until this is done, `task release` must fail with the placeholder message.
- Run `task release` with `RELEASE_SIGNING_KEY` unset, pointing to a missing file, and pointing to a key that does not
match `release.pub`: each fails before any binary is built, with a message naming the cause. With the correct key,
`checksums.txt` and `checksums.txt.sig` appear next to the six binaries and `cmd/releasesign verify` passes on them.
- Against the real Gitea feed (default `UPDATE_FEED_URL`), run a dev API with a lower fake version and press "Check for
updates" in the SPA: it reports the newest release; the "How to update" link opens that release's page.
- Real release notes (the markdown body) render as a sensible plain-text list.
- Restart the API and confirm the last result and `checked_at` survive, in `update-status.json` beside `DB_FILE`.
- Embedded SPA build (no `-tags nofrontend`) serves /settings and /home with the card, banner and pill.
- Confirm `docs/release-notes.md` (publish step: attach `checksums.txt` and `checksums.txt.sig` with the six binaries),
`docs/deployment.md` and `docs/configuration.md` are updated, and that nothing was published.
- Release gate: slices 1 to 3 ship together, so no released build shows `renewcms enable-browser-updates` before slice 3
implements it.
+508
View File
@@ -0,0 +1,508 @@
Feature: Updates part 3: Restart, the privileged helper and rollback
As the owner of a RenewCMS site
I want one Restart button that installs the staged release, or just restarts the site, and puts the old version back if the new one does not come up
So that I can update from the browser while the app itself stays unprivileged and sandboxed
Background:
Given slices 1 to 3 of Updates ship in one release
And the app never gains privileges: the documented systemd unit keeps ProtectSystem=strict and only the data directory writable
And only the helper runs as root; it is the same binary, started as "renewcms apply-update" by a oneshot systemd service
And the data directory is the directory that holds DB_FILE; no new env var is added
And the files in the data directory are:
update-restart-request.json (marker, written by the app):
{"kind":"update"|"restart","tag" (update only),"requested_at" RFC3339 UTC,"requested_by" user_id};
update-result.json (written by the helper):
{"outcome":"running"|"succeeded"|"rolled_back"|"failed","kind","tag","from_version","started_at","finished_at"};
update-helper.json (status file, written by enable-browser-updates):
{"version":1,"service","binary","data_dir","installed_at"};
update-running.json (written by the server at every startup):
{"version","pid","started_at"}
And the marker is written atomically (temp file in the data directory, then rename) and deleted by the helper after reading it
And the technical reason of a failure goes to the log or journal only, never into a file the app serves or a response
And the domain package internal/domain/update (stdlib only) gains these interfaces, each faked in tests:
RestartRequestStore (write, read, delete the marker),
ResultStore (read, write and delete the result),
RunningInfoStore (the server writes update-running.json; the helper reads it),
HelperFilesystem (lstat, open with no-follow, read, create-exclusive, copy, rename, remove, chmod, make a fresh private
temp directory, all of them symlink-aware),
ServiceControl (restart and status of the systemd service),
HealthChecker (GET http://127.0.0.1:<port>/healthz, true on 200),
Clock
And the helper logic depends only on those interfaces and on update.SignatureVerifier from slice 2 with the embedded release.pub
And O_NOFOLLOW and lstat behaviour sit behind HelperFilesystem so the logic is tested on any OS; the real adapter is Linux-only
(build-tagged) and is covered by the manual systemd checklist
And RequestRestartUseCase and the extended GetUpdateStatusUseCase depend only on domain interfaces; handlers in
api/handlers/update receive them through NewHandler; only api/dependecyInjection.go builds the adapters
And POST /v1/system/update/restart is mounted in NewSystemRouter behind jwtauth.Verifier, jwtauth.Authenticator,
RequireCurrentToken, RequireVerifiedUser and RequireOwner; there is no limiter
And its optional JSON body is {"kind":"update"|"restart"}, bound to a request struct with
validate:"omitempty,oneof=update restart" and checked by validator.Validate.Struct; an empty body is allowed
And the checks on POST run in this order: no cookie or stale token (401), unverified (403), not owner (403),
malformed body or invalid kind (400), can_apply false (409), job downloading or verifying (409), a restart already pending
or running (409), kind that does not match the state (409), marker write error (500), then 202
And with no body the server picks by state: job "ready" gives kind "update", anything else kind "restart"
And the kind given must match: "update" needs a job "ready"; "restart" needs no job "ready"; otherwise 409 and nothing is written
And POST download and POST restart delete update-result.json before they start a new job or write a marker
And the 202 body is the status JSON with state "restarting" and started_at equal to the marker's requested_at (server clock)
And errors are plain text from http.Error and carry no path or technical detail
And GET /v1/system/update has no side effects; it keeps the 12 keys of slice 1 and gains exactly one key, "finished_at":
the result's finished_at (RFC3339 UTC) whenever a result file exists, otherwise null, whatever the state
And state is one of idle, downloading, verifying, ready, restarting, succeeded, failed, derived from the files by one rule:
marker present, or result "running" younger than 5 minutes: "restarting";
result "running" older than 5 minutes and no marker: "failed", error "install";
result "succeeded", kind "update", tag equal to the running version: "succeeded";
result "succeeded" for kind "restart", or kind "update" whose tag is no longer the running version: "idle";
result "rolled_back": "failed", error "rolled_back";
result "failed": "failed", error "install";
otherwise the slice 2 job state; a missing or corrupt result file counts as no result
And a result persists and is read the same on every GET until POST download or POST restart deletes it
And error is null, "download", "verification", "rolled_back" or "install"
And GET /healthz is unchanged: body "ok", no version header
And the server writes update-running.json at every startup, after the listener is bound and before it serves, atomically; a write error
is logged and is not fatal
And the helper judges a restart by two things: GET /healthz answers 200 AND update-running.json holds the expected version AND it is
NEW: its pid differs from the pid read before the restart, or its started_at is later than the instant the restart command
was issued; a stale file with the old pid or started_at never counts
And main gains a minimal dispatcher before the normal start: the subcommands enable-browser-updates, disable-browser-updates and
apply-update run their own code and never read .env, open the database or listen; "--version" and the normal start are unchanged
And the new subcommands never write a secret value or an env value into a unit file
Scenario: Request an update restart, happy path
Given the owner, can_apply true and a job "ready" for "v2.3.0-beta"
When the owner sends POST /v1/system/update/restart with no body, or with {"kind":"update"}
Then the status is 202 and the body is the status JSON with state "restarting"
And the marker holds kind "update", tag "v2.3.0-beta", requested_by the owner's user_id and requested_at
And update-result.json was deleted first
And the running binary, the staged files and the database are unchanged by the app
And GET reports state "restarting" for any verified user
Scenario: Request a plain restart
Given the owner, can_apply true and no job "ready"
When the owner sends POST /v1/system/update/restart with no body, or with {"kind":"restart"}
Then the status is 202, the marker holds kind "restart" and no tag, and GET reports state "restarting"
Scenario Outline: The kind must match the state
Given the owner, can_apply true and <state>
When the owner sends POST /v1/system/update/restart with {"kind":"<kind>"}
Then the status is 409, no marker is written, the result file and the job are untouched
Examples:
| state | kind |
| no job "ready" (idle) | update |
| a job "failed" | update |
| a job "ready" | restart |
Scenario: Restart site never installs an update another owner just made ready
Given owner A opened the Plain restart dialog while the job was idle
And owner B then made a job "ready"
When owner A confirms and the SPA sends {"kind":"restart"}
Then the status is 409, nothing is installed and the staged files are untouched
And the SPA reloads the card and shows "Ready to install"
Scenario Outline: A bad body is a 400
Given the owner and can_apply true
When the owner sends POST /v1/system/update/restart with <body>
Then the status is 400 with a plain text body and no marker is written
Examples:
| body |
| {"kind":"upgrade"} |
| {"kind":""} |
| {"kind":7} |
| {"kind":"update" |
| not json |
Scenario Outline: POST is guarded like the other system routes
When <caller> sends POST /v1/system/update/restart
Then the status is <status> and no marker is written and no result is deleted
Examples:
| caller | status | body |
| no jwt cookie | 401 | the existing 401 text |
| a stale token version | 401 | the existing 401 text |
| an unverified owner | 403 | the existing unverified text |
| an admin | 403 | apperr.OwnerRequiredErrorMessage |
Scenario Outline: Restart is refused with 409
Given the owner and <condition>
When the owner sends POST /v1/system/update/restart
Then the status is 409, the existing marker, result and job are untouched and no new marker is written
Examples:
| condition |
| can_apply is false (no update-helper.json) |
| the job state is downloading |
| the job state is verifying |
| a marker is already pending |
| the result file reads "running" (helper at work) |
Scenario: Two restarts at once write one marker
When two owners send POST /v1/system/update/restart concurrently
Then exactly one answers 202 and the other 409 and one marker exists
Scenario: The marker cannot be written
Given the data directory is not writable, or a directory sits where the marker file goes
When the owner sends POST /v1/system/update/restart
Then the status is 500 with a plain text body without paths, no marker exists and the job record is untouched
Scenario Outline: GET derives the state from the files and never changes them
Given <files>
When any verified user sends GET /v1/system/update twice
Then both answers are identical, state is <state>, error is <error> and finished_at is <finished>
And no file in the data directory changed
Examples:
| files | state | error | finished |
| a marker is present | restarting | null | null |
| result "running" written 30 s ago | restarting | null | null |
| result "running" written 6 minutes ago, no marker | failed | "install" | its value |
| result "succeeded", kind "update", tag equal to the running version | succeeded | null | its value |
| result "succeeded", kind "update", tag older than the running one | idle | null | its value |
| result "succeeded", kind "restart" | idle | null | its value |
| result "rolled_back" | failed | "rolled_back" | its value |
| result "failed" | failed | "install" | its value |
| no marker, no result | idle | null | null |
| a corrupt result file | idle | null | null |
Scenario: The result lives until the next job
Given a result "rolled_back"
When the owner sends POST /v1/system/update/download and the job reaches "ready"
Then the result file was deleted by the POST, GET reports state "ready", error null and finished_at null
And GET /v1/system/update still has exactly the 12 keys of slice 1 plus finished_at
Scenario: After a successful update the status is consistent
Given a result "succeeded" for "v2.3.0-beta" and the running version "v2.3.0-beta"
Then GET reports state "succeeded", available false, current "v2.3.0-beta" and finished_at set
Scenario: The server writes update-running.json at startup
When the server starts with version "v2.3.0-beta"
Then update-running.json holds {"version":"v2.3.0-beta","pid":<its pid>,"started_at":<now>} written atomically
And it is written after the listener is bound and before requests are served
And a write error is logged and the server still starts
And a second start replaces the file with the new pid and started_at
And the file is not served by any route
Scenario: Healthz is unchanged
When a client sends GET /healthz
Then the status is 200, the body is "ok" and there is no version header, and the route stays public
Scenario Outline: The command dispatcher
When the binary is run with "<args>" and an empty environment
Then <outcome>
Examples:
| args | outcome |
| --version | it prints the version, exits 0 (unchanged from slice 2) |
| enable-browser-updates | it runs the installer, never reads .env or opens the database |
| disable-browser-updates | it runs the uninstaller, never reads .env or opens the database |
| apply-update | it runs the helper, never reads .env or opens the database |
| no arguments | the normal server start |
| an unknown subcommand | a usage message on stderr and a non-zero exit, the server is not started |
Scenario Outline: enable-browser-updates refuses when it cannot work
Given <situation>
When "renewcms enable-browser-updates" runs
Then it exits non-zero with the clear message "<message>" and writes nothing
Examples:
| situation | message |
| the OS is not Linux | Browser updates need Linux with systemd. |
| Linux without systemd (no /run/systemd/system) | Browser updates need systemd, which this machine is not running. |
| not run as root | Run this command as root, for example with sudo. |
| no unit for the service and no flags | Could not find the RenewCMS service. Pass --service, --binary and --data-dir. |
| the data directory cannot be resolved | Could not find the data directory. Pass --data-dir. |
Scenario: enable-browser-updates installs the units
Given systemd on Linux, root, and an existing renewcms.service with ExecStart=/opt/renewcms/renewcms and ReadWritePaths=/var/lib/renewcms
When "renewcms enable-browser-updates" runs
Then it reads the service name, binary path and data directory from the unit, with --service, --binary and --data-dir overriding them
And it writes renewcms-update.path (PathExists= the marker) and renewcms-update.service (Type=oneshot, User=root,
ExecStart=<binary> apply-update with the service, binary, data directory and port as flags)
And the port comes from --port, else from PORT in the service's environment file, else 8080
And it runs daemon-reload and enables and starts the path unit
And it writes update-helper.json last, so can_apply becomes true only when everything else worked
And no secret and no environment value is written into either unit
And it prints what it installed and how to undo it
Scenario: enable-browser-updates is idempotent
Given it ran once
When it runs again, including after the binary path or service name changed
Then the units and the status file are rewritten to the current values, no duplicate unit exists and the exit is 0
Scenario: enable-browser-updates undoes its own partial work
Given writing the second unit, daemon-reload or enable fails
Then the first unit is removed, update-helper.json is not written and the exit is non-zero with the reason
Scenario: disable-browser-updates
Given browser updates are enabled
When "renewcms disable-browser-updates" runs
Then the path unit is stopped and disabled, both unit files and update-helper.json are removed, daemon-reload runs
And the marker and result files, the staged files and backups are left in place
And running it again, or where it was never enabled, exits 0 with a message
And can_apply reads false afterwards
Scenario: apply-update, a plain restart
Given a marker of kind "restart" and update-running.json with pid 100 and started_at T0
When the helper runs
Then it reads the marker without following symlinks, deletes it, and writes the result "running" with started_at
And it records the current update-running.json, restarts the service once and polls until /healthz answers 200
and update-running.json is new (pid differs from 100, or started_at is later than the restart instant)
And it then writes "succeeded" with kind "restart" and finished_at
And the binary and the staged files are untouched
Scenario Outline: A stale running file never counts as success
Given a marker and update-running.json that <staleness> while /healthz answers 200
When the helper polls
Then it keeps polling and it is not declared succeeded or rolled back until a new file appears or 60 s pass
Examples:
| staleness |
| still holds the old pid and old started_at |
| holds the target version but the old pid and an old started_at |
| is missing |
| is corrupt |
| holds the old version with a new pid (for an update) |
Scenario: apply-update, an update, happy path
Given a marker of kind "update" for "v2.3.0-beta" and a staged binary, checksums.txt and checksums.txt.sig under updates/v2.3.0-beta/
When the helper runs
Then it creates a fresh root-owned temp directory with mode 0700 and copies the staged files into it, opening each original with no-follow
And it verifies the signature of the COPIED checksums.txt with the embedded public key
And it verifies the SHA-256 of the COPIED binary against its checksums.txt line, ignoring the earlier job record
And it copies the current binary to <name>.previous, replacing an older .previous
And it writes the verified copy to a temp file in the binary's directory (mode 0755), checks that it still hashes to the verified value,
and installs it with an atomic rename; the original staged path is never installed
And it restarts the service and polls /healthz and update-running.json for up to 60 s
And when /healthz answers 200 and update-running.json is new and holds "v2.3.0-beta" it writes "succeeded", success being declared on the
first matching poll
And it removes the temp directory and updates/v2.3.0-beta/
And the marker was deleted before any other step ran
Scenario Outline: apply-update refuses an untrusted staged binary
Given a marker of kind "update" and <fault>
When the helper runs
Then the current binary is not touched, no .previous is written and the service is not restarted
And it writes "failed", logs the technical reason only, and removes the temp directory and updates/<tag>/
Examples:
| fault |
| the binary was changed after the job verified it |
| checksums.txt was changed |
| the signature is from a different key or is missing |
| checksums.txt has no line for the asset |
| the staged binary is missing |
Scenario Outline: apply-update refuses symlinks
Given a marker of kind "update" and <symlink>
When the helper runs
Then it never reads through the link, the current binary is untouched, there is no .previous and no restart
And it writes "failed" and logs which path was a symlink
And whatever the link pointed to is not read, copied, written or removed
Examples:
| symlink |
| the marker itself is a symlink |
| <data>/updates is a symlink to another directory |
| <data>/updates/<tag> is a symlink to another directory |
| the staged binary is a symlink to /usr/bin/something |
| checksums.txt is a symlink |
| checksums.txt.sig is a symlink |
| a symlink is placed at the result path or at a temp file name |
Scenario: A symlinked marker is removed, not followed
Given the marker is a symlink to a file outside the data directory
When the helper runs
Then the link itself is unlinked, the target is untouched, and the result is "failed"
Scenario: A file swapped after verification is not installed
Given the staged binary is verified and a fake attacker replaces the original staged path with other bytes right after the copy step
When the helper installs
Then the installed bytes equal the verified copy's bytes and not the swapped bytes
And the same holds for a swap during the .previous copy and the final rename
And a swap of the temp file in the binary's directory before the rename is caught by the re-hash and ends as "failed" with the binary untouched
Scenario: Result and temp files are written without following links
Given the service user placed a symlink at update-result.json or at a predictable temp name in the data directory
When the helper writes its result
Then it creates a temp file with create-exclusive and no-follow, then renames it over the result, and the link target is untouched
Scenario Outline: apply-update distrusts the marker
Given a marker whose tag is <tag>
When the helper runs
Then it writes "failed", the binary is untouched, the service is not restarted and nothing outside <data>/updates is read
Examples:
| tag |
| ../../etc/passwd |
| v2.3.0-beta/../../x |
| an empty string |
| v2.1.0-beta (older than the running version) |
| not-a-version |
Scenario Outline: apply-update rolls back when the new version does not come up
Given an update marker and <fault> after the new binary was installed and the service restarted
When the helper runs
Then within the 60 s window it restores <name>.previous over the binary atomically and restarts the service again
And it polls until /healthz answers 200 and a NEW update-running.json holds the old version
And it writes "rolled_back" with from_version and tag and removes the temp directory and the staged files
Examples:
| fault |
| /healthz never answers within 60 s |
| /healthz answers but update-running.json stays old |
| update-running.json holds another version |
| the service restart command fails |
Scenario Outline: apply-update failures around the swap
Given an update marker and <fault>
Then <outcome>
Examples:
| fault | outcome |
| copying to .previous fails | the binary is untouched, the service not restarted, result "failed" |
| the atomic install fails | .previous and the old binary are intact, no restart, result "failed" |
| the rollback restore itself fails | result "failed", logged loudly, exit non-zero |
| the old version never returns after rollback | result "failed" (not "rolled_back"), exit non-zero |
Scenario: The result is always written
Given any marker and any outcome, including a panic in the helper
Then update-result.json holds outcome, kind, tag, from_version, started_at and finished_at, written atomically
And a "running" record exists from the moment the marker was read until the outcome replaces it
Scenario: Only the helper runs with privilege
Then the app has no code that execs systemctl, writes outside the data directory or reads the units
And the oneshot service and path unit contain no environment secrets
Scenario: Settings, owner, Restart buttons (route /settings)
Given the owner and can_apply true
Then with state "ready" the Restart button (power, primary) is enabled and opens the Install dialog
And with state "idle" (Up to date or Check failed) the Restart button (power, secondary) is enabled and opens the Plain restart dialog
And with state "downloading", "verifying" or "restarting" Restart is disabled or absent as the card draws it
And with can_apply false (Not prepared) or the admin view no Restart is rendered
And the slice 2 disabled Restart in Ready to install is now enabled and has a handler
And the SPA sends {"kind":"update"} from the Install dialog and {"kind":"restart"} from the Plain restart dialog, always
Scenario: Settings, Restart: confirm (Install dialog)
When the owner presses Restart in Ready to install
Then a dialog titled "Restart to finish the update?" shows "RenewCMS will install version 2.3.0-beta and restart. Your site will be unavailable for about 10 seconds. This page reloads on its own when the site is back. Save anything you're editing first."
And its buttons are "Restart later" and "Restart now", the confirm is neutral, not red
And focus moves to the first button, Escape and "Restart later" close it and focus returns to Restart
And no request is sent until "Restart now"
Scenario: Settings, Plain restart: confirm
When the owner presses Restart with no update waiting
Then a dialog titled "Restart the site?" shows "Your site will be unavailable for about 10 seconds. This page reloads on its own when the site is back. Save anything you're editing first."
And its buttons are "Cancel" and "Restart site", with the same focus and Escape behaviour
Scenario: Settings, Restart: request failed
Given the confirm button is pressed and POST /v1/system/update/restart answers 500 or never reaches the server
Then the dialog stays open (install or plain) with the error "Couldn't start the restart. Nothing was changed and your site is still running. Try again in a moment."
And the confirm button is enabled again, no overlay shows and nothing is stored in sessionStorage
Scenario: Settings, this tab remembers that it started the restart
Given POST /v1/system/update/restart answers 202 with started_at "S"
Then sessionStorage holds one entry with the kind and "S" (the server's started_at), and no other storage is written
And the overlay shows
Scenario: Settings, Restarting to install
Given POST /v1/system/update/restart answers 202 for an update
Then a full-page region with role "status" shows, titled "Installing version 2.3.0-beta" with
"Your site is restarting with the new version. This takes about 10 seconds. This page reloads on its own when the site is back." and a moving bar
And it is announced once as "Installing version 2.3.0-beta. Your site is restarting."
And the overlay survives failing requests and the Offline banner state is ignored while it shows
And it polls GET /healthz and GET /v1/system/update every second, tolerating network errors and non-200 answers
Scenario: Settings, Plain restart: restarting
Given POST /v1/system/update/restart answers 202 for a plain restart
Then the overlay shows "Restarting your site" / "This takes about 10 seconds. This page reloads on its own when the site is back."
And it polls the same way
Scenario: Settings, Restarting, taking longer
Given 60 seconds pass with no answer from /healthz or from GET /v1/system/update
Then the overlay shows "Still restarting" / "This is taking longer than usual. Keep this page open. It reloads on its own when the site is back, or you can reload it now." and a "Reload page" button
And the meta reads "Started at 09:51 · 1 minute ago" (clock-sensitive)
And "Reload page" reloads the page, the overlay stays until the site answers, and the polling continues
Scenario: Settings, the overlay ends when the site answers
Given the overlay shows and /healthz answers and GET /v1/system/update answers with a state other than "restarting"
and finished_at later than the stored started_at
Then the page reloads once
And a GET answering "restarting", a GET whose finished_at is null or not later than the stored started_at, a /healthz answer without a GET
answer, and a rejected GET all keep the overlay and do not reload
Scenario: Settings, Update done (the tab that started it)
Given the page reloaded, sessionStorage holds {kind "update", started_at "S"} and GET answers state "succeeded" with finished_at later than "S"
Then the entry is cleared, focus lands on the "Updates" heading (id="updates-h") with the ring shown
And a success toast "Update installed" / "RenewCMS is now on version 2.3.0-beta." is announced
And the Version card shows the new running version and the card reads "You're on version 2.3.0-beta" /
"The update is installed and your site is running again." / "Updated today at 09:52" with a "Read the release notes" link (arrow-up-right)
Scenario: Settings, Update failed, rolled back (the tab that started it)
Given the page reloaded, sessionStorage holds {kind "update", started_at "S"} and GET answers state "failed", error "rolled_back", finished_at later than "S", running "v2.2.0-beta"
Then the entry is cleared and focus lands on "Updates"
And an error toast (stays until dismissed) with icon circle-x "The update didn't install" / "Your site is back on v2.2.0-beta." shows
And the card shows icon triangle-alert (warning) "The update didn't install" /
"RenewCMS put the previous version back, so your site is running as before. Nothing was lost." /
"What to do next: try again in a few minutes. If it fails again, ask whoever manages your server to check the update." and a "Try again" button that sends POST /v1/system/update/download
And error "install" renders the same card and toast
Scenario: Settings, Plain restart: done (the tab that started it)
Given the page reloaded, sessionStorage holds {kind "restart", started_at "S"} and GET answers state "idle" with finished_at later than "S"
Then the entry is cleared, focus lands on "Updates" and a success toast "Site restarted" / "Your site is running again." is announced
And the card is the normal Up to date card
Scenario Outline: A later visit shows the card with no toast and no focus move
Given sessionStorage has no entry, or an entry whose started_at is not earlier than finished_at, and GET answers <result>
Then the card renders for that state, no toast shows and focus does not move to "Updates"
And nothing is written to sessionStorage
Examples:
| result |
| state "succeeded", finished_at set |
| state "failed", error "rolled_back" |
| state "failed", error "install" |
| state "idle", finished_at set (plain restart) |
Scenario: Settings, another owner's tab never takes the toast
Given owner B has /settings open, with no sessionStorage entry, while GET answers "restarting" and later "succeeded"
Then owner B's page shows the overlay while "restarting" and the card afterwards, with no toast and no focus move
And owner A's tab, which holds the entry, still gets the toast and the focus
And an admin sees the admin view and no overlay
Scenario: Settings, a stale sessionStorage entry
Given an entry left behind by a restart that never finished in this tab (the tab was closed and reopened by hand)
When the page loads and GET answers a finished_at that is not later than the entry's started_at, or null
Then no toast shows, focus does not move, the entry stays until a later finished_at consumes it, and a new restart overwrites it
Scenario: Settings, 409 on Restart
Given POST /v1/system/update/restart answers 409
Then the dialog closes, nothing is stored in sessionStorage and the card reloads
And when the reload shows downloading, verifying or restarting an info toast "An update is already running" / "Another owner started it. Progress shows here." shows and the card or overlay switches to that run
And when the reload shows can_apply false the card shows "Not prepared" and no toast
And when the reload shows a different "Ready to install" or "idle" (the kind did not match) the card shows that state and no toast
Scenario: Settings, 400 on Restart
Given POST /v1/system/update/restart answers 400
Then the dialog shows the "Couldn't start the restart" text and nothing is stored in sessionStorage
Scenario: Settings, 403 role changed on Restart
Given POST /v1/system/update/restart answers 403
Then the dialog closes, an error toast "Only the owner can do this" / "Ask the owner of this site to update RenewCMS." shows and the card reloads in the admin view
Scenario: Settings, 401 on Restart
Given POST /v1/system/update/restart answers 401
Then the global handler goes to /login?redirect=/settings&reason=expired and no local copy shows
Scenario: Home banner while restarting
Given state "restarting"
Then Home shows no update banner and does not poll
Scenario: The docs gain a "Browser updates" section
Then docs/deployment.md has "Browser updates" with the one-time command "sudo renewcms enable-browser-updates", what it installs
(two units, update-helper.json), how to undo it ("sudo renewcms disable-browser-updates"), and what is and is not supported
And it lists: Linux with systemd only; not Windows, macOS, Docker or other init systems; the previous binary is kept as <name>.previous
and a database backup in backups/; an update whose new version does not come up within 60 s is rolled back automatically
And it names the files update-restart-request.json, update-result.json, update-helper.json and update-running.json
And the "How to update" link of the Not prepared card points at that section
And the sentence "the site does not update itself" in the "Update checks" section is replaced
+187
View File
@@ -0,0 +1,187 @@
# QA: Updates part 3 (restart, helper, rollback)
## Automated Go (`task test`, package `test`, black-box, no live systemd, no real SMTP, no network)
Files: `test/update_restart_http_test.go` (HTTP), `test/update_restart_usecase_test.go` (request and status use cases),
`test/update_helper_test.go` (helper logic over fakes, including rollback and hardening), `test/update_helper_install_test.go`
(enable and disable over fakes), `test/update_helper_files_test.go` (real file adapters in `t.TempDir()`),
`test/update_dispatch_test.go` (built binary).
Fakes with unique names: `fakeRestartRequestStore`, `fakeResultStore`, `fakeRunningInfoStore` (scripted per poll: absent, corrupt, stale,
new), `fakeHelperFS`, `fakeServiceControl` (records restart calls with the clock instant; can fail), `fakeHealthChecker` (scripted per poll),
`fakeClock` (advances without sleeping), `fakeUnitWriter` (records unit contents, can fail the Nth write). Reuse `fakeJobStore`,
`fakeHelperDetector`, `fakeUpdateStore`, `mockUserRepo` and the throwaway ed25519 signer from slices 1 and 2. Never read the committed `release.pub`.
`fakeHelperFS`: an in-memory tree of files, directories and symlinks with owners and modes; `lstat`, no-follow open, create-exclusive, copy,
rename, remove and a fresh private temp directory are the only operations; every call is recorded in order with its path; an operation that
would traverse a symlink without the no-follow flag follows it (so a test fails if the code forgets to refuse); it can fail the Nth
call of an operation, and it has a hook `after(op, n, mutate)` that mutates the tree after a chosen call (used to swap the original
staged file after the copy step). Tests assert the paths the helper touched stay inside the data directory, the binary directory and
its own temp directory.
HTTP setup: `validator.InitValidator()`; `jwtauth.New("HS256", []byte("test-secret"), nil)`; a fresh `chi.NewRouter()` at `/v1/system`
mirroring `NewSystemRouter` (Verifier, Authenticator, RequireCurrentToken, RequireVerifiedUser; the restart route also RequireOwner);
cookies as in `test/stale_token_invalidation_http_test.go`. Marker, result and job files go in `t.TempDir()` through the real JSON adapters,
plus the fakes where noted. Helper time is driven by `fakeClock`: no `time.Sleep`, so the 60 s window runs instantly.
### Tests the coder must update (they exist from slices 1 and 2 and will break)
- Slice 1 tests that assert GET /v1/system/update has exactly 12 keys: now 13, with `finished_at` (null when no result file).
- Slice 2 tests and Vitest specs that assert the Restart button in "Ready to install" is disabled and has no handler, that no restart
endpoint, dialog or overlay exists, and that plain Restart is not rendered: replace them with the enabled behaviour below.
- Slice 2 "Pending states for slice 3" visual entries: they become real setups.
- Any slice 2 test that builds the status use case with a result store must accept the new `ResultStore` dependency.
### HTTP and use case (Go-testable)
1. Restart, update: ready job, can_apply on. POST with no body and POST `{"kind":"update"}` give 202 with state "restarting" and
`started_at` equal to the marker's `requested_at`; the marker has kind "update", the tag, requested_by equal to the owner id; the result file
was deleted first; no other file changed; GET as an admin also reads "restarting".
2. Plain restart: idle job. No body and `{"kind":"restart"}` give 202, marker kind "restart", empty tag. Also after a failed job and after a
rolled-back result.
3. Kind mismatch: `{"kind":"update"}` with no ready job (idle, failed) and `{"kind":"restart"}` with a ready job give 409; no marker, result and job untouched.
"Restart site never installs": owner A's body `{"kind":"restart"}` after the fake job store turned "ready" gives 409, no marker, staged files untouched.
4. Bad body: `{"kind":"upgrade"}`, `{"kind":""}`, `{"kind":7}`, truncated JSON, `not json` give 400 plain text, no marker. The struct uses
`validate:"omitempty,oneof=update restart"` and goes through `validator.Validate.Struct`; an empty body and `{}` are accepted.
5. Guards: admin 403 with `apperr.OwnerRequiredErrorMessage+"\n"`; no cookie 401; stale token 401; unverified 403; none writes a marker or deletes the result.
Order: an admin with a bad body gets 403, an owner with a bad body and can_apply off gets 400, can_apply off and a kind mismatch gives 409.
6. 409 table: can_apply off, downloading, verifying, marker pending, result "running": no second marker, existing files untouched.
7. Concurrency (`-race`): two simultaneous POSTs give one 202, one 409, one marker.
8. 500: a directory where the marker goes, and a read-only temp directory (`t.Skip` that one on Windows): 500, plain text without the path, no marker,
job record unchanged.
9. State derivation, one subtest per row of the feature table. Each row calls GET twice: the two bodies are byte-identical, `state`, `error` and
`finished_at` match, and a snapshot of every file in the data directory (names, bytes, mtimes) is unchanged by the GETs (GET has no side effects).
The 5-minute boundary uses `fakeClock`. Assert exactly the 12 slice 1 keys plus `finished_at`.
10. The result lives until the next job: a "rolled_back" result, then POST download and a job reaching "ready": the result is gone,
state "ready", error null, `finished_at` null. POST restart also deletes it before writing the marker.
11. After success: result "succeeded" for the running tag gives `available` false, `current` the new version, `finished_at` set.
12. Server startup file: with the real running-info adapter in `t.TempDir()` write twice; the file has `version`, `pid` and `started_at`, the second
write replaces the first, it is written by a temp file plus rename, and a write into a missing directory returns an error that the startup code logs
(use case or startup function returns it; it does not panic). The built binary (item 15) writes it before it answers `/healthz`.
13. `/healthz` is unchanged: body "ok", no `X-RenewCMS-Version` header, public.
14. A new download after "rolled_back" gives 202 and later a "ready" with error null.
15. Dispatcher: build with `go build -tags nofrontend -ldflags "-X main.version=v9.9.9" ./cmd/server` into `t.TempDir()`; with an empty environment
`--version` prints `v9.9.9`; an unknown subcommand exits non-zero with usage and does not listen; `apply-update` and `enable-browser-updates`
run without `.env` and create no `data/` (on a non-Linux machine the latter exits non-zero with the Linux/systemd message, which covers the Windows refusal).
### Helper logic over fakes (Go-testable, no systemd)
Fixture: fake FS with the binary `/opt/renewcms/renewcms` ("old"), staged `updates/v2.3.0-beta/` binary, `checksums.txt` and `checksums.txt.sig`
signed with a throwaway key injected through the verifier constructor, a marker, running version v2.2.0-beta, `update-running.json` with pid 100 and
started_at T0.
16. Plain restart: the marker is opened no-follow and deleted first, result "running" then "succeeded", one service restart, no write to the binary.
Success needs `/healthz` 200 AND a running file that is NEW.
17. Stale running info, one subtest per row: old pid and old started_at; target version but old pid and old started_at; absent; corrupt; old version with a new pid
(for an update). Health answers 200 throughout. The helper keeps polling and is not declared succeeded or rolled back until the file turns new or the
fake clock passes 60 s. Also: a file whose started_at is later than the restart instant counts as new even with the same pid.
18. Update happy path, asserting the ORDER of fake calls: no-follow read and delete of the marker, "running", fresh 0700 temp directory, no-follow copy of the
three staged files into it, signature check on the copy, SHA-256 of the copied binary, copy of the current binary to `.previous`, temp file in the
binary's directory written from the verified copy, re-hash of that temp file, atomic rename, mode 0755, record running info, restart, polls,
"succeeded", removal of the temp directory and `updates/<tag>/`. Final FS: binary equals the new bytes, `.previous` equals the old bytes.
Success is declared on the first matching poll, not at 60 s.
19. Re-verification, one subtest each: tampered binary, tampered checksums.txt, other-key signature, missing signature, no line for the asset, missing
binary. Each: binary unchanged, no `.previous`, zero restarts, result "failed", staged dir and temp dir removed, reason in the injected logger only.
20. Symlinks, one subtest each: marker; `updates`; `updates/<tag>`; the binary; checksums.txt; checksums.txt.sig; a link at the result path; a link at a
predictable temp file name. Each: the FS records no read, write, copy or removal through the link (the targets, placed outside the allowed
directories with sentinel bytes, are unchanged), binary untouched, no `.previous`, zero restarts, result "failed", the log names the link path.
The symlinked marker case: the link itself is unlinked and the target is intact.
21. TOCTOU: with the `after` hook, replace the original staged binary with other bytes immediately after the copy step; the installed bytes equal the
verified copy's bytes. Repeat with the swap after the signature check, after the hash check, and after the `.previous` copy. A swap of the temp file
in the binary's directory between write and rename is caught by the re-hash: result "failed", binary untouched.
22. Result and temp writes: create-exclusive and no-follow, then rename; a pre-planted symlink at the result path or a temp name leaves the target intact.
23. Hostile marker tags (traversal, traversal with valid prefix, empty, older version, malformed): result "failed", zero restarts, every touched path
under the allowed directories.
24. Rollback table: health never answers (60 s of fake clock, about 60 polls at 1 s), healthy but running file stays old, other version in the running file,
restart error. Each: binary restored to "old" through an atomic rename, second restart issued, polled until a NEW running file holds the old version,
result "rolled_back" with from_version and tag, temp directory and staged dir removed.
25. Swap failures: `.previous` copy fails (binary untouched, no restart, "failed"); atomic install fails (old binary and `.previous` intact, "failed");
restore fails ("failed", error returned, loud log); old version never returns after rollback ("failed", not "rolled_back").
26. Result always written: a panic in the fake service control still leaves outcome "failed" with `finished_at`; the "running" record exists before the
first service call; writes are atomic.
27. Timestamps come from `fakeClock`; finished is not before started.
28. Enable, over fake FS, unit writer and service control: refuses non-Linux, no systemd, not root, no unit and no flags, no data directory (exact
messages); on success writes both units containing the service, binary and data directory from the parsed unit, the `PathExists=` marker line and
the port flag (`--port` over `PORT` from the env file over 8080); the units never contain `JWT_SECRET` or any value from the env file (seed the
fixture env file with `JWT_SECRET=sentinel-secret` and search both units); flags override the unit; the status file is written LAST; running it
twice gives identical files and one unit pair; each failing step leaves no status file and removes the first unit.
29. Disable: removes units and the status file, keeps marker, result, staged files and backups; idempotent; a no-op where it was never enabled;
`can_apply` reads false afterwards through the real file detector.
30. Real adapters on `t.TempDir()`: the JSON marker, result, status and running-info stores round trip; the atomic write replaces an existing file.
The Linux-only no-follow adapter has a test file with `//go:build linux` (it runs on Linux CI machines and the user's WSL2, and is skipped on Windows).
31. Review items, not Go tests: the app (handlers, use cases, `api/`) execs no `systemctl` and writes only inside the data directory;
`internal/domain/update` imports only the stdlib; use cases import no `os/exec`, `net/http`, `gorm` or adapter; the handler imports no adapter;
the real filesystem adapter is the only code that calls `syscall.O_NOFOLLOW`; no secret in the repo; no new env var; `go vet -tags nofrontend`
and `gofmt` clean; no comments.
## Automated SPA (Vitest + Vue Test Utils, `task test:web`)
Mock `useApi.request` for `GET /v1/system/update`, `POST .../restart` and `POST .../download`; mock `fetch` for `GET /healthz`. Fake timers drive the
1 s polls and the 60 s switch. Stub `window.location.reload` and use a fresh `sessionStorage` per test. No test freezes the system date and none asserts a
relative date or "09:51". Sample data: running `v2.2.0-beta`, latest `v2.3.0-beta`, `started_at` and `finished_at` as plain strings.
One test per state:
1. Restart button: ready gives primary enabled; idle gives secondary enabled; downloading, verifying, restarting give disabled; can_apply false and admin give none.
2. Install dialog: exact title, text, buttons; focus on the first button; Escape and "Restart later" close it; focus returns to Restart; no request until
"Restart now"; the confirm is neutral; the request body is `{"kind":"update"}`.
3. Plain restart dialog: exact copy, "Cancel" / "Restart site", same behaviour; the request body is `{"kind":"restart"}`.
4. Restart request failed: 500 and `NetworkError`, in both dialogs: dialog stays, the exact error text, confirm enabled again, no overlay, nothing in sessionStorage. A 400 gives the same.
5. After 202, sessionStorage holds one entry with the kind and the response's `started_at`; no localStorage write.
6. Restarting to install: overlay `role="status"`, title and text, announced once; stays mounted when `fetch` rejects; the offline banner state is ignored; polls
/healthz and GET every second.
7. Plain restart: restarting: "Restarting your site" copy.
8. Taking longer: at 60 s "Still restarting", the text, "Reload page" present; pressing it calls reload; the overlay stays.
9. Overlay end: reload once when /healthz is ok and GET gives a non-"restarting" state with `finished_at` later than the stored `started_at`; no reload on
"restarting", on `finished_at` null, on `finished_at` not later, on a rejected GET, or without a GET answer; reload is not called twice.
10. Update done (entry present, state "succeeded", later `finished_at`): entry cleared, focus on `#updates-h`, success toast "Update installed" / "RenewCMS is now on version 2.3.0-beta.", card text and the "Read the release notes" link.
11. Rolled back (error "rolled_back" and "install"): entry cleared, focus on `#updates-h`, sticky error toast, card copy, "Try again" posts download.
12. Plain restart done (state "idle", later `finished_at`, kind "restart"): toast "Site restarted" / "Your site is running again.", focus, Up to date card, entry cleared.
13. No entry, or an entry not earlier than `finished_at`: for each of succeeded, rolled_back, install and plain-restart-idle results the card renders with no toast, no
focus move and no sessionStorage write.
14. Another owner's tab: no entry, GET "restarting" then "succeeded": overlay then card, no toast, no focus move. An owner tab with an entry still gets the toast. An admin sees the
admin view, no overlay and no poll.
15. Stale entry: `finished_at` null or earlier than the entry's `started_at` gives no toast and keeps the entry; a new restart overwrites it.
16. 409: reload downloading gives the info toast and progress; reload restarting gives the toast and overlay; reload can_apply false gives Not prepared and no toast; reload "ready"
or "idle" after a kind mismatch gives that card, no toast, nothing in sessionStorage.
17. 403: error toast and the admin view; 401 shows no local copy (the global handler is mocked).
18. Home: no banner or poll while "restarting".
19. Regression: slice 2's disabled-Restart assertions are replaced; Not prepared and the admin view still have no Restart.
## Visual (`task visual:check -- settings`; desktop and mobile, light and dark; every capture within 10 %)
`web/visual/states.ts` setups are added later by the coder, with the board's sample data (v2.2.0-beta, v2.3.0-beta). Exact values come from
`docs/design/source/AppFrame.dc.html` and the "Settings" group of the Screens board; describe layout as drawn (open the frame markup for the dialog, the overlay card
and its 440 px width before judging).
- [ ] Restart: confirm (install dialog)
- [ ] Plain restart: confirm
- [ ] Restart: request failed
- [ ] Restarting to install
- [ ] Plain restart: restarting
- [ ] Update failed, rolled back (the toast only if the frame draws it)
- [ ] `skip: 'clock-sensitive'`: Update done and Plain restart: done (meta "Updated today at 09:52"), Restarting, taking longer (meta "Started at 09:51 · 1 minute ago"); their copy is covered by Vitest
- [ ] Slice 2 pending states are now real: re-run the other Settings states and confirm Ready to install with an enabled Restart is within budget
- [ ] If a capture exceeds 10 %, stop and report; do not widen the budget or add an exception without the user's approval
- [ ] Not covered by screenshots: keyboard and focus order in both dialogs, the ring on `#updates-h` after the result states, the one-time overlay announcement, the motion of the bar, the Offline banner being ignored
## Manual only (real systemd Linux: WSL2 with systemd enabled, or a VPS): CANNOT be verified automatically
The user will run these. The helper's decision logic, ordering, symlink refusal, TOCTOU defence and rollback are unit-tested over fakes (items 16 to 27), but none of the following is covered:
- [ ] On Windows or macOS `renewcms enable-browser-updates` refuses with the clear message.
- [ ] On a VPS following docs/deployment.md (service user `renewcms`, `ProtectSystem=strict`, only `/var/lib/renewcms` writable): `sudo renewcms enable-browser-updates` reads the real unit, writes
`renewcms-update.path` and `renewcms-update.service`, enables the path unit (`systemctl status` active) and writes `update-helper.json`; a second run changes nothing.
- [ ] The Settings page shows the Update button (can_apply true) after a reload.
- [ ] The path unit fires when the sandboxed app writes the marker, and the app (as `renewcms`) can write the marker and cannot write the binary, the units or anything outside the data directory.
- [ ] The server writes `update-running.json` at startup (`cat` it: version, pid, started_at) and a restart replaces it.
- [ ] Real update from a real signed release (real `release.pub` committed, `task release` signing): Update, Ready, Restart, overlay, reload on the new version, toast on the tab that started it,
`.previous` next to the binary, `renewcms --version` equals the new tag, `journalctl -u renewcms-update` shows the helper log.
- [ ] Real rollback: stage a signed release whose binary prints the right `--version` but crashes at boot; the old binary is restored within about 60 s, the card reads "The update didn't install", the toast stays.
- [ ] Plain restart: overlay, about 10 s of downtime, reload with "Site restarted".
- [ ] The real no-follow adapter on Linux: as the service user, replace `updates/<tag>` with a symlink to `/etc`, replace the staged binary with a symlink, replace the marker with a symlink, and swap the staged file during
an update (a loop that rewrites it); the helper refuses or installs only verified bytes, and nothing outside the data directory is read or changed.
- [ ] Planted symlink at `update-result.json` pointing at a root-only file: the helper does not write through it.
- [ ] Binary directory ownership, SELinux and AppArmor do not block the atomic rename, and the temp file is on the same filesystem as the binary; the helper's private temp directory is root-owned 0700 and is removed.
- [ ] A hand-written marker with another tag, as the service user: refused, binary untouched.
- [ ] `sudo renewcms disable-browser-updates` removes the units and status file; the card returns to "Not prepared"; nothing else is deleted.
- [ ] A reverse proxy (nginx or Caddy) returns 502 during the restart and the overlay survives it; `/healthz` is not cached.
- [ ] Two owners in two browsers during a restart: both show the overlay; only the tab that started it gets the toast and focus.
- [ ] Embedded SPA build (no `-tags nofrontend`) serves `/settings` with the new dialogs and overlay.
- [ ] Journal and files contain no secret, and technical reasons are only in the journal.
## Final note
Not verifiable automatically: the whole privileged path on a real systemd Linux machine (generated units, path-unit trigger from the sandboxed app, real service restart, atomic swap on a real filesystem, real rollback, O_NOFOLLOW behaviour, permissions, SELinux or AppArmor, reverse-proxy behaviour). It needs the manual test on WSL2 with systemd or a VPS, which the user will do.
+2 -1
View File
@@ -11,8 +11,9 @@ require (
github.com/go-playground/validator/v10 v10.28.0
github.com/google/uuid v1.6.0
github.com/joho/godotenv v1.5.1
golang.org/x/crypto v0.44.0
golang.org/x/crypto v0.57.0
golang.org/x/image v0.46.0
golang.org/x/net v0.59.0
gopkg.in/gomail.v2 v2.0.0-20160411212932-81ebce5c23df
gorm.io/gorm v1.31.1
)
+4 -2
View File
@@ -78,14 +78,16 @@ github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
golang.org/x/crypto v0.44.0 h1:A97SsFvM3AIwEEmTBiaxPPTYpDC47w720rdiiUvgoAU=
golang.org/x/crypto v0.44.0/go.mod h1:013i+Nw79BMiQiMsOPcVCB5ZIJbYkerPrGnOa00tvmc=
golang.org/x/crypto v0.57.0 h1:3ZVCjf8Ggz7zneR/EHRVx68Ctf+2pmIMP2UFhh9cC6M=
golang.org/x/crypto v0.57.0/go.mod h1:Fdz0i5U6CoizGwLda9DttjSk6qlZo25zYNtR+ycvuZA=
golang.org/x/exp v0.0.0-20251113190631-e25ba8c21ef6 h1:zfMcR1Cs4KNuomFFgGefv5N0czO2XZpUbxGUy8i8ug0=
golang.org/x/exp v0.0.0-20251113190631-e25ba8c21ef6/go.mod h1:46edojNIoXTNOhySWIWdix628clX9ODXwPsQuG6hsK0=
golang.org/x/image v0.46.0 h1:b1+oYj0Jbp6K5MDT4i4/eZpYlk3V8SJhhDKh6LBHAyQ=
golang.org/x/image v0.46.0/go.mod h1:3B3W05VGVQyuXucLINLjXKrqISASfi4Xj+iCVkLMwew=
golang.org/x/mod v0.41.0 h1:qJmnOUb4YB+FsEuM3HcWucdZASCPGhsX6uljO6pog0c=
golang.org/x/mod v0.41.0/go.mod h1:Ek9pY8RKWXwsWvd3rQiHYtMqkjSUV+s1Rj7j4H5Ur6o=
golang.org/x/net v0.59.0 h1:5zfYln+w5XCxwrnMMJPufRgNoXEaGxl0wo5GqPXyues=
golang.org/x/net v0.59.0/go.mod h1:2DA/G1UfVbCpQPeWTmMPGY7Cs2PkBkwu743bVX5PIVg=
golang.org/x/sync v0.23.0 h1:KameEIfc1IkluZyXWLn39Wd4tURc6GbCiISGiZm2bQk=
golang.org/x/sync v0.23.0/go.mod h1:sUUOizhqBxiL6pEWpqNLUiaJn1ShEbZ6BBqskPbjZm0=
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+32
View File
@@ -0,0 +1,32 @@
package article
import (
"errors"
"strings"
)
var ErrUnsupportedBodyFormat = errors.New("unsupported body format")
type BodyFormat string
const (
BodyFormatMarkdown BodyFormat = "markdown"
BodyFormatHTML BodyFormat = "html"
BodyFormatJSON BodyFormat = "json"
)
func ParseBodyFormat(value string) (BodyFormat, error) {
switch strings.ToLower(value) {
case "", string(BodyFormatMarkdown):
return BodyFormatMarkdown, nil
case string(BodyFormatHTML):
return BodyFormatHTML, nil
case string(BodyFormatJSON):
return BodyFormatJSON, nil
}
return "", ErrUnsupportedBodyFormat
}
type BodyRenderer interface {
Render(html string, format BodyFormat) (string, error)
}
+115
View File
@@ -0,0 +1,115 @@
package update
import (
"errors"
"time"
)
const StateIdle = "idle"
var (
ErrNoRelease = errors.New("no release found")
ErrInvalidVersion = errors.New("invalid version")
ErrFeedUnavailable = errors.New("release feed unavailable")
)
type ReleaseNotes struct {
Version string `json:"version"`
ReleasedAt time.Time `json:"released_at"`
Items []string `json:"items"`
}
type Asset struct {
Name string `json:"name"`
URL string `json:"url"`
Size int64 `json:"size"`
}
type Release struct {
Tag string
URL string
PublishedAt time.Time
Notes ReleaseNotes
Assets []Asset
}
type CheckResult struct {
Latest string `json:"latest"`
ReleaseURL string `json:"release_url"`
Notes ReleaseNotes `json:"notes"`
Assets []Asset `json:"assets"`
CheckedAt time.Time `json:"checked_at"`
}
type Progress struct {
Percent int `json:"percent"`
DownloadedBytes int64 `json:"downloaded_bytes"`
TotalBytes int64 `json:"total_bytes"`
}
type UpdateStatus struct {
Current string `json:"current"`
Latest string `json:"latest"`
Available bool `json:"available"`
ReleaseURL *string `json:"release_url"`
Notes *ReleaseNotes `json:"notes"`
CheckedAt *time.Time `json:"checked_at"`
CanApply bool `json:"can_apply"`
State string `json:"state"`
Progress *Progress `json:"progress"`
Error *string `json:"error"`
StartedAt *time.Time `json:"started_at"`
FinishedAt *time.Time `json:"finished_at"`
}
func NewResult(release Release, checkedAt time.Time) CheckResult {
return CheckResult{
Latest: release.Tag,
ReleaseURL: release.URL,
Notes: release.Notes,
Assets: release.Assets,
CheckedAt: checkedAt.UTC(),
}
}
func NewStatus(current string, result *CheckResult) UpdateStatus {
status := UpdateStatus{Current: current, State: StateIdle}
if result == nil {
return status
}
releaseURL := result.ReleaseURL
notes := result.Notes
notes.Items = nonNilItems(notes.Items)
checkedAt := result.CheckedAt
status.Latest = result.Latest
status.Available = IsNewer(current, result.Latest)
status.ReleaseURL = &releaseURL
status.Notes = &notes
status.CheckedAt = &checkedAt
return status
}
func nonNilItems(items []string) []string {
if items == nil {
return []string{}
}
return items
}
func Newest(releases []Release) (Release, error) {
var newest Release
found := false
for _, release := range releases {
if _, err := ParseVersion(release.Tag); err != nil {
continue
}
if !found || IsNewer(newest.Tag, release.Tag) {
newest = release
found = true
}
}
if !found {
return Release{}, ErrNoRelease
}
return newest, nil
}
+138
View File
@@ -0,0 +1,138 @@
package update
import (
"errors"
"strconv"
"strings"
)
var (
ErrNeedsLinux = errors.New("Browser updates need Linux with systemd.")
ErrNeedsSystemd = errors.New("Browser updates need systemd, which this machine is not running.")
ErrNeedsRoot = errors.New("Run this command as root, for example with sudo.")
ErrServiceNotFound = errors.New("Could not find the RenewCMS service. Pass --service, --binary and --data-dir.")
ErrDataDirNotFound = errors.New("Could not find the data directory. Pass --data-dir.")
ErrInvalidPort = errors.New("The port must be a number between 1 and 65535.")
)
const (
OSLinux = "linux"
pathUnitDescription = "Watch for a RenewCMS restart request"
)
type ServiceDescription struct {
Name string
BinaryPath string
DataDir string
EnvironmentFile string
}
type InstallOptions struct {
Service string
Binary string
DataDir string
Port string
}
type MachineProbe interface {
OS() string
SystemdRunning() bool
IsRoot() bool
}
type ServiceLocator interface {
Locate(name string) (ServiceDescription, bool)
PortFromEnvironmentFile(path string) (string, bool)
}
type UnitWriter interface {
Write(name string, content string) error
Remove(name string) (bool, error)
}
type UnitManager interface {
DaemonReload() error
EnableNow(unit string) error
DisableNow(unit string) error
}
type HelperStatusWriter interface {
Write(dataDir string, status HelperStatus) error
Remove(dataDir string) (bool, error)
}
func CheckInstallEnvironment(probe MachineProbe) error {
if probe.OS() != OSLinux {
return ErrNeedsLinux
}
if !probe.SystemdRunning() {
return ErrNeedsSystemd
}
if !probe.IsRoot() {
return ErrNeedsRoot
}
return nil
}
func ValidatePort(port string) error {
number, err := strconv.Atoi(port)
if err != nil || number < 1 || number > 65535 {
return ErrInvalidPort
}
return nil
}
func RenderPathUnit(layout HelperLayout) string {
lines := []string{
"[Unit]",
"Description=" + pathUnitDescription,
"",
"[Path]",
"PathExists=" + layout.RestartRequestPath(),
"Unit=" + ServiceUnitName,
"",
"[Install]",
"WantedBy=multi-user.target",
"",
}
return strings.Join(lines, "\n")
}
func RenderServiceUnit(options InstallOptions) string {
command := []string{
quoteUnitArgument(options.Binary),
"apply-update",
"--service", quoteUnitArgument(options.Service),
"--binary", quoteUnitArgument(options.Binary),
"--data-dir", quoteUnitArgument(options.DataDir),
"--port", options.Port,
}
lines := []string{
"[Unit]",
"Description=RenewCMS update helper",
"",
"[Service]",
"Type=oneshot",
"User=root",
"ExecStart=" + strings.Join(command, " "),
"",
}
return strings.Join(lines, "\n")
}
var unitArgumentEscaper = strings.NewReplacer(
`\`, `\\`,
`"`, `\"`,
`%`, `%%`,
`$`, `$$`,
"\n", `\n`,
"\r", `\r`,
"\t", `\t`,
)
func quoteUnitArgument(value string) string {
if !strings.ContainsAny(value, " \t\r\n\"'\\%$;") {
return value
}
return `"` + unitArgumentEscaper.Replace(value) + `"`
}
+177
View File
@@ -0,0 +1,177 @@
package update
import (
"crypto/sha256"
"encoding/hex"
"errors"
"io"
"net/url"
"os"
"strings"
"time"
)
const (
StateDownloading = "downloading"
StateVerifying = "verifying"
StateReady = "ready"
StateFailed = "failed"
ErrorKindDownload = "download"
ErrorKindVerification = "verification"
ChecksumsAssetName = "checksums.txt"
SignatureAssetName = "checksums.txt.sig"
windowsOS = "windows"
)
var (
ErrNotPrepared = errors.New("this server cannot apply updates")
ErrJobInProgress = errors.New("an update job is already running or ready")
ErrNothingToUpdate = errors.New("there is nothing to update")
ErrPreflightRefused = errors.New("the update cannot be downloaded")
)
type Platform struct {
OS string
Arch string
}
type Job struct {
Tag string `json:"tag"`
State string `json:"state"`
Error string `json:"error"`
StartedAt time.Time `json:"started_at"`
DownloadedBytes int64 `json:"downloaded_bytes"`
TotalBytes int64 `json:"total_bytes"`
StagedBinary string `json:"staged_binary"`
}
type ProgressFunc func(done int64, total int64)
type AssetFetcher interface {
Fetch(asset Asset, destination string, report ProgressFunc) error
}
type SignatureVerifier interface {
Verify(checksumsPath string, signaturePath string) error
}
type StagedBinaryRunner interface {
Version(binaryPath string) (string, error)
}
type DatabaseBackup interface {
Backup() (string, error)
}
type StagingArea interface {
Prepare(tag string) error
PathFor(tag string, name string) string
Size(path string) (int64, error)
ReadChecksums(path string) (string, error)
MakeExecutable(path string) error
Remove(tag string) error
}
type HelperDetector interface {
Installed() bool
}
type JobStore interface {
Load() (Job, bool)
Save(job Job) error
}
type Logger interface {
Printf(format string, args ...any)
}
func (j Job) IsRunning() bool {
return j.State == StateDownloading || j.State == StateVerifying
}
func (j Job) Occupies() bool {
return j.IsRunning() || j.State == StateReady
}
func (j Job) Progress() *Progress {
if j.State != StateDownloading || j.TotalBytes <= 0 {
return nil
}
return &Progress{
Percent: int(j.DownloadedBytes * 100 / j.TotalBytes),
DownloadedBytes: j.DownloadedBytes,
TotalBytes: j.TotalBytes,
}
}
func (s UpdateStatus) WithJob(job Job) UpdateStatus {
s.State = job.State
s.Progress = job.Progress()
s.Error = nil
if job.Error != "" {
kind := job.Error
s.Error = &kind
}
startedAt := job.StartedAt
s.StartedAt = &startedAt
return s
}
func AssetName(tag string, platform Platform) string {
name := "renewcms_" + tag + "_" + platform.OS + "_" + platform.Arch
if platform.OS == windowsOS {
name += ".exe"
}
return name
}
func FindAsset(assets []Asset, name string) (Asset, bool) {
for _, asset := range assets {
if asset.Name == name {
return asset, true
}
}
return Asset{}, false
}
func HostOf(rawURL string) string {
parsed, err := url.Parse(rawURL)
if err != nil {
return ""
}
return parsed.Host
}
func IsAllowedAssetURL(rawURL string, allowedHost string) bool {
parsed, err := url.Parse(rawURL)
if err != nil || parsed.Scheme != "https" {
return false
}
return allowedHost != "" && parsed.Host == allowedHost
}
func ChecksumFor(checksums string, assetName string) (string, bool) {
for _, line := range strings.Split(checksums, "\n") {
fields := strings.Fields(line)
if len(fields) == 2 && strings.TrimPrefix(fields[1], "*") == assetName {
return strings.ToLower(fields[0]), true
}
}
return "", false
}
func FileSHA256(path string) (string, error) {
file, err := os.Open(path)
if err != nil {
return "", err
}
defer file.Close()
hash := sha256.New()
if _, err := io.Copy(hash, file); err != nil {
return "", err
}
return hex.EncodeToString(hash.Sum(nil)), nil
}
+63
View File
@@ -0,0 +1,63 @@
package update
import (
"crypto/sha256"
"encoding/hex"
"path"
)
const (
RestartRequestFileName = "update-restart-request.json"
ResultFileName = "update-result.json"
HelperStatusFileName = "update-helper.json"
RunningInfoFileName = "update-running.json"
UpdatesDirName = "updates"
HelperStatusVersion = 1
PathUnitName = "renewcms-update.path"
ServiceUnitName = "renewcms-update.service"
DefaultService = "renewcms"
DefaultPort = "8080"
PreviousSuffix = ".previous"
PreviousTempSuffix = ".previous.tmp"
InstallTempSuffix = ".new"
RestoreTempSuffix = ".restore"
ResultTempSuffix = ".tmp"
ExecutableMode = 0o755
PrivateFileMode = 0o600
)
type HelperLayout struct {
DataDir string
BinaryPath string
}
func (l HelperLayout) UpdatesDir() string {
return path.Join(l.DataDir, UpdatesDirName)
}
func (l HelperLayout) StagedDir(tag string) string {
return path.Join(l.UpdatesDir(), tag)
}
func (l HelperLayout) ResultPath() string {
return path.Join(l.DataDir, ResultFileName)
}
func (l HelperLayout) ResultTempPath() string {
return l.ResultPath() + ResultTempSuffix
}
func (l HelperLayout) RestartRequestPath() string {
return path.Join(l.DataDir, RestartRequestFileName)
}
func (l HelperLayout) PreviousPath() string {
return l.BinaryPath + PreviousSuffix
}
func SHA256Hex(content []byte) string {
sum := sha256.Sum256(content)
return hex.EncodeToString(sum[:])
}
+37
View File
@@ -0,0 +1,37 @@
package update
import (
"regexp"
"strings"
"time"
)
var (
bulletLine = regexp.MustCompile(`^[-*+]\s+(.+)$`)
markdownLink = regexp.MustCompile(`!?\[([^\]]*)\]\([^)]*\)`)
boldText = regexp.MustCompile(`\*\*([^*]+)\*\*|__([^_]+)__`)
italicText = regexp.MustCompile(`\*([^*\s][^*]*)\*`)
inlineCode = regexp.MustCompile("`([^`]*)`")
)
func BuildNotes(tag string, publishedAt time.Time, body string) ReleaseNotes {
items := []string{}
for _, line := range strings.Split(body, "\n") {
match := bulletLine.FindStringSubmatch(strings.TrimSpace(line))
if match == nil {
continue
}
if item := plainText(match[1]); item != "" {
items = append(items, item)
}
}
return ReleaseNotes{Version: tag, ReleasedAt: publishedAt, Items: items}
}
func plainText(markdown string) string {
text := markdownLink.ReplaceAllString(markdown, "$1")
text = boldText.ReplaceAllString(text, "$1$2")
text = italicText.ReplaceAllString(text, "$1")
text = inlineCode.ReplaceAllString(text, "$1")
return strings.TrimSpace(text)
}
@@ -0,0 +1,10 @@
package update
type ReleaseFeed interface {
Latest() (Release, error)
}
type StatusStore interface {
Load() (CheckResult, bool)
Save(result CheckResult) error
}
+158
View File
@@ -0,0 +1,158 @@
package update
import (
"errors"
"regexp"
"time"
)
const (
StateRestarting = "restarting"
StateSucceeded = "succeeded"
ErrorKindRolledBack = "rolled_back"
ErrorKindInstall = "install"
RestartKindUpdate = "update"
RestartKindRestart = "restart"
OutcomeRunning = "running"
OutcomeSucceeded = "succeeded"
OutcomeRolledBack = "rolled_back"
OutcomeFailed = "failed"
RunningResultMaxAge = 5 * time.Minute
)
var (
ErrRestartPending = errors.New("a restart is already pending or running")
ErrRestartKindMismatch = errors.New("the requested restart does not match the current state")
ErrNoRestartRequest = errors.New("there is no restart request")
ErrSymlinkRefused = errors.New("a symbolic link was found where a regular file is required")
ErrInvalidRestartTag = errors.New("the restart request names an invalid version")
ErrHelperUnsupported = errors.New("the privileged helper needs Linux")
)
var restartTagPattern = regexp.MustCompile(`^v[0-9]+(\.[0-9]+)*(-[0-9A-Za-z.]+)?$`)
type RestartRequest struct {
Kind string `json:"kind"`
Tag string `json:"tag,omitempty"`
RequestedAt time.Time `json:"requested_at"`
RequestedBy uint32 `json:"requested_by"`
}
type Result struct {
Outcome string `json:"outcome"`
Kind string `json:"kind"`
Tag string `json:"tag"`
FromVersion string `json:"from_version"`
StartedAt time.Time `json:"started_at"`
FinishedAt *time.Time `json:"finished_at"`
}
type RunningInfo struct {
Version string `json:"version"`
Pid int `json:"pid"`
StartedAt time.Time `json:"started_at"`
}
type HelperStatus struct {
Version int `json:"version"`
Service string `json:"service"`
Binary string `json:"binary"`
DataDir string `json:"data_dir"`
InstalledAt time.Time `json:"installed_at"`
}
type FileInfo struct {
IsSymlink bool
IsDir bool
IsRegular bool
}
type RestartRequestStore interface {
Write(request RestartRequest) error
Read() (RestartRequest, error)
Delete() error
}
type ResultStore interface {
Read() (Result, bool)
Write(result Result) error
Delete() error
}
type RunningInfoStore interface {
Write(info RunningInfo) error
Read() (RunningInfo, bool)
}
type HelperFilesystem interface {
Lstat(path string) (FileInfo, error)
ReadFile(path string) ([]byte, error)
CreateExclusive(path string, content []byte, mode uint32) error
Copy(source string, destination string, mode uint32) error
Rename(oldPath string, newPath string) error
Remove(path string) error
RemoveAll(path string) error
Chmod(path string, mode uint32) error
MakePrivateTempDir() (string, error)
}
type ServiceControl interface {
Restart() error
Status() (bool, error)
}
type HealthChecker interface {
Healthy() bool
}
type Clock interface {
Now() time.Time
Sleep(duration time.Duration)
}
func ValidateRestartTag(tag string, runningVersion string) error {
if !restartTagPattern.MatchString(tag) {
return ErrInvalidRestartTag
}
if _, err := ParseVersion(tag); err != nil || !IsNewer(runningVersion, tag) {
return ErrInvalidRestartTag
}
return nil
}
func (r Result) IsRunning() bool {
return r.Outcome == OutcomeRunning
}
func (r Result) IsKnown() bool {
switch r.Outcome {
case OutcomeRunning, OutcomeSucceeded, OutcomeRolledBack, OutcomeFailed:
return true
}
return false
}
func (i RunningInfo) IsNewerThan(previous RunningInfo, restartedAt time.Time) bool {
return i.Pid != previous.Pid || i.StartedAt.After(restartedAt)
}
const (
RestartWindow = 60 * time.Second
PollInterval = time.Second
)
type SymlinkError struct {
Path string
}
func (e SymlinkError) Error() string {
return e.Path + " is a symbolic link"
}
func (e SymlinkError) Is(target error) bool {
return target == ErrSymlinkRefused
}
@@ -0,0 +1,38 @@
package update
import "time"
func (s UpdateStatus) WithRestartRequest(request RestartRequest) UpdateStatus {
return s.settled(StateRestarting, "", request.RequestedAt)
}
func (s UpdateStatus) WithResult(result Result, currentVersion string, now time.Time) UpdateStatus {
if result.IsRunning() && now.Sub(result.StartedAt) < RunningResultMaxAge {
return s.settled(StateRestarting, "", result.StartedAt)
}
if result.IsRunning() || result.Outcome == OutcomeFailed {
return s.settled(StateFailed, ErrorKindInstall, result.StartedAt)
}
if result.Outcome == OutcomeRolledBack {
return s.settled(StateFailed, ErrorKindRolledBack, result.StartedAt)
}
if result.Kind == RestartKindUpdate && result.Tag == currentVersion {
return s.settled(StateSucceeded, "", result.StartedAt)
}
s.State = StateIdle
s.Progress = nil
s.Error = nil
s.StartedAt = nil
return s
}
func (s UpdateStatus) settled(state string, errorKind string, startedAt time.Time) UpdateStatus {
s.State = state
s.Progress = nil
s.Error = nil
if errorKind != "" {
s.Error = &errorKind
}
s.StartedAt = &startedAt
return s
}
+101
View File
@@ -0,0 +1,101 @@
package update
import (
"cmp"
"strconv"
"strings"
)
type Version struct {
numbers []int
pre []string
}
func ParseVersion(raw string) (Version, error) {
trimmed := strings.TrimPrefix(strings.TrimSpace(raw), "v")
core, pre, hasPre := strings.Cut(trimmed, "-")
if core == "" || (hasPre && pre == "") {
return Version{}, ErrInvalidVersion
}
var version Version
for _, segment := range strings.Split(core, ".") {
number, err := strconv.Atoi(segment)
if err != nil || number < 0 {
return Version{}, ErrInvalidVersion
}
version.numbers = append(version.numbers, number)
}
if hasPre {
version.pre = strings.Split(pre, ".")
}
return version, nil
}
func IsNewer(current, latest string) bool {
currentVersion, err := ParseVersion(current)
if err != nil {
return false
}
latestVersion, err := ParseVersion(latest)
if err != nil {
return false
}
return compareVersions(latestVersion, currentVersion) > 0
}
func compareVersions(a, b Version) int {
if order := compareNumbers(a.numbers, b.numbers); order != 0 {
return order
}
return comparePreRelease(a.pre, b.pre)
}
func compareNumbers(a, b []int) int {
for i := range max(len(a), len(b)) {
if order := cmp.Compare(segmentAt(a, i), segmentAt(b, i)); order != 0 {
return order
}
}
return 0
}
func segmentAt(numbers []int, index int) int {
if index < len(numbers) {
return numbers[index]
}
return 0
}
func comparePreRelease(a, b []string) int {
if len(a) == 0 && len(b) == 0 {
return 0
}
if len(a) == 0 {
return 1
}
if len(b) == 0 {
return -1
}
length := min(len(a), len(b))
for i := 0; i < length; i++ {
if order := compareIdentifiers(a[i], b[i]); order != 0 {
return order
}
}
return cmp.Compare(len(a), len(b))
}
func compareIdentifiers(a, b string) int {
numberA, errA := strconv.Atoi(a)
numberB, errB := strconv.Atoi(b)
if errA == nil && errB == nil {
return cmp.Compare(numberA, numberB)
}
if errA == nil {
return -1
}
if errB == nil {
return 1
}
return strings.Compare(a, b)
}
@@ -32,6 +32,7 @@ type Settings struct {
AuthRateLimit AuthRateLimitSettings
TrustedProxies []string
Version string
UpdateFeedURL string
}
func (s Settings) IsProduction() bool {
@@ -74,6 +75,7 @@ func NewSettingsFromEnv() (Settings, error) {
Window: time.Duration(authRateLimitWindowSeconds) * time.Second,
},
TrustedProxies: parseSemicolonSeparatedList(os.Getenv("TRUSTED_PROXIES")),
UpdateFeedURL: os.Getenv("UPDATE_FEED_URL"),
}, nil
}
+365
View File
@@ -0,0 +1,365 @@
package markdown
import (
"net/url"
"strconv"
"strings"
"golang.org/x/net/html"
"golang.org/x/net/html/atom"
)
const (
markBold = "bold"
markItalic = "italic"
markLink = "link"
markCode = "code"
codeLanguagePrefix = "language-"
)
type mark struct {
kind string
href string
}
type inline struct {
text string
marks []mark
}
type blockKind int
const (
kindHeading blockKind = iota
kindParagraph
kindList
kindBlockquote
kindCode
kindRule
kindImage
)
type block struct {
kind blockKind
level int
inlines []inline
ordered bool
items [][]block
children []block
language string
text string
src string
alt string
align string
}
var transparentBlocks = map[string]bool{
"div": true, "section": true, "article": true, "header": true, "footer": true,
"main": true, "aside": true, "nav": true, "figure": true, "figcaption": true,
"table": true, "thead": true, "tbody": true, "tfoot": true, "tr": true,
"td": true, "th": true, "dl": true, "dt": true, "dd": true, "details": true,
"summary": true, "li": true,
}
var skippedElements = map[string]bool{
"script": true, "style": true, "template": true, "head": true,
"noscript": true, "iframe": true, "object": true, "embed": true,
}
var alignments = map[string]bool{"center": true, "right": true, "justify": true}
var allowedLinkSchemes = map[string]bool{
"": true, "http": true, "https": true, "mailto": true, "tel": true,
}
func parseBlocks(source string) ([]block, error) {
context := &html.Node{Type: html.ElementNode, DataAtom: atom.Body, Data: "body"}
nodes, err := html.ParseFragment(strings.NewReader(source), context)
if err != nil {
return nil, err
}
collector := newCollector(false, paragraphBlock)
collector.walkAll(nodes, nil)
return collector.finish(false), nil
}
func paragraphBlock(inlines []inline) block {
return block{kind: kindParagraph, inlines: inlines}
}
func headingBlock(level int) func([]inline) block {
return func(inlines []inline) block {
return block{kind: kindHeading, level: level, inlines: inlines}
}
}
type collector struct {
out []block
current []inline
keepBlank bool
build func([]inline) block
}
func newCollector(keepBlank bool, build func([]inline) block) *collector {
return &collector{keepBlank: keepBlank, build: build}
}
func (c *collector) walkAll(nodes []*html.Node, marks []mark) {
for _, node := range nodes {
c.walk(node, marks)
}
}
func (c *collector) walkChildren(parent *html.Node, marks []mark) {
for child := parent.FirstChild; child != nil; child = child.NextSibling {
c.walk(child, marks)
}
}
func (c *collector) addText(text string, marks []mark) {
if text == "" {
return
}
c.current = appendInline(c.current, inline{text: text, marks: marks})
}
func (c *collector) flush() {
if len(c.current) == 0 {
return
}
if c.keepBlank || hasVisibleText(c.current) {
c.out = append(c.out, c.build(c.current))
}
c.current = nil
}
func (c *collector) finish(emitEmpty bool) []block {
hadBlocks := len(c.out) > 0
c.flush()
if emitEmpty && !hadBlocks && len(c.out) == 0 {
c.out = append(c.out, c.build(nil))
}
return c.out
}
func (c *collector) walk(node *html.Node, marks []mark) {
switch node.Type {
case html.TextNode:
c.addText(node.Data, marks)
return
case html.ElementNode:
default:
return
}
tag := node.Data
if skippedElements[tag] {
return
}
switch tag {
case "br":
c.addText("\n", marks)
case "strong", "b":
c.walkChildren(node, withMark(marks, mark{kind: markBold}))
case "em", "i":
c.walkChildren(node, withMark(marks, mark{kind: markItalic}))
case "code":
c.walkChildren(node, withMark(marks, mark{kind: markCode}))
case "a":
href := safeHref(attr(node, "href"))
if href == "" {
c.walkChildren(node, marks)
return
}
c.walkChildren(node, withMark(marks, mark{kind: markLink, href: href}))
case "img":
c.flush()
if src := attr(node, "src"); src != "" {
c.out = append(c.out, block{kind: kindImage, src: src, alt: attr(node, "alt")})
}
case "hr":
c.flush()
c.out = append(c.out, block{kind: kindRule})
case "p":
c.flush()
c.out = append(c.out, parseTextBlock(node, paragraphBlock)...)
case "h1", "h2", "h3", "h4", "h5", "h6":
c.flush()
level, _ := strconv.Atoi(tag[1:])
c.out = append(c.out, parseTextBlock(node, headingBlock(level))...)
case "ul", "ol":
c.flush()
c.out = append(c.out, parseList(node))
case "blockquote":
c.flush()
c.out = append(c.out, block{kind: kindBlockquote, children: parseContainer(node)})
case "pre":
c.flush()
c.out = append(c.out, parseCodeBlock(node))
default:
if transparentBlocks[tag] {
c.flush()
c.walkChildren(node, marks)
c.flush()
return
}
c.walkChildren(node, marks)
}
}
func parseTextBlock(node *html.Node, build func([]inline) block) []block {
inner := newCollector(true, build)
inner.walkChildren(node, nil)
blocks := inner.finish(true)
if align := alignFromStyle(attr(node, "style")); align != "" {
for index := range blocks {
if blocks[index].kind == kindParagraph || blocks[index].kind == kindHeading {
blocks[index].align = align
}
}
}
return blocks
}
func alignFromStyle(style string) string {
for _, declaration := range strings.Split(style, ";") {
name, value, found := strings.Cut(declaration, ":")
if !found || strings.ToLower(strings.TrimSpace(name)) != "text-align" {
continue
}
if align := strings.ToLower(strings.TrimSpace(value)); alignments[align] {
return align
}
}
return ""
}
func parseContainer(node *html.Node) []block {
inner := newCollector(false, paragraphBlock)
inner.walkChildren(node, nil)
return inner.finish(false)
}
func parseList(node *html.Node) block {
list := block{kind: kindList, ordered: node.Data == "ol"}
for child := node.FirstChild; child != nil; child = child.NextSibling {
if child.Type == html.ElementNode && child.Data == "li" {
list.items = append(list.items, parseContainer(child))
}
}
return list
}
func parseCodeBlock(node *html.Node) block {
code := block{kind: kindCode, text: strings.TrimSuffix(textContent(node), "\n")}
for child := node.FirstChild; child != nil; child = child.NextSibling {
if child.Type == html.ElementNode && child.Data == "code" {
code.language = languageFromClass(attr(child, "class"))
break
}
}
return code
}
func languageFromClass(class string) string {
for _, name := range strings.Fields(class) {
if strings.HasPrefix(name, codeLanguagePrefix) {
return strings.TrimPrefix(name, codeLanguagePrefix)
}
}
return ""
}
func textContent(node *html.Node) string {
var builder strings.Builder
var visit func(*html.Node)
visit = func(n *html.Node) {
switch {
case n.Type == html.TextNode:
builder.WriteString(n.Data)
case n.Type == html.ElementNode && skippedElements[n.Data]:
return
case n.Type == html.ElementNode && n.Data == "br":
builder.WriteString("\n")
}
for child := n.FirstChild; child != nil; child = child.NextSibling {
visit(child)
}
}
visit(node)
return builder.String()
}
func attr(node *html.Node, name string) string {
for _, a := range node.Attr {
if a.Key == name {
return a.Val
}
}
return ""
}
func safeHref(href string) string {
trimmed := strings.TrimSpace(href)
parsed, err := url.Parse(trimmed)
if err != nil || !allowedLinkSchemes[strings.ToLower(parsed.Scheme)] {
return ""
}
return trimmed
}
func withMark(marks []mark, added mark) []mark {
for _, existing := range marks {
if existing.kind == added.kind {
return marks
}
}
next := make([]mark, 0, len(marks)+1)
next = append(next, marks...)
return append(next, added)
}
func hasVisibleText(inlines []inline) bool {
for _, item := range inlines {
if strings.TrimSpace(item.text) != "" {
return true
}
}
return false
}
func sameMarks(a, b []mark) bool {
if len(a) != len(b) {
return false
}
for index := range a {
if a[index] != b[index] {
return false
}
}
return true
}
func appendInline(inlines []inline, next inline) []inline {
if last := len(inlines) - 1; last >= 0 && sameMarks(inlines[last].marks, next.marks) {
inlines[last].text += next.text
return inlines
}
return append(inlines, next)
}
func withoutCodeMarks(inlines []inline) []inline {
merged := make([]inline, 0, len(inlines))
for _, item := range inlines {
kept := make([]mark, 0, len(item.marks))
for _, m := range item.marks {
if m.kind != markCode {
kept = append(kept, m)
}
}
merged = appendInline(merged, inline{text: item.text, marks: kept})
}
return merged
}
@@ -0,0 +1,33 @@
package markdown
import (
domain "RenewCMS/internal/domain/article"
)
type Converter struct{}
var _ domain.BodyRenderer = &Converter{}
func NewConverter() *Converter {
return &Converter{}
}
func (c *Converter) Render(html string, format domain.BodyFormat) (string, error) {
switch format {
case domain.BodyFormatHTML:
return html, nil
case domain.BodyFormatMarkdown:
blocks, err := parseBlocks(html)
if err != nil {
return "", err
}
return renderMarkdown(blocks), nil
case domain.BodyFormatJSON:
blocks, err := parseBlocks(html)
if err != nil {
return "", err
}
return renderJSON(blocks)
}
return "", domain.ErrUnsupportedBodyFormat
}
@@ -0,0 +1,111 @@
package markdown
import (
"bytes"
"encoding/json"
"strings"
)
type jsonMark struct {
Type string `json:"type"`
Href string `json:"href,omitempty"`
}
type jsonText struct {
Type string `json:"type"`
Text string `json:"text"`
Marks []jsonMark `json:"marks"`
}
type jsonHeading struct {
Type string `json:"type"`
Level int `json:"level"`
Align string `json:"align,omitempty"`
Children []jsonText `json:"children"`
}
type jsonParagraph struct {
Type string `json:"type"`
Align string `json:"align,omitempty"`
Children []jsonText `json:"children"`
}
type jsonList struct {
Type string `json:"type"`
Ordered bool `json:"ordered"`
Items [][]any `json:"items"`
}
type jsonBlockquote struct {
Type string `json:"type"`
Children []any `json:"children"`
}
type jsonCode struct {
Type string `json:"type"`
Language string `json:"language"`
Text string `json:"text"`
}
type jsonRule struct {
Type string `json:"type"`
}
type jsonImage struct {
Type string `json:"type"`
Src string `json:"src"`
Alt string `json:"alt"`
}
func renderJSON(blocks []block) (string, error) {
var buffer bytes.Buffer
encoder := json.NewEncoder(&buffer)
encoder.SetEscapeHTML(false)
if err := encoder.Encode(toJSONBlocks(blocks)); err != nil {
return "", err
}
return strings.TrimSuffix(buffer.String(), "\n"), nil
}
func toJSONBlocks(blocks []block) []any {
result := make([]any, 0, len(blocks))
for _, b := range blocks {
result = append(result, toJSONBlock(b))
}
return result
}
func toJSONBlock(b block) any {
switch b.kind {
case kindHeading:
return jsonHeading{Type: "heading", Level: b.level, Align: b.align, Children: toJSONTexts(b.inlines)}
case kindParagraph:
return jsonParagraph{Type: "paragraph", Align: b.align, Children: toJSONTexts(b.inlines)}
case kindList:
items := make([][]any, 0, len(b.items))
for _, item := range b.items {
items = append(items, toJSONBlocks(item))
}
return jsonList{Type: "list", Ordered: b.ordered, Items: items}
case kindBlockquote:
return jsonBlockquote{Type: "blockquote", Children: toJSONBlocks(b.children)}
case kindCode:
return jsonCode{Type: "code", Language: b.language, Text: b.text}
case kindImage:
return jsonImage{Type: "image", Src: b.src, Alt: b.alt}
}
return jsonRule{Type: "hr"}
}
func toJSONTexts(inlines []inline) []jsonText {
plain := withoutCodeMarks(inlines)
texts := make([]jsonText, 0, len(plain))
for _, item := range plain {
marks := make([]jsonMark, 0, len(item.marks))
for _, m := range item.marks {
marks = append(marks, jsonMark{Type: m.kind, Href: m.href})
}
texts = append(texts, jsonText{Type: "text", Text: item.text, Marks: marks})
}
return texts
}
@@ -0,0 +1,213 @@
package markdown
import (
"regexp"
"strconv"
"strings"
)
const (
blockSeparator = "\n\n"
hardBreak = "\\\n"
bulletMarker = "- "
codeFence = "```"
alignOpen = `<div style="text-align: `
alignOpenEnd = `">`
alignClose = "</div>"
)
var textEscaper = strings.NewReplacer(
"\\", "\\\\", "*", "\\*", "_", "\\_", "`", "\\`", "[", "\\[", "]", "\\]", "<", "\\<",
)
var (
numberedLineStart = regexp.MustCompile(`^(\d+)([.)])(\s|$)`)
markerLineStart = regexp.MustCompile(`^(>|#{1,6}(\s|$)|[+-](\s|$|-)|=+\s*$)`)
)
var hrefEscaper = strings.NewReplacer(" ", "%20", "(", "%28", ")", "%29", "<", "%3C", ">", "%3E")
func renderMarkdown(blocks []block) string {
return renderBlocks(blocks, blockSeparator)
}
func renderBlocks(blocks []block, separator string) string {
parts := make([]string, 0, len(blocks))
for _, b := range blocks {
if rendered := renderBlock(b); rendered != "" {
parts = append(parts, rendered)
}
}
return strings.Join(parts, separator)
}
func renderBlock(b block) string {
rendered := renderPlainBlock(b)
if b.align == "" || rendered == "" {
return rendered
}
return alignOpen + b.align + alignOpenEnd + blockSeparator + rendered + blockSeparator + alignClose
}
func renderPlainBlock(b block) string {
switch b.kind {
case kindHeading:
return strings.Repeat("#", b.level) + " " + renderInlines(b.inlines)
case kindParagraph:
return escapeLineStarts(renderInlines(b.inlines))
case kindList:
return renderList(b)
case kindBlockquote:
return prefixLines(renderBlocks(b.children, blockSeparator), "> ", ">")
case kindCode:
return renderCode(b)
case kindImage:
return "![" + escapeAlt(b.alt) + "](" + hrefEscaper.Replace(b.src) + ")"
}
return "---"
}
func escapeLineStarts(text string) string {
lines := strings.Split(text, "\n")
for index, line := range lines {
line = numberedLineStart.ReplaceAllString(line, `$1\$2$3`)
if markerLineStart.MatchString(line) {
line = `\` + line
}
lines[index] = line
}
return strings.Join(lines, "\n")
}
func renderCode(b block) string {
fence := codeFence
for strings.Contains(b.text, fence) {
fence += "`"
}
return fence + b.language + "\n" + b.text + "\n" + fence
}
func escapeAlt(alt string) string {
return strings.NewReplacer("[", "\\[", "]", "\\]", "\n", " ").Replace(alt)
}
func renderList(b block) string {
lines := make([]string, 0, len(b.items))
for index, item := range b.items {
marker := bulletMarker
if b.ordered {
marker = strconv.Itoa(index+1) + ". "
}
content := renderBlocks(item, itemSeparator(item))
lines = append(lines, marker+indentContinuation(content, len(marker)))
}
return strings.Join(lines, "\n")
}
func itemSeparator(item []block) string {
textBlocks := 0
for _, b := range item {
if b.kind != kindList {
textBlocks++
}
}
if textBlocks > 1 {
return blockSeparator
}
return "\n"
}
func indentContinuation(content string, width int) string {
indent := strings.Repeat(" ", width)
lines := strings.Split(content, "\n")
for index := 1; index < len(lines); index++ {
if lines[index] != "" {
lines[index] = indent + lines[index]
}
}
return strings.Join(lines, "\n")
}
func prefixLines(content, prefix, emptyPrefix string) string {
lines := strings.Split(content, "\n")
for index, line := range lines {
if line == "" {
lines[index] = emptyPrefix
continue
}
lines[index] = prefix + line
}
return strings.Join(lines, "\n")
}
func renderInlines(inlines []inline) string {
var builder strings.Builder
for _, item := range inlines {
builder.WriteString(renderInline(item))
}
return builder.String()
}
func renderInline(item inline) string {
isCode := hasMarkKind(item.marks, markCode)
lines := strings.Split(item.text, "\n")
for index, line := range lines {
lines[index] = wrapMarks(item.marks, line, isCode)
}
return strings.Join(lines, hardBreak)
}
func hasMarkKind(marks []mark, kind string) bool {
for _, m := range marks {
if m.kind == kind {
return true
}
}
return false
}
func wrapMarks(marks []mark, text string, isCode bool) string {
core := strings.TrimSpace(text)
if core == "" {
return text
}
start := strings.Index(text, core)
leading, trailing := text[:start], text[start+len(core):]
var wrapped string
if isCode {
wrapped = inlineCode(core)
} else {
wrapped = escapeText(core)
}
for index := len(marks) - 1; index >= 0; index-- {
wrapped = applyMark(marks[index], wrapped)
}
return leading + wrapped + trailing
}
func inlineCode(text string) string {
fence := "`"
for strings.Contains(text, fence) {
fence += "`"
}
if strings.HasPrefix(text, "`") || strings.HasSuffix(text, "`") {
return fence + " " + text + " " + fence
}
return fence + text + fence
}
func applyMark(m mark, text string) string {
switch m.kind {
case markBold:
return "**" + text + "**"
case markItalic:
return "*" + text + "*"
case markLink:
return "[" + text + "](" + hrefEscaper.Replace(m.href) + ")"
}
return text
}
func escapeText(text string) string {
return textEscaper.Replace(text)
}
@@ -0,0 +1,46 @@
package update
import (
"encoding/json"
"errors"
"io/fs"
"os"
)
const readableFilePermissions = 0o644
func writeFileAtomically(path string, content []byte, permissions os.FileMode) error {
temporary := path + ".tmp"
if err := os.WriteFile(temporary, content, permissions); err != nil {
return err
}
if err := os.Rename(temporary, path); err != nil {
_ = os.Remove(temporary)
return err
}
return nil
}
func writeJSONAtomically(path string, value any, permissions os.FileMode) error {
content, err := json.Marshal(value)
if err != nil {
return err
}
return writeFileAtomically(path, content, permissions)
}
func removeFile(path string) (bool, error) {
err := os.Remove(path)
if err == nil {
return true, nil
}
if errors.Is(err, fs.ErrNotExist) {
return false, nil
}
return false, err
}
func removeIfPresent(path string) error {
_, err := removeFile(path)
return err
}
@@ -0,0 +1,44 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"crypto/ed25519"
"encoding/base64"
"errors"
"os"
"strings"
)
var (
errSignatureEncoding = errors.New("the signature is not a base64 encoded ed25519 signature")
errSignatureMismatch = errors.New("the signature does not match the checksums file")
)
type Ed25519SignatureVerifier struct {
key ed25519.PublicKey
}
var _ domain.SignatureVerifier = &Ed25519SignatureVerifier{}
func NewEd25519SignatureVerifier(key ed25519.PublicKey) *Ed25519SignatureVerifier {
return &Ed25519SignatureVerifier{key: key}
}
func (v *Ed25519SignatureVerifier) Verify(checksumsPath string, signaturePath string) error {
content, err := os.ReadFile(checksumsPath)
if err != nil {
return err
}
rawSignature, err := os.ReadFile(signaturePath)
if err != nil {
return err
}
signature, err := base64.StdEncoding.DecodeString(strings.TrimSpace(string(rawSignature)))
if err != nil || len(signature) != ed25519.SignatureSize {
return errSignatureEncoding
}
if len(v.key) != ed25519.PublicKeySize || !ed25519.Verify(v.key, content, signature) {
return errSignatureMismatch
}
return nil
}
@@ -0,0 +1,29 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"context"
"os/exec"
"strings"
"time"
)
const stagedBinaryRunTimeout = 15 * time.Second
type ExecStagedBinaryRunner struct{}
var _ domain.StagedBinaryRunner = &ExecStagedBinaryRunner{}
func NewExecStagedBinaryRunner() *ExecStagedBinaryRunner {
return &ExecStagedBinaryRunner{}
}
func (r *ExecStagedBinaryRunner) Version(binaryPath string) (string, error) {
ctx, cancel := context.WithTimeout(context.Background(), stagedBinaryRunTimeout)
defer cancel()
output, err := exec.CommandContext(ctx, binaryPath, "--version").Output()
if err != nil {
return "", err
}
return strings.TrimSpace(string(output)), nil
}
@@ -0,0 +1,26 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"os"
)
type FileHelperDetector struct {
statusPath string
}
var _ domain.HelperDetector = &FileHelperDetector{}
func NewFileHelperDetector(statusPath string) *FileHelperDetector {
return &FileHelperDetector{statusPath: statusPath}
}
func (d *FileHelperDetector) Installed() bool {
content, err := os.ReadFile(d.statusPath)
if err != nil {
return false
}
var status map[string]any
return json.Unmarshal(content, &status) == nil && status != nil
}
@@ -0,0 +1,82 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"errors"
"fmt"
"io/fs"
)
type FSRestartRequestStore struct {
files domain.HelperFilesystem
path string
}
var _ domain.RestartRequestStore = &FSRestartRequestStore{}
func NewFSRestartRequestStore(files domain.HelperFilesystem, path string) *FSRestartRequestStore {
return &FSRestartRequestStore{files: files, path: path}
}
func (s *FSRestartRequestStore) Write(request domain.RestartRequest) error {
return writeJSONThroughTemporary(s.files, s.path, request, statusFilePermissions)
}
func (s *FSRestartRequestStore) Read() (domain.RestartRequest, error) {
info, err := s.files.Lstat(s.path)
if errors.Is(err, fs.ErrNotExist) {
return domain.RestartRequest{}, domain.ErrNoRestartRequest
}
if err != nil {
return domain.RestartRequest{}, err
}
if info.IsSymlink {
return domain.RestartRequest{}, domain.SymlinkError{Path: s.path}
}
if !info.IsRegular {
return domain.RestartRequest{}, fmt.Errorf("%s is not a regular file", s.path)
}
content, err := s.files.ReadFile(s.path)
if err != nil {
return domain.RestartRequest{}, err
}
var request domain.RestartRequest
return request, json.Unmarshal(content, &request)
}
func (s *FSRestartRequestStore) Delete() error {
return removeThrough(s.files, s.path)
}
func removeThrough(files domain.HelperFilesystem, path string) error {
if err := files.Remove(path); err != nil && !errors.Is(err, fs.ErrNotExist) {
return err
}
return nil
}
func writeJSONThroughTemporary(files domain.HelperFilesystem, path string, value any, mode uint32) error {
content, err := json.Marshal(value)
if err != nil {
return err
}
return writeThroughTemporary(files, path, content, mode)
}
func writeThroughTemporary(files domain.HelperFilesystem, path string, content []byte, mode uint32) error {
temporary := path + domain.ResultTempSuffix
if _, err := files.Lstat(temporary); err == nil {
if err := files.Remove(temporary); err != nil {
return err
}
}
if err := files.CreateExclusive(temporary, content, mode); err != nil {
return err
}
if err := files.Rename(temporary, path); err != nil {
_ = files.Remove(temporary)
return err
}
return nil
}
@@ -0,0 +1,36 @@
package update
import (
domain "RenewCMS/internal/domain/update"
)
type FSResultStore struct {
files domain.HelperFilesystem
path string
}
var _ domain.ResultStore = &FSResultStore{}
func NewFSResultStore(files domain.HelperFilesystem, path string) *FSResultStore {
return &FSResultStore{files: files, path: path}
}
func (s *FSResultStore) Read() (domain.Result, bool) {
info, err := s.files.Lstat(s.path)
if err != nil || !info.IsRegular {
return domain.Result{}, false
}
content, err := s.files.ReadFile(s.path)
if err != nil {
return domain.Result{}, false
}
return decodeResult(content)
}
func (s *FSResultStore) Write(result domain.Result) error {
return writeJSONThroughTemporary(s.files, s.path, result, readableFilePermissions)
}
func (s *FSResultStore) Delete() error {
return removeThrough(s.files, s.path)
}
@@ -0,0 +1,95 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"fmt"
"io"
"net/http"
"strings"
"time"
)
const (
releasesPath = "/api/v1/repos/fsylvain/RenewCMS/releases"
feedRequestTimeout = 10 * time.Second
maxFeedBodyBytes = 4 << 20
)
type GiteaReleaseFeed struct {
baseURL string
client *http.Client
}
var _ domain.ReleaseFeed = &GiteaReleaseFeed{}
type giteaRelease struct {
TagName string `json:"tag_name"`
HTMLURL string `json:"html_url"`
Body string `json:"body"`
Draft bool `json:"draft"`
PublishedAt time.Time `json:"published_at"`
Assets []giteaAsset `json:"assets"`
}
type giteaAsset struct {
Name string `json:"name"`
Size int64 `json:"size"`
DownloadURL string `json:"browser_download_url"`
}
func NewGiteaReleaseFeed(baseURL string) *GiteaReleaseFeed {
return &GiteaReleaseFeed{
baseURL: strings.TrimRight(baseURL, "/"),
client: &http.Client{Timeout: feedRequestTimeout},
}
}
func (g *GiteaReleaseFeed) Latest() (domain.Release, error) {
releases, err := g.fetch()
if err != nil {
return domain.Release{}, err
}
return domain.Newest(releases)
}
func (g *GiteaReleaseFeed) fetch() ([]domain.Release, error) {
response, err := g.client.Get(g.baseURL + releasesPath)
if err != nil {
return nil, fmt.Errorf("%w: %v", domain.ErrFeedUnavailable, err)
}
defer response.Body.Close()
if response.StatusCode != http.StatusOK {
return nil, fmt.Errorf("%w: status %d", domain.ErrFeedUnavailable, response.StatusCode)
}
var raw []giteaRelease
if err := json.NewDecoder(io.LimitReader(response.Body, maxFeedBodyBytes)).Decode(&raw); err != nil {
return nil, fmt.Errorf("%w: %v", domain.ErrFeedUnavailable, err)
}
return toReleases(raw), nil
}
func toReleases(raw []giteaRelease) []domain.Release {
releases := make([]domain.Release, 0, len(raw))
for _, item := range raw {
if item.Draft {
continue
}
releases = append(releases, domain.Release{
Tag: item.TagName,
URL: item.HTMLURL,
PublishedAt: item.PublishedAt,
Notes: domain.BuildNotes(item.TagName, item.PublishedAt, item.Body),
Assets: toAssets(item.Assets),
})
}
return releases
}
func toAssets(raw []giteaAsset) []domain.Asset {
assets := make([]domain.Asset, 0, len(raw))
for _, item := range raw {
assets = append(assets, domain.Asset{Name: item.Name, URL: item.DownloadURL, Size: item.Size})
}
return assets
}
@@ -0,0 +1,185 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"context"
"errors"
"fmt"
"io"
"net/http"
"net/url"
"os"
"path/filepath"
"strings"
"time"
)
const (
maxBinaryBytes int64 = 200 << 20
maxChecksumsBytes int64 = 64 << 10
maxSignatureBytes int64 = 1 << 10
assetDownloadTimeout = 10 * time.Minute
maxAssetRedirects = 5
assetFilePermission = 0o644
signatureSuffix = ".sig"
)
var (
errAssetURLRefused = errors.New("the asset url is not https on the release feed host")
errAssetStatus = errors.New("the asset server answered with an error status")
errAssetTooLarge = errors.New("the asset is larger than its size cap")
errTooManyRedirects = errors.New("the asset url redirected too many times")
)
type FileOpener func(path string) (io.WriteCloser, error)
type HTTPAssetFetcher struct {
allowedHost string
allowInsecure bool
sizeCap int64
timeout time.Duration
transport http.RoundTripper
openFile FileOpener
}
var _ domain.AssetFetcher = &HTTPAssetFetcher{}
type FetcherOption func(*HTTPAssetFetcher)
func WithInsecureScheme() FetcherOption {
return func(f *HTTPAssetFetcher) { f.allowInsecure = true }
}
func WithSizeCap(bytes int64) FetcherOption {
return func(f *HTTPAssetFetcher) { f.sizeCap = bytes }
}
func WithTimeout(timeout time.Duration) FetcherOption {
return func(f *HTTPAssetFetcher) { f.timeout = timeout }
}
func WithTransport(transport http.RoundTripper) FetcherOption {
return func(f *HTTPAssetFetcher) { f.transport = transport }
}
func WithFileOpener(opener FileOpener) FetcherOption {
return func(f *HTTPAssetFetcher) { f.openFile = opener }
}
func NewHTTPAssetFetcher(feedURL string, options ...FetcherOption) *HTTPAssetFetcher {
fetcher := &HTTPAssetFetcher{
allowedHost: domain.HostOf(feedURL),
timeout: assetDownloadTimeout,
openFile: createAssetFile,
}
for _, option := range options {
option(fetcher)
}
return fetcher
}
func (f *HTTPAssetFetcher) Fetch(asset domain.Asset, destination string, report domain.ProgressFunc) error {
if !f.isAllowed(asset.URL) {
return errAssetURLRefused
}
ctx, cancel := context.WithTimeout(context.Background(), f.timeout)
defer cancel()
request, err := http.NewRequestWithContext(ctx, http.MethodGet, asset.URL, nil)
if err != nil {
return err
}
response, err := f.client().Do(request)
if err != nil {
return err
}
defer response.Body.Close()
if response.StatusCode != http.StatusOK {
return fmt.Errorf("%w: %d", errAssetStatus, response.StatusCode)
}
limit := f.capFor(asset.Name)
if response.ContentLength > limit {
return errAssetTooLarge
}
if err := f.writeBody(response.Body, destination, limit, asset.Size, report); err != nil {
_ = os.Remove(destination)
return err
}
return nil
}
func (f *HTTPAssetFetcher) writeBody(body io.Reader, destination string, limit int64, declaredSize int64, report domain.ProgressFunc) error {
file, err := f.openFile(destination)
if err != nil {
return err
}
counter := &progressWriter{destination: file, total: declaredSize, report: report}
written, copyErr := io.Copy(counter, io.LimitReader(body, limit+1))
closeErr := file.Close()
if copyErr != nil {
return copyErr
}
if closeErr != nil {
return closeErr
}
if written > limit {
return errAssetTooLarge
}
return nil
}
func (f *HTTPAssetFetcher) isAllowed(rawURL string) bool {
parsed, err := url.Parse(rawURL)
if err != nil || f.allowedHost == "" || parsed.Host != f.allowedHost {
return false
}
return parsed.Scheme == "https" || (f.allowInsecure && parsed.Scheme == "http")
}
func (f *HTTPAssetFetcher) client() *http.Client {
return &http.Client{
Transport: f.transport,
CheckRedirect: func(next *http.Request, via []*http.Request) error {
if len(via) >= maxAssetRedirects {
return errTooManyRedirects
}
if !f.isAllowed(next.URL.String()) {
return errAssetURLRefused
}
return nil
},
}
}
func (f *HTTPAssetFetcher) capFor(name string) int64 {
if f.sizeCap > 0 {
return f.sizeCap
}
if name == domain.ChecksumsAssetName {
return maxChecksumsBytes
}
if strings.HasSuffix(name, signatureSuffix) {
return maxSignatureBytes
}
return maxBinaryBytes
}
type progressWriter struct {
destination io.Writer
total int64
done int64
report domain.ProgressFunc
}
func (w *progressWriter) Write(chunk []byte) (int, error) {
written, err := w.destination.Write(chunk)
w.done += int64(written)
w.report(w.done, w.total)
return written, err
}
func createAssetFile(path string) (io.WriteCloser, error) {
if err := os.MkdirAll(filepath.Dir(path), os.ModePerm); err != nil {
return nil, err
}
return os.OpenFile(path, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, assetFilePermission)
}
@@ -0,0 +1,32 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"net/http"
"time"
)
const healthCheckTimeout = 2 * time.Second
type HTTPHealthChecker struct {
url string
client *http.Client
}
var _ domain.HealthChecker = &HTTPHealthChecker{}
func NewHTTPHealthChecker(port string) *HTTPHealthChecker {
return &HTTPHealthChecker{
url: "http://127.0.0.1:" + port + "/healthz",
client: &http.Client{Timeout: healthCheckTimeout},
}
}
func (c *HTTPHealthChecker) Healthy() bool {
response, err := c.client.Get(c.url)
if err != nil {
return false
}
defer response.Body.Close()
return response.StatusCode == http.StatusOK
}
@@ -0,0 +1,22 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"path/filepath"
)
type JSONHelperStatusWriter struct{}
var _ domain.HelperStatusWriter = &JSONHelperStatusWriter{}
func NewJSONHelperStatusWriter() *JSONHelperStatusWriter {
return &JSONHelperStatusWriter{}
}
func (w *JSONHelperStatusWriter) Write(dataDir string, status domain.HelperStatus) error {
return writeJSONAtomically(filepath.Join(dataDir, domain.HelperStatusFileName), status, readableFilePermissions)
}
func (w *JSONHelperStatusWriter) Remove(dataDir string) (bool, error) {
return removeFile(filepath.Join(dataDir, domain.HelperStatusFileName))
}
@@ -0,0 +1,90 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"os"
"path/filepath"
"sync"
)
type JSONJobStore struct {
path string
mu sync.Mutex
}
var _ domain.JobStore = &JSONJobStore{}
func NewJSONJobStore(path string) *JSONJobStore {
store := &JSONJobStore{path: path}
store.failInterruptedJob()
return store
}
func (s *JSONJobStore) failInterruptedJob() {
job, found := s.read()
if !found || !job.IsRunning() {
return
}
job.State = domain.StateFailed
job.Error = domain.ErrorKindDownload
job.DownloadedBytes = 0
job.TotalBytes = 0
_ = s.write(job)
}
func (s *JSONJobStore) Load() (domain.Job, bool) {
s.mu.Lock()
defer s.mu.Unlock()
job, found := s.read()
if !found {
return domain.Job{}, false
}
if job.State == domain.StateReady && !fileExists(job.StagedBinary) {
return domain.Job{}, false
}
return job, true
}
func (s *JSONJobStore) Save(job domain.Job) error {
s.mu.Lock()
defer s.mu.Unlock()
return s.write(job)
}
func (s *JSONJobStore) read() (domain.Job, bool) {
content, err := os.ReadFile(s.path)
if err != nil {
return domain.Job{}, false
}
var job domain.Job
if err := json.Unmarshal(content, &job); err != nil || job.State == "" {
return domain.Job{}, false
}
return job, true
}
func (s *JSONJobStore) write(job domain.Job) error {
content, err := json.Marshal(job)
if err != nil {
return err
}
if err := os.MkdirAll(filepath.Dir(s.path), os.ModePerm); err != nil {
return err
}
temporary := s.path + ".tmp"
if err := os.WriteFile(temporary, content, statusFilePermissions); err != nil {
return err
}
return os.Rename(temporary, s.path)
}
func fileExists(path string) bool {
if path == "" {
return false
}
info, err := os.Stat(path)
return err == nil && !info.IsDir()
}
@@ -0,0 +1,54 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"errors"
"io/fs"
"os"
"sync"
)
type JSONRestartRequestStore struct {
path string
mu sync.Mutex
}
var _ domain.RestartRequestStore = &JSONRestartRequestStore{}
func NewJSONRestartRequestStore(path string) *JSONRestartRequestStore {
return &JSONRestartRequestStore{path: path}
}
func (s *JSONRestartRequestStore) Write(request domain.RestartRequest) error {
s.mu.Lock()
defer s.mu.Unlock()
return writeJSONAtomically(s.path, request, statusFilePermissions)
}
func (s *JSONRestartRequestStore) Read() (domain.RestartRequest, error) {
s.mu.Lock()
defer s.mu.Unlock()
info, err := os.Lstat(s.path)
if errors.Is(err, fs.ErrNotExist) || (err == nil && info.IsDir()) {
return domain.RestartRequest{}, domain.ErrNoRestartRequest
}
if err != nil {
return domain.RestartRequest{}, err
}
content, err := os.ReadFile(s.path)
if err != nil {
return domain.RestartRequest{}, err
}
var request domain.RestartRequest
return request, json.Unmarshal(content, &request)
}
func (s *JSONRestartRequestStore) Delete() error {
s.mu.Lock()
defer s.mu.Unlock()
return removeIfPresent(s.path)
}
@@ -0,0 +1,52 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"os"
"sync"
)
type JSONResultStore struct {
path string
mu sync.Mutex
}
var _ domain.ResultStore = &JSONResultStore{}
func NewJSONResultStore(path string) *JSONResultStore {
return &JSONResultStore{path: path}
}
func (s *JSONResultStore) Read() (domain.Result, bool) {
s.mu.Lock()
defer s.mu.Unlock()
content, err := os.ReadFile(s.path)
if err != nil {
return domain.Result{}, false
}
return decodeResult(content)
}
func (s *JSONResultStore) Write(result domain.Result) error {
s.mu.Lock()
defer s.mu.Unlock()
return writeJSONAtomically(s.path, result, readableFilePermissions)
}
func (s *JSONResultStore) Delete() error {
s.mu.Lock()
defer s.mu.Unlock()
return removeIfPresent(s.path)
}
func decodeResult(content []byte) (domain.Result, bool) {
var result domain.Result
if err := json.Unmarshal(content, &result); err != nil || !result.IsKnown() {
return domain.Result{}, false
}
return result, true
}
@@ -0,0 +1,45 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"os"
"sync"
)
type JSONRunningInfoStore struct {
path string
mu sync.Mutex
}
var _ domain.RunningInfoStore = &JSONRunningInfoStore{}
func NewJSONRunningInfoStore(path string) *JSONRunningInfoStore {
return &JSONRunningInfoStore{path: path}
}
func (s *JSONRunningInfoStore) Write(info domain.RunningInfo) error {
s.mu.Lock()
defer s.mu.Unlock()
return writeJSONAtomically(s.path, info, readableFilePermissions)
}
func (s *JSONRunningInfoStore) Read() (domain.RunningInfo, bool) {
s.mu.Lock()
defer s.mu.Unlock()
linkInfo, err := os.Lstat(s.path)
if err != nil || !linkInfo.Mode().IsRegular() {
return domain.RunningInfo{}, false
}
content, err := os.ReadFile(s.path)
if err != nil {
return domain.RunningInfo{}, false
}
var info domain.RunningInfo
if err := json.Unmarshal(content, &info); err != nil || info.Version == "" || info.Pid == 0 {
return domain.RunningInfo{}, false
}
return info, true
}
@@ -0,0 +1,55 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"encoding/json"
"os"
"path/filepath"
"sync"
)
const statusFilePermissions = 0o600
type JSONStatusStore struct {
path string
mu sync.Mutex
}
var _ domain.StatusStore = &JSONStatusStore{}
func NewJSONStatusStore(path string) *JSONStatusStore {
return &JSONStatusStore{path: path}
}
func (s *JSONStatusStore) Load() (domain.CheckResult, bool) {
s.mu.Lock()
defer s.mu.Unlock()
content, err := os.ReadFile(s.path)
if err != nil {
return domain.CheckResult{}, false
}
var result domain.CheckResult
if err := json.Unmarshal(content, &result); err != nil || result.CheckedAt.IsZero() {
return domain.CheckResult{}, false
}
return result, true
}
func (s *JSONStatusStore) Save(result domain.CheckResult) error {
s.mu.Lock()
defer s.mu.Unlock()
content, err := json.Marshal(result)
if err != nil {
return err
}
if err := os.MkdirAll(filepath.Dir(s.path), os.ModePerm); err != nil {
return err
}
temporary := s.path + ".tmp"
if err := os.WriteFile(temporary, content, statusFilePermissions); err != nil {
return err
}
return os.Rename(temporary, s.path)
}
@@ -0,0 +1,163 @@
//go:build linux
package update
import (
domain "RenewCMS/internal/domain/update"
"errors"
"io"
"io/fs"
"os"
"path/filepath"
"syscall"
)
const (
privateTempDirPrefix = "renewcms-update-"
readNoFollowFlags = os.O_RDONLY | syscall.O_NOFOLLOW | syscall.O_NONBLOCK
createNoFollowFlags = os.O_WRONLY | os.O_CREATE | os.O_EXCL | syscall.O_NOFOLLOW
directoryFlags = os.O_RDONLY | syscall.O_NOFOLLOW | syscall.O_DIRECTORY
)
var errNotRegularFile = errors.New("not a regular file")
type NoFollowFilesystem struct{}
var _ domain.HelperFilesystem = &NoFollowFilesystem{}
func NewNoFollowFilesystem() *NoFollowFilesystem {
return &NoFollowFilesystem{}
}
func (f *NoFollowFilesystem) Lstat(path string) (domain.FileInfo, error) {
info, err := os.Lstat(path)
if err != nil {
return domain.FileInfo{}, err
}
mode := info.Mode()
return domain.FileInfo{
IsSymlink: mode&fs.ModeSymlink != 0,
IsDir: mode.IsDir(),
IsRegular: mode.IsRegular(),
}, nil
}
func (f *NoFollowFilesystem) ReadFile(path string) ([]byte, error) {
file, err := openRegularNoFollow(path)
if err != nil {
return nil, err
}
defer file.Close()
return io.ReadAll(file)
}
func (f *NoFollowFilesystem) CreateExclusive(path string, content []byte, mode uint32) error {
file, err := os.OpenFile(path, createNoFollowFlags, fs.FileMode(mode))
if err != nil {
return err
}
if _, err := file.Write(content); err != nil {
file.Close()
return err
}
return finishWrite(file, mode)
}
func (f *NoFollowFilesystem) Copy(source string, destination string, mode uint32) error {
input, err := openRegularNoFollow(source)
if err != nil {
return err
}
defer input.Close()
output, err := os.OpenFile(destination, createNoFollowFlags, fs.FileMode(mode))
if err != nil {
return err
}
if _, err := io.Copy(output, input); err != nil {
output.Close()
return err
}
return finishWrite(output, mode)
}
func (f *NoFollowFilesystem) Rename(oldPath string, newPath string) error {
return os.Rename(oldPath, newPath)
}
func (f *NoFollowFilesystem) Remove(path string) error {
return os.Remove(path)
}
func (f *NoFollowFilesystem) RemoveAll(path string) error {
info, err := os.Lstat(path)
if errors.Is(err, fs.ErrNotExist) {
return nil
}
if err != nil {
return err
}
if !info.IsDir() {
return os.Remove(path)
}
names, err := readDirectoryNames(path)
if err != nil {
return err
}
for _, name := range names {
if err := f.RemoveAll(filepath.Join(path, name)); err != nil {
return err
}
}
return os.Remove(path)
}
func (f *NoFollowFilesystem) Chmod(path string, mode uint32) error {
file, err := os.OpenFile(path, readNoFollowFlags, 0)
if err != nil {
return err
}
defer file.Close()
return file.Chmod(fs.FileMode(mode))
}
func (f *NoFollowFilesystem) MakePrivateTempDir() (string, error) {
return os.MkdirTemp("", privateTempDirPrefix)
}
func openRegularNoFollow(path string) (*os.File, error) {
file, err := os.OpenFile(path, readNoFollowFlags, 0)
if err != nil {
return nil, err
}
info, err := file.Stat()
if err != nil {
file.Close()
return nil, err
}
if !info.Mode().IsRegular() {
file.Close()
return nil, errNotRegularFile
}
return file, nil
}
func finishWrite(file *os.File, mode uint32) error {
if err := file.Chmod(fs.FileMode(mode)); err != nil {
file.Close()
return err
}
if err := file.Sync(); err != nil {
file.Close()
return err
}
return file.Close()
}
func readDirectoryNames(path string) ([]string, error) {
directory, err := os.OpenFile(path, directoryFlags, 0)
if err != nil {
return nil, err
}
defer directory.Close()
return directory.Readdirnames(-1)
}
@@ -0,0 +1,49 @@
//go:build !linux
package update
import domain "RenewCMS/internal/domain/update"
type NoFollowFilesystem struct{}
var _ domain.HelperFilesystem = &NoFollowFilesystem{}
func NewNoFollowFilesystem() *NoFollowFilesystem {
return &NoFollowFilesystem{}
}
func (f *NoFollowFilesystem) Lstat(string) (domain.FileInfo, error) {
return domain.FileInfo{}, domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) ReadFile(string) ([]byte, error) {
return nil, domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) CreateExclusive(string, []byte, uint32) error {
return domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) Copy(string, string, uint32) error {
return domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) Rename(string, string) error {
return domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) Remove(string) error {
return domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) RemoveAll(string) error {
return domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) Chmod(string, uint32) error {
return domain.ErrHelperUnsupported
}
func (f *NoFollowFilesystem) MakePrivateTempDir() (string, error) {
return "", domain.ErrHelperUnsupported
}
@@ -0,0 +1,58 @@
package update
import (
"RenewCMS/internal/domain/update"
"os"
"path/filepath"
)
const (
stagedDirectoryPermissions = 0o755
stagedBinaryPermissions = 0o755
)
type OSStagingArea struct {
root string
}
var _ update.StagingArea = &OSStagingArea{}
func NewOSStagingArea(root string) *OSStagingArea {
return &OSStagingArea{root: root}
}
func (a *OSStagingArea) Prepare(tag string) error {
directory := filepath.Join(a.root, tag)
if err := os.RemoveAll(directory); err != nil {
return err
}
return os.MkdirAll(directory, stagedDirectoryPermissions)
}
func (a *OSStagingArea) PathFor(tag string, name string) string {
return filepath.Join(a.root, tag, name)
}
func (a *OSStagingArea) Size(path string) (int64, error) {
info, err := os.Stat(path)
if err != nil {
return 0, err
}
return info.Size(), nil
}
func (a *OSStagingArea) ReadChecksums(path string) (string, error) {
content, err := os.ReadFile(path)
if err != nil {
return "", err
}
return string(content), nil
}
func (a *OSStagingArea) MakeExecutable(path string) error {
return os.Chmod(path, stagedBinaryPermissions)
}
func (a *OSStagingArea) Remove(tag string) error {
return os.RemoveAll(filepath.Join(a.root, tag))
}
@@ -0,0 +1,38 @@
package update
import (
"bytes"
"crypto/ed25519"
_ "embed"
"encoding/base64"
"errors"
"strings"
)
//go:embed release.pub
var embeddedPublicKey string
var (
ErrPublicKeyFormat = errors.New("the public key is not a base64 encoded 32 byte ed25519 key")
ErrPlaceholderPublicKey = errors.New("the placeholder public key has not been replaced: run task release:keygen and commit the real key as internal/infrastructure/update/release.pub")
)
func EmbeddedPublicKey() (ed25519.PublicKey, error) {
return ParsePublicKey(embeddedPublicKey)
}
func ParsePublicKey(text string) (ed25519.PublicKey, error) {
decoded, err := base64.StdEncoding.DecodeString(strings.TrimSpace(text))
if err != nil || len(decoded) != ed25519.PublicKeySize {
return nil, ErrPublicKeyFormat
}
return ed25519.PublicKey(decoded), nil
}
func IsPlaceholderPublicKey(key ed25519.PublicKey) bool {
return bytes.Equal(key, make([]byte, ed25519.PublicKeySize))
}
func EncodePublicKey(key ed25519.PublicKey) string {
return base64.StdEncoding.EncodeToString(key)
}
@@ -0,0 +1 @@
cuIg/xm6NmUEi3WtUTO3Rrjo8QoUyKzU315g0HtiVcI=
@@ -0,0 +1,292 @@
package releasesign
import (
"RenewCMS/internal/infrastructure/update"
"crypto/ed25519"
"crypto/rand"
"crypto/sha256"
"encoding/base64"
"encoding/hex"
"errors"
"flag"
"fmt"
"io"
"os"
"path/filepath"
"sort"
"strings"
)
const (
exitOK = 0
exitFailure = 1
exitUsage = 2
signingKeyEnvVar = "RELEASE_SIGNING_KEY"
signatureSuffix = ".sig"
privateKeyFileMode = 0o600
publicFileMode = 0o644
repositoryMarker = ".git"
checksumsFileName = "checksums.txt"
usageText = "usage: releasesign keygen <private-key-path> [--pub-out <path>] | sign <file> [--key <path>] [--pub <path>] | verify <file> [--pub <path>] | checksums <dir> [--match <glob>]"
publicKeyCommitHint = "commit the public key as internal/infrastructure/update/release.pub"
)
var (
errInsideRepository = errors.New("the private key path is inside the repository work tree, choose a path outside it")
errKeyMismatch = errors.New("the private key does not match the public key in use")
errPrivateKeyFormat = errors.New("the private key file is not a base64 encoded ed25519 private key")
errSignatureFormat = errors.New("the signature file is not a base64 encoded ed25519 signature")
errBadSignature = errors.New("the signature does not match the file: it was changed or signed with another key")
errNoKeyPath = errors.New("no private key given: pass --key or set RELEASE_SIGNING_KEY")
)
func Run(args []string, stdout, stderr io.Writer) int {
if len(args) == 0 {
fmt.Fprintln(stderr, usageText)
return exitUsage
}
commands := map[string]func([]string, io.Writer) error{
"keygen": keygen,
"sign": sign,
"verify": verify,
"checksums": checksums,
}
command, known := commands[args[0]]
if !known {
fmt.Fprintln(stderr, usageText)
return exitUsage
}
if err := command(args[1:], stdout); err != nil {
fmt.Fprintln(stderr, "releasesign:", err)
return exitFailure
}
return exitOK
}
func parseArguments(name string, args []string, define func(*flag.FlagSet)) (string, error) {
set := flag.NewFlagSet(name, flag.ContinueOnError)
set.SetOutput(io.Discard)
define(set)
positional, flags := splitArguments(args)
if err := set.Parse(flags); err != nil {
return "", err
}
if len(positional) != 1 {
return "", errors.New(usageText)
}
return positional[0], nil
}
func splitArguments(args []string) ([]string, []string) {
var positional, flags []string
for i := 0; i < len(args); i++ {
if strings.HasPrefix(args[i], "--") {
flags = append(flags, args[i])
if !strings.Contains(args[i], "=") && i+1 < len(args) {
i++
flags = append(flags, args[i])
}
continue
}
positional = append(positional, args[i])
}
return positional, flags
}
func keygen(args []string, stdout io.Writer) error {
var pubOut string
keyPath, err := parseArguments("keygen", args, func(set *flag.FlagSet) { set.StringVar(&pubOut, "pub-out", "", "") })
if err != nil {
return err
}
if err := refuseInsideRepository(keyPath); err != nil {
return err
}
if _, err := os.Stat(keyPath); err == nil {
return fmt.Errorf("%s already exists, it is not overwritten", keyPath)
}
publicKey, privateKey, err := ed25519.GenerateKey(rand.Reader)
if err != nil {
return err
}
encodedPrivate := base64.StdEncoding.EncodeToString(privateKey) + "\n"
if err := os.WriteFile(keyPath, []byte(encodedPrivate), privateKeyFileMode); err != nil {
return err
}
encodedPublic := update.EncodePublicKey(publicKey)
if pubOut != "" {
if err := os.WriteFile(pubOut, []byte(encodedPublic+"\n"), publicFileMode); err != nil {
return err
}
}
fmt.Fprintf(stdout, "private key written to %s: keep it outside the repository and never share it\n", keyPath)
fmt.Fprintf(stdout, "public key: %s\n%s\n", encodedPublic, publicKeyCommitHint)
return nil
}
func refuseInsideRepository(path string) error {
absolute, err := filepath.Abs(path)
if err != nil {
return err
}
for directory := filepath.Dir(absolute); ; directory = filepath.Dir(directory) {
if _, err := os.Stat(filepath.Join(directory, repositoryMarker)); err == nil {
return fmt.Errorf("%w (%s)", errInsideRepository, directory)
}
if directory == filepath.Dir(directory) {
return nil
}
}
}
func sign(args []string, stdout io.Writer) error {
var keyPath, pubPath string
file, err := parseArguments("sign", args, func(set *flag.FlagSet) {
set.StringVar(&keyPath, "key", "", "")
set.StringVar(&pubPath, "pub", "", "")
})
if err != nil {
return err
}
publicKey, err := loadPublicKey(pubPath)
if err != nil {
return err
}
privateKey, err := loadPrivateKey(keyPath)
if err != nil {
return err
}
if !publicKeyOf(privateKey).Equal(publicKey) {
return errKeyMismatch
}
content, err := os.ReadFile(file)
if err != nil {
return err
}
signature := base64.StdEncoding.EncodeToString(ed25519.Sign(privateKey, content))
if err := os.WriteFile(file+signatureSuffix, []byte(signature+"\n"), publicFileMode); err != nil {
return err
}
fmt.Fprintf(stdout, "signed %s into %s\n", file, file+signatureSuffix)
return nil
}
func verify(args []string, stdout io.Writer) error {
var pubPath string
file, err := parseArguments("verify", args, func(set *flag.FlagSet) { set.StringVar(&pubPath, "pub", "", "") })
if err != nil {
return err
}
publicKey, err := loadPublicKey(pubPath)
if err != nil {
return err
}
content, err := os.ReadFile(file)
if err != nil {
return err
}
rawSignature, err := os.ReadFile(file + signatureSuffix)
if err != nil {
return err
}
signature, err := base64.StdEncoding.DecodeString(strings.TrimSpace(string(rawSignature)))
if err != nil || len(signature) != ed25519.SignatureSize {
return errSignatureFormat
}
if !ed25519.Verify(publicKey, content, signature) {
return errBadSignature
}
fmt.Fprintf(stdout, "%s is signed by the release key\n", file)
return nil
}
func checksums(args []string, stdout io.Writer) error {
match := "*"
dir, err := parseArguments("checksums", args, func(set *flag.FlagSet) { set.StringVar(&match, "match", "*", "") })
if err != nil {
return err
}
paths, err := filepath.Glob(filepath.Join(dir, match))
if err != nil {
return err
}
sort.Strings(paths)
var lines strings.Builder
for _, path := range paths {
line, err := checksumLine(path)
if err != nil {
return err
}
lines.WriteString(line)
}
if lines.Len() == 0 {
return fmt.Errorf("no file in %s matches %s", dir, match)
}
target := filepath.Join(dir, checksumsFileName)
if err := os.WriteFile(target, []byte(lines.String()), publicFileMode); err != nil {
return err
}
fmt.Fprintln(stdout, "wrote", target)
return nil
}
func checksumLine(path string) (string, error) {
name := filepath.Base(path)
if name == checksumsFileName || strings.HasSuffix(name, signatureSuffix) {
return "", nil
}
info, err := os.Stat(path)
if err != nil || info.IsDir() {
return "", err
}
content, err := os.ReadFile(path)
if err != nil {
return "", err
}
sum := sha256.Sum256(content)
return fmt.Sprintf("%s %s\n", hex.EncodeToString(sum[:]), name), nil
}
func loadPublicKey(pubPath string) (ed25519.PublicKey, error) {
var key ed25519.PublicKey
var err error
if pubPath == "" {
key, err = update.EmbeddedPublicKey()
} else {
var content []byte
content, err = os.ReadFile(pubPath)
if err == nil {
key, err = update.ParsePublicKey(string(content))
}
}
if err != nil {
return nil, err
}
if update.IsPlaceholderPublicKey(key) {
return nil, update.ErrPlaceholderPublicKey
}
return key, nil
}
func loadPrivateKey(keyPath string) (ed25519.PrivateKey, error) {
if keyPath == "" {
keyPath = os.Getenv(signingKeyEnvVar)
}
if keyPath == "" {
return nil, errNoKeyPath
}
content, err := os.ReadFile(keyPath)
if err != nil {
return nil, err
}
decoded, err := base64.StdEncoding.DecodeString(strings.TrimSpace(string(content)))
if err != nil || len(decoded) != ed25519.PrivateKeySize {
return nil, errPrivateKeyFormat
}
return ed25519.PrivateKey(decoded), nil
}
func publicKeyOf(privateKey ed25519.PrivateKey) ed25519.PublicKey {
return privateKey.Public().(ed25519.PublicKey)
}
@@ -0,0 +1,87 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"errors"
"os"
"path/filepath"
"sort"
"strings"
"time"
"gorm.io/gorm"
)
var errBackupExists = errors.New("a backup with this name already exists")
const (
backupsToKeep = 3
backupFileExtension = ".db"
backupFilePrefix = "renewcms-"
backupTimeLayout = "20060102T150405.000000000Z"
)
type SQLiteDatabaseBackup struct {
db *gorm.DB
directory string
now func() time.Time
}
var _ domain.DatabaseBackup = &SQLiteDatabaseBackup{}
func NewSQLiteDatabaseBackup(db *gorm.DB, directory string, now func() time.Time) *SQLiteDatabaseBackup {
return &SQLiteDatabaseBackup{db: db, directory: directory, now: now}
}
func (b *SQLiteDatabaseBackup) Backup() (string, error) {
if err := os.MkdirAll(b.directory, os.ModePerm); err != nil {
return "", err
}
target := filepath.Join(b.directory, backupFilePrefix+b.now().UTC().Format(backupTimeLayout)+backupFileExtension)
if _, err := os.Stat(target); err == nil {
return "", errBackupExists
}
if err := b.db.Exec("VACUUM INTO ?", target).Error; err != nil {
_ = os.Remove(target)
return "", err
}
if err := b.prune(); err != nil {
return "", err
}
return target, nil
}
type backupFile struct {
path string
modified time.Time
}
func (b *SQLiteDatabaseBackup) prune() error {
entries, err := os.ReadDir(b.directory)
if err != nil {
return err
}
files := make([]backupFile, 0, len(entries))
for _, entry := range entries {
if entry.IsDir() || !strings.HasSuffix(entry.Name(), backupFileExtension) {
continue
}
info, err := entry.Info()
if err != nil {
return err
}
files = append(files, backupFile{path: filepath.Join(b.directory, entry.Name()), modified: info.ModTime()})
}
sort.Slice(files, func(i, j int) bool {
if files[i].modified.Equal(files[j].modified) {
return files[i].path > files[j].path
}
return files[i].modified.After(files[j].modified)
})
for _, stale := range files[min(backupsToKeep, len(files)):] {
if err := os.Remove(stale.path); err != nil {
return err
}
}
return nil
}
@@ -0,0 +1,22 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"time"
)
type SystemClock struct{}
var _ domain.Clock = &SystemClock{}
func NewSystemClock() *SystemClock {
return &SystemClock{}
}
func (c *SystemClock) Now() time.Time {
return time.Now()
}
func (c *SystemClock) Sleep(duration time.Duration) {
time.Sleep(duration)
}
@@ -0,0 +1,30 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"os"
"runtime"
)
const systemdRuntimeDirectory = "/run/systemd/system"
type SystemMachineProbe struct{}
var _ domain.MachineProbe = &SystemMachineProbe{}
func NewSystemMachineProbe() *SystemMachineProbe {
return &SystemMachineProbe{}
}
func (p *SystemMachineProbe) OS() string {
return runtime.GOOS
}
func (p *SystemMachineProbe) SystemdRunning() bool {
info, err := os.Stat(systemdRuntimeDirectory)
return err == nil && info.IsDir()
}
func (p *SystemMachineProbe) IsRoot() bool {
return os.Geteuid() == 0
}
@@ -0,0 +1,57 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"errors"
"fmt"
"os/exec"
"strings"
)
const systemctlCommand = "systemctl"
type SystemctlControl struct {
service string
}
var (
_ domain.ServiceControl = &SystemctlControl{}
_ domain.UnitManager = &SystemctlControl{}
)
func NewSystemctlControl(service string) *SystemctlControl {
return &SystemctlControl{service: service}
}
func (c *SystemctlControl) Restart() error {
return runSystemctl("restart", c.service)
}
func (c *SystemctlControl) Status() (bool, error) {
err := exec.Command(systemctlCommand, "is-active", "--quiet", c.service).Run()
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
return false, nil
}
return err == nil, err
}
func (c *SystemctlControl) DaemonReload() error {
return runSystemctl("daemon-reload")
}
func (c *SystemctlControl) EnableNow(unit string) error {
return runSystemctl("enable", "--now", unit)
}
func (c *SystemctlControl) DisableNow(unit string) error {
return runSystemctl("disable", "--now", unit)
}
func runSystemctl(arguments ...string) error {
output, err := exec.Command(systemctlCommand, arguments...).CombinedOutput()
if err != nil {
return fmt.Errorf("systemctl %s: %w: %s", strings.Join(arguments, " "), err, strings.TrimSpace(string(output)))
}
return nil
}
@@ -0,0 +1,104 @@
package update
import (
domain "RenewCMS/internal/domain/update"
"os"
"path/filepath"
"strconv"
"strings"
)
const (
systemUnitDirectory = "/etc/systemd/system"
unitFilePermissions = 0o644
unitFileSuffix = ".service"
)
type SystemdUnits struct {
directory string
}
var (
_ domain.UnitWriter = &SystemdUnits{}
_ domain.ServiceLocator = &SystemdUnits{}
)
func NewSystemdUnits() *SystemdUnits {
return NewSystemdUnitsIn(systemUnitDirectory)
}
func NewSystemdUnitsIn(directory string) *SystemdUnits {
return &SystemdUnits{directory: directory}
}
func (u *SystemdUnits) Write(name string, content string) error {
return os.WriteFile(filepath.Join(u.directory, name), []byte(content), unitFilePermissions)
}
func (u *SystemdUnits) Remove(name string) (bool, error) {
return removeFile(filepath.Join(u.directory, name))
}
func (u *SystemdUnits) Locate(name string) (domain.ServiceDescription, bool) {
content, err := os.ReadFile(filepath.Join(u.directory, name+unitFileSuffix))
if err != nil {
return domain.ServiceDescription{}, false
}
description := ParseServiceUnit(string(content))
description.Name = name
return description, true
}
func (u *SystemdUnits) PortFromEnvironmentFile(path string) (string, bool) {
if path == "" {
return "", false
}
content, err := os.ReadFile(path)
if err != nil {
return "", false
}
return portFromEnvironment(string(content))
}
func ParseServiceUnit(content string) domain.ServiceDescription {
var description domain.ServiceDescription
for _, line := range strings.Split(content, "\n") {
key, value, found := strings.Cut(strings.TrimSpace(line), "=")
if !found {
continue
}
switch key {
case "ExecStart":
description.BinaryPath = firstUnitPath(value, "@-:+!")
case "EnvironmentFile":
description.EnvironmentFile = firstUnitPath(value, "-")
case "ReadWritePaths":
if description.DataDir == "" {
description.DataDir = firstUnitPath(value, "-+!")
}
}
}
return description
}
func firstUnitPath(value string, prefixes string) string {
fields := strings.Fields(value)
if len(fields) == 0 {
return ""
}
return strings.Trim(strings.TrimLeft(fields[0], prefixes), `"`)
}
func portFromEnvironment(content string) (string, bool) {
for _, line := range strings.Split(content, "\n") {
key, value, found := strings.Cut(strings.TrimSpace(line), "=")
if !found || strings.TrimSpace(key) != "PORT" {
continue
}
port := strings.Trim(strings.TrimSpace(value), `"'`)
if _, err := strconv.Atoi(port); err == nil {
return port, true
}
}
return "", false
}
@@ -0,0 +1,382 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"errors"
"fmt"
"path"
"time"
)
type ApplyRestartRequestUseCase struct {
requests update.RestartRequestStore
results update.ResultStore
running update.RunningInfoStore
files update.HelperFilesystem
service update.ServiceControl
health update.HealthChecker
verifier update.SignatureVerifier
clock update.Clock
logger update.Logger
layout update.HelperLayout
platform update.Platform
}
type ApplyRestartRequestDependencies struct {
Requests update.RestartRequestStore
Results update.ResultStore
Running update.RunningInfoStore
Files update.HelperFilesystem
Service update.ServiceControl
Health update.HealthChecker
Verifier update.SignatureVerifier
Clock update.Clock
Logger update.Logger
Layout update.HelperLayout
Platform update.Platform
}
func NewApplyRestartRequestUseCase(dependencies ApplyRestartRequestDependencies) *ApplyRestartRequestUseCase {
return &ApplyRestartRequestUseCase{
requests: dependencies.Requests,
results: dependencies.Results,
running: dependencies.Running,
files: dependencies.Files,
service: dependencies.Service,
health: dependencies.Health,
verifier: dependencies.Verifier,
clock: dependencies.Clock,
logger: dependencies.Logger,
layout: dependencies.Layout,
platform: dependencies.Platform,
}
}
type helperRun struct {
apply *ApplyRestartRequestUseCase
result update.Result
tempDir string
stagedTag string
}
type verifiedCopy struct {
binaryPath string
checksum string
}
func (a *ApplyRestartRequestUseCase) Apply() (err error) {
request, readErr := a.requests.Read()
if errors.Is(readErr, update.ErrNoRestartRequest) {
a.logger.Printf("no restart request found, nothing to do")
return nil
}
run := &helperRun{apply: a, result: update.Result{
Outcome: update.OutcomeRunning,
Kind: request.Kind,
Tag: request.Tag,
StartedAt: a.clock.Now().UTC(),
}}
defer run.recoverPanic(&err)
deleteErr := a.requests.Delete()
symlinkErr := a.symlinkedDataFile()
if info, found := a.running.Read(); found {
run.result.FromVersion = info.Version
}
run.record()
for _, refusal := range []error{readErr, deleteErr, symlinkErr} {
if refusal != nil {
return run.fail(refusal)
}
}
return run.dispatch()
}
func (a *ApplyRestartRequestUseCase) symlinkedDataFile() error {
for _, candidate := range []string{a.layout.ResultPath(), a.layout.ResultTempPath()} {
if info, err := a.files.Lstat(candidate); err == nil && info.IsSymlink {
return update.SymlinkError{Path: candidate}
}
}
return nil
}
func (r *helperRun) dispatch() error {
switch r.result.Kind {
case update.RestartKindRestart:
return r.plainRestart()
case update.RestartKindUpdate:
return r.installUpdate()
}
return r.fail(fmt.Errorf("unknown restart kind %q", r.result.Kind))
}
func (r *helperRun) plainRestart() error {
if !r.apply.restartAndAwait("") {
return r.failLoudly(errors.New("the site did not come back after the restart"))
}
return r.finish(update.OutcomeSucceeded)
}
func (r *helperRun) installUpdate() error {
a := r.apply
tag := r.result.Tag
if r.result.FromVersion == "" {
return r.fail(errors.New("the running version could not be read from update-running.json"))
}
if err := update.ValidateRestartTag(tag, r.result.FromVersion); err != nil {
return r.fail(fmt.Errorf("tag %q: %w", tag, err))
}
r.stagedTag = tag
assetName := update.AssetName(tag, a.platform)
if err := a.requireStagedFiles(tag, assetName); err != nil {
return r.fail(err)
}
verified, err := r.copyAndVerify(tag, assetName)
if err != nil {
return r.fail(err)
}
if err := a.swapBinary(verified); err != nil {
return r.fail(err)
}
if a.restartAndAwait(tag) {
return r.finish(update.OutcomeSucceeded)
}
return r.rollBack()
}
func (r *helperRun) copyAndVerify(tag string, assetName string) (verifiedCopy, error) {
a := r.apply
tempDir, err := a.files.MakePrivateTempDir()
if err != nil {
return verifiedCopy{}, err
}
r.tempDir = tempDir
stagedDir := a.layout.StagedDir(tag)
for _, name := range []string{assetName, update.ChecksumsAssetName, update.SignatureAssetName} {
original := path.Join(stagedDir, name)
if err := a.files.Copy(original, path.Join(tempDir, name), update.PrivateFileMode); err != nil {
return verifiedCopy{}, fmt.Errorf("copying %s: %w", original, err)
}
}
return a.verifyCopy(tempDir, assetName)
}
func (a *ApplyRestartRequestUseCase) verifyCopy(tempDir string, assetName string) (verifiedCopy, error) {
checksumsPath := path.Join(tempDir, update.ChecksumsAssetName)
if err := a.verifier.Verify(checksumsPath, path.Join(tempDir, update.SignatureAssetName)); err != nil {
return verifiedCopy{}, fmt.Errorf("signature check: %w", err)
}
checksums, err := a.files.ReadFile(checksumsPath)
if err != nil {
return verifiedCopy{}, err
}
expected, found := update.ChecksumFor(string(checksums), assetName)
if !found {
return verifiedCopy{}, fmt.Errorf("checksums.txt has no line for %q", assetName)
}
binaryPath := path.Join(tempDir, assetName)
content, err := a.files.ReadFile(binaryPath)
if err != nil {
return verifiedCopy{}, err
}
if update.SHA256Hex(content) != expected {
return verifiedCopy{}, fmt.Errorf("sha-256 mismatch for the staged %q", assetName)
}
return verifiedCopy{binaryPath: binaryPath, checksum: expected}, nil
}
func (a *ApplyRestartRequestUseCase) requireStagedFiles(tag string, assetName string) error {
for _, directory := range []string{a.layout.UpdatesDir(), a.layout.StagedDir(tag)} {
if err := a.requireDirectory(directory); err != nil {
return err
}
}
for _, name := range []string{assetName, update.ChecksumsAssetName, update.SignatureAssetName} {
if err := a.requireRegularFile(path.Join(a.layout.StagedDir(tag), name)); err != nil {
return err
}
}
return nil
}
func (a *ApplyRestartRequestUseCase) requireDirectory(target string) error {
return a.requireEntry(target, "a directory", func(info update.FileInfo) bool { return info.IsDir })
}
func (a *ApplyRestartRequestUseCase) requireRegularFile(target string) error {
return a.requireEntry(target, "a regular file", func(info update.FileInfo) bool { return info.IsRegular })
}
func (a *ApplyRestartRequestUseCase) requireEntry(target string, description string, matches func(update.FileInfo) bool) error {
info, err := a.files.Lstat(target)
if err != nil {
return fmt.Errorf("%s: %w", target, err)
}
if info.IsSymlink {
return update.SymlinkError{Path: target}
}
if !matches(info) {
return fmt.Errorf("%s is not %s", target, description)
}
return nil
}
func (a *ApplyRestartRequestUseCase) swapBinary(verified verifiedCopy) error {
binary := a.layout.BinaryPath
if err := a.replaceViaTemp(binary, a.layout.PreviousPath(), binary+update.PreviousTempSuffix); err != nil {
return fmt.Errorf("keeping the previous binary: %w", err)
}
installTemp := binary + update.InstallTempSuffix
a.removeQuietly(installTemp)
if err := a.files.Copy(verified.binaryPath, installTemp, update.ExecutableMode); err != nil {
a.removeQuietly(installTemp)
return fmt.Errorf("writing the new binary: %w", err)
}
if err := a.installIfUnchanged(installTemp, verified.checksum); err != nil {
a.removeQuietly(installTemp)
return err
}
return nil
}
func (a *ApplyRestartRequestUseCase) installIfUnchanged(installTemp string, checksum string) error {
content, err := a.files.ReadFile(installTemp)
if err != nil {
return err
}
if update.SHA256Hex(content) != checksum {
return fmt.Errorf("%s changed after it was verified", installTemp)
}
if err := a.files.Chmod(installTemp, update.ExecutableMode); err != nil {
return err
}
if err := a.files.Rename(installTemp, a.layout.BinaryPath); err != nil {
return fmt.Errorf("installing the new binary: %w", err)
}
return nil
}
func (a *ApplyRestartRequestUseCase) replaceViaTemp(source string, destination string, temporary string) error {
a.removeQuietly(temporary)
if err := a.files.Copy(source, temporary, update.ExecutableMode); err != nil {
a.removeQuietly(temporary)
return err
}
if err := a.files.Rename(temporary, destination); err != nil {
a.removeQuietly(temporary)
return err
}
return nil
}
func (r *helperRun) rollBack() error {
a := r.apply
a.logger.Printf("version %s did not come up, restoring %s", r.result.Tag, a.layout.PreviousPath())
restoreTemp := a.layout.BinaryPath + update.RestoreTempSuffix
if err := a.replaceViaTemp(a.layout.PreviousPath(), a.layout.BinaryPath, restoreTemp); err != nil {
return r.failLoudly(fmt.Errorf("the previous binary could not be restored, the site may be down: %w", err))
}
if !a.restartAndAwait(r.result.FromVersion) {
return r.failLoudly(errors.New("the previous version did not come back after the rollback"))
}
return r.finish(update.OutcomeRolledBack)
}
func (a *ApplyRestartRequestUseCase) restartAndAwait(expectedVersion string) bool {
baseline, _ := a.running.Read()
restartedAt := a.clock.Now()
if err := a.service.Restart(); err != nil {
a.logger.Printf("restarting the service failed: %v", err)
return false
}
for a.clock.Now().Sub(restartedAt) < update.RestartWindow {
if a.isBackUp(baseline, restartedAt, expectedVersion) {
return true
}
a.clock.Sleep(update.PollInterval)
}
return false
}
func (a *ApplyRestartRequestUseCase) isBackUp(baseline update.RunningInfo, restartedAt time.Time, expectedVersion string) bool {
if !a.health.Healthy() {
return false
}
info, found := a.running.Read()
if !found || !info.IsNewerThan(baseline, restartedAt) {
return false
}
return expectedVersion == "" || info.Version == expectedVersion
}
func (r *helperRun) record() {
if err := r.apply.results.Write(r.result); err != nil {
r.apply.logger.Printf("update-result.json could not be written: %v", err)
}
}
func (r *helperRun) finish(outcome string) error {
finishedAt := r.apply.clock.Now().UTC()
r.result.Outcome = outcome
r.result.FinishedAt = &finishedAt
r.record()
r.cleanUp()
return nil
}
func (r *helperRun) fail(reason error) error {
r.apply.logger.Printf("restart request refused or failed: %v", reason)
return r.finish(update.OutcomeFailed)
}
func (r *helperRun) failLoudly(reason error) error {
r.apply.logger.Printf("restart request failed: %v", reason)
_ = r.finish(update.OutcomeFailed)
return reason
}
func (r *helperRun) recoverPanic(err *error) {
if recovered := recover(); recovered != nil {
*err = r.failLoudly(fmt.Errorf("panic: %v", recovered))
}
}
func (r *helperRun) cleanUp() {
a := r.apply
if r.tempDir != "" {
a.removeTreeQuietly(r.tempDir)
}
if r.stagedTag != "" {
a.removeStaged(r.stagedTag)
}
}
func (a *ApplyRestartRequestUseCase) removeStaged(tag string) {
if err := a.requireDirectory(a.layout.UpdatesDir()); err != nil {
a.logger.Printf("staged files left in place: %v", err)
return
}
staged := a.layout.StagedDir(tag)
info, err := a.files.Lstat(staged)
if err != nil {
return
}
if info.IsSymlink {
a.removeQuietly(staged)
return
}
a.removeTreeQuietly(staged)
}
func (a *ApplyRestartRequestUseCase) removeQuietly(target string) {
_ = a.files.Remove(target)
}
func (a *ApplyRestartRequestUseCase) removeTreeQuietly(target string) {
if err := a.files.RemoveAll(target); err != nil {
a.logger.Printf("could not remove %s: %v", target, err)
}
}
@@ -0,0 +1,29 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"time"
)
type CheckForUpdateUseCase struct {
feed update.ReleaseFeed
store update.StatusStore
currentVersion string
now func() time.Time
}
func NewCheckForUpdateUseCase(feed update.ReleaseFeed, store update.StatusStore, currentVersion string, now func() time.Time) *CheckForUpdateUseCase {
return &CheckForUpdateUseCase{feed: feed, store: store, currentVersion: currentVersion, now: now}
}
func (c *CheckForUpdateUseCase) Check() (update.UpdateStatus, error) {
release, err := c.feed.Latest()
if err != nil {
return update.UpdateStatus{}, err
}
result := update.NewResult(release, c.now())
if err := c.store.Save(result); err != nil {
return update.UpdateStatus{}, err
}
return update.NewStatus(c.currentVersion, &result), nil
}
@@ -6,15 +6,17 @@ import (
type CreateArticleUseCase struct {
articleRepository article.Repository
bodyRenderer article.BodyRenderer
}
type CreateArticleCommand struct {
Title string
Body string
Title string
Body string
Format article.BodyFormat
}
func NewCreateArticleUseCase(articleRepository article.Repository) *CreateArticleUseCase {
return &CreateArticleUseCase{articleRepository}
func NewCreateArticleUseCase(articleRepository article.Repository, bodyRenderer article.BodyRenderer) *CreateArticleUseCase {
return &CreateArticleUseCase{articleRepository, bodyRenderer}
}
func (g *CreateArticleUseCase) CreateArticle(createArticle CreateArticleCommand) (article.Article, error) {
@@ -22,9 +24,13 @@ func (g *CreateArticleUseCase) CreateArticle(createArticle CreateArticleCommand)
return article.Article{}, err
}
return g.articleRepository.Create(article.Article{
created, err := g.articleRepository.Create(article.Article{
Title: createArticle.Title,
Body: createArticle.Body,
IsOnline: false,
})
if err != nil {
return article.Article{}, err
}
return renderArticle(g.bodyRenderer, created, createArticle.Format)
}
+11 -6
View File
@@ -4,13 +4,14 @@ import "RenewCMS/internal/domain/article"
type GetArticleUseCase struct {
articleRepository article.Repository
bodyRenderer article.BodyRenderer
}
func NewGetArticleUseCase(articleRepository article.Repository) *GetArticleUseCase {
return &GetArticleUseCase{articleRepository}
func NewGetArticleUseCase(articleRepository article.Repository, bodyRenderer article.BodyRenderer) *GetArticleUseCase {
return &GetArticleUseCase{articleRepository, bodyRenderer}
}
func (u *GetArticleUseCase) GetOnlineArticle(id uint32) (article.Article, error) {
func (u *GetArticleUseCase) GetOnlineArticle(id uint32, format article.BodyFormat) (article.Article, error) {
art, err := u.articleRepository.Get(id)
if err != nil {
return article.Article{}, err
@@ -20,11 +21,15 @@ func (u *GetArticleUseCase) GetOnlineArticle(id uint32) (article.Article, error)
return article.Article{}, article.ErrArticleNotFound
}
return art, nil
return renderArticle(u.bodyRenderer, art, format)
}
func (u *GetArticleUseCase) GetArticle(id uint32) (article.Article, error) {
return u.articleRepository.Get(id)
func (u *GetArticleUseCase) GetArticle(id uint32, format article.BodyFormat) (article.Article, error) {
art, err := u.articleRepository.Get(id)
if err != nil {
return article.Article{}, err
}
return renderArticle(u.bodyRenderer, art, format)
}
func (g *GetArticleUseCase) GetArticleByName(name string) (article.Article, error) {
@@ -0,0 +1,22 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"time"
)
type GetUpdateStatusUseCase struct {
status updateStatusBuilder
helper update.HelperDetector
}
func NewGetUpdateStatusUseCase(store update.StatusStore, jobs update.JobStore, helper update.HelperDetector, results update.ResultStore, requests update.RestartRequestStore, currentVersion string, now func() time.Time) *GetUpdateStatusUseCase {
return &GetUpdateStatusUseCase{
status: updateStatusBuilder{store: store, jobs: jobs, results: results, requests: requests, currentVersion: currentVersion, now: now},
helper: helper,
}
}
func (g *GetUpdateStatusUseCase) GetStatus(isOwner bool) update.UpdateStatus {
return g.status.build(isOwner && g.helper.Installed())
}
@@ -4,19 +4,28 @@ import "RenewCMS/internal/domain/article"
type ListArticlesUseCase struct {
articleRepository article.Repository
bodyRenderer article.BodyRenderer
}
func NewListArticlesUseCase(articleRepository article.Repository) *ListArticlesUseCase {
return &ListArticlesUseCase{articleRepository}
func NewListArticlesUseCase(articleRepository article.Repository, bodyRenderer article.BodyRenderer) *ListArticlesUseCase {
return &ListArticlesUseCase{articleRepository, bodyRenderer}
}
func (u *ListArticlesUseCase) ListOnlineArticles() ([]article.Article, error) {
func (u *ListArticlesUseCase) ListOnlineArticles(format article.BodyFormat) ([]article.Article, error) {
online := true
return u.articleRepository.FindByFilters(article.Filters{
articles, err := u.articleRepository.FindByFilters(article.Filters{
IsOnline: &online,
})
if err != nil {
return nil, err
}
return renderArticles(u.bodyRenderer, articles, format)
}
func (u *ListArticlesUseCase) ListAllArticles() ([]article.Article, error) {
return u.articleRepository.FindByFilters(article.Filters{})
func (u *ListArticlesUseCase) ListAllArticles(format article.BodyFormat) ([]article.Article, error) {
articles, err := u.articleRepository.FindByFilters(article.Filters{})
if err != nil {
return nil, err
}
return renderArticles(u.bodyRenderer, articles, format)
}
@@ -0,0 +1,175 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"strings"
"time"
)
type ManageBrowserUpdatesDependencies struct {
Probe update.MachineProbe
Locator update.ServiceLocator
Units update.UnitWriter
Manager update.UnitManager
Status update.HelperStatusWriter
Now func() time.Time
}
type EnableBrowserUpdatesUseCase struct {
dependencies ManageBrowserUpdatesDependencies
}
type DisableBrowserUpdatesUseCase struct {
dependencies ManageBrowserUpdatesDependencies
}
func NewEnableBrowserUpdatesUseCase(dependencies ManageBrowserUpdatesDependencies) *EnableBrowserUpdatesUseCase {
return &EnableBrowserUpdatesUseCase{dependencies: dependencies}
}
func NewDisableBrowserUpdatesUseCase(dependencies ManageBrowserUpdatesDependencies) *DisableBrowserUpdatesUseCase {
return &DisableBrowserUpdatesUseCase{dependencies: dependencies}
}
func (e *EnableBrowserUpdatesUseCase) Enable(options update.InstallOptions) (string, error) {
d := e.dependencies
if err := update.CheckInstallEnvironment(d.Probe); err != nil {
return "", err
}
resolved, err := e.resolve(options)
if err != nil {
return "", err
}
if err := e.install(resolved); err != nil {
e.undo()
return "", err
}
status := update.HelperStatus{
Version: update.HelperStatusVersion,
Service: resolved.Service,
Binary: resolved.Binary,
DataDir: resolved.DataDir,
InstalledAt: d.Now().UTC(),
}
if err := d.Status.Write(resolved.DataDir, status); err != nil {
e.undo()
return "", err
}
return enabledMessage(resolved), nil
}
func (e *EnableBrowserUpdatesUseCase) resolve(options update.InstallOptions) (update.InstallOptions, error) {
service := firstNonEmpty(options.Service, update.DefaultService)
description, found := e.dependencies.Locator.Locate(service)
resolved := update.InstallOptions{
Service: service,
Binary: firstNonEmpty(options.Binary, description.BinaryPath),
DataDir: firstNonEmpty(options.DataDir, description.DataDir),
}
if resolved.Binary == "" || (resolved.DataDir == "" && !found) {
return resolved, update.ErrServiceNotFound
}
if resolved.DataDir == "" {
return resolved, update.ErrDataDirNotFound
}
resolved.Port = e.port(options.Port, description)
return resolved, update.ValidatePort(resolved.Port)
}
func (e *EnableBrowserUpdatesUseCase) port(flag string, description update.ServiceDescription) string {
if flag != "" {
return flag
}
if port, found := e.dependencies.Locator.PortFromEnvironmentFile(description.EnvironmentFile); found {
return port
}
return update.DefaultPort
}
func (e *EnableBrowserUpdatesUseCase) install(options update.InstallOptions) error {
d := e.dependencies
layout := update.HelperLayout{DataDir: options.DataDir, BinaryPath: options.Binary}
if err := d.Units.Write(update.ServiceUnitName, update.RenderServiceUnit(options)); err != nil {
return err
}
if err := d.Units.Write(update.PathUnitName, update.RenderPathUnit(layout)); err != nil {
return err
}
if err := d.Manager.DaemonReload(); err != nil {
return err
}
return d.Manager.EnableNow(update.PathUnitName)
}
func (e *EnableBrowserUpdatesUseCase) undo() {
d := e.dependencies
_ = d.Manager.DisableNow(update.PathUnitName)
_, _ = d.Units.Remove(update.ServiceUnitName)
_, _ = d.Units.Remove(update.PathUnitName)
_ = d.Manager.DaemonReload()
}
func enabledMessage(options update.InstallOptions) string {
lines := []string{
"Browser updates are enabled for " + options.Service + ".",
"Installed " + update.PathUnitName + " and " + update.ServiceUnitName + " (port " + options.Port + ") and wrote " + update.HelperStatusFileName + " in " + options.DataDir + ".",
"To undo it, run: renewcms disable-browser-updates",
}
return strings.Join(lines, "\n")
}
func (u *DisableBrowserUpdatesUseCase) Disable(options update.InstallOptions) (string, error) {
d := u.dependencies
if d.Probe.OS() != update.OSLinux || !d.Probe.SystemdRunning() {
return notEnabledMessage, nil
}
if err := update.CheckInstallEnvironment(d.Probe); err != nil {
return "", err
}
dataDir := firstNonEmpty(options.DataDir, u.locatedDataDir(options.Service))
_ = d.Manager.DisableNow(update.PathUnitName)
removed := u.removeUnits()
if dataDir == "" {
return "", update.ErrDataDirNotFound
}
statusRemoved, err := d.Status.Remove(dataDir)
if err != nil {
return "", err
}
if !removed && !statusRemoved {
return notEnabledMessage, nil
}
if err := d.Manager.DaemonReload(); err != nil {
return "", err
}
return disabledMessage, nil
}
func (u *DisableBrowserUpdatesUseCase) locatedDataDir(service string) string {
description, _ := u.dependencies.Locator.Locate(firstNonEmpty(service, update.DefaultService))
return description.DataDir
}
func (u *DisableBrowserUpdatesUseCase) removeUnits() bool {
removedAny := false
for _, name := range []string{update.PathUnitName, update.ServiceUnitName} {
removed, err := u.dependencies.Units.Remove(name)
removedAny = removedAny || (removed && err == nil)
}
return removedAny
}
const (
notEnabledMessage = "Browser updates were not enabled, nothing to remove."
disabledMessage = "Browser updates are disabled. The restart request, the result, the staged files and the backups were left in place."
)
func firstNonEmpty(values ...string) string {
for _, value := range values {
if value != "" {
return value
}
}
return ""
}
@@ -0,0 +1,21 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"time"
)
type RecordRunningInfoUseCase struct {
store update.RunningInfoStore
version string
pid int
now func() time.Time
}
func NewRecordRunningInfoUseCase(store update.RunningInfoStore, version string, pid int, now func() time.Time) *RecordRunningInfoUseCase {
return &RecordRunningInfoUseCase{store: store, version: version, pid: pid, now: now}
}
func (r *RecordRunningInfoUseCase) Record() error {
return r.store.Write(update.RunningInfo{Version: r.version, Pid: r.pid, StartedAt: r.now().UTC()})
}
@@ -0,0 +1,79 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"sync"
"time"
)
type RequestRestartUseCase struct {
jobs update.JobStore
helper update.HelperDetector
results update.ResultStore
requests update.RestartRequestStore
status updateStatusBuilder
now func() time.Time
mu sync.Mutex
}
func NewRequestRestartUseCase(store update.StatusStore, jobs update.JobStore, helper update.HelperDetector, results update.ResultStore, requests update.RestartRequestStore, currentVersion string, now func() time.Time) *RequestRestartUseCase {
return &RequestRestartUseCase{
jobs: jobs,
helper: helper,
results: results,
requests: requests,
status: updateStatusBuilder{store: store, jobs: jobs, results: results, requests: requests, currentVersion: currentVersion, now: now},
now: now,
}
}
func (r *RequestRestartUseCase) Request(userId uint32, kind string) (update.UpdateStatus, error) {
if !r.helper.Installed() {
return update.UpdateStatus{}, update.ErrNotPrepared
}
r.mu.Lock()
defer r.mu.Unlock()
current := r.status.build(true)
if err := refuseWhileBusy(current); err != nil {
return update.UpdateStatus{}, err
}
request, err := r.requestFor(kind, userId)
if err != nil {
return update.UpdateStatus{}, err
}
if err := r.results.Delete(); err != nil {
return update.UpdateStatus{}, err
}
if err := r.requests.Write(request); err != nil {
return update.UpdateStatus{}, err
}
return r.status.build(true), nil
}
func refuseWhileBusy(status update.UpdateStatus) error {
switch status.State {
case update.StateDownloading, update.StateVerifying:
return update.ErrJobInProgress
case update.StateRestarting:
return update.ErrRestartPending
}
return nil
}
func (r *RequestRestartUseCase) requestFor(kind string, userId uint32) (update.RestartRequest, error) {
request := update.RestartRequest{
Kind: update.RestartKindRestart,
RequestedAt: r.now().UTC(),
RequestedBy: userId,
}
if job, found := r.jobs.Load(); found && job.State == update.StateReady {
request.Kind = update.RestartKindUpdate
request.Tag = job.Tag
}
if kind != "" && kind != request.Kind {
return update.RestartRequest{}, update.ErrRestartKindMismatch
}
return request, nil
}
@@ -0,0 +1,282 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"errors"
"fmt"
"sync"
"time"
)
type StartUpdateDownloadUseCase struct {
store update.StatusStore
jobs update.JobStore
helper update.HelperDetector
results update.ResultStore
status updateStatusBuilder
fetcher update.AssetFetcher
verifier update.SignatureVerifier
runner update.StagedBinaryRunner
backup update.DatabaseBackup
staging update.StagingArea
logger update.Logger
currentVersion string
platform update.Platform
feedHost string
now func() time.Time
mu sync.Mutex
}
type StartUpdateDownloadDependencies struct {
Store update.StatusStore
Jobs update.JobStore
Helper update.HelperDetector
Results update.ResultStore
Requests update.RestartRequestStore
Fetcher update.AssetFetcher
Verifier update.SignatureVerifier
Runner update.StagedBinaryRunner
Backup update.DatabaseBackup
Staging update.StagingArea
Logger update.Logger
CurrentVersion string
Platform update.Platform
FeedURL string
Now func() time.Time
}
type jobFailure struct {
kind string
reason error
}
func (f jobFailure) Error() string {
return f.reason.Error()
}
func NewStartUpdateDownloadUseCase(dependencies StartUpdateDownloadDependencies) *StartUpdateDownloadUseCase {
return &StartUpdateDownloadUseCase{
store: dependencies.Store,
jobs: dependencies.Jobs,
helper: dependencies.Helper,
results: dependencies.Results,
status: updateStatusBuilder{
store: dependencies.Store,
jobs: dependencies.Jobs,
results: dependencies.Results,
requests: dependencies.Requests,
currentVersion: dependencies.CurrentVersion,
now: dependencies.Now,
},
fetcher: dependencies.Fetcher,
verifier: dependencies.Verifier,
runner: dependencies.Runner,
backup: dependencies.Backup,
staging: dependencies.Staging,
logger: dependencies.Logger,
currentVersion: dependencies.CurrentVersion,
platform: dependencies.Platform,
feedHost: update.HostOf(dependencies.FeedURL),
now: dependencies.Now,
}
}
func (s *StartUpdateDownloadUseCase) Start() (update.UpdateStatus, error) {
if !s.helper.Installed() {
return update.UpdateStatus{}, update.ErrNotPrepared
}
s.mu.Lock()
defer s.mu.Unlock()
if job, found := s.jobs.Load(); found && job.Occupies() {
return update.UpdateStatus{}, update.ErrJobInProgress
}
if s.status.build(true).State == update.StateRestarting {
return update.UpdateStatus{}, update.ErrRestartPending
}
result, found := s.store.Load()
if !found || !update.IsNewer(s.currentVersion, result.Latest) {
return update.UpdateStatus{}, update.ErrNothingToUpdate
}
binary, checksums, signature, err := s.preflight(result)
if err != nil {
s.logger.Printf("update download refused: %v", err)
return update.UpdateStatus{}, update.ErrPreflightRefused
}
job := update.Job{
Tag: result.Latest,
State: update.StateDownloading,
StartedAt: s.now().UTC(),
TotalBytes: binary.Size,
}
if err := s.results.Delete(); err != nil {
return update.UpdateStatus{}, err
}
if err := s.jobs.Save(job); err != nil {
return update.UpdateStatus{}, err
}
status := s.status.build(true)
go s.run(job, binary, checksums, signature)
return status, nil
}
func (s *StartUpdateDownloadUseCase) preflight(result update.CheckResult) (binary, checksums, signature update.Asset, err error) {
names := []string{update.AssetName(result.Latest, s.platform), update.ChecksumsAssetName, update.SignatureAssetName}
found := make([]update.Asset, 0, len(names))
for _, name := range names {
asset, ok := update.FindAsset(result.Assets, name)
if !ok {
return binary, checksums, signature, fmt.Errorf("asset %q is not listed for %s", name, result.Latest)
}
if !update.IsAllowedAssetURL(asset.URL, s.feedHost) {
return binary, checksums, signature, fmt.Errorf("asset %q has a url outside the feed host or without https", name)
}
found = append(found, asset)
}
return found[0], found[1], found[2], nil
}
func (s *StartUpdateDownloadUseCase) run(job update.Job, binary, checksums, signature update.Asset) {
defer func() {
if recovered := recover(); recovered != nil {
s.fail(job, downloadFailure(fmt.Errorf("panic: %v", recovered)))
}
}()
if err := s.execute(&job, binary, checksums, signature); err != nil {
s.fail(job, err)
}
}
func (s *StartUpdateDownloadUseCase) execute(job *update.Job, binary, checksums, signature update.Asset) error {
binaryPath := s.staging.PathFor(job.Tag, binary.Name)
checksumsPath := s.staging.PathFor(job.Tag, checksums.Name)
signaturePath := s.staging.PathFor(job.Tag, signature.Name)
if err := s.staging.Prepare(job.Tag); err != nil {
return downloadFailure(err)
}
if err := s.fetchSmall(checksums, checksumsPath); err != nil {
return downloadFailure(err)
}
if err := s.fetchSmall(signature, signaturePath); err != nil {
return downloadFailure(err)
}
if err := s.fetchBinary(job, binary, binaryPath); err != nil {
return downloadFailure(err)
}
job.State = update.StateVerifying
if err := s.jobs.Save(*job); err != nil {
return downloadFailure(err)
}
if err := s.verify(job.Tag, binary.Name, binaryPath, checksumsPath, signaturePath); err != nil {
return jobFailure{kind: update.ErrorKindVerification, reason: err}
}
if _, err := s.backup.Backup(); err != nil {
return downloadFailure(err)
}
job.State = update.StateReady
job.StagedBinary = binaryPath
job.DownloadedBytes = 0
job.TotalBytes = 0
return s.jobs.Save(*job)
}
func (s *StartUpdateDownloadUseCase) fetchSmall(asset update.Asset, destination string) error {
if err := s.fetcher.Fetch(asset, destination, ignoreProgress); err != nil {
return err
}
return s.assertDeclaredSize(asset, destination)
}
func (s *StartUpdateDownloadUseCase) fetchBinary(job *update.Job, asset update.Asset, destination string) error {
lastPercent := -1
report := func(done int64, _ int64) {
current := *job
current.DownloadedBytes = done
percent := 0
if progress := current.Progress(); progress != nil {
percent = progress.Percent
}
if percent == lastPercent && done < asset.Size {
return
}
lastPercent = percent
_ = s.jobs.Save(current)
}
if err := s.fetcher.Fetch(asset, destination, report); err != nil {
return err
}
return s.assertDeclaredSize(asset, destination)
}
func ignoreProgress(int64, int64) {}
func (s *StartUpdateDownloadUseCase) assertDeclaredSize(asset update.Asset, path string) error {
size, err := s.staging.Size(path)
if err != nil {
return err
}
if asset.Size > 0 && size != asset.Size {
return fmt.Errorf("received %d bytes for %q, the release declares %d", size, asset.Name, asset.Size)
}
return nil
}
func (s *StartUpdateDownloadUseCase) verify(tag, assetName, binaryPath, checksumsPath, signaturePath string) error {
if err := s.verifier.Verify(checksumsPath, signaturePath); err != nil {
return fmt.Errorf("signature check: %w", err)
}
content, err := s.staging.ReadChecksums(checksumsPath)
if err != nil {
return err
}
expected, found := update.ChecksumFor(content, assetName)
if !found {
return fmt.Errorf("checksums.txt has no line for %q", assetName)
}
actual, err := update.FileSHA256(binaryPath)
if err != nil {
return err
}
if actual != expected {
return fmt.Errorf("sha-256 mismatch for %q", assetName)
}
if err := s.staging.MakeExecutable(binaryPath); err != nil {
return err
}
output, err := s.runner.Version(binaryPath)
if err != nil {
return fmt.Errorf("running the staged binary: %w", err)
}
if output != tag {
return fmt.Errorf("the staged binary reports version %q, expected %q", output, tag)
}
return nil
}
func downloadFailure(err error) error {
return jobFailure{kind: update.ErrorKindDownload, reason: err}
}
func (s *StartUpdateDownloadUseCase) fail(job update.Job, err error) {
kind := update.ErrorKindDownload
var failure jobFailure
if errors.As(err, &failure) {
kind = failure.kind
}
s.logger.Printf("update to %s failed (%s): %v", job.Tag, kind, err)
_ = s.staging.Remove(job.Tag)
job.State = update.StateFailed
job.Error = kind
job.DownloadedBytes = 0
job.TotalBytes = 0
job.StagedBinary = ""
if saveErr := s.jobs.Save(job); saveErr != nil {
s.logger.Printf("update job record could not be saved: %v", saveErr)
}
}
@@ -4,16 +4,25 @@ import "RenewCMS/internal/domain/article"
type UpdateArticleUseCase struct {
articleRepository article.Repository
bodyRenderer article.BodyRenderer
}
func NewUpdateArticleUseCase(articleRepository article.Repository) *UpdateArticleUseCase {
return &UpdateArticleUseCase{articleRepository}
func NewUpdateArticleUseCase(articleRepository article.Repository, bodyRenderer article.BodyRenderer) *UpdateArticleUseCase {
return &UpdateArticleUseCase{articleRepository, bodyRenderer}
}
func (g *UpdateArticleUseCase) UpdateBody(id uint32, body string) (article.Article, error) {
return g.articleRepository.UpdateBody(id, body)
func (g *UpdateArticleUseCase) UpdateBody(id uint32, body string, format article.BodyFormat) (article.Article, error) {
updated, err := g.articleRepository.UpdateBody(id, body)
if err != nil {
return article.Article{}, err
}
return renderArticle(g.bodyRenderer, updated, format)
}
func (g *UpdateArticleUseCase) UpdateIsOnline(id uint32, isOnline bool) (article.Article, error) {
return g.articleRepository.UpdateIsOnline(id, isOnline)
func (g *UpdateArticleUseCase) UpdateIsOnline(id uint32, isOnline bool, format article.BodyFormat) (article.Article, error) {
updated, err := g.articleRepository.UpdateIsOnline(id, isOnline)
if err != nil {
return article.Article{}, err
}
return renderArticle(g.bodyRenderer, updated, format)
}
@@ -0,0 +1,24 @@
package useCases
import "RenewCMS/internal/domain/article"
func renderArticle(renderer article.BodyRenderer, art article.Article, format article.BodyFormat) (article.Article, error) {
body, err := renderer.Render(art.Body, format)
if err != nil {
return article.Article{}, err
}
art.Body = body
return art, nil
}
func renderArticles(renderer article.BodyRenderer, articles []article.Article, format article.BodyFormat) ([]article.Article, error) {
rendered := make([]article.Article, 0, len(articles))
for _, art := range articles {
renderedArticle, err := renderArticle(renderer, art, format)
if err != nil {
return nil, err
}
rendered = append(rendered, renderedArticle)
}
return rendered, nil
}
@@ -0,0 +1,44 @@
package useCases
import (
"RenewCMS/internal/domain/update"
"errors"
"time"
)
type updateStatusBuilder struct {
store update.StatusStore
jobs update.JobStore
results update.ResultStore
requests update.RestartRequestStore
currentVersion string
now func() time.Time
}
func (b updateStatusBuilder) build(canApply bool) update.UpdateStatus {
status := b.baseStatus()
if job, found := b.jobs.Load(); found {
status = status.WithJob(job)
}
status.CanApply = canApply
request, requestErr := b.requests.Read()
result, hasResult := b.results.Read()
if hasResult {
status.FinishedAt = result.FinishedAt
}
switch {
case !errors.Is(requestErr, update.ErrNoRestartRequest):
return status.WithRestartRequest(request)
case hasResult:
return status.WithResult(result, b.currentVersion, b.now())
}
return status
}
func (b updateStatusBuilder) baseStatus() update.UpdateStatus {
if result, found := b.store.Load(); found {
return update.NewStatus(b.currentVersion, &result)
}
return update.NewStatus(b.currentVersion, nil)
}
+361
View File
@@ -0,0 +1,361 @@
package test
import (
"RenewCMS/api/handlers/article"
"RenewCMS/api/middleware"
"RenewCMS/api/pkg/apperr"
validator "RenewCMS/api/pkg/validator"
domainArticle "RenewCMS/internal/domain/article"
"RenewCMS/internal/infrastructure/markdown"
"RenewCMS/internal/infrastructure/useCases"
"bytes"
"encoding/json"
"errors"
"net/http"
"net/http/httptest"
"testing"
"github.com/go-chi/chi/v5"
"github.com/go-chi/jwtauth/v5"
)
type fakeBodyRenderer struct {
fail bool
calls int
}
var _ domainArticle.BodyRenderer = &fakeBodyRenderer{}
func (f *fakeBodyRenderer) Render(html string, format domainArticle.BodyFormat) (string, error) {
f.calls++
if f.fail {
return "", errors.New("render failed")
}
return html, nil
}
const (
bodyFormatArticleOneHTML = "<h2>Plan</h2><p>Replace the <strong>old</strong> deck.</p>"
bodyFormatArticleOneMD = "## Plan\n\nReplace the **old** deck."
bodyFormatArticleOneJSON = `[{"type":"heading","level":2,"children":[{"type":"text","text":"Plan","marks":[]}]},{"type":"paragraph","children":[{"type":"text","text":"Replace the ","marks":[]},{"type":"text","text":"old","marks":[{"type":"bold"}]},{"type":"text","text":" deck.","marks":[]}]}]`
)
func newBodyFormatRouter(articleRepo *mockArticleRepo, userRepo *mockUserRepo, renderer domainArticle.BodyRenderer, token *jwtauth.JWTAuth) *chi.Mux {
getUserUseCase := useCases.NewGetUserUseCase(userRepo)
articleHandler := article.NewHandler(
useCases.NewCreateArticleUseCase(articleRepo, renderer),
useCases.NewGetArticleUseCase(articleRepo, renderer),
useCases.NewListArticlesUseCase(articleRepo, renderer),
useCases.NewDeleteArticleUseCase(articleRepo),
useCases.NewUpdateArticleUseCase(articleRepo, renderer),
getUserUseCase,
)
r := chi.NewRouter()
r.Route("/v1", func(r chi.Router) {
r.Route("/article", func(r chi.Router) {
r.Use(jwtauth.Verifier(token))
r.Get("/", articleHandler.ListArticles)
r.Get("/{id}", articleHandler.GetArticle)
r.Group(func(r chi.Router) {
r.Use(jwtauth.Authenticator(token))
r.Use(middleware.RequireVerifiedUser(getUserUseCase))
r.Post("/", articleHandler.PostArticle)
r.Patch("/{id}", articleHandler.UpdateArticleBody)
r.Patch("/{id}/publish", articleHandler.PublishArticle)
r.Patch("/{id}/unpublish", articleHandler.UnpublishArticle)
})
})
})
return r
}
func seedBodyFormatRepo() *mockArticleRepo {
repo := newMockArticleRepo()
repo.articles[1] = domainArticle.Article{ID: 1, Title: "Backyard Renovation Update", Body: bodyFormatArticleOneHTML, IsOnline: true}
repo.articles[2] = domainArticle.Article{ID: 2, Title: "Draft: Kitchen Remodel", Body: "<p>Draft</p>", IsOnline: false}
repo.articles[3] = domainArticle.Article{ID: 3, Title: "Second article", Body: "<p>Second</p>", IsOnline: true}
repo.nextID = 3
return repo
}
type bodyFormatResponse struct {
ID uint32 `json:"id"`
Title string `json:"title"`
Body json.RawMessage `json:"body"`
BodyFormat string `json:"body_format"`
IsOnline bool `json:"is_online"`
}
func serveBodyFormat(router http.Handler, method, path, body string, cookie *http.Cookie) *httptest.ResponseRecorder {
req := httptest.NewRequest(method, path, bytes.NewBufferString(body))
if cookie != nil {
req.AddCookie(cookie)
}
rec := httptest.NewRecorder()
router.ServeHTTP(rec, req)
return rec
}
func decodeBodyFormatArticle(t *testing.T, rec *httptest.ResponseRecorder, expectedStatus int) bodyFormatResponse {
t.Helper()
if rec.Code != expectedStatus {
t.Fatalf("expected status %d, got %d, body %q", expectedStatus, rec.Code, rec.Body.String())
}
var got bodyFormatResponse
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
return got
}
func assertBodyFormat(t *testing.T, got bodyFormatResponse, format, expectedBody string) {
t.Helper()
if got.BodyFormat != format {
t.Errorf("expected body_format %q, got %q", format, got.BodyFormat)
}
if format == "json" {
assertSameJSON(t, string(got.Body), expectedBody)
return
}
var text string
if err := json.Unmarshal(got.Body, &text); err != nil {
t.Fatalf("body is not a JSON string: %s", got.Body)
}
if text != expectedBody {
t.Errorf("expected body %q, got %q", expectedBody, text)
}
}
func assertSameJSON(t *testing.T, actual, expected string) {
t.Helper()
var actualValue, expectedValue any
if err := json.Unmarshal([]byte(actual), &actualValue); err != nil {
t.Fatalf("actual is not JSON: %s", actual)
}
if err := json.Unmarshal([]byte(expected), &expectedValue); err != nil {
t.Fatalf("expected is not JSON: %s", expected)
}
actualBytes, _ := json.Marshal(actualValue)
expectedBytes, _ := json.Marshal(expectedValue)
if string(actualBytes) != string(expectedBytes) {
t.Errorf("expected %s, got %s", expectedBytes, actualBytes)
}
}
func TestArticleBodyFormatHttp(t *testing.T) {
validator.InitValidator()
token := jwtauth.New("HS256", []byte("test-secret"), nil)
newRouter := func(repo *mockArticleRepo, users *mockUserRepo, renderer domainArticle.BodyRenderer) *chi.Mux {
return newBodyFormatRouter(repo, users, renderer, token)
}
realRouter := func() (*chi.Mux, *mockArticleRepo) {
repo := seedBodyFormatRepo()
return newRouter(repo, newPublicArticleReadUserRepo(true), markdown.NewConverter()), repo
}
verifiedCookie := mintPublicArticleReadCookie(t, token, 1)
t.Run("Single read negotiates the body format", func(t *testing.T) {
examples := []struct {
query, format, body string
}{
{"", "markdown", bodyFormatArticleOneMD},
{"?format=", "markdown", bodyFormatArticleOneMD},
{"?format=markdown", "markdown", bodyFormatArticleOneMD},
{"?format=MarkDown", "markdown", bodyFormatArticleOneMD},
{"?format=html", "html", bodyFormatArticleOneHTML},
{"?format=HTML", "html", bodyFormatArticleOneHTML},
{"?format=json", "json", bodyFormatArticleOneJSON},
{"?format=JSON", "json", bodyFormatArticleOneJSON},
}
for _, example := range examples {
router, _ := realRouter()
rec := serveBodyFormat(router, http.MethodGet, "/v1/article/1"+example.query, "", nil)
got := decodeBodyFormatArticle(t, rec, http.StatusOK)
assertBodyFormat(t, got, example.format, example.body)
}
})
t.Run("List read negotiates every element", func(t *testing.T) {
router, _ := realRouter()
expectations := []struct {
query, format, secondBody string
}{
{"", "markdown", "Second"},
{"?format=html", "html", "<p>Second</p>"},
{"?format=json", "json", `[{"type":"paragraph","children":[{"type":"text","text":"Second","marks":[]}]}]`},
}
for _, expectation := range expectations {
rec := serveBodyFormat(router, http.MethodGet, "/v1/article/"+expectation.query, "", nil)
var items []bodyFormatResponse
if err := json.Unmarshal(rec.Body.Bytes(), &items); err != nil {
t.Fatalf("failed to decode list: %v", err)
}
if len(items) != 2 {
t.Fatalf("expected 2 online articles, got %d", len(items))
}
for _, item := range items {
if item.BodyFormat != expectation.format {
t.Errorf("expected body_format %q, got %q", expectation.format, item.BodyFormat)
}
if item.ID == 3 {
assertBodyFormat(t, item, expectation.format, expectation.secondBody)
}
}
}
})
t.Run("An unsupported format is rejected", func(t *testing.T) {
for _, path := range []string{"/v1/article/1?format=pdf", "/v1/article/?format=xml", "/v1/article/9999?format=pdf", "/v1/article/1?format=md"} {
renderer := &fakeBodyRenderer{}
router := newRouter(seedBodyFormatRepo(), newMockUserRepo(), renderer)
rec := serveBodyFormat(router, http.MethodGet, path, "", nil)
if rec.Code != http.StatusBadRequest {
t.Fatalf("%s: expected status 400, got %d", path, rec.Code)
}
if rec.Body.String() != apperr.ArticleBodyFormatErrorMessage+"\n" {
t.Errorf("%s: unexpected body %q", path, rec.Body.String())
}
if renderer.calls != 0 {
t.Errorf("%s: renderer must not be called", path)
}
}
})
t.Run("An invalid id is reported before an invalid format", func(t *testing.T) {
router, _ := realRouter()
rec := serveBodyFormat(router, http.MethodGet, "/v1/article/abc?format=pdf", "", nil)
if rec.Code != http.StatusBadRequest || rec.Body.String() != apperr.IdUint32ErrorMessage+"\n" {
t.Errorf("unexpected response %d %q", rec.Code, rec.Body.String())
}
})
t.Run("The first repeated format parameter wins", func(t *testing.T) {
router, _ := realRouter()
rec := serveBodyFormat(router, http.MethodGet, "/v1/article/1?format=html&format=json", "", nil)
got := decodeBodyFormatArticle(t, rec, http.StatusOK)
assertBodyFormat(t, got, "html", bodyFormatArticleOneHTML)
})
t.Run("Offline articles stay hidden whatever the format", func(t *testing.T) {
unverified := newRouter(seedBodyFormatRepo(), newMockUserRepo(), markdown.NewConverter())
rec := serveBodyFormat(unverified, http.MethodGet, "/v1/article/2?format=json", "", nil)
if rec.Code != http.StatusNotFound || rec.Body.String() != apperr.ArticleNotFoundErrorMessage+"\n" {
t.Errorf("unexpected response %d %q", rec.Code, rec.Body.String())
}
})
t.Run("Authenticated routes negotiate the response body", func(t *testing.T) {
paragraph := func(text string) string {
return `[{"type":"paragraph","children":[{"type":"text","text":"` + text + `","marks":[]}]}]`
}
type expectedBodies map[string]string
bodiesA := expectedBodies{"markdown": "A", "html": "<p>A</p>", "json": paragraph("A")}
bodiesB := expectedBodies{"markdown": "B", "html": "<p>B</p>", "json": paragraph("B")}
bodiesOne := expectedBodies{"markdown": bodyFormatArticleOneMD, "html": bodyFormatArticleOneHTML, "json": bodyFormatArticleOneJSON}
examples := []struct {
method, path, body string
status int
format string
bodies expectedBodies
}{
{http.MethodPost, "/v1/article/", `{"title":"Deck","body":"<p>A</p>"}`, 201, "markdown", bodiesA},
{http.MethodPost, "/v1/article/?format=html", `{"title":"Deck","body":"<p>A</p>"}`, 201, "html", bodiesA},
{http.MethodPost, "/v1/article/?format=json", `{"title":"Deck","body":"<p>A</p>"}`, 201, "json", bodiesA},
{http.MethodPatch, "/v1/article/1", `{"body":"<p>B</p>"}`, 200, "markdown", bodiesB},
{http.MethodPatch, "/v1/article/1?format=json", `{"body":"<p>B</p>"}`, 200, "json", bodiesB},
{http.MethodPatch, "/v1/article/1/publish", "", 200, "markdown", bodiesOne},
{http.MethodPatch, "/v1/article/1/unpublish?format=html", "", 200, "html", bodiesOne},
}
for _, example := range examples {
router, repo := realRouter()
rec := serveBodyFormat(router, example.method, example.path, example.body, verifiedCookie)
got := decodeBodyFormatArticle(t, rec, example.status)
assertBodyFormat(t, got, example.format, example.bodies[example.format])
stored := repo.articles[got.ID].Body
if example.bodies["html"] != stored {
t.Errorf("%s %s: stored body must stay HTML %q, got %q", example.method, example.path, example.bodies["html"], stored)
}
}
})
t.Run("An unsupported format on a write route changes nothing", func(t *testing.T) {
requests := []struct {
method, path, body string
}{
{http.MethodPatch, "/v1/article/1?format=pdf", `{"body":"<p>B</p>"}`},
{http.MethodPost, "/v1/article/?format=pdf", `{"title":"Deck","body":"<p>A</p>"}`},
{http.MethodPatch, "/v1/article/1/publish?format=pdf", ""},
{http.MethodPatch, "/v1/article/1/unpublish?format=pdf", ""},
}
for _, request := range requests {
repo := seedBodyFormatRepo()
renderer := &fakeBodyRenderer{}
router := newRouter(repo, newPublicArticleReadUserRepo(true), renderer)
rec := serveBodyFormat(router, request.method, request.path, request.body, verifiedCookie)
if rec.Code != http.StatusBadRequest {
t.Fatalf("%s %s: expected 400, got %d", request.method, request.path, rec.Code)
}
if rec.Body.String() != apperr.ArticleBodyFormatErrorMessage+"\n" {
t.Errorf("%s %s: unexpected body %q", request.method, request.path, rec.Body.String())
}
if renderer.calls != 0 {
t.Errorf("%s %s: renderer must not be called", request.method, request.path)
}
if repo.articles[1].Body != bodyFormatArticleOneHTML {
t.Errorf("%s %s: stored body changed to %q", request.method, request.path, repo.articles[1].Body)
}
if !repo.articles[1].IsOnline {
t.Errorf("%s %s: is_online changed", request.method, request.path)
}
if repo.createCalled {
t.Errorf("%s %s: no article may be created", request.method, request.path)
}
}
})
t.Run("The authenticated list includes offline articles in the negotiated format", func(t *testing.T) {
router, _ := realRouter()
rec := serveBodyFormat(router, http.MethodGet, "/v1/article/?format=json", "", verifiedCookie)
var items []bodyFormatResponse
if err := json.Unmarshal(rec.Body.Bytes(), &items); err != nil {
t.Fatalf("failed to decode list: %v", err)
}
seen := map[uint32]bool{}
for _, item := range items {
seen[item.ID] = true
if item.BodyFormat != "json" {
t.Errorf("expected json, got %q", item.BodyFormat)
}
}
if !seen[1] || !seen[2] {
t.Errorf("expected articles 1 and 2, got %v", seen)
}
})
t.Run("A converter failure answers 500", func(t *testing.T) {
router := newRouter(seedBodyFormatRepo(), newMockUserRepo(), &fakeBodyRenderer{fail: true})
rec := serveBodyFormat(router, http.MethodGet, "/v1/article/1", "", nil)
if rec.Code != http.StatusInternalServerError || rec.Body.String() != "Internal server error\n" {
t.Errorf("unexpected response %d %q", rec.Code, rec.Body.String())
}
})
}
func TestParseBodyFormat(t *testing.T) {
valid := map[string]domainArticle.BodyFormat{
"": domainArticle.BodyFormatMarkdown, "markdown": domainArticle.BodyFormatMarkdown, "MARKDOWN": domainArticle.BodyFormatMarkdown,
"html": domainArticle.BodyFormatHTML, "Html": domainArticle.BodyFormatHTML, "json": domainArticle.BodyFormatJSON,
}
for input, expected := range valid {
got, err := domainArticle.ParseBodyFormat(input)
if err != nil || got != expected {
t.Errorf("ParseBodyFormat(%q) = %q, %v", input, got, err)
}
}
for _, input := range []string{"pdf", "md", " html"} {
if _, err := domainArticle.ParseBodyFormat(input); !errors.Is(err, domainArticle.ErrUnsupportedBodyFormat) {
t.Errorf("ParseBodyFormat(%q) should be unsupported, got %v", input, err)
}
}
}
Loaded 100 of 258 files, more files were not shown because too many files have changed in this diff. Show more