From 27659b0ca155d05cdf9a1a99f236b7da80c2d6ad Mon Sep 17 00:00:00 2001
From: Florian Sylvain <floriansylvain@mailo.com>
Date: Mon, 10 Jun 2024 00:40:23 +0200
Subject: [PATCH] feat: faces "culling"

---
 public/debug.png | Bin 0 -> 1100 bytes
 public/grass.png | Bin 1283 -> 1283 bytes
 src/face.ts      |   8 ++---
 src/main.ts      |  88 +++++++++++++++++++++++++++++++++++++++--------
 4 files changed, 78 insertions(+), 18 deletions(-)
 create mode 100644 public/debug.png

diff --git a/public/debug.png b/public/debug.png
new file mode 100644
index 0000000000000000000000000000000000000000..8299a13ce09c3dc506706a0b12790e83205f7ae7
GIT binary patch
literal 1100
zcmV-S1he~zP)<h;3K|Lk000e1NJLTq000mG003YJ0ssI2o3my200001b5ch_0Itp)
z=>Px#1ZP1_K>z@;j|==^1poj532;bRa{vGi!vFvd!vV){sAK>D1K~+TK~z{ry_ZjH
z6;%|*e+61VNC6wMgc2>WDbWQO39GvBPh!f31Y)Z;VWE))jV#y+hJ{gCxNyOOg!m^h
zVS%hPA!<kzLP7`)A#RMIsntRarZgBAXrb@<&6zth_ue=4b+qmGPCMs(_nv#^+&Oda
zotAo?N?78qb4C#1#to<VSh|!A8=Rg%4!LaH=tv*^{Xw6=n3{6Z(ZQ}=Oim^;GZXX)
za#**{$+BgM$W5{&OtU=c*4E_KOHuBSMkvLs4wWNRc9;zd?@(TR)6=xIIX%K+RI5|w
zipmiJhreLdsRd#tsqjo*G3E`A`P7)dJtl~7A3ER|eD8=7#5p_#&%%4oDnaa^pu=zy
z&O0JT;Lrj!*bUFayN-)d5<xfwXW=u`Bg77hAUp#v!Uv{DD0dLvgiCPFSp~{(Nq7?W
z!N<-j5GU>99e4sB2s<ru@y!J-MVfQNyxfvvUV$H+)c`g7asnQNPHXD6LXSEGhMx0s
zD+%d(IX;2!!VZ$axM%}k2+2qSL+|24&}T2Q&-)VFD(lBB&Py=T&?<@TR6c}Fpw;qn
zLsM+$@*6w~ugCoC4^A_y72%e%Jop1>LRHg0nf|p_eRx0YAPEfJ@zXX+x<9-Xwwja`
z-%Xf;E!uq@;bY;eRj+8Z5dS+ujoJhg&M<W8=fgYMBr?E&YcRCfh`yBEQV%_OvjRFc
zL**Ri!(oiEHLU5RvzzXd$=(tmo~1zsuX6P`$ECN@x{Yn^w5LrDd48#Ami(j}WuB70
z#<g4=l_QEc#E@&q5OpXizG?kDv?Xgnfkmj+<R+_No~HF*kUIR)uz&p8aI*S2c{~Q?
z@DZ#sC70*y=;SklcASus{H32VpJ#0|W(r?rj6@@9iI(E*?eJ=*e`C#$!2XQUk|>Nz
z&y#)uzHn-Cxax<U7Bj`SwlcfbARQw;f&FN@wgzRD`fCLd(+h{Qp6(*i?s*_7r39KH
z?TUhqL8+n<V~3Y5=$95DWwew(W{k$lyA_&tSwYFXmN9P|qbb%{dACB#7d#zrQ$}a9
z6dEh<R%ntP*8GddJZy}%jGQSn$vyZzWd4kp%H^#csG7rnc;oyCwHgyPSF2aEcCAs3
zC{~a<1K#Gaem#5kFghA^s5h>BJv~XoojaU9&G<OIy~+Oo{s4-QI^?o>Gkf>?OtYki
zhdFb`>4s(wig5cjw~8}LGlzS6_RwBz5zQRN#^~x|<w|EZahROs=url>UKA*ExPG0H
z5l)?=ua6ZgIC8}C4&Ib8lx+@r(p$H3@E~{Z1|90ER$YAPQ(BnqYkJ|U75)Jw(m4-#
SHlCdT0000<MNUMnLSTZbodOU5

literal 0
HcmV?d00001

diff --git a/public/grass.png b/public/grass.png
index f45330956ac4b21ca1dd57c7ea13a7fd422363d6..e8b9d7e1fc7beeedaa01b7992971713e1d242b2d 100644
GIT binary patch
delta 21
dcmZqXYUY~Y$#sx{f$t#Wj)~cCHwJHD0RT;P2j~C*

delta 21
dcmZqXYUY~Y$#s~4f$uQm@%$Aj8-q8n002wy2aNy#

diff --git a/src/face.ts b/src/face.ts
index 62d4ddd..82e5d2a 100644
--- a/src/face.ts
+++ b/src/face.ts
@@ -27,13 +27,13 @@ export const FACE_ORIENTATION = [
 	},
 	{
 		orientation: "East",
-		position: new Vector3(0.5, 0, 0),
-		rotation: new Vector3(0, 90 * DEG_RAD, 0)
+		position: new Vector3(-0.5, 0, 0),
+		rotation: new Vector3(0, -90 * DEG_RAD, 0)
 	},
 	{
 		orientation: "West",
-		position: new Vector3(-0.5, 0, 0),
-		rotation: new Vector3(0, -90 * DEG_RAD, 0)
+		position: new Vector3(0.5, 0, 0),
+		rotation: new Vector3(0, 90 * DEG_RAD, 0)
 	},
 	{
 		orientation: "South",
diff --git a/src/main.ts b/src/main.ts
index dfdbb4e..f3551c5 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -20,12 +20,71 @@ const controls = new OrbitControls(camera, renderer.domElement)
 controls.update()
 document.body.appendChild(renderer.domElement)
 
-new TextureLoader("/grass.png", 16, 16, onTextureLoaded)
+new TextureLoader("/debug.png", 16, 16, onTextureLoaded)
+
+// const gridHelper = new THREE.GridHelper(1000, 1000)
+// scene.add(gridHelper)
+
+// const axesHelper = new THREE.AxesHelper(500)
+// scene.add(axesHelper)
+
+const FACES_OFFSETS: { [key: string]: THREE.Vector3 } = {
+	Up: new THREE.Vector3(0, 1, 0),
+	North: new THREE.Vector3(0, 0, 1),
+	South: new THREE.Vector3(0, 0, -1),
+	East: new THREE.Vector3(-1, 0, 0),
+	West: new THREE.Vector3(1, 0, 0),
+	Down: new THREE.Vector3(0, -1, 0)
+}
+
+function filterFaces(
+	faces: Face[],
+	block: THREE.Vector3,
+	chunk: THREE.Vector3[]
+): Face[] {
+	return faces.filter((face) => {
+		const offset = FACES_OFFSETS[face.orientation]
+		const adjacentBlock = new THREE.Vector3(
+			block.x + offset.x,
+			block.y + offset.y,
+			block.z + offset.z
+		)
+		return !chunk.some((c) => c.equals(adjacentBlock))
+	})
+}
+
+function countVisibleFaces(chunk: THREE.Vector3[]): { [key: string]: number } {
+	const faceCounts: { [key: string]: number } = {
+		Up: 0,
+		North: 0,
+		South: 0,
+		East: 0,
+		West: 0,
+		Down: 0
+	}
+
+	chunk.forEach((block) => {
+		Object.keys(FACES_OFFSETS).forEach((orientation) => {
+			const offset = FACES_OFFSETS[orientation]
+			const adjacentBlock = new THREE.Vector3(
+				block.x + offset.x,
+				block.y + offset.y,
+				block.z + offset.z
+			)
+			if (!chunk.some((c) => c.equals(adjacentBlock))) {
+				faceCounts[orientation]++
+			}
+		})
+	})
+
+	return faceCounts
+}
 
 function onTextureLoaded(textures: THREE.Texture[]) {
 	const chunk = [] as THREE.Vector3[]
-	for (let i = -16; i < 16; i++) {
-		for (let j = -16; j < 16; j++) {
+	const radius = 64
+	for (let i = -radius; i < radius; i++) {
+		for (let j = -radius; j < radius; j++) {
 			chunk.push(
 				new THREE.Vector3(
 					i,
@@ -36,19 +95,20 @@ function onTextureLoaded(textures: THREE.Texture[]) {
 		}
 	}
 
+	const faceCounts = countVisibleFaces(chunk)
+
 	const faces = [
-		new Face("Up", chunk.length, textures[0]),
-		new Face("North", chunk.length, textures[1]),
-		new Face("South", chunk.length, textures[2]),
-		new Face("East", chunk.length, textures[3]),
-		new Face("West", chunk.length, textures[4]),
-		new Face("Down", chunk.length, textures[5])
+		new Face("Up", faceCounts.Up, textures[0]),
+		new Face("North", faceCounts.North, textures[1]),
+		new Face("South", faceCounts.South, textures[2]),
+		new Face("East", faceCounts.East, textures[3]),
+		new Face("West", faceCounts.West, textures[4]),
+		new Face("Down", faceCounts.Down, textures[5])
 	]
 
 	const cubes = [] as Block[]
 	chunk.forEach((block) => {
-		// TODO PUSH FACES ONLY IN CONTACT WITH AIR
-		cubes.push(new Block(faces, block))
+		cubes.push(new Block(filterFaces(faces, block, chunk), block))
 	})
 
 	faces.forEach((face) => {
@@ -56,9 +116,9 @@ function onTextureLoaded(textures: THREE.Texture[]) {
 	})
 }
 
-camera.position.x = 20
-camera.position.y = 20
-camera.position.z = 20
+camera.position.x = 5
+camera.position.y = 5
+camera.position.z = 5
 
 function animate(elapsedTimeMs: number) {
 	renderer.render(scene, camera)