DB improv., sessions/users handlers improv.

src/__tests__/app.test.ts

@@ -1,7 +1,9 @@
 import { initServer } from '../app.js'
 import request from 'supertest'
+import { User } from '.prisma/client'
 
 const app = initServer()
+let jwtCookie: string | undefined
 
 describe('GET /v1', () => {
     it('returns status code 200 and api version message', async () => {
@@ -13,10 +15,10 @@ describe('GET /v1', () => {
     })
 })
 
-describe('POST /v1/login', () => {
+describe('POST /v1/session/login', () => {
     it('returns status code 200 and set httpOnly jwt token cookie', async () => {
         const res = await request(app)
-            .post('/v1/login')
+            .post('/v1/session/login')
             .set('Content-Type', 'application/json')
             .send(JSON.stringify({
                 email: "a@a.com",
@@ -24,10 +26,39 @@ describe('POST /v1/login', () => {
             }))
 
         const jwtRegEx = /^jwt=.*Path=\/.*HttpOnly.*Secure.*SameSite=Strict.*$/
-        const jwtToken = res.get('Set-Cookie')
-            .filter(cookie => cookie.match(jwtRegEx))
+        jwtCookie = res.get('Set-Cookie')
+            ?.filter(cookie => cookie.match(jwtRegEx))[0]
+
+        // jwtToken = jwtCookie.match('(^|;)\\s*jwt\\s*=\\s*([^;]+)')?.pop() || ''
 
         expect(res.statusCode).toEqual(200)
-        expect(jwtToken).not.toBe(undefined)
+        expect(jwtCookie).not.toBe(undefined)
     })
 })
+
+
+describe('PUT /v1/user', () => {
+    it('returns status code 200', async () => {
+        const res = await request(app)
+            .put('/v1/user')
+            .set('Content-Type', 'application/json')
+            .set('Cookie', jwtCookie as string)
+            .send(JSON.stringify({
+                name: 'didier'
+            }))
+
+        expect(res.statusCode).toEqual(200)
+    })
+
+    it('returns status code 400 and an error message', async () => {
+        const res = await request(app)
+            .put('/v1/user')
+            .set('Content-Type', 'application/json')
+            .set('Cookie', 'jwt=23897yr0287yf.12423fv.23f4325')
+            .send(JSON.stringify({
+                name: 'didier'
+            }))
+
+        expect(res.statusCode).toEqual(400)
+    })
+})

src/app.ts

@@ -5,6 +5,7 @@ import jwt from 'jsonwebtoken'
 import cors from 'cors'
 import cookieParser from 'cookie-parser'
 import { getJwtSecret } from './utils/jwt.js'
+import sessionRouter from './routers/session.js'
 
 const authMiddleware: RequestHandler = (req, res, next) => {
     const token = req.cookies.jwt
@@ -54,7 +55,9 @@ export function initServer(): express.Express {
 
     appRouter.get('/', appRouterGet)
 
-    appRouter.use(userRouter)
+    appRouter.use('/session/', sessionRouter)
+    appRouter.use('/user/', authMiddleware, userRouter)
+
     app.use('/v1/', appRouter)
 
     return app

src/routers/session.ts

@@ -0,0 +1,105 @@
+import { PrismaClient, User } from "@prisma/client"
+import express from "express"
+import { RequestHandler } from "express-serve-static-core"
+import { z } from "zod"
+import { getJwtSecret } from "../utils/jwt.js"
+import bcrypt from 'bcrypt'
+import jwt from 'jsonwebtoken'
+
+interface LoginData {
+    email: string,
+    password: string
+}
+
+const sessionRouter = express.Router()
+const prisma = new PrismaClient()
+
+const LoginValidator = z.object({
+    email: z.string().email(),
+    password: z.string().min(4).max(20)
+})
+
+async function isUserValid(user: User | null, loginData: any): Promise<boolean> {
+    if (user == undefined) return false
+    return await bcrypt.compare(loginData.password, user.password)
+}
+
+async function isUserEmailAlreadyUsed(email: string): Promise<boolean> {
+    const user = await prisma.user.findFirst({ where: { email } })
+    return user != undefined
+}
+
+async function createUser(email: string, password: string) {
+    await prisma.user.create({
+        data: {
+            email: email,
+            password: password,
+            name: '',
+            picture_path: '',
+            created_at: new Date(),
+            updated_at: new Date()
+        },
+    })
+}
+
+async function getUser(email: string): Promise<User | null> {
+    return await prisma.user.findFirst({
+        where: {
+            email: email
+        }
+    })
+}
+
+function parseLoginData(data: any): LoginData | undefined {
+    try {
+        const loginData: LoginData = LoginValidator.parse(data)
+        return loginData
+    } catch {
+        return undefined
+    }
+}
+
+export const userRouterPostLogin: RequestHandler = async (req, res) => {
+    const loginData = parseLoginData(req.body)
+    if (loginData === undefined) {
+        res.status(400).json({ message: 'Incorrect credentials format.' })
+        return;
+    }
+
+    const user = await getUser(loginData.email)
+    if (await isUserValid(user, loginData) === false) {
+        res.status(400).json({ message: 'Incorrect credentials.' })
+        return;
+    }
+
+    const jwtToken = jwt.sign({ userId: user?.id }, getJwtSecret(), { expiresIn: "1h" })
+    res.cookie('jwt', jwtToken, {
+        httpOnly: true,
+        secure: true,
+        sameSite: 'strict'
+    }).json({ message: 'Logged in! httpOnly cookie set.' })
+}
+
+export const userRouterPostRegister: RequestHandler = async (req, res) => {
+    const loginData = parseLoginData(req.body)
+    if (loginData == undefined) {
+        res.status(400).json({ message: 'Incorrect credentials format.' })
+        return;
+    }
+
+    if (await isUserEmailAlreadyUsed(loginData.email)) {
+        res.status(400).json({ message: 'Email already linked to an account.' })
+        return;
+    }
+
+    const hashedPassword = await bcrypt.hash(loginData.password, 10)
+
+    createUser(loginData.email, hashedPassword)
+
+    res.json({ message: 'User successfully created!' })
+}
+
+sessionRouter.post('/login', userRouterPostLogin)
+sessionRouter.post('/register', userRouterPostRegister)
+
+export default sessionRouter

src/routers/user.ts

@@ -1,105 +1,44 @@
 import { PrismaClient, User } from '@prisma/client'
 import express, { RequestHandler } from 'express'
-
-import { z } from 'zod'
-import bcrypt from 'bcrypt'
 import jwt from 'jsonwebtoken'
-import { getJwtSecret } from '../utils/jwt.js'
-
-interface LoginData {
-    email: string,
-    password: string
-}
 
 const userRouter = express.Router()
 const prisma = new PrismaClient()
 
-const LoginValidator = z.object({
-    email: z.string().email(),
-    password: z.string().min(4).max(20)
-})
-
-async function isUserValid(user: User | null, loginData: any): Promise<boolean> {
-    if (user == undefined) return false
-    return await bcrypt.compare(loginData.password, user.password)
+function parseJwtUserId(jwtoken: string): number | undefined {
+    const payload = jwt.decode(jwtoken)
+    if (payload == undefined) {
+        return undefined
+    } else if (typeof payload == 'string') {
+        return undefined
+    }
+    return payload.userId
 }
 
-async function isUserEmailAlreadyUsed(email: string): Promise<boolean> {
-    const user = await prisma.user.findFirst({ where: { email } })
-    return user != undefined
-}
-
-async function createUser(email: string, password: string) {
-    await prisma.user.create({
+async function updateUser(userId: number): Promise<User> {
+    return await prisma.user.update({
+        where: { id: userId },
         data: {
-            email: email,
-            password: password,
-            name: '',
-            picture_path: '',
-            created_at: new Date(),
-            updated_at: new Date()
-        },
-    })
-}
-
-async function getUser(email: string): Promise<User | null> {
-    return await prisma.user.findFirst({
-        where: {
-            email: email
         }
     })
 }
 
-function parseLoginData(data: any): LoginData | undefined {
-    try {
-        const loginData: LoginData = LoginValidator.parse(data)
-        return loginData
-    } catch {
-        return undefined
+const userRouterPut: RequestHandler = async (req, res) => {
+    const userId = parseJwtUserId(req.cookies.jwt)
+    if (userId === undefined) {
+        res.status(400).json({
+            message: 'Incorrect JWT payload.'
+        })
+        return;
     }
+
+    await updateUser(userId)
+
+    res.json({
+        message: 'User successfully updated.'
+    })
 }
 
-const userRouterPostLogin: RequestHandler = async (req, res) => {
-    const loginData = parseLoginData(req.body)
-    if (loginData === undefined) {
-        res.status(400).json({ message: 'Incorrect credentials format.' })
-        return;
-    }
-
-    const user = await getUser(loginData.email)
-    if (await isUserValid(user, loginData) === false) {
-        res.status(400).json({ message: 'Incorrect credentials.' })
-        return;
-    }
-
-    const jwtToken = jwt.sign({}, getJwtSecret(), { expiresIn: "1h" })
-    res.cookie('jwt', jwtToken, {
-        httpOnly: true,
-        secure: true,
-        sameSite: 'strict'
-    }).json({ message: "Logged in! httpOnly cookie set." })
-}
-
-const userRouterPostRegister: RequestHandler = async (req, res) => {
-    const loginData = parseLoginData(req.body)
-    if (loginData == undefined) {
-        res.status(400).json({ message: 'Incorrect credentials format.' })
-        return;
-    }
-
-    if (await isUserEmailAlreadyUsed(loginData.email)) {
-        res.status(400).json({ message: 'Email already linked to an account.' })
-        return;
-    }
-
-    const hashedPassword = await bcrypt.hash(loginData.password, 10)
-
-    createUser(loginData.email, hashedPassword)
-
-    res.json({ message: 'User successfully created!' })
-}
-
-userRouter.post("/login", userRouterPostLogin)
-userRouter.post("/register", userRouterPostRegister)
+userRouter.put("/", userRouterPut)
 
 export default userRouter