From 02dbc0e6f69d9c567bd312ad262212ed1426a1a3 Mon Sep 17 00:00:00 2001
From: Florian Sylvain <floriansylvainpro@gmail.com>
Date: Thu, 2 Feb 2023 10:15:56 +0100
Subject: [PATCH] Added :id param on snippet delete route

---
 src/__tests__/app.test.ts | 7 ++-----
 src/routers/snippet.ts    | 9 ++-------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/src/__tests__/app.test.ts b/src/__tests__/app.test.ts
index b400ddd..e9194f7 100644
--- a/src/__tests__/app.test.ts
+++ b/src/__tests__/app.test.ts
@@ -255,15 +255,12 @@ describe('PUT /v1/snippet/:id', () => {
     })
 })
 
-describe('DELETE /v1/snippet', () => {
+describe('DELETE /v1/snippet/:id', () => {
     it('returns status code 200 and success message', async () => {
         const res = await request(app)
-            .delete('/v1/snippet')
+            .delete(`/v1/snippet/${snippet_id}`)
             .set('Content-Type', 'application/json')
             .set('Cookie', jwtCookie as string)
-            .send(JSON.stringify({
-                id: snippet_id
-            }))
 
         expect(res.status).toEqual(200)
         expect(res.body).toHaveProperty('message')
diff --git a/src/routers/snippet.ts b/src/routers/snippet.ts
index 77e49c4..12c9946 100644
--- a/src/routers/snippet.ts
+++ b/src/routers/snippet.ts
@@ -12,10 +12,6 @@ const snippetPostParser = z.object({
     language: z.string().max(32)
 }).required()
 
-const snippetDeleteParser = z.object({
-    id: z.number(),
-}).required()
-
 const snippetUpdateParser = z.object({
     code: z.string().optional(),
     title: z.string().max(50).optional(),
@@ -91,10 +87,9 @@ const snippetDelete: RequestHandler = async (req, res) => {
     let deleted: Prisma.BatchPayload
 
     try {
-        const snippetToDel = snippetDeleteParser.parse(req.body)
         deleted = await prisma.category.deleteMany({
             where: {
-                id: snippetToDel.id,
+                id: paramsIdParser.parse(req.params).id,
                 user_id: req.body.userId
             }
         })
@@ -109,6 +104,6 @@ const snippetDelete: RequestHandler = async (req, res) => {
 snippetRouter.get('/', userIdMiddleware, snippetGet)
 snippetRouter.post('/', userIdMiddleware, snippetPost)
 snippetRouter.put('/:id', userIdMiddleware, snippetUpdate)
-snippetRouter.delete('/', userIdMiddleware, snippetDelete)
+snippetRouter.delete('/:id', userIdMiddleware, snippetDelete)
 
 export default snippetRouter