refac: DELETE /v1/user/{id}?expected_role_id=N, user.remove audit event, 409 target_role_not_found, GetAll returns its error, Own-scope visibility filter moved into repos, JSON tags removed from use-case types

internal/infrastructure/useCases/ReassignRoleMembers.go

@@ -34,7 +34,8 @@ func (u *ReassignRoleMembersUseCase) Reassign(ctx context.Context, command Reass
 	if err := u.checkSource(command.Caller, source); err != nil {
 		return 0, err
 	}
-	if err := u.checkTarget(command, source); err != nil {
+	target, err := u.checkTarget(command, source)
+	if err != nil {
 		return 0, err
 	}
 
@@ -42,6 +43,7 @@ func (u *ReassignRoleMembersUseCase) Reassign(ctx context.Context, command Reass
 	event.Target = roleTarget(source)
 	event.Params[audit.ParamFrom] = source.ID
 	event.Params[audit.ParamTo] = command.TargetID
+	event.Params[audit.ParamToName] = target.Name
 	event.Params[audit.ParamMoved] = 0
 	moved, err := u.roles.ReassignMembers(source.ID, command.TargetID)
 	if err != nil {
@@ -68,19 +70,22 @@ func (u *ReassignRoleMembersUseCase) checkSource(caller ContentCaller, source ro
 	return ensureCovered(caller, u.contentTypes, source)
 }
 
-func (u *ReassignRoleMembersUseCase) checkTarget(command ReassignRoleMembersCommand, source role.Role) error {
+func (u *ReassignRoleMembersUseCase) checkTarget(command ReassignRoleMembersCommand, source role.Role) (role.Role, error) {
 	if command.TargetID == 0 || command.TargetID == source.ID {
-		return role.ErrInvalidReassign
+		return role.Role{}, role.ErrInvalidReassign
 	}
 	target, err := u.roles.Get(command.TargetID)
 	if errors.Is(err, role.ErrRoleNotFound) {
-		return role.ErrInvalidReassign
+		return role.Role{}, role.ErrReassignTargetNotFound
 	}
 	if err != nil {
-		return err
+		return role.Role{}, err
 	}
 	if target.Locked {
-		return role.ErrInvalidReassign
+		return role.Role{}, role.ErrInvalidReassign
 	}
-	return ensureCovered(command.Caller, u.contentTypes, target)
+	if err := ensureCovered(command.Caller, u.contentTypes, target); err != nil {
+		return role.Role{}, err
+	}
+	return target, nil
 }