refac: migration crash, real-database tests, site deleted during create, ruels out of the repo, lists

test/article_create_language_test.go

@@ -81,6 +81,17 @@ func TestCreateArticleStartingLanguage(t *testing.T) {
 		}
 	})
 
+	t.Run("A site deleted after its lookup refuses the creation with a specific error", func(t *testing.T) {
+		create, transactor, articles := newCreateLanguageFixture(map[uint32]string{createLanguageSiteID: confirmedDefaultTag})
+		transactor.languages.removed = map[uint32]bool{createLanguageSiteID: true}
+
+		_, err := create.CreateArticle(context.Background(), createLanguageCommand())
+
+		if !errors.Is(err, article.ErrTargetSiteDeleted) || errors.Is(err, site.ErrSiteNotFound) || articles.createCalled {
+			t.Errorf("expected ErrTargetSiteDeleted without a create, got %v", err)
+		}
+	})
+
 	t.Run("The command site decides the site and the language lock", func(t *testing.T) {
 		create, transactor, articles := newCreateLanguageFixture(map[uint32]string{createLanguageSiteID: confirmedDefaultTag, createLanguageOtherSiteID: "de"})
 		create = useCases.NewCreateArticleUseCase(transactor, &fakeBodyRenderer{}, discardRecorder, createLanguageSites(), plainAuthors())