feat: Users API, ownership transfer and removal of the legacy role string

test/author_support_test.go

@@ -340,7 +340,6 @@ var _ author.Repository = &mockAuthorRepo{}
 const (
 	authorEditorID      = 5
 	authorOtherEditorID = 6
-	authorEditorRole    = user.Role("editor")
 )
 
 type authorEnv struct {
@@ -351,8 +350,8 @@ type authorEnv struct {
 func newAuthorEnv(t *testing.T) *authorEnv {
 	t.Helper()
 	p := newProducersEnv(t)
-	p.users.users[authorEditorID] = user.User{ID: authorEditorID, Username: "edith", DisplayName: "Edith Moreau", Email: "edith@example.com", IsVerified: true, Role: authorEditorRole, RoleID: writerRoleID}
-	p.users.users[authorOtherEditorID] = user.User{ID: authorOtherEditorID, Username: "frank", Email: "frank@example.com", IsVerified: true, Role: authorEditorRole, RoleID: writerRoleID}
+	p.users.users[authorEditorID] = user.User{ID: authorEditorID, Username: "edith", DisplayName: "Edith Moreau", Email: "edith@example.com", IsVerified: true, RoleID: writerRoleID}
+	p.users.users[authorOtherEditorID] = user.User{ID: authorOtherEditorID, Username: "frank", Email: "frank@example.com", IsVerified: true, RoleID: writerRoleID}
 	p.users.nextID = authorOtherEditorID
 	authors := newMockAuthorRepo(p.articles)
 	sites := plainSites()
@@ -437,9 +436,9 @@ func joinNames(names []string) string {
 }
 
 func userWithEmail(id uint32, username string, email string) user.User {
-	return user.User{ID: id, Username: username, Email: email, IsVerified: true, Role: authorEditorRole, RoleID: writerRoleID}
+	return user.User{ID: id, Username: username, Email: email, IsVerified: true, RoleID: writerRoleID}
 }
 
 func userNamed(id uint32, username string, displayName string) user.User {
-	return user.User{ID: id, Username: username, DisplayName: displayName, Email: username + "@example.com", IsVerified: true, Role: authorEditorRole, RoleID: writerRoleID}
+	return user.User{ID: id, Username: username, DisplayName: displayName, Email: username + "@example.com", IsVerified: true, RoleID: writerRoleID}
 }