refac: repository updates, image attachment and deletes report the domain not-found error for an unknown id, the same for articles, users and images, and the test fakes stop returning GORM errors

test/use_case_baseline_test.go

@@ -11,8 +11,6 @@ import (
 	"strings"
 	"testing"
 	"time"
-
-	"gorm.io/gorm"
 )
 
 func TestCreateArticleTitleLengthLimit(t *testing.T) {
@@ -258,8 +256,8 @@ func TestUpdateArticleDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateArticleUseCase(repo)
 		_, err := uc.UpdateBody(9, "New body")
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, article.ErrArticleNotFound) {
+			t.Errorf("expected article.ErrArticleNotFound, got %v", err)
 		}
 	})
 
@@ -279,8 +277,8 @@ func TestUpdateArticleDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateArticleUseCase(repo)
 		_, err := uc.UpdateIsOnline(9, true)
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, article.ErrArticleNotFound) {
+			t.Errorf("expected article.ErrArticleNotFound, got %v", err)
 		}
 	})
 
@@ -304,8 +302,8 @@ func TestUpdateArticleDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateArticleUseCase(repo)
 		err := uc.AddImage(9, 1)
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, article.ErrArticleNotFound) {
+			t.Errorf("expected article.ErrArticleNotFound, got %v", err)
 		}
 	})
 
@@ -313,25 +311,34 @@ func TestUpdateArticleDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateArticleUseCase(repo)
 		err := uc.AddImage(1, 9)
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, imageDomain.ErrImageNotFound) {
+			t.Errorf("expected image.ErrImageNotFound, got %v", err)
 		}
 	})
 }
 
-func TestDeleteArticleSucceedsSilently(t *testing.T) {
-	for _, id := range []uint32{1, 9} {
-		t.Run(fmt.Sprintf("id_%d", id), func(t *testing.T) {
-			repo := newMockArticleRepo()
-			repo.articles[1] = article.Article{ID: 1}
-			uc := useCases.NewDeleteArticleUseCase(repo)
+func TestDeleteArticleReportsMissingArticle(t *testing.T) {
+	t.Run("id_1", func(t *testing.T) {
+		repo := newMockArticleRepo()
+		repo.articles[1] = article.Article{ID: 1}
+		uc := useCases.NewDeleteArticleUseCase(repo)
 
-			err := uc.DeleteArticle(id)
-			if err != nil {
-				t.Errorf("expected no error, got %v", err)
-			}
-		})
-	}
+		err := uc.DeleteArticle(1)
+		if err != nil {
+			t.Errorf("expected no error, got %v", err)
+		}
+	})
+
+	t.Run("id_9", func(t *testing.T) {
+		repo := newMockArticleRepo()
+		repo.articles[1] = article.Article{ID: 1}
+		uc := useCases.NewDeleteArticleUseCase(repo)
+
+		err := uc.DeleteArticle(9)
+		if !errors.Is(err, article.ErrArticleNotFound) {
+			t.Errorf("expected article.ErrArticleNotFound, got %v", err)
+		}
+	})
 }
 
 func TestDeleteArticlePropagatesRepositoryFailure(t *testing.T) {
@@ -425,8 +432,8 @@ func TestDeleteImageRequiresExistence(t *testing.T) {
 		uc := useCases.NewDeleteImageUseCase(repo)
 
 		err := uc.DeleteImage(9)
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, imageDomain.ErrImageNotFound) {
+			t.Errorf("expected image.ErrImageNotFound, got %v", err)
 		}
 	})
 }
@@ -604,8 +611,8 @@ func TestUpdateUserDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateUserUseCase(repo, &stubHasher{})
 		_, err := uc.UpdateVerificationStatus(9, true)
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, user.ErrUserNotFound) {
+			t.Errorf("expected user.ErrUserNotFound, got %v", err)
 		}
 	})
 
@@ -625,8 +632,8 @@ func TestUpdateUserDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateUserUseCase(repo, &stubHasher{})
 		_, err := uc.UpdatePassword(9, "newpassword123")
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, user.ErrUserNotFound) {
+			t.Errorf("expected user.ErrUserNotFound, got %v", err)
 		}
 	})
 
@@ -646,25 +653,34 @@ func TestUpdateUserDelegatesEachOperation(t *testing.T) {
 		repo := newRepo()
 		uc := useCases.NewUpdateUserUseCase(repo, &stubHasher{})
 		_, err := uc.UpdatePasswordResetCode(9, "reset-code-123")
-		if !errors.Is(err, gorm.ErrRecordNotFound) {
-			t.Errorf("expected gorm.ErrRecordNotFound, got %v", err)
+		if !errors.Is(err, user.ErrUserNotFound) {
+			t.Errorf("expected user.ErrUserNotFound, got %v", err)
 		}
 	})
 }
 
-func TestDeleteUserSucceedsSilently(t *testing.T) {
-	for _, id := range []uint32{1, 9} {
-		t.Run(fmt.Sprintf("id_%d", id), func(t *testing.T) {
-			repo := newMockUserRepo()
-			repo.users[1] = user.User{ID: 1}
-			uc := useCases.NewDeleteUserUseCase(repo)
+func TestDeleteUserReportsMissingUser(t *testing.T) {
+	t.Run("id_1", func(t *testing.T) {
+		repo := newMockUserRepo()
+		repo.users[1] = user.User{ID: 1}
+		uc := useCases.NewDeleteUserUseCase(repo)
 
-			err := uc.DeleteUser(id)
-			if err != nil {
-				t.Errorf("expected no error, got %v", err)
-			}
-		})
-	}
+		err := uc.DeleteUser(1)
+		if err != nil {
+			t.Errorf("expected no error, got %v", err)
+		}
+	})
+
+	t.Run("id_9", func(t *testing.T) {
+		repo := newMockUserRepo()
+		repo.users[1] = user.User{ID: 1}
+		uc := useCases.NewDeleteUserUseCase(repo)
+
+		err := uc.DeleteUser(9)
+		if !errors.Is(err, user.ErrUserNotFound) {
+			t.Errorf("expected user.ErrUserNotFound, got %v", err)
+		}
+	})
 }
 
 func TestSendMailForwardsArgumentsVerbatim(t *testing.T) {