feat(media): pagination

features/editor_media_picker.feature

@@ -17,13 +17,16 @@ Feature: The editor's Library tab, picking an image from the media library
       a bottom sheet on mobile
     And the footer reads "Cancel", and on the Library tab also a primary "Insert image" that is
       disabled until an image is selected
-    And the Library tab calls GET /v1/media/ through useApi with limit=24, with q only while a
-      search is set and cursor only when loading more (no filter and no sort parameter), and the
-      Upload tab is specified in features/editor_image_upload.feature
-    And the response is { items, next_cursor, counts }, newest first; sizes read "8 KB" and
+    And the Library tab calls GET /v1/media/?q=Q&page=N&size=25 through useApi, with q only while a
+      search is set and page 1, then 2, 3, ... when loading more (no filter and no sort parameter),
+      and the Upload tab is specified in features/editor_image_upload.feature
+    And the response is { items, total, page, size, counts }, newest first; "Load more" shows while
+      the loaded count is below the response total (the matching count, not counts.all); sizes read "8 KB" and
       "3.9 MB", dimensions read "2400 × 1600" (an SVG reads "Vector"), dates are absolute
     And the 12-image fixture, ids 1 to 12, is the one in features/media_browse.feature, and the
-      picker mocks use next_cursor "c24" and counts { all: 48, unused: 2, duplicates: 2 }
+      picker mocks use total 48 and counts { all: 48, unused: 2, duplicates: 2 }
+    And this slice is amended by features/media_pagination_api.feature: cursor and limit are gone,
+      LIBRARY_PAGE_LIMIT 24 became the page size 25, and a mock with items equal to its total is the last page
     And an image is "in this article" when an image node with its id as data-image-id is in
       the editor's current content, unsaved insertions included, when the dialog opens;
       in the examples below images 1 (north-wall.jpg) and 4 (logo-renew.svg) are in the article
@@ -42,13 +45,13 @@ Feature: The editor's Library tab, picking an image from the media library
   Rule: Which tab opens
 
     Scenario: The library has images, so Library opens
-      Given GET /v1/media/?limit=24 resolves 200 with the 12-image fixture
+      Given GET /v1/media/?page=1&size=25 resolves 200 with the 12-image fixture
       When the user activates the toolbar's "Image" button
       Then the Library tab is selected and the footer reads "Cancel" and a disabled "Insert image"
       And nothing is drawn in the grid for the first 150 ms, then 8 skeleton tiles show until the response arrives
 
     Scenario: The library is empty, so Upload opens
-      Given GET /v1/media/?limit=24 resolves 200 with no item and no search set
+      Given GET /v1/media/?page=1&size=25 resolves 200 with no item and no search set
       When the dialog opens
       Then the Upload tab is selected, in its idle state
       When the user selects the Library tab
@@ -56,9 +59,9 @@ Feature: The editor's Library tab, picking an image from the media library
 
     Scenario: A dropped file opens Upload and sends no list request
       When the user drops "before.png" onto the editor
-      Then the Upload tab is selected and no GET /v1/media/?limit=24 is sent
+      Then the Upload tab is selected and no GET /v1/media/?page=1&size=25 is sent
       When the user selects the Library tab
-      Then GET /v1/media/?limit=24 is sent
+      Then GET /v1/media/?page=1&size=25 is sent
 
   Rule: Browsing
 
@@ -75,7 +78,7 @@ Feature: The editor's Library tab, picking an image from the media library
       Then the line reads "Newest first"
 
     Scenario: Load more is hidden on the last page
-      Given the response has next_cursor null
+      Given the loaded items equal the response total (for example total 12 with the 12-image fixture)
       Then "Load more" is not shown
 
     Scenario Outline: A tile's accessible name
@@ -167,16 +170,16 @@ Feature: The editor's Library tab, picking an image from the media library
     Scenario: Typing searches after a debounce
       Given the Library tab shows the 12-image fixture
       When the user types "wall"
-      Then after a 120 ms debounce GET /v1/media/ is sent with q=wall and limit=24 and no cursor
+      Then after a 120 ms debounce GET /v1/media/ is sent with q=wall, page=1 and size=25
       And skeleton tiles show after 150 ms, and any selection is cleared
 
     Scenario: The x in the field clears the search
       Given the search field holds "wall" with results shown
       When the user activates the x in the field
-      Then the field is empty and GET /v1/media/ is sent with limit=24 and no q
+      Then the field is empty and GET /v1/media/ is sent with page=1 and size=25 and no q
 
     Scenario: No results
-      Given GET /v1/media/?q=wall&limit=24 resolves 200 with no item
+      Given GET /v1/media/?q=wall&page=1&size=25 resolves 200 with no item
       Then the search icon shows with the title `No images match "wall"`, the text "Check the spelling, or search for a shorter part of the filename." and a "Clear search" button
       And the search field still shows "wall" above it, and "Insert image" is disabled
       When the user activates "Clear search"
@@ -185,23 +188,23 @@ Feature: The editor's Library tab, picking an image from the media library
   Rule: Load more
 
     Scenario: Loading more shows progress and appends
-      Given the first page resolved with 12 images, next_cursor "c24"
+      Given the first page resolved with 12 images and total 48
       When the user activates "Load more"
-      Then GET /v1/media/ is sent with limit=24 and cursor=c24
+      Then GET /v1/media/ is sent with page=2 and size=25
       And the button reads "Loading…" with a loader-circle and is disabled, and one row of skeleton tiles shows at the end
       And focus stays on the button
       When the request resolves 200 with 12 more images
       Then the new tiles are appended after the first 12, and focus moves to the first new tile
 
-    Scenario: The cursor and the search combine
-      Given the search "wall" is active and the page has next_cursor "c24"
+    Scenario: The next page and the search combine
+      Given the search "wall" is active and the response total is above the loaded count
       When the user activates "Load more"
-      Then GET /v1/media/ is sent with q=wall, limit=24 and cursor=c24
+      Then GET /v1/media/ is sent with q=wall, page=2 and size=25
 
   Rule: Empty and failed
 
     Scenario: Empty library
-      Given the Library tab is selected and GET /v1/media/?limit=24 resolved with no item
+      Given the Library tab is selected and GET /v1/media/?page=1&size=25 resolved with no item
       Then the images icon shows with "Your library is empty", "Images you upload appear here, ready to use in any article." and a primary "Upload an image"
       And "Insert image" is disabled
       When the user activates "Upload an image"