refac: stale test entries, failing web tests, Postgre backup bug, Hardcoded MySQL table count, Stale Postgre connection in test, own-scope visibility filter, GetAll ignoring its error, JSON tags in use-case types, 31 copies of DESKTOP_QUERY, ProfileView endpoint paths

internal/infrastructure/useCases/AcceptInvite.go

@@ -72,7 +72,11 @@ func (a *AcceptInviteUseCase) recordRefusal(ctx context.Context, event audit.Eve
 }
 
 func (a *AcceptInviteUseCase) accept(command AcceptInviteCommand, pending invite.Invite, assigned role.Role, now time.Time) (user.User, error) {
-	if a.emailHasAccount(pending.Email) {
+	hasAccount, err := a.emailHasAccount(pending.Email)
+	if err != nil {
+		return user.User{}, err
+	}
+	if hasAccount {
 		if _, err := findUsableInvite(a.inviteRepository, a.hasher, command.Code, now); err != nil {
 			return user.User{}, err
 		}
@@ -122,13 +126,17 @@ func (a *AcceptInviteUseCase) inviterOf(pending invite.Invite) (uint32, error) {
 	return assigner.ID, nil
 }
 
-func (a *AcceptInviteUseCase) emailHasAccount(email string) bool {
-	for _, existingUser := range a.userRepository.GetAll() {
+func (a *AcceptInviteUseCase) emailHasAccount(email string) (bool, error) {
+	users, err := a.userRepository.GetAll()
+	if err != nil {
+		return false, err
+	}
+	for _, existingUser := range users {
 		if strings.EqualFold(existingUser.Email, email) {
-			return true
+			return true, nil
 		}
 	}
-	return false
+	return false, nil
 }
 
 func (a *AcceptInviteUseCase) ensureUsernameFree(username string) error {