refac: stale test entries, failing web tests, Postgre backup bug, Hardcoded MySQL table count, Stale Postgre connection in test, own-scope visibility filter, GetAll ignoring its error, JSON tags in use-case types, 31 copies of DESKTOP_QUERY, ProfileView endpoint paths

api/handlers/user/inviteHandler.go

@@ -4,6 +4,7 @@ import (
 	"RenewCMS/api/pkg/access"
 	"RenewCMS/api/pkg/apperr"
 	"RenewCMS/api/pkg/claims"
+	"RenewCMS/api/pkg/payload"
 	validator "RenewCMS/api/pkg/validator"
 	"RenewCMS/internal/domain/invite"
 	"RenewCMS/internal/domain/user"
@@ -30,34 +31,34 @@ type CreateInviteRequest struct {
 }
 
 type inviteResponse struct {
-	ID        uint32           `json:"id"`
-	Kind      string           `json:"kind"`
-	Email     string           `json:"email"`
-	Status    string           `json:"status"`
-	Role      useCases.RoleRef `json:"role"`
-	CreatedAt time.Time        `json:"created_at"`
-	ExpiresAt time.Time        `json:"expires_at"`
+	ID        uint32          `json:"id"`
+	Kind      string          `json:"kind"`
+	Email     string          `json:"email"`
+	Status    string          `json:"status"`
+	Role      payload.RoleRef `json:"role"`
+	CreatedAt time.Time       `json:"created_at"`
+	ExpiresAt time.Time       `json:"expires_at"`
 }
 
 type inviteListItem struct {
-	ID        uint32            `json:"id"`
-	Kind      string            `json:"kind"`
-	Email     string            `json:"email"`
-	Role      *useCases.RoleRef `json:"role"`
-	Status    string            `json:"status"`
-	CreatedAt time.Time         `json:"created_at"`
+	ID        uint32           `json:"id"`
+	Kind      string           `json:"kind"`
+	Email     string           `json:"email"`
+	Role      *payload.RoleRef `json:"role"`
+	Status    string           `json:"status"`
+	CreatedAt time.Time        `json:"created_at"`
 }
 
 type userListItem struct {
-	ID             uint32                 `json:"id"`
-	Kind           string                 `json:"kind"`
-	Username       string                 `json:"username"`
-	DisplayName    string                 `json:"display_name"`
-	Email          string                 `json:"email"`
-	Role           *useCases.RoleRef      `json:"role"`
-	RoleAssignedBy *useCases.RoleAssigner `json:"role_assigned_by"`
-	Status         string                 `json:"status"`
-	CreatedAt      time.Time              `json:"created_at"`
+	ID             uint32                `json:"id"`
+	Kind           string                `json:"kind"`
+	Username       string                `json:"username"`
+	DisplayName    string                `json:"display_name"`
+	Email          string                `json:"email"`
+	Role           *payload.RoleRef      `json:"role"`
+	RoleAssignedBy *payload.RoleAssigner `json:"role_assigned_by"`
+	Status         string                `json:"status"`
+	CreatedAt      time.Time             `json:"created_at"`
 }
 
 func NewInviteHandler(createInvite *useCases.CreateInviteUseCase, cancelInvite *useCases.CancelInviteUseCase, renewInvite *useCases.RenewInviteUseCase, listUsersAndInvites *useCases.ListUsersAndInvitesUseCase) *InviteHandler {
@@ -107,7 +108,7 @@ func writeInviteResponse(w http.ResponseWriter, status int, entry useCases.Invit
 		Kind:      useCases.EntryKindInvite,
 		Email:     entry.Email,
 		Status:    string(entry.StatusAt(time.Now())),
-		Role:      entry.Role,
+		Role:      payload.RoleRefOf(entry.Role),
 		CreatedAt: entry.CreatedAt,
 		ExpiresAt: entry.ExpiresAt,
 	})
@@ -212,7 +213,7 @@ func (h *InviteHandler) ListUsers(w http.ResponseWriter, _ *http.Request) {
 				ID:        entry.ID,
 				Kind:      entry.Kind,
 				Email:     entry.Email,
-				Role:      entry.Role,
+				Role:      payload.RoleRefPtrOf(entry.Role),
 				Status:    entry.Status,
 				CreatedAt: entry.CreatedAt,
 			})