From 46491a688b2bd2f3b017ea3dcbcaa78feebcf74b Mon Sep 17 00:00:00 2001
From: Florian Sylvain <floriansylvainpro@gmail.com>
Date: Thu, 17 Aug 2023 05:55:31 +0200
Subject: [PATCH] clean: refacto User and Article repos for clarity

Simplified the code for creating and returning user and article entities in userRepository.go and articleRepository.go. Direct function calls to domain.FromDb(...) were replaced with the more descriptive mapping functions mapUserToDomain(...) and mapArticleToDomain(...). This ensures better code readability and understanding and provides a single, consistent way to map database entities to domain entities.
---
 adapters/secondary/gateways/articleRepository.go | 10 ++--------
 adapters/secondary/gateways/userRepository.go    |  8 +-------
 2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/adapters/secondary/gateways/articleRepository.go b/adapters/secondary/gateways/articleRepository.go
index f2d87f7..34eda9d 100644
--- a/adapters/secondary/gateways/articleRepository.go
+++ b/adapters/secondary/gateways/articleRepository.go
@@ -26,7 +26,7 @@ func (a *ArticleRepository) Get(id uint32) (domain.Article, error) {
 		return domain.Article{}, err
 	}
 
-	return domain.FromDb(article.ID, article.Title, article.Body, article.CreatedAt, article.UpdatedAt), nil
+	return mapArticleToDomain(article), nil
 }
 
 func (a *ArticleRepository) Create(article domain.Article) (domain.Article, error) {
@@ -41,13 +41,7 @@ func (a *ArticleRepository) Create(article domain.Article) (domain.Article, erro
 	var createdArticle entity.Article
 	creationResult.Scan(&createdArticle)
 
-	return domain.FromDb(
-			createdArticle.ID,
-			createdArticle.Title,
-			createdArticle.Body,
-			createdArticle.CreatedAt,
-			createdArticle.UpdatedAt),
-		nil
+	return mapArticleToDomain(createdArticle), nil
 }
 
 func (a *ArticleRepository) GetAll() []domain.Article {
diff --git a/adapters/secondary/gateways/userRepository.go b/adapters/secondary/gateways/userRepository.go
index 691ed33..7f7c39c 100644
--- a/adapters/secondary/gateways/userRepository.go
+++ b/adapters/secondary/gateways/userRepository.go
@@ -45,13 +45,7 @@ func (u *UserRepository) Create(user domain.User) (domain.User, error) {
 	var createdUser entity.User
 	creationResult.Scan(&createdUser)
 
-	return domain.FromDb(
-			createdUser.ID,
-			createdUser.Username,
-			createdUser.Password,
-			createdUser.Email,
-			createdUser.CreatedAt,
-			createdUser.UpdatedAt),
+	return mapUserToDomain(createdUser),
 		nil
 }