refac: missing mutation tests, spa specs, checks shown to pass, touch targets, catalogue entry, production code

test/article_seo_index_support_test.go

@@ -26,6 +26,8 @@ func (m *mockArticleRepo) seoFresh(version article.Article) bool {
 }
 
 func (m *mockArticleRepo) StaleSEO(afterID uint32, limit int) ([]article.Article, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	if err := m.fail.trigger("StaleSEO"); err != nil {
 		return nil, err
 	}
@@ -45,6 +47,8 @@ func (m *mockArticleRepo) StaleSEO(afterID uint32, limit int) ([]article.Article
 }
 
 func (m *mockArticleRepo) StoreSEO(records []article.SEORecord) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	if err := m.fail.trigger("StoreSEO"); err != nil {
 		return err
 	}
@@ -64,6 +68,8 @@ func (m *mockArticleRepo) StoreSEO(records []article.SEORecord) error {
 }
 
 func (m *mockArticleRepo) MarkSiteSEOStale(siteID uint32) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	for id, version := range m.articles {
 		if version.SiteID == siteID {
 			delete(m.assessed, id)
@@ -73,6 +79,8 @@ func (m *mockArticleRepo) MarkSiteSEOStale(siteID uint32) error {
 }
 
 func (m *mockArticleRepo) CountSuggestions(filters article.Filters) (int, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	if err := m.fail.trigger("CountSuggestions"); err != nil {
 		return 0, err
 	}
@@ -86,6 +94,8 @@ func (m *mockArticleRepo) CountSuggestions(filters article.Filters) (int, error)
 }
 
 func (m *mockArticleRepo) CountSuggestedStories(readable article.StoryFilters) (int, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	m.listCalls++
 	if err := m.fail.trigger("CountSuggestedStories"); err != nil {
 		return 0, err
@@ -116,6 +126,8 @@ func mockVisible(version article.Article, onlineOnly bool, visibleTo *uint32) bo
 }
 
 func (m *mockArticleRepo) ListVersions(ids []uint32) ([]article.Article, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	m.listCalls++
 	if err := m.fail.trigger("ListVersions"); err != nil {
 		return nil, err
@@ -130,6 +142,8 @@ func (m *mockArticleRepo) ListVersions(ids []uint32) ([]article.Article, error)
 }
 
 func (m *mockArticleRepo) DeleteStory(storyID uint32) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	if err := m.fail.trigger("DeleteStory"); err != nil {
 		return err
 	}