refac: runtime settings are read once at startup and passed in through the composition root; no handler, router or repository reads environment variables

api/router.go

@@ -6,10 +6,9 @@ import (
 	"RenewCMS/api/handlers/frontend"
 	"RenewCMS/api/handlers/image"
 	"RenewCMS/api/middleware"
+	"RenewCMS/internal/infrastructure/config"
 	"encoding/json"
 	"net/http"
-	"os"
-	"strings"
 
 	"github.com/MadAppGang/httplog"
 	"github.com/go-chi/chi/v5"
@@ -18,8 +17,8 @@ import (
 	"github.com/go-chi/jwtauth/v5"
 )
 
-func enableLoggingIfDev(r *chi.Mux, routerName string) {
-	if os.Getenv("ENVIRONMENT") == "development" {
+func enableLoggingIfDev(r *chi.Mux, routerName string, environment string) {
+	if environment == "development" {
 		r.Use(httplog.LoggerWithName(routerName))
 	}
 }
@@ -51,10 +50,10 @@ func NewArticleRouter(container *UseCases) http.Handler {
 	return r
 }
 
-func NewAuthRouter(container *UseCases) http.Handler {
+func NewAuthRouter(container *UseCases, isProduction bool) http.Handler {
 	r := chi.NewRouter()
 
-	authHandler := auth.NewHandler(container.Token, container.GetUserUseCase, container.ListUsersUseCase, container.CreateUserUseCase, container.AuthenticateUserUseCase)
+	authHandler := auth.NewHandler(container.Token, container.GetUserUseCase, container.ListUsersUseCase, container.CreateUserUseCase, container.AuthenticateUserUseCase, isProduction)
 
 	r.Post("/register", authHandler.Register)
 	r.Post("/login", authHandler.Login)
@@ -62,10 +61,10 @@ func NewAuthRouter(container *UseCases) http.Handler {
 	return r
 }
 
-func InitBackendRoutes(container *UseCases) *chi.Mux {
+func InitBackendRoutes(container *UseCases, settings config.Settings) *chi.Mux {
 	r := chi.NewRouter()
 
-	enableLoggingIfDev(r, "backend")
+	enableLoggingIfDev(r, "backend", settings.Environment)
 
 	r.Use(chimiddleware.GetHead)
 	r.Use(middleware.JsonContentTypeMiddleware)
@@ -74,15 +73,15 @@ func InitBackendRoutes(container *UseCases) *chi.Mux {
 		r.Use(jwtauth.Verifier(container.Token))
 		r.Mount("/article", NewArticleRouter(container))
 	})
-	r.Mount("/auth", NewAuthRouter(container))
+	r.Mount("/auth", NewAuthRouter(container, settings.IsProduction()))
 
 	return r
 }
 
-func InitFrontendRoutes() *chi.Mux {
+func InitFrontendRoutes(environment string) *chi.Mux {
 	r := chi.NewRouter()
 
-	enableLoggingIfDev(r, "frontend")
+	enableLoggingIfDev(r, "frontend", environment)
 
 	r.Mount("/", frontend.NewFrontendRouter())
 
@@ -94,13 +93,12 @@ func GetHealth(w http.ResponseWriter, _ *http.Request) {
 	_, _ = w.Write([]byte("ok"))
 }
 
-func enableCorsIfConfigured(r *chi.Mux) {
-	origins := os.Getenv("CORS_ALLOWED_ORIGINS")
-	if origins == "" {
+func enableCorsIfConfigured(r *chi.Mux, origins []string) {
+	if len(origins) == 0 {
 		return
 	}
 	r.Use(cors.Handler(cors.Options{
-		AllowedOrigins:   strings.Split(origins, ";"),
+		AllowedOrigins:   origins,
 		AllowedMethods:   []string{"GET", "POST", "PUT", "DELETE", "OPTIONS"},
 		AllowedHeaders:   []string{"Accept", "Authorization", "Content-Type", "X-CSRF-Token"},
 		ExposedHeaders:   []string{"Link"},
@@ -109,12 +107,12 @@ func enableCorsIfConfigured(r *chi.Mux) {
 	}))
 }
 
-func InitRoutes(container *UseCases) *chi.Mux {
-	backend := InitBackendRoutes(container)
-	frontend := InitFrontendRoutes()
+func InitRoutes(container *UseCases, settings config.Settings) *chi.Mux {
+	backend := InitBackendRoutes(container, settings)
+	frontend := InitFrontendRoutes(settings.Environment)
 
 	apiRouter := chi.NewRouter()
-	enableCorsIfConfigured(apiRouter)
+	enableCorsIfConfigured(apiRouter, settings.CorsAllowedOrigins)
 	apiRouter.Use(chimiddleware.GetHead)
 	apiRouter.Get("/healthz", GetHealth)
 	apiRouter.Mount("/v1", backend)